Commit Graph

1024 Commits

Author SHA1 Message Date
Sarbojit2019 45613311d7 [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425)
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior
2019-11-07 13:18:12 +05:30
ansurya e07926ce0f Fixed texture 2D mapping for pitched arrays & 3D Texture read (#1415)
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313

SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components
2019-11-07 13:17:46 +05:30
Rahul Garg 579a4f36fa Rename hip/hip_hcc.h to hip/hip_ext.h (#1341)
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h
2019-11-07 13:17:10 +05:30
Jeff Daily 85080905c0 hipEventRecord only needs one lock; remove locked_eventIsReady 2019-11-06 15:56:32 +00:00
Jeff Daily 7986090d9c remove ihipEvent_t::refreshEventStatus(), new hipEventElapsedTime
This fixes possible races in hipEventElapsedTime.
2019-11-06 15:46:46 +00:00
Jeff Daily 6fcff0118e fix race condition in hipEventRecord 2019-11-04 17:45:11 +00:00
Rahul Garg 782cf1c007 Merge pull request #1598 from lmoriche/master
Fix a code object memory corruption
2019-10-31 17:12:24 -07:00
Rahul Garg 85d70086cb Add stream 2019-10-31 12:15:56 -04:00
Rahul Garg efe6fa86dc Fix HIP init calls in hipMemcpy2DFromArray 2019-10-31 12:15:56 -04:00
Rahul Garg ba8105e0cd Merge pull request #1515 from ansurya/tex_unbind_issue_fix
Fix undefined ref to hipUnbindTexture for texture types
2019-10-30 17:54:15 -07:00
Laurent Morichetti 91748f4e6c Addressed review comments
Change comment "must exceed" to "must be no shorter than"
move the std::string instead of creating a copy
2019-10-30 13:14:41 -07:00
Rahul Garg e4a1e44162 Revert "Fix occupany APIs (#1560)"
This reverts commit af351d7e1b.
2019-10-29 11:41:08 -07:00
Laurent Morichetti 7473140a76 Fix a code object memory corruption
The lifetime of the buffer given to
hsa_code_object_reader_create_from_memory must exceed that of the
code object reader. We need to create a copy of the code object
binary memory (file) that is kept allocated until the code object
reader is destroyed.
2019-10-29 08:23:57 -07:00
Anusha Godavarthy Surya 03623cc3f1 Merge branch 'master' into tex_unbind_issue_fix 2019-10-25 15:54:25 +05:30
Anusha Godavarthy Surya 5f47e99ffe merge from master 2019-10-25 15:52:09 +05:30
Rahul Garg 356765a223 Add hipMemcpy2DfromArray (#1510)
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.
2019-10-25 15:43:33 +05:30
Anusha Godavarthy Surya 259d8b4cdf Merge branch 'master' into tex_unbind_issue_fix 2019-10-25 15:36:55 +05:30
satyanveshd af351d7e1b Fix occupany APIs (#1560)
Addresses SWDEV-205006
2019-10-24 17:44:47 +05:30
searlmc1 c4a51f3679 Improve performance of v2 arg handling (#1539)
* Improve performance of v2 arg handling

* Missing change to `std::string`
2019-10-24 17:44:05 +05:30
Aryan Salmanpour 359dc79101 [hip] add support for implicit kernel argument for multi-grid sync (#1456)
* [hip] add support for implicit kernel argument for multi-grid sync

* modified code for calculating the prev_sum

* change the impCoopArg type to size_t

* add memory clean up

* launch init_gws and main kernels into two separate loops
2019-10-24 17:43:30 +05:30
Rahul Garg e1aac060da Merge pull request #1544 from vsytch/master
QoL changes to the hipMemset family
2019-10-16 18:54:20 -07:00
Nick Curtis 73ca2b0083 Guard against division by zero for no VGPR usage (e.g., in an empty kernel) (#1528)
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)

* fix bracket format

* clean up parenthesis
2019-10-16 10:49:56 +05:30
Vladislav Sytchenko 0b52c1d9d8 Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description. 2019-10-15 14:18:42 -04:00
Anusha Godavarthy Surya af5f195e46 Fix undefine ref to hipUbindTexture for texture types 2019-10-09 16:26:06 +05:30
Evgeny 4e93833035 tracing layer unifying with hcc: removing API_ID_ANY 2019-10-08 19:09:43 -05:00
Rahul Garg 96530cba3b Fix PCI Domain ID query (#1424)
* Fix PCI Domain ID query

* Update BDF comment
2019-10-07 14:11:52 +05:30
mhbliao 4d632166bb [hip] Add the missing header <sstream>. (#1498) 2019-10-04 13:39:29 +05:30
Rahul Garg bec725dec2 Add texref get APIs support (#1471)
Added support for -
    hipTexRefGetArray
    hipTexRefGetAddressMode
    hipTexRefGetAddress
2019-10-04 13:38:45 +05:30
ansurya ba9c6e13e4 Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.
2019-10-04 13:36:31 +05:30
Siu Chi Chan dcf70ff9a2 fix kernel descriptor bug with code object v3
Change-Id: I9306b2baf36d338e36c5ab1226f74373a61a5ae0
2019-10-03 10:56:35 -04:00
satyanveshd 3d661e4706 Reimplement hipMemGetInfo (#1447)
Addresses SWDEV-136570. hipMemGetInfo changed to compute free memory based on information from kfd instead of relying on hc::am_tracker.
2019-10-01 12:40:36 +05:30
Jeff Daily 56f67e5e36 hipModuleUnload should remove global variables from memtracker (#1464) 2019-09-30 10:41:20 +05:30
Sarbojit2019 0fa42af08c [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.
2019-09-26 13:53:33 +05:30
satyanveshd cfbd0e77fe Fix checks in hipMemcpy[D/H]to[D/H]() (#1397)
* SWDEV-202043 hipMemcpyDtoD() issue
2019-09-16 08:32:38 +00:00
ansurya ceb734b917 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported
2019-09-16 08:31:30 +00:00
Aryan Salmanpour bac52d3729 [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API (#1368)
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API

* fix formatting
2019-09-16 08:31:17 +00:00
Rahul Garg f0a1f95864 Fix typo and colon in comment 2019-09-13 03:09:01 +05:30
Rahul Garg fe47b2185c [HACK] Temporary fix for hipFree for hipManagedMalloc 2019-09-13 02:10:21 +05:30
Jeff Daily 8384f487ad fix bug where HIP_DB=1 seg faults at startup (#1388) 2019-09-05 10:04:19 +00:00
Rahul Garg 6545521d6c Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit ac62d7a5c0.
2019-09-03 05:13:46 +00:00
Sarbojit2019 0722704f35 Updated hipErrorString and CUDAErrorTohipError (#1365) 2019-08-29 01:02:59 +00:00
Sarbojit2019 5c4f78bac3 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path
2019-08-29 01:02:41 +00:00
Aryan Salmanpour 5066700ace [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339)
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties
2019-08-23 09:19:35 +00:00
Rahul Garg 71559200c0 Fix memcpy with IPC slowness (#1321)
* Fix memcpy with IPC slowness

* Make early erroneous returns

* Real Clean up

* Real Clean up++
2019-08-23 09:19:18 +00:00
Jatin Chaudhary ac62d7a5c0 Using HSA API for hipMemsetAsync (#1346) 2019-08-21 10:00:10 +00:00
Rahul Garg 47b832bba7 Fix build issues seen with hip-clang path (#1331) 2019-08-16 02:13:45 +00:00
Rahul Garg 2405621f62 Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check
2019-08-16 02:13:16 +00:00
Rahul Garg 3dd0e988b1 Fix undefined identifier issue for hipExtModuleLaunchKernel 2019-08-14 16:46:32 -04:00
Rahul Garg 45b73e0961 Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis
2019-08-09 11:50:37 +00:00
Siu Chi Chan 83af327ef2 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back
2019-08-08 08:33:04 +00:00