Alex Voicu
6e4ca3fbb4
Change memset kernel to use memcpy instead of placement new. Simplify indexers.
2017-11-28 19:45:47 +00:00
Alex Voicu
02c2bfc7ef
Re-sync with upstream and re-factor platform global management for texture references.
2017-11-28 19:15:29 +00:00
Alex Voicu
dc67ca3feb
Merge remote-tracking branch 'origin/master' into feature_use_module_based_dispatch_instead_of_pfe
...
# Conflicts:
# src/hip_module.cpp
2017-11-28 17:29:11 +00:00
Ben Sander
0da0426f94
Merge pull request #256 from gargrahul/texture_driver_api_support
...
Texture driver APIs support
2017-11-27 13:52:39 -06:00
Alex Voicu
08f252e4bf
Remove leftover comment.
2017-11-22 19:37:03 +00:00
Rahul Garg
56862b1c35
Fixed review comments
2017-11-21 21:19:06 +05:30
Rahul Garg
9866fa250d
Changed function hipMemcpy_2D to hipMemcpyParam2D
2017-11-21 12:36:24 +05:30
Alex Voicu
9d088d2283
Refactor the __device__ versions of memset and memcpy to be less awkward i.e. not return nullptr as opposed to the destination pointer (it can only be assumed it was done for maximum confusion) and actually unroll as they claim to. Change all of the {to, from}Symbol functions to use hipModuleGetGlobal, as opposed to hc::accelerator::get_symbol_address which is no longer valid with module based dispatch.
2017-11-21 02:40:34 +00:00
Alex Voicu
7d5a45ac1a
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
2017-11-20 16:33:52 +00:00
Alex Voicu
c5f2b22d0d
Re-sync with upstream.
2017-11-20 15:34:50 +00:00
Rahul Garg
c7d60a7a75
Update hipModuleGetTexRef API
2017-11-19 22:10:46 +05:30
Alex Voicu
cffd0e14eb
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
2017-11-19 01:54:12 +00:00
Rahul Garg
4b19c2aa0c
-Fixed texture driver API sample
...
-Added hipTexRefSetAddress and hipTexRefSetAddress2D APIs
2017-11-15 18:23:28 +05:30
Rahul Garg
63680edd30
Texture code reorganized
2017-11-14 11:09:35 +05:30
Rahul Garg
ef09c4918d
Texture driver APIs support
2017-11-09 22:10:55 +05:30
Alex Voicu
d8e323d4b5
Clean up trailing whitespace so as to reduce noise in #246 .
2017-11-08 00:08:55 +00:00
Alex Voicu
c2482d1255
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
2017-11-01 15:09:59 +00:00
Ben Sander
2e8ec71e40
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
2017-10-30 17:58:48 +01:00
Siu Chi Chan
a9789ddcda
Merge remote-tracking branch 'origin/master' into HEAD
2017-10-27 01:18:28 -04:00
Siu Chi Chan
f8bdb9f688
add a printf device function
2017-10-23 18:30:08 -04:00
Ben Sander
acf89b43d4
Update device properties.
...
- clear properties to defined initial state.
- enable some property flags which are now supported.
2017-10-20 15:52:13 +00:00
Chris Kitching
1d205ab130
Add [[nodiscard]] attribute to hipError_t in C++17 mode
...
This will yield a compiler warning any time you discard an error
return value from an API call.
2017-10-19 13:34:02 +01:00
Maneesh Gupta
c1803c1951
Merge pull request #194 from bensander/fix_genco_math_path
...
Fix math ordering for --genco mode.
2017-10-03 16:17:34 +05:30
Ben Sander
68c2146dc3
Fix math ordering for --genco mode.
2017-10-02 21:52:16 +00:00
Rahul Garg
b8aae66424
Fixed review comment
2017-10-02 17:29:08 +05:30
Rahul Garg
19d574d939
Fixed review comments
2017-10-02 10:57:25 +05:30
Rahul Garg
f62254a8d8
Fixed build issue
2017-10-02 10:40:01 +05:30
Rahul Garg
470224cf25
Fix texture support on HIP/NVCC path
2017-10-02 10:40:01 +05:30
Siu Chi Chan
83d9e889a9
ensure the condition is evaluated before applying the negation operator
2017-09-20 01:38:28 -04:00
Maneesh Gupta
8c92d28ff3
Merge pull request #155 from wsttiger/master
...
Modify hip headers such that they are more compatible with strict C compiler
2017-09-15 10:49:55 +05:30
Maneesh Gupta
c3c94dcd8d
Fix typo in nvcc_detail/hip_runtime_api.h
2017-09-14 16:19:57 +05:30
Maneesh Gupta
c7e5fd24ac
Merge pull request #175 from gargrahul/assert_support
...
Device side assert support
2017-09-14 16:08:00 +05:30
sriharikarnam
3e69b2ed5a
Add hipDevice[Get/Set]SharedMemConfig API on nvcc details
2017-09-14 16:03:19 +05:30
Rahul Garg
40ff42e555
Device side assert support
2017-09-07 20:45:27 +05:30
Ben Sander
1a9e588932
Update docs.
...
- Review unsupported comments and refresh.
- Review experimental tag in API.
2017-08-28 15:44:38 -05:00
wsttiger
b6a3d8c946
Modify header such that it's compatible with strict C compiler
2017-08-15 13:23:09 -05:00
wsttiger
512214e930
Add missing CUDA tags
2017-08-15 13:22:20 -05:00
Siu Chi Chan
96e79f97e2
implement __threadfence_system
2017-08-02 08:50:18 +00:00
Ben Sander
4f93b99f23
Merge pull request #100 from weixingzhang/texture
...
HIP Texture Support
2017-07-26 19:28:15 -05:00
Maneesh Gupta
7a446dcbc5
Renable frexp(f) device math function
...
Change-Id: I53c022b8ddf38cd17ddb42eba457b9020db66395
2017-07-20 14:41:30 +05:30
Weixing Zhang
e671cec367
HIP Texture Support
2017-07-17 15:16:12 -04:00
Wen-Heng (Jack) Chung
30ee797dd4
Remove explicit address spaces declarations
2017-07-07 12:46:29 -05:00
Ben Sander
0459f3db72
Add hipdbPrintMem - wrapper for hcc memory tracker.
2017-07-03 15:05:30 -05:00
Rahul Garg
34fcaa23bb
Fixed build error in hipDeviceGetByPCIBusId
...
Change-Id: I33be362910c4c5dca7435fb9c41f427b54f0e9a7
2017-07-01 07:56:30 +05:30
Ben Sander
9c229f7530
Refactor hip_hcc.
...
Don't require setting __HIP_PLATFORM_HCC__ ; Instead check if compiler is HCC.
The functions here use HCC-specific functionality so only work with HCC.
ANd they work regardless of the __HIP_PLATFORM_HCC__ setting so don't
require that.
Also remove the "hcc_detail" extra hierarchy level for hip_hcc.h as
it is not necessary. Remove hcc_detail/hip_hcc.h.
2017-06-30 08:26:15 -05:00
Rahul Garg
65cb024b61
Fixed hipDeviceGetByPCIBusId
...
Change-Id: Ia36bb9425671ef7659541c9aeedae4098456a31b
2017-06-30 10:11:41 +05:30
Rahul Garg
d6db525f51
Fixed hipDeviceGetPCIBusId for HIP/NVCC
...
Change-Id: I662efa148257a710f09002850b41d57bef00dff3
2017-06-29 00:13:02 +05:30
Rahul Garg
f4ea3b76c8
Fixed hipDeviceGetPCIBusId for HIP/HCC
...
Change-Id: I3688fa2476e1baada2d3c5fc3735cec3f15a1e21
2017-06-28 23:48:27 +05:30
Sun, Peng
1e1654c225
Remove some warning debug info and add weak attribute back to GGL __global__ define
...
Change-Id: I2021b107dda697b1262d44fa1506465e94a3916b
2017-06-27 14:15:16 -05:00
Aditya Atluri
522e059a79
fixed default args for symbol memcpy apis
...
Change-Id: Ie0b63f8b9c5535eb3946bd6af3f30fe71a015244
2017-06-23 19:05:44 -05:00