Граф коммитов

2018 Коммитов

Автор SHA1 Сообщение Дата
jiabaxie 5af8ba8513 SWDEV-450204 - hipGetProcAddress check for null corrected
Change-Id: Ic34b0d561d3d70f3411a60924a64c3b89954394f


[ROCm/clr commit: 14bcbcc25b]
2024-03-13 16:44:08 -04:00
Jaydeep Patel 05fccb2d7e SWDEV-447525 - Fix merge conflict.
Change-Id: I9dc852e634fb702a0d17ace3fad53e14178d4da0


[ROCm/clr commit: 79162c244b]
2024-03-13 11:52:28 +00:00
Jaydeep Patel 844765d7e0 SWDEV-447525 - maxSize param for Mem pool props.
Change-Id: Ib743611a66921aeaa449b6622b933cc8b9190d87


[ROCm/clr commit: b72d8da1bd]
2024-03-13 00:58:48 -04:00
kjayapra-amd 8947420e41 SWDEV-423835 - Fixing kernel launch issues on Virtual Memory Management path.
Change-Id: I9f5e8a3d83af3809b2c50b21a10697e26113dd23


[ROCm/clr commit: f5ca620baa]
2024-03-12 17:22:07 -04:00
taosang2 8cc8dda1cd SWDEV-450225 - Add missing targets in hipRtc
Change-Id: Ifccdddfc8ac72585f6ba145578e5bbb7e3cd1643


[ROCm/clr commit: 4c82df817f]
2024-03-12 10:34:08 -04:00
German Andryeyev f3db4e12e6 SWDEV-311271 - Correct the error codes in mempool
Change-Id: Iacf8ad2cc454dfe53ccdb47c08d871b24ecf4107


[ROCm/clr commit: 1d8562eb7d]
2024-03-12 10:18:44 -04:00
sdashmiz 0c65a7baea SWDEV-447458 - remove check for image support
- remove the check from hipmallocpitch

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ife3a95381be703b1c1b7492abfd4432c4a8141c8


[ROCm/clr commit: 315d0fc46e]
2024-03-11 11:39:14 -04:00
Jaydeep Patel 79a57a6fc1 SWDEV-446219 - Validate option value.
Change-Id: Ifccdddfc8ac71585f6ba045578e5bbb7e3cd1649


[ROCm/clr commit: 66f6a3e255]
2024-03-07 12:53:34 -05:00
Anusha GodavarthySurya 41ec66ff67 SWDEV-448586 - Added implementation for new API hipStreamBeginCaptureToGraph
Change-Id: I1ce802102cef2b66c92d3375f769983841de793f


[ROCm/clr commit: 4feb1f9337]
2024-03-07 05:24:49 +00:00
German Andryeyev 4bb028a49d SWDEV-311271 - Add dependency tracking for streams
Mempool has capability to track dependency between streams for
faster memory reuse. Enable that capability.

Change-Id: I28266a7e38d0fc4c5d027b9542d3719653840821


[ROCm/clr commit: 17d0c166d2]
2024-03-05 12:53:09 -05:00
German Andryeyev 396b3f8de7 SWDEV-311271 - Return different errors
Match errors with the tests

Change-Id: I32db83843e45e0f09359149ea9fd7a532c881e16


[ROCm/clr commit: 11a6be1ede]
2024-03-04 17:02:30 -05:00
Jatin Chaudhary 286599824e SWDEV-441629 - add some missing hiprtc link options
Change-Id: I10019823e212c6d4de6df30c0fe1c20d9e992f29


[ROCm/clr commit: 7f9651d4bb]
2024-03-01 07:49:57 -05:00
ChingShihLi 5ca2131ce0 SWDEV-413377 - Segfault for hipLaunchKernel with multi GPUs
- Using runtime unbundler, no any gfx device can load fat binary,
if there is any device without available code object.

- Extract available code object to corresponding gfx devices. So
users can work ROCm with those ready devices without segmentation
fault.

Change-Id: I9f14c65ecebf2d3c4b127a007cb434a3ae98c450


[ROCm/clr commit: 6723277ad4]
2024-03-01 02:24:22 -05:00
Rahul Manocha 0a269e98a9 [SWDEV-448077][SWDEV-448067] - Changes to Kernel Node Attribute related APIs
Change-Id: Ibbf773fd5f134a62b7ce04f6956b10c1086b1782


[ROCm/clr commit: 2c0fa829b4]
2024-02-28 18:14:41 -05:00
Anusha GodavarthySurya f1e5162757 SWDEV-447545 - Fix Enable/Disable node with hipGraph
Node can be enabled/disabled only for kernel, memcpy and memset nodes.
If the node is disabled it becomes empty node.
To maintain ordering just enqueue marker with respective node dependencies.

Change-Id: I710f3e88ab4e76c81f6f86a40a7dc61fd4c7e440


[ROCm/clr commit: e0e63eb04d]
2024-02-28 17:34:03 -05:00
Anusha GodavarthySurya 67543a60f1 SWDEV-444988 - Fix hiddenheap variable initialization
Change-Id: Icdb32ef4718b8ca0beedd569a4aaf40a9f4fb49d


[ROCm/clr commit: ea66946399]
2024-02-28 17:22:32 -05:00
German Andryeyev e26e82d58e SWDEV-311271 - Update mempool errors
Add extra validations for negative tests.

Change-Id: I7b2879b8840b5d1b6c5cb0d919a651cd868b7529


[ROCm/clr commit: d808ae6782]
2024-02-28 17:13:49 -05:00
Sourabh Betigeri 423fd58c3f SWDEV-425640 - An instantiated graphExec should retain a copy of every reference in the source graph
Change-Id: Idf6b224449ca642af2860b33dc739f51a6248e4c


[ROCm/clr commit: 3fdd46ae59]
2024-02-28 12:04:53 -05:00
Satyanvesh Dittakavi 9caac12074 SWDEV-446781 - Check validity of hiprtc link state before using it
Change-Id: I864e8d1a79bb28d9df0e4ee528cb50a96bc245cc


[ROCm/clr commit: 15a058cb60]
2024-02-28 00:27:17 -05:00
Anusha GodavarthySurya 4499ded668 SWDEV-445981 - Handle hipGraphExecUpdate to update graph kernel node params with graph performance optimizations
Change-Id: I3b05c6bfc83404152bcae9b31cfdf56af7cc61a4


[ROCm/clr commit: 4b4ec7fc52]
2024-02-27 15:20:23 -05:00
Jonathan R. Madsen 1f91fcf42e SWDEV-443227 - Update hip_api_trace.cpp
- enforce incrementing the table versioning number when a table size changes outside of ifdef for ROCPROFILER_REGISTER
- add new HIP_ENFORCE_ABI entries
- update the HipDispatchTable size and bump HIP_RUNTIME_API_TABLE_STEP_VERSION to 1
- re-enable rocprofiler-register

Change-Id: Ie0cc1d8491c5640056e5dd393ea243e4dce4e8a9


[ROCm/clr commit: d84c5ae3af]
2024-02-27 13:29:33 -05:00
Anusha GodavarthySurya 49cbeaea21 SWDEV-444988 - Fix __amd_rocclr_initHeap sync with DEBUG_CLR_GRAPH_PACKET_CAPTURE
When kernel does device side malloc, initial heap is allocated with __amd_rocclr_initHeap.
During graph launch kernel __amd_rocclr_initHeap is enqueued followed by actual kernel . So kernel will execute after initHeap kernel.

But with graph optimizations during capture initHeap gets enqueued on device null stream and actual kernel on graph launch stream.
So no proper synchronization. Switch to command creation and enqueue during launch for kernel node with hidden heap.

Change-Id: Iaf600251faef9a448853f19429023c118aa760b9


[ROCm/clr commit: 2dc6ec68a5]
2024-02-27 13:11:31 -05:00
kjayapra-amd d30e344ae0 SWDEV-446959 - Check fatbinaryinfo for nullptr and return hipErrorInvalidDevice.
Change-Id: Iabc0d8b66ddf73a92e67dd469f1a8bc0b54b9309


[ROCm/clr commit: 8a715ba58c]
2024-02-23 14:45:43 -06:00
Satyanvesh Dittakavi 0595e7c41f SWDEV-426272 - hipPointerGetAttribute shouldn't segfault when host ptr is passed
Check the pointer if its present in the arrayset before trying to dereference
it as it can cause access violation if the pointer is allocated using malloc

Change-Id: Ida72b9015dc22269fc1fbe0728e66e3de29fda3d


[ROCm/clr commit: 821ae6a103]
2024-02-21 16:37:21 +00:00
Ioannis Assiouras 80ddb8e4eb SWDEV-446399 - Fixed segfault in hipMemSetAccess
Change-Id: Ia1200d9bee03e8abade211287505f081e635ceec


[ROCm/clr commit: 1f6d416684]
2024-02-20 18:51:05 -05:00
Saleel Kudchadker ec59b1bc3e SWDEV-443760 - Enable device kern args
- Implement workaround to ensure HDP writes are done by writing and
reading the HDP MMIO register.
- Implement the same workaround for graphs, we no longer need sentinel
write/readback

Change-Id: I0d3027b46a1f61131ec62e3c8c669ff5184fa6b2


[ROCm/clr commit: f138e0d113]
2024-02-20 02:03:14 -05:00
Saleel Kudchadker 6383be514b SWDEV-301667 - Cleanup code and better log
Change-Id: Ie2345264e84026156a9f81b421eed3cf4aeeeffc


[ROCm/clr commit: 81b8598af9]
2024-02-19 05:42:47 -05:00
Anusha GodavarthySurya 80887e8559 SWDEV-444767 - Fix graph tests for context change between Inst & launch with DEBUG_CLR_GRAPH_PACKET_CAPTURE
When graph is Instantiate on device 0 graph and launch on device1 switch to command creation and enqueue during launch.

Change-Id: Ied34dc99b2a776130d1354ed3830c6ccab9068e4


[ROCm/clr commit: 7d09e1abed]
2024-02-14 17:02:36 +00:00
Jaydeep Patel 97ad1412ea SWDEV-445539, SWDEV-445549 - Restore kernel launch prof data.
Issue is due to INIT_hipLaunchKernel_CB_ARGS_DATA turns out to be empty when we generate new hip_prof_str.h with since
extra space introduced by https://gerrit-git.amd.com/c/compute/ec/clr/+/846275/77/hipamd/src/hip_module.cpp#667

Change-Id: Id251956c1663483cc7ab11a3722769cb5b0d3664


[ROCm/clr commit: d1b75659f2]
2024-02-14 00:05:41 -05:00
Ilya Panfilov 34cfbb5751 SWDEV-438299 - Remove unused variables
Change-Id: Id2908fe851d566ec2515161090f1e21b60cf6447


[ROCm/clr commit: 243555959f]
2024-02-13 19:39:11 -05:00
German Andryeyev c9bace9b71 SWDEV-311271 - Fix Windows mempool management
Windows path still uses multi threading implementation. Hence, in graphs
all nodes are executed in a queue thread and that requires to manage
mempool in the queue thread. However, the spec allows to destory memory,
allocated in a graph, outside of the graph's execution. That may cause
mempool management to go out of sync.

Change-Id: I0ffb2244b3cb720455ed44d1b3e2487fa8959a77


[ROCm/clr commit: 4f6b0da028]
2024-02-13 17:16:06 -05:00
Anusha GodavarthySurya 2c045d12ee SWDEV-445013 - During CaptureAQLPackets correct sentinal value to copy integer size bytes
Read and write int bytes sentinal value to dev_ptr or PCIE connected devices at the tail end of the kernarg surface.

Change-Id: I993d552ac872b3cd56aef4746c4d1d92c58d38b4


[ROCm/clr commit: 853abeb75e]
2024-02-13 07:05:57 +00:00
Ioannis Assiouras eb5d8d2647 SWDEV-445576 - Return error when hipMemPoolDestroy is invoked on the default mempool
Change-Id: I7a7ab499f781cf7e92cad1ae39a40b4f37f62653


[ROCm/clr commit: 4d61237a6f]
2024-02-12 12:48:21 +00:00
Ioannis Assiouras fb39e68de7 SWDEV-445221 - Fix the memory reported for hipMemPoolAttrReservedMemHigh
Change-Id: I894a836643612c73feb322f29a9236ada4d8cbda


[ROCm/clr commit: 5e6ad190ff]
2024-02-08 23:40:51 +00:00
jiabaxie b251260e2a SWDEV-437702 - implement hipGetProcAddress
This should be used in place of dlsym or GetProcAddress (linux and windows respectively)

Change-Id: I5501b538e03892e8e5a2282678d848fcaf21d911


[ROCm/clr commit: 0479cdb3dd]
2024-02-08 11:26:02 -05:00
Anusha GodavarthySurya fe3c0a3fdc SWDEV-445084 - Add DEBUG_CLR_GRAPH_PACKET_CAPTURE support for hipGraphInstantiateWithFlags/Params
Change-Id: I5096b4c8d73d1faf972dfd23ab86a53d888946c4


[ROCm/clr commit: d6bc40e822]
2024-02-08 04:55:53 -05:00
Anusha GodavarthySurya 3cad2e16f6 SWDEV-444558 - SWDEV-444418 - Fix capturing of AQL packets when kernel arg size is 0
When graph doesn't have kernel nodes.

Change-Id: I6b3b476654d7eedc9ff0cec4b7269168aa115360


[ROCm/clr commit: ca0b50c9ca]
2024-02-08 06:12:16 +00:00
Rahul Manocha b564fbef5d SWDEV-421025 - Graph Instantiate with Params API Update
Change-Id: I3ed821ced02420858d360e8dab5e1e931c350c7e


[ROCm/clr commit: f964975db0]
2024-02-07 11:35:21 -05:00
kjayapra-amd bef39a9369 SWDEV-437832 - Changes to update host unified memory and iommuv2 flags.
Change-Id: I88998cf57c21fc446fa28e250f826c607923670b


[ROCm/clr commit: 7d5b4a8f7a]
2024-02-07 06:27:47 -05:00
Satyanvesh Dittakavi 45f3dc72fd SWDEV-400448 - SWDEV-392872 - Optimize to add lock only if its null stream
Change-Id: Ia905109a295614e8ce4e2bd24261c86ba8138178


[ROCm/clr commit: a6841e3f43]
2024-02-07 04:51:54 -05:00
Anusha GodavarthySurya daf22604af SWDEV-439637 - Updated to compile with clang compiler
Change-Id: Ib0a8e1cc007f083fb1d1f4363cf89ba76ad3c4f2


[ROCm/clr commit: a1b2cbe44e]
2024-02-06 23:57:13 -05:00
Anusha GodavarthySurya 78aee3d79f SWDEV-439637 - Fix undefined symbol error hipTexRefGetArray & hipTexRefGetBorderColor (github id- #3382)
Change-Id: Iae1956779e84759f23011151b60a01cef0d0ef32


[ROCm/clr commit: 5303cd2740]
2024-02-06 03:04:07 -05:00
Satyanvesh Dittakavi cd898208d9 SWDEV-400448 - SWDEV-392872 - Add lock to NullStream
Fetching null stream's logic has changed earlier from amd::HostQueue
to hip::Stream. This seem to cause some timing difference between
checking for null stream and creating it due to which issues are
observed in multithreaded applications using default stream.

Change-Id: Ie02365dec537275d23a1d225de9811e2fd3a9c55


[ROCm/clr commit: 8d265838cb]
2024-02-05 02:58:23 -05:00
Rahul Manocha 7bccc07147 SWDEV-421025 - hipGraphInstantiateWithParams API changes
Change-Id: Ib07d4dd1698220b68ed27f91d58d3bd315a8804c


[ROCm/clr commit: 1a3901fa49]
2024-02-05 05:08:11 +00:00
Anusha GodavarthySurya 5c0490f53b SWDEV-422207 - Enable DEBUG_CLR_GRAPH_PACKET_CAPTURE environiment variable
Change-Id: I9bf72b9c1a56980352109bd4d42b54ecb2d1b8f9


[ROCm/clr commit: ae0368d12d]
2024-02-05 05:08:11 +00:00
Ioannis Assiouras 3316766258 SWDEV-443018 - Restrict input range for value argument in hipPointerSetAttribute
Change-Id: I17b6448bf49aed49315a0b4c1426dcbe011735d9


[ROCm/clr commit: 5b72582474]
2024-02-05 05:08:11 +00:00
Shilei Tian d6811208f4 SWDEV-442719 - Set CMP0074 to NEW to make sure find_package works correctly
If a system has LLVM installed, `find_package` could choose that one
even if we set `HIP_LLVM_ROOT`. `LLVM_ROOT` is ignored because of this
CMake policy is set to `OLD` by default.

Change-Id: I18fa0453afe170c229e92d6ddc386b43eb0c44f6


[ROCm/clr commit: a2a8dad980]
2024-02-05 05:08:11 +00:00
Todd tiantuo Li 3445b57a43 SWDEV-438503 - Always report hipDeviceAttributeUnifiedAddressing as true.
Change-Id: I3119bd8f99c079280bde1ba32b3d26b474899e7d


[ROCm/clr commit: 60549b101c]
2024-02-05 05:08:11 +00:00
Satyanvesh Dittakavi f6ea7f732b SWDEV-440029 - Fix hipMemcpyFrom/ToSymbol directions allowed
Change-Id: Ib0b3d737cd5d297ac2d3c1ba549902b96e29c18c


[ROCm/clr commit: 9fd8b4d3f1]
2024-02-05 05:08:11 +00:00
Ajay ca50750dae SWDEV-440718 - Suffix hip bin name with _6.
Link to amd_comgr_2.dll

Change-Id: I5d21af0cc91f2082099273f75ebe1c3279b6365d


[ROCm/clr commit: b53fcb4d02]
2024-02-05 05:08:11 +00:00