Commit gráf

4785 Commit-ok

Szerző SHA1 Üzenet Dátum
Evgeny 5b974209a0 cleanup: unneeded '\'
Change-Id: I0276312fdb0e4829d678de4281ccfd12eb7f232e


[ROCm/clr commit: 49091c2463]
2020-07-16 01:57:07 -05:00
Ashutosh Mishra beda35b8af Adding "BUILD_SHARED_LIBS" flag to cmake files
JIRA : SWDEV-234471
With this change compilation of the ibamdhip64 to be decied by arguments to build_hip_on_rocclr.sh file
build_hip_on_rocclr.sh -r (current) shall conitnue to create libamdhip64.so;
build_hip_on_rocclr.sh -r a (new) shall create libamdhip64.a
other options remain the same

Changed the targets according to requirement of stage2 dependencies.
Changed find_lib with find_package

Adpated the review comments

Change-Id: I719918f73ab33cd8031a32db6fe9b8adaa1b4b87


[ROCm/clr commit: a77c7e21be]
2020-07-16 00:29:14 -04:00
Sudheer Kumar 31e62c5852 [dtest] Enhanced tests to cover multiple hipmemset and hipmemsetAsync apis
SWDEV-238517 for enhancing hip unit tests

Change-Id: Iba2c419a4487955f34b4f19abe174ef427d289d8


[ROCm/clr commit: 7d77902198]
2020-07-15 01:13:07 -04:00
sushantkumar14 14e9205334 [dtest] Half2 comparison related tests
Tests heq2, hne2, hle2, hge2, hlt2, hgt2 APIs for functionality
and NaN tests

SWDEV-238517 for enhancing hip unit tests

Change-Id: I88a9a8ead0d00a1261f3d650361d655f2f397e48


[ROCm/clr commit: fe3cd6ca27]
2020-07-14 23:53:55 -04:00
mshivama 3b311d6c70 Add support for few CUDA compatible reduction operations like __syncthreads_count()
Change-Id: I0917820058f0edad5c0bdd42dea37f06353fc63c


[ROCm/clr commit: 1c5537dde4]
2020-07-14 12:03:14 -04:00
Sarbojit Sarkar a4c135ec8a host pointer check [SWDEV-243104, SWDEV-243206]
Change-Id: Id58dabfe5c35e5f8e42d224e700a431a4a97d003


[ROCm/clr commit: 9ba3732180]
2020-07-14 07:16:12 -04:00
kjayapra-amd 7de79c9a40 SWDEV-240165 - Adding a simple test for IPC memory.
Change-Id: Ib33ac20412cafa779fe20ff4df8a76dc22d50421


[ROCm/clr commit: 6be6cd9ebd]
2020-07-13 10:29:04 -04:00
Tao Sang 5225aff583 Implement HIP_ENABLE_DEFERRED_LOADING in right way
Change-Id: Ia28dbdea5cde93b3ca69f44c6a3c18ec8a730d42


[ROCm/clr commit: 19d6a646bb]
2020-07-11 18:14:03 -04:00
kjayapra-amd 28b5e13757 SWDEV-240165 - Move all amd::MemObjMap_ reference to ROCclr and only allow base ptr to get ipc handle.
Change-Id: I4f11e56ba455a7ce5a066c0e9e49657c5220a211


[ROCm/clr commit: ff36244b9c]
2020-07-09 21:19:50 -04:00
German Andryeyev 7fea66c9e9 Host device context should return a valid queue
Host memory allocations use shared device context, which allows
to have access from any device. That breaks default queue detection.

Change-Id: I27ad1234d49ab0ea8f5edd6f2e3ffa93c47d4b1f


[ROCm/clr commit: ef75a3c1db]
2020-07-09 10:56:33 -04:00
sushantkumar14 985e113fdb [dtest] Added hipStreamGetPriority API test
SWDEV-238517 for enhancing hip unit tests

Change-Id: Icff175360815ba6e25a6954a67947b65caff3711


[ROCm/clr commit: 2dc42154c4]
2020-07-09 01:59:44 -04:00
jujiang 3eb6440e59 SWDEV-242207-Update deprecated APIs
Change-Id: I0c1c7f33f75232b210495241d0e5e7e6b90d45f0


[ROCm/clr commit: b90f3732ea]
2020-07-08 15:23:52 -04:00
jujiang da470ad95f SWDEV-241903-Add document HIP_logging.md
Change-Id: I348218218b305e845b7e26afaeb4e287bf0387de


[ROCm/clr commit: e73e0d2fb3]
2020-07-08 11:19:33 -04:00
Rahul Garg 6d8419f433 Bump version to 3.7
Change-Id: Id077c317573e95833c8bc7f16951df776de2a273


[ROCm/clr commit: 27002fd792]
2020-07-08 01:54:05 -04:00
Aryan Salmanpour c69f88fe04 add an error message before aborting if a wrong GPU target was used for compilation
Change-Id: I7b41e93d420dbc47978238a681f2956a0def01cb


[ROCm/clr commit: 8f862becd0]
2020-07-07 14:50:44 -04:00
Lakhan singh Thakur 4bf371401d [dtest] Enhancing hipStreamAddCallback() api test
-Scenario-1:: This test case is used to verify if the callback function
              called through  hipStreamAddCallback() api completes the
	      execution in order as hipStreamAddCallback() api queued
	      in their respective streams: hipStreamACb_AltEnqueue.cpp
-Scenario-2:: This test case tests if Host thread continues with next
              command after hipStreamAddCallback() api or wait for
	      callback() call to finish. Ideally Host thread should not
              wait for callback to
              finish: hipStreamACb_ThrdBehaviour.cpp
-Scenario-3:: Streams are launched in individual GPUs with different
              kernel Verify that all the kernels queued are executed
	      before the callback is hit: hipStreamACb_MStrm_Mgpu.cpp
-Scenario-4:: Checks the callback execution in the same order it was
              added. Also, it checks if the number of callbacks
	      executed are same as the number of callbacks added:
	      hipStreamACb_order.cpp
-Scenario-5:: This test case checks whether hipStreamSynchronize() is
              taking less time than the time taken by Callback()
	      function launched by hipStreamAddCallback() api :
	      hipStreamACb_StrmSyncTiming.cpp
-Scenario-6:: This test case is used to check if the runtime is ok when
              hipStreamAddCallback() is called back to back multiple
	      calls: hipStreamACb_MultiCalls.cpp
-Scenario-7:: This test case is used to check the behaviour of HIP when
              multiple hipStreaAddCallback() are called over multiple
	      Threads:hipStreamACb_MultiThread.cpp
              (Currently disabled)

SWDEV-238517 for enhancing hip unit tests

Change-Id: I9c7b7df6766c728b2b201df18726b9fbdd434c06


[ROCm/clr commit: 18f8b15523]
2020-07-07 00:43:32 -04:00
Michael LIAO 8ad59be46d [hipcc] Only add -x hip on HIP-Clang compilation.
Change-Id: I19704c713ad00f92196d7586498e62f80b8cd177


[ROCm/clr commit: b39195b639]
2020-07-06 15:16:51 -04:00
Yaxun (Sam) Liu aad28fd31d Add pow(float/double/_Float16,int)
Change-Id: Ie65d15cd3df9853a3bbd613d8c7188ae39c327c7


[ROCm/clr commit: b72e8b54e0]
2020-07-06 07:38:57 -04:00
Jatin Chaudhary 718c7142d0 Fix error: cannot pass object of non-trivial type string through variadic function when building in debug mode
Change-Id: Idd55ed422addc815fb56c57b05bd4afa9563f2ac


[ROCm/clr commit: 3173dbdec0]
2020-07-06 00:48:40 -04:00
Jason Tang 33b063d7d6 SWDEV-242879 - Not to use fixnames
Change-Id: I3d0e2f3fe6c773e020c8bf8cdfd75fd565d61505


[ROCm/clr commit: c371b4e3b0]
2020-07-02 08:15:07 -04:00
kjayapra-amd 5cf8c4331b SWDEV-236178 - Fixing func_attributes that was over written on redesign.
Change-Id: I157913ae4fa4a3a149817e901f10475b7750188b


[ROCm/clr commit: 2f963728f7]
2020-07-01 11:52:45 -04:00
German Andryeyev f2464edb74 Remove hipMemcpyDeviceToDevice check.
There is hipMemcpyDefault that requires validation also.

Change-Id: I5ae0ffa1c023b7774547acbdc049b84a0c2cb4c5


[ROCm/clr commit: 11b7842f71]
2020-06-30 12:59:54 -04:00
Ronak Chauhan 845c0a5b8a Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

This is different from 4dfef9a25b.

We try to accomodate the case when a kernel template has multiple
type parameters.

Change-Id: I87577d402c92b0f3b51e298f8293f4065e1f6de8


[ROCm/clr commit: 133251a6e1]
2020-06-30 10:44:55 -04:00
Daniil Fukalov a2e2f9b8c6 Add __attribute__((const)) to grid related functions declarations
This is cherrypick of Daniil Fukalov's PR https://github.com/ROCm-Developer-Tools/HIP/pull/2110
which has been committed to master branch.

Make declarations consistent with https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/amd-stg-open/ockl/src/workitem.cl
Without the attribute these functions don't have "readnone" LLVM IR attribute. Without it some optimizations fails, e.g. Loop Invariant Code Motion doesn't hoist these calls out of a loop.

Change-Id: Idb599570d142152cc4f6a3c8986384ad7f0c4729


[ROCm/clr commit: 359ea4fcaf]
2020-06-29 13:33:18 -04:00
Cole Nelson 684004ca35 packaging/hip-rocclr.txt: multi-version install broken because of 'hip_rocclr'
Versioning understands 'hip-rocclr' not the deprecated 'hip_rocclr'.
Remove this.

Leaving Provides hip-hcc until package shifts settle down.

SWDEV-242143:

Change-Id: I489fa28dd1394625bc6016a3adda4f73d02da202
Signed-off-by: Cole Nelson <cole.nelson@amd.com>


[ROCm/clr commit: 0b7703560a]
2020-06-25 14:17:16 -04:00
rohit pathania 6b04a13e52 [dtest] hipMemcpyWithStream API multithreaded test scenarios
1.hipMemcpyWithStream with one stream
2.hipMemcpyWithStream with two streams
3.hipMemcpyWithStream multiGPU with one stream
4.hipMemcpyWithStream with kind DtoH
5.hipMemcpyWithStream with HtoH
6.hipMemcpyWithStream with DtoD
7.hipMemcpyWithStream with Default kind
8.hipMemcpyWithStream with Default kind on same device
9.hipMemcpyWithStream with DtoD on same device

SWDEV-238517 for enhancing hip unit tests

Change-Id: I5f55a12bdd7c8d28fcb06db94a491c2ad5ee3004


[ROCm/clr commit: c14e95741b]
2020-06-25 12:51:23 -04:00
Ronak Nilesh Chauhan 179a9974f4 Revert "Support passing macros to hipLaunchKernelGGL"
This reverts commit 4dfef9a25b.

Reason for revert: This patch breaks ROCPrim tests

Change-Id: Ib2235f719861c9f4317c33e86b6c1f8bc669cfd4


[ROCm/clr commit: b15e835d9e]
2020-06-24 04:28:46 -04:00
Evgeny 790d14d84b HIP-PROF: fixing pointers tracing
Change-Id: Id2c35972e1d134012980c95a3649ddfdf9303494


[ROCm/clr commit: c148adf362]
2020-06-23 14:02:35 -04:00
kjayapra-amd 39523e2c63 SWDEV-209747 - Staging Copy will not be supported in HIP, adjust test case accordingly.
Change-Id: Iad616ef3990d539cdb82bbd8a22ea2124f7abe50


[ROCm/clr commit: a5c437c82e]
2020-06-23 13:14:17 -04:00
agodavar 4644558c2b SWDEV-239297:hipMemset fix, getMemoryObject with unaligned ptr
Change-Id: I37b8139c5099d37b42f34d728a3d694fdf9cb55d


[ROCm/clr commit: 6a47458764]
2020-06-23 08:56:09 -04:00
German Andryeyev 0dd2e2b010 Disable flush on marker
Change-Id: I04d0fd995fb4b29a6bc372e1543902a053017d6a


[ROCm/clr commit: 265d84bab9]
2020-06-22 13:27:39 -04:00
Tao Sang 3113312e03 Fix static lib crashing issue
Initialize HIP_ENABLE_DEFERRED_LOADING = 1

Change-Id: I432ccf1926b953c4391fdd086cde7da2380962bb


[ROCm/clr commit: d536a661ac]
2020-06-22 13:24:40 -04:00
Michael LIAO 5e3c45afde [hip] Disable assert workaround for HCC on HIP-Clang.
- HIP-Clang follows the standard assert definition by providing
  `__assert_fail`.  But, `assert` macro is added as an HCC-specific
  workaround due to the missing implementation. Only enable that on the
  HCC compilation to avoid unexpected behaviors on HIP-Clang
  compilation.

Change-Id: I1c9a707baff9b85c30faef58c52ebfe07e3fc3fc


[ROCm/clr commit: 41aedf5273]
2020-06-22 10:33:56 -04:00
Ronak Chauhan 4dfef9a25b Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

Change-Id: Id76e2bf91acd5d68f56a24fc39f219f2eeb06d33


[ROCm/clr commit: fb6bb04f03]
2020-06-22 04:35:29 -04:00
Tao Sang b702f41277 Support numa policy set by user
Add hipHostMallocNumaUser flag to hipHostMalloc() in order to support
numa policy set by user.

Change-Id: I6d70ed539a5f97f27187f2242b68849c0e27e4d6


[ROCm/clr commit: 71c64e98a0]
2020-06-19 21:23:58 -04:00
Vlad Sytchenko 02641f4f43 Correct texture element size calculations
hipChannelFormatDesc contains size of each channel in bits. There's 8 bits per byte, not 4, so we should divide by 8.

Change-Id: I38ae2d28ad54740823c98908ca2afecad0ba0183


[ROCm/clr commit: 81b15ed36e]
2020-06-19 11:39:03 -04:00
Yaxun (Sam) Liu 8849a591f7 Fix missing ldexp(float,int)
Change-Id: I2c1553407dfc26948d3ab7aa532eef42a0f6b204


[ROCm/clr commit: 2461135d8a]
2020-06-18 15:16:59 -04:00
rohit pathania 11ef0984f4 [ dtest ] Added different test scenario with hipMemcpyWithStream
- Test with one, two streams
- Test Multi-gpu (one stream per gpu)
- Test D-D (on same device/different devices).  Can discover issues
  when devices are on same or different root complexes.
- Test H-D/Default

SWDEV-238517 for enhancing hip unit tests

Change-Id: I8031a7eebe2f9c8c0e0996e2c7accb09ac0b96d4


[ROCm/clr commit: 226c438559]
2020-06-18 10:31:01 -04:00
Vlad Sytchenko 0a3e99aa14 Support creating textures from user ptr with offset
Change-Id: Ied0af9a842fc6ef067e068a9d89dde63ff5dfce1


[ROCm/clr commit: ba2d3fbbb3]
2020-06-17 14:10:14 -04:00
Vlad Sytchenko 7a902e0788 Fix -Wsign-compare warnings
Change-Id: I874dc007ac657c25a72c6752c1a2da74c028a822


[ROCm/clr commit: 8db45328d9]
2020-06-17 11:20:45 -04:00
Jason Tang ab081f39cc Add asicRevision
Change-Id: I59f3ad20b9bdadf77bd1e0725f7a401d7ad423a3


[ROCm/clr commit: 8933c078f6]
2020-06-16 17:54:20 -04:00
Tao Sang 315cd2f959 Make hipHostMalloc() respect hipSetDevice()
Change-Id: I2410240f91b108c24597ee0fa7cf31e7b1f3ac5d


[ROCm/clr commit: 63ce69224a]
2020-06-15 23:20:09 -04:00
kjayapra-amd b079478641 SWDEV-240589 - Remove guarantee @ __hipRegisterFunction flow for now.
Change-Id: Ic51e2a1f951ac7745c2bbd11cfd2b92521c6966a


[ROCm/clr commit: 2467e37f3f]
2020-06-15 22:32:24 -04:00
Vlad Sytchenko e5f959ce02 Enable the use of some warnings when building HIP-ROCclr
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385, except no -Wno-strict-aliasing.

With this change only two warnings show up during the build - -Wsign-compare and -Wmisleading-indentation.

Change-Id: Iffa436c65ab6312aeaa6def71ee6af38ed1b4a4e


[ROCm/clr commit: 509a38f50c]
2020-06-15 20:33:30 -04:00
German Andryeyev 17bf7b0138 Initial support for HIP managed memory
- Call the new ROCclr interfaces for HMM

Change-Id: I2cd1bf438f712a9e9e328340e7d0c025257ca6c1


[ROCm/clr commit: b182ad9574]
2020-06-15 18:10:41 -04:00
Aryan Salmanpour c60c625688 expose five missing memcpy hip APIs
exposing the following hip APIs which have been previously implemented:

hipMemcpy2DFromArray
hipMemcpy2DFromArrayAsync
hipMemcpyAtoH
hipMemcpyHtoA
hipMemcpyParam2DAsync

Change-Id: I3f8635bd4265d2bf5aa2084f4eabb51f74fb18ba


[ROCm/clr commit: 02c62165b8]
2020-06-15 12:30:31 -04:00
kjayapra-amd 1ed6d978a8 SWDEV-236178 - Store texture reference metadata for dynamically loaded modules.
Change-Id: I99ecc80da7e29c691341a01a09e4532972f1e3e5


[ROCm/clr commit: 0b788c4c67]
2020-06-11 22:34:50 -04:00
kjayapra-amd fb0c0122af SWDEV-236178 - Remove __hip_pinned_shadow reference from dtests and add hipModuleUnload for all corresponding hipModuleLoad calls.
Change-Id: I405789b430ffbb8fccda1cebdb5d18e83a85c926


[ROCm/clr commit: 3fab381493]
2020-06-11 22:34:36 -04:00
Rahul Garg c2eb3cd2f7 Addback __mbcnt_lo and __mbcnt_hi
Change-Id: Ic3facba2e2245461515799f6a17842da0f5d9933


[ROCm/clr commit: 2d4b865d63]
2020-06-11 21:21:36 -04:00
Vlad Sytchenko b9efee6df8 Revert "Let hipcc not pass -mllvm option to HIP-Clang on Windows"
This reverts commit 23a8dfc8f3.

Change-Id: If29906b9c63f03d6e51144f510d3a956d90935e8


[ROCm/clr commit: e82e9355f2]
2020-06-11 16:36:48 -04:00