* SWDEV-552613 - Disable Direct Dispatch on Windows
* SWDEV-552613 - Use Direct Dispatch on HSA backend only
---------
Co-authored-by: GunaShekar <agunashe@amd.com>
Co-authored-by: Christophe Paquot <35546540+chrispaquot@users.noreply.github.com>
This PR intends to cover the edge case seen in https://github.com/ROCm/rocm-systems/issues/694.
`hip-config-amd.cmake` uses rocm_agent_enumerator to determine which GPU architecture to target when no target is specified.
https://github.com/ROCm/rocm-systems/blob/9a02dae75f8df9d8f08923d34d06d76e96ced7b4/projects/clr/hipamd/hip-config-amd.cmake.in#L86-L95
On WSL, both `readFromKFD` and `readFromLSPCI` are skipped. If `readFromTargetLstFile()` isn't in use, `readFromROCMINFO()` is called on. If rocminfo times out, it prints the following message to stdout.
```
"Timeout querying rocminfo. Are you compiling with more than 254 threads?"
```
Because this is output and not an explicit error message, `execute_command` in the previous code blocks treats the output as `OUTPUT_VARIABLE` and passes it on as a valid gfx arch which causes these errors in CMake,
```
lang++: error: invalid target ID 'Timeout'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'querying'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'rocminfo.'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'Are'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'you'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
clang++: error: invalid target ID 'compiling'; format is a processor name followed by an optional colon-delimited list of features followed by an enable/disable sign (e.g., 'gfx908:sramecc+:xnack-')
```
The output can be properly pushed to `ERROR_VARIABLE` if rocm_agent_enumerator pushes the output to stderr instead of stdout. This can be done with the changes to the print statement in this PR or using the `logging` module.
* Increase rocDecode code coverage and add version check
* Update rocJPEG tests
* Fix rocJPEG tests
* Enable building tests/samples in rocm release compat workflow
* Readded rocJPEG test skips
* formatting
* Adding ROCm libraries for the code-coverage job
* Added return value check for error message and updated compatability to enable tests
* Disable rocm_release_compatibility samples and tests until openmp issue is resolved
---------
Co-authored-by: Ian Trowbridge <Ian.Trowbridge@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Jonathan R. Madsen <Jonathan.Madsen@amd.com>
* Detect SELinux mode and fail-fast
* Detect SELinux status by reading /sys/fs/selinux/enforce during initialization.
* Fix the verbose mode for HIP Stream events
* Add more information in the logs
Add information to the user about how to change the setting
* rocprofv3-avail scrip fix
* addressing feedback
* formatting
* rocprofv3 and rocprofv3-avail to display help when no args are provided
---------
Co-authored-by: gobhardw <gopesh.bhardwaj@amd.com>
* SWDEV-515512 - Enable memcpy synchronization_behaviour tests
* SWDEV-515512 - Remove invalid parts of the tests
* SWDEV-515512 - Format the code
---------
Co-authored-by: Marko Arandjelovic <Marko.Arandjelovic@amd.com>
* SWDEV-548482 - Address memory leaks in memory tests
* SWDEV-547453 - Do not alter the dev_ptr if operation is not successfull
* SWDEV-548482 - Minor tweaks
* SWDEV-548482 - Move eventlist release after the command is created
---------
Co-authored-by: Marko Arandjelovic <Marko.Arandjelovic@amd.com>
* Updated stream code to handle special cases when stream value is 0x01 or 0x02
* Removed extra definitions and updated tests to account for special case
* Modified stream.cpp so that each thread assigned a unique stream ID when hipStreamPerThread is used as stream value. Modified tests to check that threads are assigned unique, repeated values when hipStreamPerThread is called
* Updated idx_offset, stream_map, and thread counter to be in one struct.
* Update stream.cpp to only use add_stream() and update tests for seperate unit test for hipStreamPerThread
* Remove unecessary comment
* Removed unecessary line
* Updated tests and stream.cpp to update stream ID correctly
* Updated test structure
Jimbo
Sam Ruscica
Ajay GunaShekar
habajpai-amd
harkgill-amd
vedithal-amd
jamessiddeley-amd
SaleelK
marandje
vstojilj
German Andryeyev
Ioannis Assiouras
RahulC
systems-assistant[bot]
estewart08
Ammar ELWazir
Saurabh Verma
Pengda Xie
Satyanvesh Dittakavi
Venkateshwar Reddy Kandula
David Galiffi
Sajina PK
Scott Todd
Mythreya Kuricheti
gabrpham
usrihari123
itrowbri