Граф коммитов

4765 Коммитов

Автор SHA1 Сообщение Дата
kjayapra-amd 5cf8c4331b SWDEV-236178 - Fixing func_attributes that was over written on redesign.
Change-Id: I157913ae4fa4a3a149817e901f10475b7750188b


[ROCm/clr commit: 2f963728f7]
2020-07-01 11:52:45 -04:00
German Andryeyev f2464edb74 Remove hipMemcpyDeviceToDevice check.
There is hipMemcpyDefault that requires validation also.

Change-Id: I5ae0ffa1c023b7774547acbdc049b84a0c2cb4c5


[ROCm/clr commit: 11b7842f71]
2020-06-30 12:59:54 -04:00
Ronak Chauhan 845c0a5b8a Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

This is different from 4dfef9a25b.

We try to accomodate the case when a kernel template has multiple
type parameters.

Change-Id: I87577d402c92b0f3b51e298f8293f4065e1f6de8


[ROCm/clr commit: 133251a6e1]
2020-06-30 10:44:55 -04:00
Daniil Fukalov a2e2f9b8c6 Add __attribute__((const)) to grid related functions declarations
This is cherrypick of Daniil Fukalov's PR https://github.com/ROCm-Developer-Tools/HIP/pull/2110
which has been committed to master branch.

Make declarations consistent with https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/amd-stg-open/ockl/src/workitem.cl
Without the attribute these functions don't have "readnone" LLVM IR attribute. Without it some optimizations fails, e.g. Loop Invariant Code Motion doesn't hoist these calls out of a loop.

Change-Id: Idb599570d142152cc4f6a3c8986384ad7f0c4729


[ROCm/clr commit: 359ea4fcaf]
2020-06-29 13:33:18 -04:00
Cole Nelson 684004ca35 packaging/hip-rocclr.txt: multi-version install broken because of 'hip_rocclr'
Versioning understands 'hip-rocclr' not the deprecated 'hip_rocclr'.
Remove this.

Leaving Provides hip-hcc until package shifts settle down.

SWDEV-242143:

Change-Id: I489fa28dd1394625bc6016a3adda4f73d02da202
Signed-off-by: Cole Nelson <cole.nelson@amd.com>


[ROCm/clr commit: 0b7703560a]
2020-06-25 14:17:16 -04:00
rohit pathania 6b04a13e52 [dtest] hipMemcpyWithStream API multithreaded test scenarios
1.hipMemcpyWithStream with one stream
2.hipMemcpyWithStream with two streams
3.hipMemcpyWithStream multiGPU with one stream
4.hipMemcpyWithStream with kind DtoH
5.hipMemcpyWithStream with HtoH
6.hipMemcpyWithStream with DtoD
7.hipMemcpyWithStream with Default kind
8.hipMemcpyWithStream with Default kind on same device
9.hipMemcpyWithStream with DtoD on same device

SWDEV-238517 for enhancing hip unit tests

Change-Id: I5f55a12bdd7c8d28fcb06db94a491c2ad5ee3004


[ROCm/clr commit: c14e95741b]
2020-06-25 12:51:23 -04:00
Ronak Nilesh Chauhan 179a9974f4 Revert "Support passing macros to hipLaunchKernelGGL"
This reverts commit 4dfef9a25b.

Reason for revert: This patch breaks ROCPrim tests

Change-Id: Ib2235f719861c9f4317c33e86b6c1f8bc669cfd4


[ROCm/clr commit: b15e835d9e]
2020-06-24 04:28:46 -04:00
Evgeny 790d14d84b HIP-PROF: fixing pointers tracing
Change-Id: Id2c35972e1d134012980c95a3649ddfdf9303494


[ROCm/clr commit: c148adf362]
2020-06-23 14:02:35 -04:00
kjayapra-amd 39523e2c63 SWDEV-209747 - Staging Copy will not be supported in HIP, adjust test case accordingly.
Change-Id: Iad616ef3990d539cdb82bbd8a22ea2124f7abe50


[ROCm/clr commit: a5c437c82e]
2020-06-23 13:14:17 -04:00
agodavar 4644558c2b SWDEV-239297:hipMemset fix, getMemoryObject with unaligned ptr
Change-Id: I37b8139c5099d37b42f34d728a3d694fdf9cb55d


[ROCm/clr commit: 6a47458764]
2020-06-23 08:56:09 -04:00
German Andryeyev 0dd2e2b010 Disable flush on marker
Change-Id: I04d0fd995fb4b29a6bc372e1543902a053017d6a


[ROCm/clr commit: 265d84bab9]
2020-06-22 13:27:39 -04:00
Tao Sang 3113312e03 Fix static lib crashing issue
Initialize HIP_ENABLE_DEFERRED_LOADING = 1

Change-Id: I432ccf1926b953c4391fdd086cde7da2380962bb


[ROCm/clr commit: d536a661ac]
2020-06-22 13:24:40 -04:00
Michael LIAO 5e3c45afde [hip] Disable assert workaround for HCC on HIP-Clang.
- HIP-Clang follows the standard assert definition by providing
  `__assert_fail`.  But, `assert` macro is added as an HCC-specific
  workaround due to the missing implementation. Only enable that on the
  HCC compilation to avoid unexpected behaviors on HIP-Clang
  compilation.

Change-Id: I1c9a707baff9b85c30faef58c52ebfe07e3fc3fc


[ROCm/clr commit: 41aedf5273]
2020-06-22 10:33:56 -04:00
Ronak Chauhan 4dfef9a25b Support passing macros to hipLaunchKernelGGL
This makes hipLaunchKernelGGL take a variable argument list, that will be
expanded before being fed to hipLaunchKernelGGLInternal.

Change-Id: Id76e2bf91acd5d68f56a24fc39f219f2eeb06d33


[ROCm/clr commit: fb6bb04f03]
2020-06-22 04:35:29 -04:00
Tao Sang b702f41277 Support numa policy set by user
Add hipHostMallocNumaUser flag to hipHostMalloc() in order to support
numa policy set by user.

Change-Id: I6d70ed539a5f97f27187f2242b68849c0e27e4d6


[ROCm/clr commit: 71c64e98a0]
2020-06-19 21:23:58 -04:00
Vlad Sytchenko 02641f4f43 Correct texture element size calculations
hipChannelFormatDesc contains size of each channel in bits. There's 8 bits per byte, not 4, so we should divide by 8.

Change-Id: I38ae2d28ad54740823c98908ca2afecad0ba0183


[ROCm/clr commit: 81b15ed36e]
2020-06-19 11:39:03 -04:00
Yaxun (Sam) Liu 8849a591f7 Fix missing ldexp(float,int)
Change-Id: I2c1553407dfc26948d3ab7aa532eef42a0f6b204


[ROCm/clr commit: 2461135d8a]
2020-06-18 15:16:59 -04:00
rohit pathania 11ef0984f4 [ dtest ] Added different test scenario with hipMemcpyWithStream
- Test with one, two streams
- Test Multi-gpu (one stream per gpu)
- Test D-D (on same device/different devices).  Can discover issues
  when devices are on same or different root complexes.
- Test H-D/Default

SWDEV-238517 for enhancing hip unit tests

Change-Id: I8031a7eebe2f9c8c0e0996e2c7accb09ac0b96d4


[ROCm/clr commit: 226c438559]
2020-06-18 10:31:01 -04:00
Vlad Sytchenko 0a3e99aa14 Support creating textures from user ptr with offset
Change-Id: Ied0af9a842fc6ef067e068a9d89dde63ff5dfce1


[ROCm/clr commit: ba2d3fbbb3]
2020-06-17 14:10:14 -04:00
Vlad Sytchenko 7a902e0788 Fix -Wsign-compare warnings
Change-Id: I874dc007ac657c25a72c6752c1a2da74c028a822


[ROCm/clr commit: 8db45328d9]
2020-06-17 11:20:45 -04:00
Jason Tang ab081f39cc Add asicRevision
Change-Id: I59f3ad20b9bdadf77bd1e0725f7a401d7ad423a3


[ROCm/clr commit: 8933c078f6]
2020-06-16 17:54:20 -04:00
Tao Sang 315cd2f959 Make hipHostMalloc() respect hipSetDevice()
Change-Id: I2410240f91b108c24597ee0fa7cf31e7b1f3ac5d


[ROCm/clr commit: 63ce69224a]
2020-06-15 23:20:09 -04:00
kjayapra-amd b079478641 SWDEV-240589 - Remove guarantee @ __hipRegisterFunction flow for now.
Change-Id: Ic51e2a1f951ac7745c2bbd11cfd2b92521c6966a


[ROCm/clr commit: 2467e37f3f]
2020-06-15 22:32:24 -04:00
Vlad Sytchenko e5f959ce02 Enable the use of some warnings when building HIP-ROCclr
Similar to http://gerrit-git.amd.com/c/compute/ec/vdi/+/375385, except no -Wno-strict-aliasing.

With this change only two warnings show up during the build - -Wsign-compare and -Wmisleading-indentation.

Change-Id: Iffa436c65ab6312aeaa6def71ee6af38ed1b4a4e


[ROCm/clr commit: 509a38f50c]
2020-06-15 20:33:30 -04:00
German Andryeyev 17bf7b0138 Initial support for HIP managed memory
- Call the new ROCclr interfaces for HMM

Change-Id: I2cd1bf438f712a9e9e328340e7d0c025257ca6c1


[ROCm/clr commit: b182ad9574]
2020-06-15 18:10:41 -04:00
Aryan Salmanpour c60c625688 expose five missing memcpy hip APIs
exposing the following hip APIs which have been previously implemented:

hipMemcpy2DFromArray
hipMemcpy2DFromArrayAsync
hipMemcpyAtoH
hipMemcpyHtoA
hipMemcpyParam2DAsync

Change-Id: I3f8635bd4265d2bf5aa2084f4eabb51f74fb18ba


[ROCm/clr commit: 02c62165b8]
2020-06-15 12:30:31 -04:00
kjayapra-amd 1ed6d978a8 SWDEV-236178 - Store texture reference metadata for dynamically loaded modules.
Change-Id: I99ecc80da7e29c691341a01a09e4532972f1e3e5


[ROCm/clr commit: 0b788c4c67]
2020-06-11 22:34:50 -04:00
kjayapra-amd fb0c0122af SWDEV-236178 - Remove __hip_pinned_shadow reference from dtests and add hipModuleUnload for all corresponding hipModuleLoad calls.
Change-Id: I405789b430ffbb8fccda1cebdb5d18e83a85c926


[ROCm/clr commit: 3fab381493]
2020-06-11 22:34:36 -04:00
Rahul Garg c2eb3cd2f7 Addback __mbcnt_lo and __mbcnt_hi
Change-Id: Ic3facba2e2245461515799f6a17842da0f5d9933


[ROCm/clr commit: 2d4b865d63]
2020-06-11 21:21:36 -04:00
Vlad Sytchenko b9efee6df8 Revert "Let hipcc not pass -mllvm option to HIP-Clang on Windows"
This reverts commit 23a8dfc8f3.

Change-Id: If29906b9c63f03d6e51144f510d3a956d90935e8


[ROCm/clr commit: e82e9355f2]
2020-06-11 16:36:48 -04:00
kjayapra-amd d6ccf1209c SWDEV-236178 - Reorganizing Platform/Modules code for easy access.
Change-Id: Ie8920260ffc4ff01e44b48af8cec9ea5aed1aa9b


[ROCm/clr commit: 840347f0d0]
2020-06-11 10:11:20 -04:00
Siu Chi Chan 3d7612af8d fix uninitialized value in hipcc
Change-Id: I90b070c491f0efc328fcf97de0e111658ec772de


[ROCm/clr commit: 32f3374af9]
2020-06-10 16:07:51 -04:00
jujiang 83c3939c6c Fix for SWDEV-239415 to handle hipGetDevice properly while no GPU present
Change-Id: I252cbbf9a89fc76fe1be1fbb8f45778e96c70fb2


[ROCm/clr commit: bb32492438]
2020-06-10 14:18:56 -04:00
kjayapra-amd 5593475c37 SWDEV-231701 - Remove amd::memory->svm_ptr from MemObj, instead of the ptr to the object.
Change-Id: I5aab450a2320cfa5417c284e2a8454102df6f99d


[ROCm/clr commit: 9ff22151d2]
2020-06-10 11:49:02 -04:00
Dittakavi Satyanvesh a0fbc8fd08 SWDEV-236670 Address Eigen unit test failure by adding __host__ attribute to half2 functions
Change-Id: Ifdc852c30a1b3704871e0ee58cb7a55d3d37fc6e


[ROCm/clr commit: bb785840b9]
2020-06-10 03:01:42 -04:00
Christophe Paquot 4206cfddc5 Do not deferred stream creation now that we multiplex HW queues
SWDEV-239856

Change-Id: I156650faf832f86891f00ee167269509edd844ec


[ROCm/clr commit: 20ae4d709f]
2020-06-09 19:16:25 -04:00
Yaxun (Sam) Liu 0d8425ee5a Fix include path and wrapper header
Currently std::complex and some other std functions require uses to
include hip_runtime.h before any other headers to work, which is not
reliable.

changes are made in clang to fix this issue:
https://reviews.llvm.org/D81176

which requires hipcc and HIP headers to make corresponding changes.

This patch will make sure the clang change will not break
HIP/ROCclr during this transition.

After the transition is done, we can remove explicitly setting
include path for HIP-Clang and HIP header in hipcc and hip config
cmake files and rely on clang driver to set it automatically.

Change-Id: I5d226861c2560ffa6c5ab17343a43cc378048061


[ROCm/clr commit: 0a513d8a02]
2020-06-09 17:37:20 -04:00
jujiang b815322dd6 To fix a format in hip_porting_guide.md
Change-Id: I5faa4ec9b3d17625b7cb5cea86b9f44766b1cfa9


[ROCm/clr commit: 06c6951205]
2020-06-09 13:14:52 -04:00
Rahul Garg 8e4c48bd25 Bump version to 3.6
Change-Id: I739a7bd03a4ed102bbc7c2f60d108e20132f5423


[ROCm/clr commit: 6aab5fa993]
2020-06-09 11:22:20 -04:00
Saleel Kudchadker 3f07846c7e Modify HIP_RETURN to print useful details
Change-Id: I23892c2d9a738b0298cdf24106d688a792937c73


[ROCm/clr commit: fbba37070c]
2020-06-06 02:05:21 -04:00
kjayapra-amd edcdf621b9 SWDEV-239327 - Remove amd_mem_obj during unregistervar
Change-Id: I2130eaa21369b9634a9459680061138c61eaaaa4


[ROCm/clr commit: ee2ff4bc5e]
2020-06-05 23:24:38 -04:00
kjayapra-amd db1b21b1fa SWDEV-235295 - Move addDeviceProgram() to lazy loading
Change-Id: I8fe07e370e58844496e18c858bb528393556854f


[ROCm/clr commit: 1dc24194a3]
2020-06-05 18:03:32 -04:00
Jason Tang 7735b228ec SWDEV-227909 - Add gcnArchName
Change-Id: Iea6d16b5d693dd0d900fa424d7a321c39315430e


[ROCm/clr commit: 14c699e9de]
2020-06-05 15:33:55 -04:00
kjayapra-amd 70e90419a9 SWDEV-234295 - Pass flag to ROCclr to not clear device programs during program::build()
Change-Id: I50b9fa1a96da6895f73fdf4a7c0d3f096b1188da


[ROCm/clr commit: 9261a35be9]
2020-06-05 09:53:11 -04:00
rohit pathania 16af0aebc0 [ dtest ] hipModuleLaunchKernel multiThreaded n multiGPU scenarios
1.Added hipModuleLaunchKernel multithreaded multi GPU scenario.
2.removed hipCtxCreate API from earlier test as it is deprecated.

SWDEV-238517 for enhancing hip unit tests

Change-Id: Id102d80887b6ff61a59938dbeb9fa2a26a3275b2


[ROCm/clr commit: 0920bac577]
2020-06-05 09:40:58 -04:00
Lakhan Singh Thakur bedadf571d [dtest] merge 'Adding the two test cases to cover scenarios observed in SWDEV-181598.'
SWDEV-238517 for enhancing hip unit tests

Change-Id: Ie61145b46c89b2e970af0ab11e22b6f6286ec90f


[ROCm/clr commit: 6f87616103]
2020-06-05 09:10:23 -04:00
Aryan Salmanpour 1c329fee60 Add support for setting hip stream priority
this change follows CUDA convention where lower number is greater priority

Change-Id: I72596a36449e818cbd8c175bf8519c51f46b1610


[ROCm/clr commit: 83b8e1fbac]
2020-06-04 22:50:30 -04:00
Payam 8bdf07bb9c Observed softhang while running hipStreamAddCallbackCatch SWDEV-236746
Workaround hipStream deadlock issue as the same lock was used twice SWDEV-236746

Change-Id: Icc60104ce6edf4cfd2a3a889bab78a6caadd50b7


[ROCm/clr commit: f3ee29cdb2]
2020-06-04 14:11:22 -04:00
Aaron En Ye Shi 4d51dbf4f1 Add gfx908 to hip-config.cmake
Support gfx908 as part of the default AMDGPU_TARGETS. MIGraphX requires this change.

Change-Id: I692f87f27829778e04f59c9ca655c6e8cbc00abc


[ROCm/clr commit: 29c7c9b1c2]
2020-06-04 11:00:09 -04:00
Siu Chi Chan 1f7c745330 add constexpr constructor for vector types
Change-Id: I45bb0537d6a24ee50b548c2fd8b4f20518764813


[ROCm/clr commit: 4b56aaefd6]
2020-06-04 01:57:03 -04:00