Commit Graph

2814 Commits

Author SHA1 Message Date
Yaxun Sam Liu 5d54fe864f Add more checks for fatbin
[ROCm/clr commit: 80b382a37a]
2018-11-08 16:46:01 -05:00
Maneesh Gupta a3758b506d Merge pull request #730 from yxsamliu/dbg-fatbin
Add more checks and debug outputs for fat binary

[ROCm/clr commit: e510be9395]
2018-11-08 11:44:27 +05:30
Maneesh Gupta 387e6de9e6 Merge pull request #721 from fronteer/my-fix
Make correct checking of the returned hipDeviceptr_t from read_global…

[ROCm/clr commit: 0bafc38135]
2018-11-08 11:42:08 +05:30
Maneesh Gupta 46bf341c12 Merge pull request #742 from gargrahul/fix_module_global_tracking
Fixes global symbols tracking in hip_module

[ROCm/clr commit: 8b1544c911]
2018-11-08 11:41:35 +05:30
Aaron Enye Shi 890beb81d6 Guard rcp rounded implementation as well
Since rcp implementations of non-default rounded versions are not correct or supported in OCML, guard them using the same macro OCML_BASIC_ROUNDED_OPERATIONS. Also update the docs and tests.


[ROCm/clr commit: 7b3bbc85c5]
2018-11-06 19:53:28 +00:00
Aaron Enye Shi 4480bb6d06 Guard the OCML rounded operations instead
Instead of commenting all these functions out, guard the functions with a macro OCML_BASIC_ROUNDED_OPERATIONS.


[ROCm/clr commit: 9aa92238ab]
2018-11-06 16:32:14 +00:00
Aaron Enye Shi 4587e32e46 Update hip-math-api doc to remove non-default-rounded
[ROCm/clr commit: 789814ab30]
2018-11-05 22:54:55 +00:00
Aaron Enye Shi 5c1dc7a071 Remove non-working non-default-rounded math apis
In ROCm-Device-Libs, they have dropped the non-default-rounded versions of add, sub, mul, div, sqrt and fma. Therefore, ocml has removed the rte, rtp, rtn, and rtz counterparts. This will remove the same math APIs in HIP for _ru, _rd, _rn, and _rz.


[ROCm/clr commit: cef6e8ef1f]
2018-11-05 22:34:16 +00:00
Siu Chi Chan e26a728173 Move the global arrays for hip malloc/free
from a header into a source file such that
there's only an unique copy in an executable
and prevent wasting static memory on the host

Change-Id: Id5b62766f77809c8d7b47892cb7149c490dcbdb9


[ROCm/clr commit: cdd0109e70]
2018-11-01 16:20:35 -04:00
Evgeny Mankov 77835ded3f [HIPIFY][doc] Update README.md
+ Split Linux and Windows sections
+ Rewrite Testing section


[ROCm/clr commit: 83d1b50615]
2018-11-01 19:11:40 +03:00
Evgeny Mankov 7b244965b6 [HIPIFY][fix] Fix typo and functions' string arguments
+ Fix typo with missing comma in counterNames array
+ Change std::string argument to const std::string& argument in all functions


[ROCm/clr commit: 48abb4a36b]
2018-11-01 16:57:57 +03:00
Jeff Daily 34c5d69f7c typedef struct hipFuncAttributes now C compatible.
Fixes #591.
Fixes #694.


[ROCm/clr commit: 6eac038694]
2018-10-31 14:12:45 +05:30
Maneesh Gupta 7052a66935 Merge pull request #733 from ex-rzr/fix_array_alloc_size
Fix allocation size of arrays with multiple and/or non-32-bit channels

[ROCm/clr commit: a75d4c0ecc]
2018-10-31 14:08:58 +05:30
Maneesh Gupta 130edf2c43 Merge pull request #714 from aaronenyeshi/remove-static-hip-device
Remove libhip_device.a static library

[ROCm/clr commit: c7f2198c6e]
2018-10-31 14:08:29 +05:30
Maneesh Gupta 58aec2b859 Merge pull request #713 from scchan/master-hcc_early_finalize_support
Support more than one device code blobs in a single .kernel section

[ROCm/clr commit: 8f667984af]
2018-10-31 14:04:06 +05:30
Rahul Garg 8856b89b21 Fixes global symbols tracking in hip_module
[ROCm/clr commit: 592efa017f]
2018-10-31 03:22:38 +05:30
Evgeny Mankov 5150bb398e Merge pull request #741 from emankov/master
[HIPIFY][fix][#739] Fix garbage after replacements

[ROCm/clr commit: ec68fda25a]
2018-10-30 19:37:19 +03:00
Evgeny Mankov 24bd6d2925 [HIPIFY][fix][#739] Fix garbage after replacements
[Issue] https://github.com/ROCm-Developer-Tools/HIP/issues/739
[Resolution] Always use an std::string not a clang::StringRef for replacement

P.S. Occurred only on Linux, on Windows works fine.


[ROCm/clr commit: 2ab8e92195]
2018-10-30 19:35:59 +03:00
Evgeny Mankov c5db5e4c4a Merge pull request #740 from emankov/master
[HIPIFY][fix] Return back cudaDeviceProp's struct field warpSize to hipWarpSize mapping

[ROCm/clr commit: b2e6ce7be0]
2018-10-30 15:55:17 +03:00
Evgeny Mankov 4ae4f1073f [HIPIFY][fix] Return back cudaDeviceProp's struct field warpSize to hipWarpSize mapping.
[ROCm/clr commit: 3489fe9ca1]
2018-10-30 15:53:00 +03:00
Maneesh Gupta 73c69744d4 Merge pull request #726 from ROCm-Developer-Tools/feature_minimal_changes_for_hc_next
hipLaunchKernel, hipLaunchParm are deprecated, and shall be removed.

[ROCm/clr commit: a36889113c]
2018-10-30 09:20:39 +05:30
Evgeny Mankov 8c98204b9c [HIPIFY] Modify HIP types to conform to CUDA's ones
[ROCm/clr commit: 2af2827a05]
2018-10-29 20:51:25 +03:00
Evgeny Mankov 4e7e8b7704 [HIPIFY] CUDA Runtime API data types total revise
+ for all CUDA versions up to 10.0
+ add missing types
+ fix typos
+ sync with HIP
+ sync with CUDA Driver API
+ update CUDA_Runtime_API_functions_supported_by_HIP.md
+ update CUDA Driver API map accordingly
+ update CUDA_Driver_API_functions_supported_by_HIP.md
+ formatting, annotating


[ROCm/clr commit: 41bc184e90]
2018-10-29 17:13:00 +03:00
Anton Gorenko 600e5cdb58 Fix allocation size of arrays with multiple and/or non-32-bit channels
hipMallocArray and hipMalloc3DArray must use sum of bits
of all components.


[ROCm/clr commit: 6e6297f3cd]
2018-10-29 18:12:00 +06:00
Yaxun Sam Liu cc101b22ed Add HIP_DUMP_CODE_OBJECT
[ROCm/clr commit: 0027a54d8b]
2018-10-26 14:14:00 -04:00
Yaxun Sam Liu 4012f63d87 Adding checks and debug output for fat binary for hip-clang
[ROCm/clr commit: da6c5c152e]
2018-10-26 14:13:12 -04:00
Evgeny Mankov 8c3f9ebac6 [HIPIFY][doc] Readme update
Clang 7.0.0 release has a known bug https://bugs.llvm.org/show_bug.cgi?id=36384, thus 7.0.0 is unstable release for Linux and Windows.
Last stable and tested LLVM+Clang release is 6.0.1.


[ROCm/clr commit: 5ab9c4bbca]
2018-10-26 15:01:58 +03:00
Aaron Enye Shi 1c05b06bcd Remove libhip_device.a static library
Move remaining function definitions from device_util.cpp to hip_runtime.h header. We can now remove the static library completely as device_util.cpp was the last file part of target hip::hip_device .


[ROCm/clr commit: ba43d1ce1b]
2018-10-25 19:52:35 +00:00
Evgeny Mankov 587ba6f1d4 [HIPIFY][cmake][fix] Mark all target_link_libraries with PRIVATE keyword
[Reason]
Avoid cmake error occurred when mixing signatures with AddLLVM.cmake

[Error]
CMake Error at CMakeLists.txt:26 (target_link_libraries): The keyword signature for target_link_libraries has already been used with the target "hipify-clang".
All uses of target_link_libraries with a target must be either all-keyword or all-plain.

Error occurred only on Linux and LLVM 7.0.0


[ROCm/clr commit: b244d1fc99]
2018-10-25 17:09:18 +03:00
Alex Voicu 5a6601c62a hipLaunchKernel, hipLaunchParm are deprecated, and shall be removed.
[ROCm/clr commit: a743939900]
2018-10-25 13:32:17 +01:00
Maneesh Gupta bd0e1c87b7 Merge pull request #723 from mangupta/fix_double_shfl
Fix logic for double variants of __shfl*

[ROCm/clr commit: 05beeec84d]
2018-10-25 06:01:38 +05:30
Maneesh Gupta 42a8d09f51 Merge pull request #720 from mangupta/make_rocm19_usable_again
Make HIP functional again with HCC from ROCm 1.9.x

[ROCm/clr commit: cd53504215]
2018-10-25 06:01:27 +05:30
Maneesh Gupta bf119ef4e8 Merge pull request #716 from yxsamliu/gfx906
Let hipcc handle gfx906 for hip-clang

[ROCm/clr commit: df02a8ef5f]
2018-10-25 06:01:16 +05:30
Maneesh Gupta b6f6734285 Fix logic for double variants of __shfl*
Change-Id: I604f00b54cf4bd9c5f26ca6fa680fca5e9629417


[ROCm/clr commit: 7b6d232672]
2018-10-24 12:39:09 +05:30
Maneesh Gupta 127f7d0320 Make HIP functional again with HCC from ROCm 1.9.x
Change-Id: I214acdfd0b79dcf783993e44fe31baee64fd4dc3


[ROCm/clr commit: b01ac26948]
2018-10-24 10:41:56 +05:30
Qianfeng Zhang b12c16f72b Make correct checking of the returned hipDeviceptr_t from read_global_description()
[ROCm/clr commit: 443698ce00]
2018-10-23 21:13:11 +08:00
Evgeny Mankov 26509d1f68 [HIPIFY] Split CUDA2HIP map into a number of maps based on API type
[Reasons]
+ Simplify the support
+ Optimize compilation and code generation time

[Additionally]
+ Update minimum required version of cmake
+ Fix MSVC compile options force update


[ROCm/clr commit: 75972cb51d]
2018-10-23 00:00:10 +03:00
Yaxun Sam Liu 5626b48795 Let hipcc handle gfx906 for hip-clang
[ROCm/clr commit: 1f7b924e2e]
2018-10-21 10:04:30 -04:00
Maneesh Gupta b859ab46df Merge pull request #705 from ROCm-Developer-Tools/feature_minimal_changes_for_hc_next
Feature minimal changes for hc next

[ROCm/clr commit: 407e092a13]
2018-10-19 06:58:31 +05:30
Siu Chi Chan 5d1a265efc Support more than one bundles in a single .kernel section
When compiling with Early Finalization enabled in HCC,
the resulting .kernel section of the host object now may
contain more than one device code bundles.  This is to
teach the HIP runtime to correctly extract all the
bundles from the .kernel section.


[ROCm/clr commit: f39873c584]
2018-10-18 17:00:27 -04:00
Evgeny Mankov ff564c763c [HIPIFY] CUDA Driver API data types total revise
+ for all CUDA versions
+ add missing types
+ fix typos
+ sync with HIP
+ update CUDA_Driver_API_functions_supported_by_HIP.md
+ formatting, annotating


[ROCm/clr commit: 865c6f23c7]
2018-10-18 18:50:24 +03:00
Alex Voicu 35e9dfc593 Dumb workaround is still needed, so add it back.
[ROCm/clr commit: 3678063598]
2018-10-18 15:33:46 +01:00
Alex Voicu fe7e09d222 Guard new includes.
[ROCm/clr commit: 59533b84e1]
2018-10-18 12:29:27 +01:00
Alex Voicu c505c2be38 Re-sync with upstream.
[ROCm/clr commit: 602280eb8b]
2018-10-18 12:27:03 +01:00
Maneesh Gupta 5070b00c83 Merge pull request #688 from aaronenyeshi/fix-sinf-cosf-ocml
Use sinf and cosf from ocml device libs

[ROCm/clr commit: 30523b72a2]
2018-10-18 16:39:20 +05:30
Maneesh Gupta cf95358003 Merge pull request #692 from whchung/hip-reinit-take2
HIP program state re-initialization logic (take 2)

[ROCm/clr commit: 9143ae6bdb]
2018-10-18 12:06:41 +05:30
Maneesh Gupta c5a8113e91 Merge pull request #711 from nicholasmalaya/patch-1
Updates to HIP porting guide 

[ROCm/clr commit: c7a147f109]
2018-10-18 12:06:31 +05:30
Nicholas Malaya ad5861ad46 Update hip_porting_guide.md
[ROCm/clr commit: bfbc1298d1]
2018-10-17 14:27:11 -05:00
Nicholas Malaya 4f63362a1c Fixing link
[ROCm/clr commit: adc7741441]
2018-10-17 14:26:49 -05:00
Nicholas Malaya be03a6f8b2 Fixing a link
[ROCm/clr commit: 319f7232c2]
2018-10-17 14:25:54 -05:00