Commit Graph

71094 Commits

Author SHA1 Message Date
Maisam Arif 28fbf0d74f Create symbolic links instead of hard links
This unbreaks having sources on one mount point and builds at another.

Signed-off-by: Marius Brehler <marius.brehler@amd.com>
Change-Id: I68363112382a95baaa867cad91e09bdec2b30d90


[ROCm/amdsmi commit: bd3579a1ac]
2025-09-26 12:17:06 -05:00
Rahul Manocha 538f1c3b74 SWDEV-556205 - fix segfault in hiprtc (#1058)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-09-26 09:06:37 -07:00
amd-hsivasun b4f4d24dda [Ex CI] Enable rdc (#941)
* [Ex CI] Enable rdc

* Reorder pipelineID list
2025-09-26 11:53:03 -04:00
Mustafa Abduljabbar 0dd2b2f65e Fix extra token typo (#1943) 2025-09-26 11:18:43 -04:00
Gerardo Hernandez e45c56c0f8 SWDEV-1 - if hipconfig process invocation by cmake fails, produce a readable error and abort
* SWDEV-1 - if platform auto-detection via hipconfig fails, provide a meaningful error and do not try to parse the output
* SWDEV-1 - if getting HIP_VERSION via hipconfig fails, provide a meaningful error and do not try to parse the output
2025-09-26 14:50:57 +01:00
German Andryeyev bb1295bcdf SWDEV-547108 - Fix compilation errors under Windows (#1085)
Also correct AQL print under Windows
2025-09-26 09:42:50 -04:00
Laura Promberger 3fd56bfefc Update TheRock CI to use health status script (#1130)
This will update the CI to match TheRocks CI by introducing to use a
python script to report on health status. Commands that were in the
section that modified the status were moved to separate sections
(ccache, git config, ..).

Related PR:
https://github.com/ROCm/TheRock/pull/1516
2025-09-26 10:09:31 +02:00
Maisam Arif 843dfaeed2 Removed unused version config files
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I3b00a8c302615026422f6d5d602959989ee0418e
2025-09-25 18:19:14 -05:00
Maisam Arif 4fcf92ee14 Removed unused version config files
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I3b00a8c302615026422f6d5d602959989ee0418e


[ROCm/amdsmi commit: 843dfaeed2]
2025-09-25 18:19:14 -05:00
Mario Limonciello ccfdb65b6f Set the SOVERSION in CMake from MAJOR/MINOR/RELEASE variables
Having the SOVERSION derived from the git tags doesn't scale well
for distributions that don't have the git history while building
(such as a tarball).

As part of e7d6590 the strings are parsed from a header.  Re-use
those.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
2025-09-25 18:19:14 -05:00
Mario Limonciello ef8882b4bf Set the SOVERSION in CMake from MAJOR/MINOR/RELEASE variables
Having the SOVERSION derived from the git tags doesn't scale well
for distributions that don't have the git history while building
(such as a tarball).

As part of 8b96ee5 the strings are parsed from a header.  Re-use
those.

Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>


[ROCm/amdsmi commit: ccfdb65b6f]
2025-09-25 18:19:14 -05:00
Mustafa Abduljabbar 7a329bbd94 Expose symbols for RCCL algo/proto/channels selection functions (#1923)
* Unhide symbols for algo/proto functions

* Add all_gather direct usage detection
2025-09-25 18:58:30 -04:00
Maisam Arif df87246b40 Changed amd_smi_drm.cc to depend on dynamic libdrm
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ie8a794578da1a3ad8893d436e54bbfb67857a7ae
2025-09-25 17:40:05 -05:00
Maisam Arif f20ecc8512 Changed amd_smi_drm.cc to depend on dynamic libdrm
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ie8a794578da1a3ad8893d436e54bbfb67857a7ae


[ROCm/amdsmi commit: df87246b40]
2025-09-25 17:40:05 -05:00
Larry Meadows cb14fccdcc - LL Protocol: Add missing fences for gfx950, this fixes the hang issue (#1932)
- Remove asm flat_store_dwordx4, not needed
2025-09-25 14:07:07 -07:00
Rahul Manocha 2bc561d404 SWDEV-557057 - fix for datatype for hipMemcpy3DBatchAsync (#1114)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-09-25 13:53:23 -07:00
Bindhiya Kanangot Balakrishnan 3e7e4ab1ac [SWDEV-556005 & SWDEV-556853] Initialize temp-type map
Added back the temp-type map initialization to
RSMI_TEMP_TYPE_INVALID before probing hwmon files. This
prevents std::out_of_range for unsupported or absent
temperature sensor types.

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
2025-09-25 12:03:35 -05:00
Bindhiya Kanangot Balakrishnan f4b921c5f5 [SWDEV-556005 & SWDEV-556853] Initialize temp-type map
Added back the temp-type map initialization to
RSMI_TEMP_TYPE_INVALID before probing hwmon files. This
prevents std::out_of_range for unsupported or absent
temperature sensor types.

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>


[ROCm/amdsmi commit: 3e7e4ab1ac]
2025-09-25 12:03:35 -05:00
Sourabh U Betigeri b24f922a24 SWDEV-552620 - Adds a new graph benchmark test for different topologies (#1073) 2025-09-25 09:50:10 -07:00
David Yat Sin cd48105282 rocr: Fix ext-fine-grain flag on host memory (#1067)
Fix for extended-fine-grain flag not set in thunk when
allocating host memory.
2025-09-25 11:10:43 -04:00
Godavarthy Surya, Anusha fb72d7f851 SWDEV-524746 - Part-II Add multi device support for hip graph. Updated kernel arg manager for each device (#813)
- Updated kernel arg manager to support allocating kernel args on multiple devices for single graph.
- Updated AQL path to capture on the device where graph node is added.

Co-authored-by: Anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>
2025-09-25 20:38:18 +05:30
MachineTom 4a31affb76 Users/taosang/SWDEV-510994 - Refractor atomics header and tests (#902)
* SWDEV-550626 - Refactor atomics header and tests

1. Introduce __HIP_ATOMIC_BACKWARD_COMPAT.
By default we define __HIP_ATOMIC_BACKWARD_COMPAT=1 to
let hip atomic functions maintain old assumptions. if
users want to adopt the new behavior, that is , by default
assume no-fine-grained no-remote-memory, then they can
define __HIP_ATOMIC_BACKWARD_COMPAT=0 and get the new
behaviour.

2. Use  __HIP_ATOMIC_BACKWARD_COMPAT_MEMORY to replace
original __HIP_FINE_GRAINED_MEMORY  in atomic header.
And apply __HIP_FINE_GRAINED_MEMORY onto all 
atomicXXX_system() functions to prevent failure on memory
allocated by hipHostMalloc().

3. Replace HIP_TEST_FINE_GRAINED_MEMORY with
HIP_TEST_ATOMIC_BACKWARD_COMPAT_MEMORY in hip-tests.

4. Fix negative test errors.
    Fix managed memory test error on memory order.
    some other minor changes.
    As a result  all originally disabled tests are enabled.

5. Add more atomics tests in some cases.

6. Reduce test time in each case.
     Reduce iteration number to 1 for tests that cost too much time.

8. Put common codes into hip_test_common.hh
2025-09-25 10:58:59 -04:00
systems-assistant[bot] becb4646bd SWDEV-546346 - [catch2][dtest] Tests for hipStreamSetAttribute and hipStreamGetAttribute (#524)
* SWDEV-546346 - [catch2][dtest] Tests for hipStreamSetAttribute and hipStreamGetAttribute

* SWDEV-546346 - Modified Kernel, added info statement

---------

Co-authored-by: Rambabu Swargam <rambabu.swargam@amd.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-09-25 15:29:26 +05:30
AL Musaffar, Yazen 6550c51b35 [AMD-SMI] [SWDEV-551318] amdsmi_get_afids_from_cper python api Docs Updated (#709)
* Fix formatting & Examples for amdsmi_get_afids_from_cper CPER record examples in documentation

---------
Change-Id: Ib5e268dc818adc633541652a0eb982641385bf7d
Signed-off-by: AL Musaffar, Yazen <Yazen.ALMusaffar@amd.com>
2025-09-24 21:06:38 -05:00
AL Musaffar, Yazen a2b299d2a0 [AMD-SMI] [SWDEV-551318] amdsmi_get_afids_from_cper python api Docs Updated (#709)
* Fix formatting & Examples for amdsmi_get_afids_from_cper CPER record examples in documentation

---------
Change-Id: Ib5e268dc818adc633541652a0eb982641385bf7d
Signed-off-by: AL Musaffar, Yazen <Yazen.ALMusaffar@amd.com>

[ROCm/amdsmi commit: 6550c51b35]
2025-09-24 21:06:38 -05:00
Maisam Arif 9f22e59c52 Change libdrm.so.2 references to dynamic libdrm naming
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ie02c91a3a210ab7612fec670b2aad66d476d2cf3
2025-09-24 20:44:03 -05:00
Maisam Arif 0caec33dc5 Change libdrm.so.2 references to dynamic libdrm naming
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: Ie02c91a3a210ab7612fec670b2aad66d476d2cf3


[ROCm/amdsmi commit: 9f22e59c52]
2025-09-24 20:44:03 -05:00
Stella Laurenzo 4d5d24d1c6 Fix delay loading of drm by soname. 2025-09-24 20:44:03 -05:00
Stella Laurenzo 7412d14fed Fix delay loading of drm by soname.
[ROCm/amdsmi commit: 4d5d24d1c6]
2025-09-24 20:44:03 -05:00
Stella Laurenzo 62e4329559 Add rt dep back 2025-09-24 20:44:03 -05:00
Stella Laurenzo e16c125f20 Add rt dep back
[ROCm/amdsmi commit: 62e4329559]
2025-09-24 20:44:03 -05:00
Stella Laurenzo 4e6731a817 [cmake] Fix dependencies.
* Use CMAKE_DL_LIBS instead of hard-coded `dl`.
* Use Threads::Threads instead of `pthread`.
* Drop `rt` dep.
* Find libdrm via pkgconfig (consistent to how other ROCm projects do it as documented here: https://github.com/ROCm/TheRock/blob/main/docs/development/dependencies.md#libdrm)
2025-09-24 20:44:03 -05:00
Stella Laurenzo 060293c7fc [cmake] Fix dependencies.
* Use CMAKE_DL_LIBS instead of hard-coded `dl`.
* Use Threads::Threads instead of `pthread`.
* Drop `rt` dep.
* Find libdrm via pkgconfig (consistent to how other ROCm projects do it as documented here: https://github.com/ROCm/TheRock/blob/main/docs/development/dependencies.md#libdrm)


[ROCm/amdsmi commit: 4e6731a817]
2025-09-24 20:44:03 -05:00
vedithal-amd 5f12d9b789 Fix instructions to build standalone binary (#1116) 2025-09-24 16:31:08 -04:00
David Galiffi 4d959460e1 Add ROCPROFSYS_PATH variable to environment (#1103)
* Add ROCPROFSYS_ROOT to the env for sample

* Add env for causal

* Add env for instrument

* Check for null and address memory leak

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2025-09-24 13:52:34 -04:00
solaiys 8912930840 [rocm-core] Adding a tool for ROCM Deployment Health Check (#958)
* Adding a tool for ROCM Deployment Health Check

rdhc.py - This simple tool will check for the rocm
installation and its readiness on the current system and its working status.
Check the README file for more info.

Signed-off-by: Saravanan Solaiyappan <saravanan.solaiyappan@amd.com>
2025-09-24 22:43:42 +05:30
Istvan Kiss 83fb0c8c47 SWDEV-541514 - Docs update 2025-09-15 (#993)
Co-authored-by: Julia Jiang <56359287+jujiang-del@users.noreply.github.com>
2025-09-24 09:57:00 -07:00
Dmitrii 0575606e49 chore: [rdc] Add copyright notice (#1098) 2025-09-24 09:07:20 -07:00
vedithal-amd bd7a1de879 Remove rocprofv1/v2 in favour of rocprofiler-sdk (#673)
* Set default rocprof interface as rocprofiler-sdk

* Remove rocrprofv1 and rocprofv2 interfaces

* Remove deprecation notice for rocprof v1/v2/v3 interfaces
  * Make rocprofiler-sdk the default interface and make rocprofv3 interface opt-in using ROCPROF=rocprofv3

* Add deprecation notice for rocprofv3
2025-09-24 10:37:01 -04:00
vedithal-amd 7df02745eb [rocprofiler-compute] Update gfx12 counter definitions (#1003)
* Update gfx12 counter definitions

* Add counter defintions for Navi 4

* Made changes per https://github.com/ROCm/rocm-systems/pull/238 and
  doubled checked register specification

* bugfix
2025-09-24 10:32:21 -04:00
vedithal-amd f5505b5989 Use ROCM_PATH for sdk library path (#1097) 2025-09-24 10:31:20 -04:00
marandje a90f28cd5c SWDEV-555178 - Fix and enable Unit_hipMemVmm_Uncached (#1090) 2025-09-24 15:51:22 +02:00
jamessiddeley-amd 05315c5bb2 fixed function argument dir in apply_filters (#1100) 2025-09-24 09:50:58 -04:00
marandje 778f2f05bf SWDEV-555296 - Fix and enable Unit_hipEventIpc (#992) 2025-09-24 15:48:53 +02:00
Kian Cossettini 7eb606a582 Make lock init and destroy cb events instant (#1074)
Removed names changes for `ROCPROFILER_OMPT_ID_lock_init` and `ROCPROFILER_OMPT_ID_lock_destroy`. 
Made both of these callbacks instant.
2025-09-24 07:41:47 -04:00
Ioannis Assiouras c53bdb9643 SWDEV-556866 - Added misssing include of rocrctx.hpp in rocurilocator (#1094) 2025-09-24 06:44:02 +01:00
Sai Enduri 01d16d4139 Enable multi node rccl tests on MI350x slurm cluster. (#1900)
* Add tests on slurm cluster

* Integrate slurm.

* Add flags.

* Added dynamic selection of runners for tests and cleanup for slurm reservation

* Revert "Added dynamic selection of runners for tests and cleanup for slurm reservation"

This reverts commit d5350ff6e4f563ddd56ad81e4bc2a393ed55ba00.

* Refactor so tests run on both architectures.

* continue on error

* fail fast false on matrix

* remove scancel

* skip all single node tests

* fix pattern matching for pytest

* switch to always skip github job

* Update to latest allocation.

* Clean up workflows and update docker image.

* Updated container image published from PR #1517

* Switch back to TheRock main branch sha.

---------

Co-authored-by: arravikum <arravikum@amd.com>
2025-09-23 22:00:26 -07:00
Benjamin Welton 9743ff0c74 Improve error message for invalid extra counters YAML format (#219)
When users provide an incorrectly formatted YAML file to the -E/--extra-counters
option in rocprofv3, they now receive a clear error message showing:

- What went wrong (invalid YAML format)
- The correct rocprofiler-sdk YAML structure with example
- The actual content that failed to parse

This addresses confusion where users might use the legacy ROCProfiler YAML
format instead of the new rocprofiler-sdk schema format.
2025-09-23 22:23:57 -05:00
SaleelK d0e622e978 hip-tests: Fix hipPerfBufferCopySpeed (#946)
* Fix formatting and buffer size
2025-09-23 23:11:20 -04:00
itrowbri abd6029603 [rocprofv3] MultiKernelDispatch ATT support (#774)
* Initial consecutive kernel WIP

* Updated logic after discussion, create context only when needed, change set of captured ids to dispatch_id_t type

* Updated to fix concurrency issues and revert kernel_iterations

* Add captured id in first lock capture

* Updated code to use wlock, added comments, removed some unecessary atomic

* Cleaned up, need to add test

* Add test to check that generated stats csv file is not empty

* Updated test to check if vector-ops kernels are being used

* Fix phase bug

* Updated for comments

* Flattened ATT logic a bit

* Fix incorrect if-statement

* Fix merge conflict
2025-09-23 20:19:27 -05:00