Commit Graph

37726 Commits

Author SHA1 Message Date
taosang2 d91e1f19d0 SWDEV-512613 - Improve device atomics functions
Also part of SWDEV-510994.
1. Fix atomicMin/Max_system() for float and double.
2. Remove logics of gfx941 which isn't supported.

Change-Id: Iacfdc1bc13e8da2f5df8751bb315b37d33cea667
2025-03-06 10:05:59 -05:00
Ioannis Assiouras e963d30b5d SWDEV-517715 - Remove dependency on non-static hipcc from hip-static-devel
Change-Id: I1184680949fa73d7dc0957062292e6682179b203
2025-03-06 10:01:58 -05:00
Aidan Belton-Schure 674ed47852 SWDEV-489364 - Free memory in hipAPIStreamDisable
Change-Id: I4f740fe803bcc4bbf57865173d92c567de65fdbb
2025-03-06 04:07:21 -05:00
Rawat, Swati 27d0bc087c Update CHANGELOG.md: editorial review (#254)
Update CHANGELOG.md

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>

[ROCm/rocprofiler-sdk commit: d74ea0876f]
2025-03-06 12:32:02 +05:30
Rawat, Swati d74ea0876f Update CHANGELOG.md: editorial review (#254)
Update CHANGELOG.md

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
2025-03-06 12:32:02 +05:30
Su, Daniel 70b44c576c External CI: change trigger from amd-master to amd-mainline
Signed-off-by: Su, Daniel <Daniel.Su@amd.com>
2025-03-05 16:24:29 -05:00
Sohaib Nadeem 95a07edf0b Fix hardware counter summary files not being generated after profiling (#124)
- Register a cleanup function in tim::manager instance to write out data in
counter storages

- The counter_storage::write() calls in tool_fini happen after the storage is destroyed
which is too late for the write to happen.

- Adjust traits for counter_data_tracker

- Add MIN, MAX, VAR, STDDEV columns
- Remove DEPTH, UNITS, %SELF columns

- Update "add_validation_test" to test for the existence of output file(s).
- Added step to test perfetto output for `transpose-rocprofiler-sampling`
and `transpose-rocprofiler-binary-rewrite`

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-systems commit: 42922ec851]
2025-03-05 16:05:18 -05:00
Sohaib Nadeem 42922ec851 Fix hardware counter summary files not being generated after profiling (#124)
- Register a cleanup function in tim::manager instance to write out data in
counter storages

- The counter_storage::write() calls in tool_fini happen after the storage is destroyed
which is too late for the write to happen.

- Adjust traits for counter_data_tracker

- Add MIN, MAX, VAR, STDDEV columns
- Remove DEPTH, UNITS, %SELF columns

- Update "add_validation_test" to test for the existence of output file(s).
- Added step to test perfetto output for `transpose-rocprofiler-sampling`
and `transpose-rocprofiler-binary-rewrite`

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-03-05 16:05:18 -05:00
Marko Arandjelovic 7ef404621e SWDEV-441296 - Add unit test for hipTexObjectCreate
Change-Id: Ibfc2c910a54ccd1686a3939a1008c472a8465137
2025-03-05 12:10:14 -05:00
Madsen, Jonathan 15c8c05f0c [rocprofv3] Fix calculation of services which collected data (#265)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: e7c64e12f9]
2025-03-05 10:59:06 -06:00
Madsen, Jonathan e7c64e12f9 [rocprofv3] Fix calculation of services which collected data (#265)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-03-05 10:59:06 -06:00
Saleel Kudchadker 940347ad42 SWDEV-508004 - Improve hipStreamWaitEvent & Fix typo
- hipStreamWaitEvent may not resolve streams
- Correct usage of flag passed to streamWait function

Change-Id: I2ee163615d303b98937c1035d60da283cce6f677
2025-03-05 11:56:01 -05:00
Pengda Xie ae3b053ddf SWDEV-518317 - Don't attempt to remove managedVars when map is empty
Change-Id: I25c33487dc08f96c087b6acc1abe42a4a666a609
2025-03-05 11:53:18 -05:00
taosang2 f6471c5b2c SWDEV-507141 - Make some buffered print tests shorter
Change-Id: I651c25f011c24d2192c62596722b8fddc581655b
2025-03-05 11:33:55 -05:00
Julia Jiang 490f02a66e SWDEV-512851 - Update P2P Device Memory Access section in HIP API header
Change-Id: Ie49de7e9a943c36df03e5387dc083517993d6baa
2025-03-05 11:29:06 -05:00
David Yat Sin 6dac90c89a rocr: Only expose ext-fine-grain pool on xgmi-hive systems
We cannot guarrantee system-scope coherency on systems with only PCIe
connections, so do not expose extended fine-grain memory pool on these
systems.
2025-03-05 10:41:38 -05:00
arvindcheru c283b69b62 Move install location of internal papi files to lib/<pkgnm> (#118)
Signed-off-by: ArvindCheru <acheruva@amd.com>

[ROCm/rocprofiler-systems commit: c3138e1962]
2025-03-05 10:23:58 -05:00
arvindcheru c3138e1962 Move install location of internal papi files to lib/<pkgnm> (#118)
Signed-off-by: ArvindCheru <acheruva@amd.com>
2025-03-05 10:23:58 -05:00
taosang2 1a7df073ba SWDEV-501963 - Add missing codes for gfx950
Change-Id: I6b3c6bf54c61cffd44cd6f17b75998f751b75724
2025-03-05 08:18:22 -05:00
Branislav Brzak c2d1776ebd SWDEV-516564 - SWDEV-512817 - Remove mentions of gfx940 and gfx941
Change-Id: Ia069fcb9c6948c3fc9a00961593c9dcc59609375
2025-03-05 04:26:07 -05:00
Jaydeep Patel b42adb24b4 SWDEV-457316 - Fix tests to use graph's reserve memory instead of hipMemGetInfo.
Change-Id: I839aaec3f502ed8686651fdc05b71c0da3e5dea2
2025-03-05 00:48:15 -05:00
David Galiffi 8a70f4b15d Update workflow runners due to the deprecation of ubuntu-20.04 runners (#102)
* Update runners to `ubuntu-latest`.

The `ubuntu-20.04` runner is deprecated and will be removed.

* Add 'vim' and 'perfetto' to CI docker images

For convenience when using the images locally.

[ROCm/rocprofiler-systems commit: a25554359b]
2025-03-04 19:31:13 -05:00
David Galiffi a25554359b Update workflow runners due to the deprecation of ubuntu-20.04 runners (#102)
* Update runners to `ubuntu-latest`.

The `ubuntu-20.04` runner is deprecated and will be removed.

* Add 'vim' and 'perfetto' to CI docker images

For convenience when using the images locally.
2025-03-04 19:31:13 -05:00
David Galiffi 4a86630875 Move cmake files to .../lib/cmake/rocprofiler-systems (#128)
* Move cmake files to `.../lib/cmake/rocprofiler-systems`


[ROCm/rocprofiler-systems commit: a588f53d3e]
2025-03-04 19:28:59 -05:00
David Galiffi a588f53d3e Move cmake files to .../lib/cmake/rocprofiler-systems (#128)
* Move cmake files to `.../lib/cmake/rocprofiler-systems`
2025-03-04 19:28:59 -05:00
Lao, Darren 0cd46b6582 rocr: Change grid dimensions
Signed-off-by: Lao, Darren <Darren.Lao@amd.com>
2025-03-04 16:19:51 -05:00
Saleel Kudchadker e03e4f3b5d SWDEV-502365 - Track last used command
- This change tries to save extra synchronization packets we may insert
  as we didnt track the completion signals for every command. We track
the current enqueued command until it exits the enqueue stage. We also
record the exit scope to know if we flushed the caches
- Handle correct release scopes and store completion signal as HW events
- Use a new finishCommand implementation to only wait for the command
  passed as the argument

Change-Id: Ie4350c5dd24f5d48dfa6ccbabd892f0544caadcc
2025-03-04 16:05:02 -05:00
German Andryeyev cece301fd4 SWDEV-518474 - Add comgr debug mask
Move prints from CO processing under COMGR debug mask.

Change-Id: I2a417e42a1f4e2922a34eb104c69e4db10b5f1c6
2025-03-04 14:37:08 -05:00
Julia Jiang 81db54d3f9 SWDEV-509855 - Update hipDeviceAttributePciDomainID in CLR
Change-Id: I79939b333ef6114b97009ca4bfb67f63a9a22784
2025-03-04 14:08:08 -05:00
Marko Arandjelovic 293ff3a025 SWDEV-504084 - Corrected CooperativeKernelMultipleDevice testcases
Module and stream should be created on the same device, while hipModuleGetFunction can be called from any device.

Change-Id: I4a424f9631678684292e40e05ffbaf3d887aea55
2025-03-04 13:08:30 -05:00
Jaydeep Patel 2356da049c SWDEV-512585 - Don't use catch2's REQUIRE macro in child/worker thread which might fail.
Change-Id: I513176259eb87879ea2bf557e923b2c2cd6166a2
2025-03-04 12:38:35 -05:00
David Yat Sin 4cb6a6d45d rocrtst: Disable RLIMIT for negative queue tests
The negative queue tests generate an exception which triggers a coredump
generation. Disable RLIMIT so that the coredumps are not generated for
these tests.
2025-03-04 10:29:34 -05:00
David Yat Sin d031af9eb5 rocr: Check RLIMIT_CORE before generating coredump
Check for RLIMIT_CORE before collecting data for coredump. If the
current limit is 0, then we can return early without spending time
collecting coredump data.
2025-03-04 10:29:34 -05:00
adapryor 9571dad23d [SWDEV-517396] Align rdc_field with rdc_bootstrap
Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I5e05e25c5980a3141665ae2d13a6ae09207ccb41
2025-03-04 08:49:28 -06:00
adapryor fbeacaff0c [SWDEV-517396] Align rdc_field with rdc_bootstrap
Signed-off-by: adapryor <Adam.pryor@amd.com>
Change-Id: I5e05e25c5980a3141665ae2d13a6ae09207ccb41


[ROCm/rdc commit: 9571dad23d]
2025-03-04 08:49:28 -06:00
Galantsev, Dmitrii d5f8ff0ab0 CMAKE - Set fallback version to 0.3.0
Change-Id: I2322bdb7d3a8e4f83346ca4f5d24351ad2a4eccc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-03-04 08:43:32 -06:00
Galantsev, Dmitrii 705d42f0f5 CMAKE - Set fallback version to 0.3.0
Change-Id: I2322bdb7d3a8e4f83346ca4f5d24351ad2a4eccc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rdc commit: d5f8ff0ab0]
2025-03-04 08:43:32 -06:00
Li Ma 26ea06bb69 Modify the error log for MM_ENC_UTIL
Signed-off-by: Li Ma <li.ma@amd.com>
Change-Id: I83805fc8ad7003ecd5189c8f940b44edbf0ebd1f
2025-03-04 08:42:22 -06:00
Li Ma 709b621c48 Modify the error log for MM_ENC_UTIL
Signed-off-by: Li Ma <li.ma@amd.com>
Change-Id: I83805fc8ad7003ecd5189c8f940b44edbf0ebd1f


[ROCm/rdc commit: 26ea06bb69]
2025-03-04 08:42:22 -06:00
dependabot[bot] 933ee1cf26 Bump rocm-docs-core[api_reference] from 1.17.0 to 1.17.1 in /docs/sphinx (#127)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.17.0 to 1.17.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.17.0...v1.17.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/rocprofiler-systems commit: 9b4ec6adb9]
2025-03-03 22:55:17 -05:00
dependabot[bot] 9b4ec6adb9 Bump rocm-docs-core[api_reference] from 1.17.0 to 1.17.1 in /docs/sphinx (#127)
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.17.0 to 1.17.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.17.0...v1.17.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-03-03 22:55:17 -05:00
Bhardwaj, Gopesh af84efb389 SWDEV-518428 Fixing experimental filesystem compilation issue (#262)
* SWDEV-518428 Fixing experimental filesystem compilation issue

* addressing feedback

[ROCm/rocprofiler-sdk commit: 73aa1bdeab]
2025-03-04 08:48:23 +05:30
Bhardwaj, Gopesh 73aa1bdeab SWDEV-518428 Fixing experimental filesystem compilation issue (#262)
* SWDEV-518428 Fixing experimental filesystem compilation issue

* addressing feedback
2025-03-04 08:48:23 +05:30
Ioannis Assiouras bae567a560 SWDEV-517040 - Prevent segfault in Unit_hiprtc_includepath if can't open saxpy.h
Change-Id: Ie26857fe5dc16c8053b67b145d88588ce209281c
2025-03-03 19:34:37 -05:00
David Yat Sin 3944da1d76 rocr:Only set asan flag on GPU agents 2025-03-03 14:51:19 -05:00
Jaydeep Patel 192528c7f2 SWDEV-465220 - Update Kernel Launch negative cases to match with current CLR code.
Change-Id: I891544cdfdc1092467454189ea348f986fc12818
2025-03-03 10:48:18 -05:00
David Galiffi d9ec34e837 fix false positive in perfetto validation (#125)
- The Perfetto validation script was generating false positives if the queried Perfetto data was empty.
- Fixed some failures that appeared after fixing the script.

[ROCm/rocprofiler-systems commit: 610cd00971]
2025-03-03 10:32:54 -05:00
David Galiffi 610cd00971 fix false positive in perfetto validation (#125)
- The Perfetto validation script was generating false positives if the queried Perfetto data was empty.
- Fixed some failures that appeared after fixing the script.
2025-03-03 10:32:54 -05:00
David Yat Sin 9a950ab788 rocr: Temporarily disable alternate scratch memory
Temporarily disable alternate scratch memory usage by default due to
some stability issues.
2025-03-03 09:27:29 -05:00
Aidan Belton-Schure 5007b3f5e4 SWDEV-491303 - Add_concurrent_stream_error_checking
Change-Id: I70268bfa2b97994e0906ded6bae9885ec540292e
2025-03-03 04:21:40 -05:00