Revīziju grafs

37726 Revīzijas

Autors SHA1 Ziņojums Datums
Bhardwaj, Gopesh 6d2e70d8da updating roctx documentation for functions (#30)
updating roctx documentation for funcitons
2024-12-05 19:47:57 +05:30
Marko Arandjelovic f65d41442f SWDEV-499927 - Fix hipMemAllocationProp
- The member of the hipMemAllocationProp struct is named requestedHandleTypes. However, in HIP, it is named requestedHandleType. I have decided not to follow CUDA's naming convention, as it would require a lot of changes across HIP repositories (clr, hip, hip-tests).
 - Fix hipMemGetAllocationPropertiesFromHandle to update out parameter properly.

Change-Id: I8417a2e73b0ee9fa5ca0d36546e75cfce82cbf3e
2024-12-05 04:55:54 -05:00
Ioannis Assiouras e4077f827c SWDEV-474345 - Address potential segmentation fault in Print_Out_Attributes test
Change-Id: Ie507d3da66d9644eea56a510e76564af1970e2c0
2024-12-05 04:52:04 -05:00
Branislav Brzak f2dba978f5 SWDEV-490860 - Include signal_is_required in dot file dumps
Change-Id: Iec4b433b11fbecb71a4ce68beb7d6f681d25b8e6
2024-12-05 04:51:59 -05:00
Branislav Brzak b0599b7e4a SWDEV-489116 - Add missing hipFree to Unit_cg_binary_part
Change-Id: I1c2a8f21213d7e257e491d55714f0a2b77f6d1b3
2024-12-05 04:41:28 -05:00
Branislav Brzak 31c3eb29d4 SWDEV-487934 - Properly destroy shareable mem pool
Change-Id: I6df15c0d463dd95237c5c51e8136d96ede3db4fe
2024-12-05 04:41:17 -05:00
Branislav Brzak 09697ca260 SWDEV-489117 - Add missing stream destry in Unit_hipCGMultiGridGroupType_Basic
Change-Id: Ic926da700e7c1933d105495306b94f302d130150
2024-12-05 04:37:35 -05:00
Aidan Belton-Schure 952028a888 SWDEV-483558 - Only add .bat extension once
Change-Id: I8ac5703be836766e2803e1c507aadfdfa275730d
2024-12-05 04:24:29 -05:00
Marko Arandjelovic 18f69cba00 SWDEV-473788 - Add unit test for hipBindTexture
Change-Id: Iefb695feb56cb70aff186eb719cbbd366297d91e
2024-12-05 04:23:09 -05:00
Baraldi, Giovanni d7453990cc SWDEV-489158: Adding consumer+producer model to AST evaluation (#13)
* Rebased optizations for rocprofv3 tool

* Fixing merge conflicts

* Formatting

* Open from within mutex

* Small name changes

* Added operator

* removed some parameters

* Optimizing counter collection

* Re-arrange code

* Adding back dimension query

* Formatting

* Update source/lib/rocprofiler-sdk/thread_trace/att_core.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Formatting 2

* Fix for test compilation

* Fix for yield

* Adding back check for zero

* Improved thread handling

* Formatting

* Remove automatic start

* Adding test

* Small fixes

* Adding lock for buffer callbacks

* Fix for race condition in AST

* Adding check for ptr

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: b7661bccfd]
2024-12-04 22:33:53 -06:00
Baraldi, Giovanni b7661bccfd SWDEV-489158: Adding consumer+producer model to AST evaluation (#13)
* Rebased optizations for rocprofv3 tool

* Fixing merge conflicts

* Formatting

* Open from within mutex

* Small name changes

* Added operator

* removed some parameters

* Optimizing counter collection

* Re-arrange code

* Adding back dimension query

* Formatting

* Update source/lib/rocprofiler-sdk/thread_trace/att_core.cpp

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Formatting 2

* Fix for test compilation

* Fix for yield

* Adding back check for zero

* Improved thread handling

* Formatting

* Remove automatic start

* Adding test

* Small fixes

* Adding lock for buffer callbacks

* Fix for race condition in AST

* Adding check for ptr

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2024-12-04 22:33:53 -06:00
Shane Xiao 231b2410a0 SWDEV-492049 - Remove the handle of Phy Mem from Memobj
The hipGraph will use VMM by default when allocating memory.
However, the handle of Phy mem has been added to Memobj by default.
Since the Memobj will track the whole address range from handle to
handle + size, this needs the system to reserve the whole address
range. If the system range have not reserved by the system, then it
will have the potential issue that clr finds the Memobj incorrectly.

This patch removes the handle from the Memobj to fix this potential
issue.

Change-Id: I2da38e6b2d11d0d48e1afe66c46899500c290624
2024-12-04 19:39:52 -05:00
Nagaraj, Sriraksha e67918dfe8 rocprofv3: rocprofv3-avail tool (#15)
* support avail tool

Updating avail library and script

Listing on Std output incase the output folder is not given

Extending list metrics test

misc fix

misc fix

fixing memory leak

changing list-metrics to list-avail

fixing formatting issue

Fixing CMakeLists

Add test for list avil with trace

Fix test fail

clang tidy errors fixed

Removing build commands for rocprofv3-trigger-list

Addressing review changes

addressing review comment

moving avail to libexec

merge fix

Fix test failures

updating doc

Fix doc error

* updating legacy doc

* fix formatting issue

* Addressing review comments

[ROCm/rocprofiler-sdk commit: c42bdc3128]
2024-12-04 18:34:10 -06:00
Nagaraj, Sriraksha c42bdc3128 rocprofv3: rocprofv3-avail tool (#15)
* support avail tool

Updating avail library and script

Listing on Std output incase the output folder is not given

Extending list metrics test

misc fix

misc fix

fixing memory leak

changing list-metrics to list-avail

fixing formatting issue

Fixing CMakeLists

Add test for list avil with trace

Fix test fail

clang tidy errors fixed

Removing build commands for rocprofv3-trigger-list

Addressing review changes

addressing review comment

moving avail to libexec

merge fix

Fix test failures

updating doc

Fix doc error

* updating legacy doc

* fix formatting issue

* Addressing review comments
2024-12-04 18:34:10 -06:00
Nagaraj, Sriraksha 9cfbfb5060 rocprofv3: PC Sampling Support (#14)
* Adding tool pc sampling support

Fixing merge issue

tool support on SDKupdates

link amd-comgr

Sanitizer failure fix

fix format

Addressing review comments

misc fix

Adding dispatch id to the CSV output

AddingCHANGELOG

[ROCProfV3][PC Sampling] Initial ROCProfV3 PC sampling tests for JSON and CSV formats (#17)

ROCProfV3 initial tests for JSON and CSV output.

Simple kernels that simplify the verification of samples to instruction decoding
has been introduced.

removing option to enable pc sampling explicitly

Adding documentation

no pc-sampling option in tests anymore

Addressing review comments

Updating docs

an option for choosing whether all units must be sampled

try ignoring PC sampling tests (#36)

* run pc-sampling tests on MI2xx runners
* use v_fmac_f32 instead of s_nop 0 in tests

* fixing docs

[ROCm/rocprofiler-sdk commit: 50b185b9ac]
2024-12-04 18:32:48 -06:00
Nagaraj, Sriraksha 50b185b9ac rocprofv3: PC Sampling Support (#14)
* Adding tool pc sampling support

Fixing merge issue

tool support on SDKupdates

link amd-comgr

Sanitizer failure fix

fix format

Addressing review comments

misc fix

Adding dispatch id to the CSV output

AddingCHANGELOG

[ROCProfV3][PC Sampling] Initial ROCProfV3 PC sampling tests for JSON and CSV formats (#17)

ROCProfV3 initial tests for JSON and CSV output.

Simple kernels that simplify the verification of samples to instruction decoding
has been introduced.

removing option to enable pc sampling explicitly

Adding documentation

no pc-sampling option in tests anymore

Addressing review comments

Updating docs

an option for choosing whether all units must be sampled

try ignoring PC sampling tests (#36)

* run pc-sampling tests on MI2xx runners
* use v_fmac_f32 instead of s_nop 0 in tests

* fixing docs
2024-12-04 18:32:48 -06:00
Jason Tang 01f01adedf SWDEV-500435 - Use raw strings for regular expression.
Starting from Python version 3.12, a backslash-character pair that
is not a valid escape sequence generates a SyntaxWarning, instead
of DeprecationWarning. Using raw strings fixes the warnings.

Change-Id: I6a9f35e2e2e5d9d09410dfb5964fdc19cf0bfa4a
2024-12-04 16:48:42 -05:00
Jason Tang 2c8312626e SWDEV-500435 - Use raw strings for regular expression.
Starting from Python version 3.12, a backslash-character pair that
is not a valid escape sequence generates a SyntaxWarning, instead
of DeprecationWarning. Using raw strings fixes the warnings.

Change-Id: I6a9f35e2e2e5d9d09410dfb5964fdc19cf0bfa4a


[ROCm/rocprofiler commit: 01f01adedf]
2024-12-04 16:48:42 -05:00
David Yat Sin 0544c2336b rocr: Avoid polling for SDMA signals
When all 64-bits of the signal value are 0, we can skip polling for that
signal.
We need to keep signals as 64-bit numbers as part of the spec. But most
users of ROCr do will never set the signal value to more than 32-bits.
When the dependent-signals are less than 32-bits, avoid adding extra
SDMA poll packet as this adds latency to the SDMA copies.

Change-Id: I37dca65fe3f060dc7164f49b98cb1985023663c4
2024-12-04 16:45:04 -05:00
Elwazir, Ammar 5ec8560fab CI: PC Sampling to be included in code coverage (#45)
* CI: PC Sampling to be included in code coverage

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

[ROCm/rocprofiler-sdk commit: eedee0fb96]
2024-12-04 14:33:09 -06:00
Elwazir, Ammar eedee0fb96 CI: PC Sampling to be included in code coverage (#45)
* CI: PC Sampling to be included in code coverage

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml
2024-12-04 14:33:09 -06:00
David Galiffi 741dd3ea2e Add test for ompt-target
[ROCm/rocprofiler-systems commit: 8f0282bb69]
2024-12-04 15:21:51 -05:00
David Galiffi 8f0282bb69 Add test for ompt-target 2024-12-04 15:21:51 -05:00
Saleel Kudchadker 7863eb92dc SWDEV-497145 - Use rocr copyOnEngine API for staged copies
- Refactor blit code and clean ASAN instrumentation
- Use unified function for rocr copy
- Enable shader copy path for unpinned writeBuffer/readBuffer paths
- Set GPU_FORCE_BLIT_COPY_SIZE=16 which means we will use BLIT copy for
  pinned copies or unpinned H2D/D2H copies < 16KB

Change-Id: I42045cca79234b340dbf53dafb93044199736ae4
2024-12-04 13:38:13 -05:00
Baraldi, Giovanni 145d94495a Fix use-after-free for ATT code objects (#35)
* Fix use-after-free for ATT code objects

* Formatting

* Temporary fix for last kernel

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: 21c577ba60]
2024-12-04 10:22:57 -08:00
Baraldi, Giovanni 21c577ba60 Fix use-after-free for ATT code objects (#35)
* Fix use-after-free for ATT code objects

* Formatting

* Temporary fix for last kernel

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2024-12-04 10:22:57 -08:00
German Andryeyev efd3ea4b30 SWDEV-501403 - Switch to std::shared_mutex for streamSetLock
Shared mutex allows to have access to the list of streams  from
multiple threads at the same time.

Change-Id: Ibee64b846cde03321d5b17dbee2829c0bab7e7d6
2024-12-04 12:06:51 -05:00
Marko Arandjelovic 8736cabea3 SWDEV-478998 - Add unit test for hipFreeHost
Change-Id: I85235243e0014ec6bd2b6a544222fdee8f0a7c68
2024-12-04 11:56:44 -05:00
Indic, Vladimir 1055ba96b4 Exclude PC sampling tests from non-MI2xx runners (#44)
[ROCm/rocprofiler-sdk commit: 85ad519ca7]
2024-12-04 10:55:22 -06:00
Indic, Vladimir 85ad519ca7 Exclude PC sampling tests from non-MI2xx runners (#44) 2024-12-04 10:55:22 -06:00
Jatin Chaudhary 063f7ef32a SWDEV-485945 - use union to convert values
this shows up in some compilers as warnings.

Change-Id: I862cd6baf2edb8161757adc54abb787530489481
2024-12-04 11:15:03 -05:00
Elwazir, Ammar d857134a70 Disable faulty tests in CI (#43)
* Disable faulty tests

* Update continuous_integration.yml

[ROCm/rocprofiler-sdk commit: 97f24c62eb]
2024-12-04 10:01:59 -06:00
Elwazir, Ammar 97f24c62eb Disable faulty tests in CI (#43)
* Disable faulty tests

* Update continuous_integration.yml
2024-12-04 10:01:59 -06:00
Jaydeep Patel 80144befea SWDEV-487988 - Destroy event and free memory.
Change-Id: I95ceaac5b343132c0660de0dabba548fb6a29034
2024-12-04 10:07:59 -05:00
Jaydeep Patel 8515ac9b2f SWDEV-488033 - Add dependency between memcpy node for child graph.
Since 29cc678d8d H2D can't be synced always so it's good to have dependency set.

Change-Id: I7d757a9b6afd3cf7064dc3b7014677cdf754125a
2024-12-04 10:06:52 -05:00
Jaydeep Patel 064d0398d8 SWDEV-487997 - Kernel launch can return invalid config/value in case of thread/block is 0 & -ve.
Change-Id: I91fbe2361894f16c65236c9736bd677a6d5f1f61
2024-12-04 10:06:36 -05:00
Jaydeep Patel 0422d78c1b SWDEV-487992 - Free memory.
Change-Id: Ic4c7448d7e537953bcebc73210647f52de53b0ee
2024-12-04 09:07:29 -05:00
Jimbo Xie 6c755a4116 SWDEV-485672 - LOG_INFO corrected to LOG_ERROR for errors
Change-Id: I8ab5f2117dfd7725bd4ed8b178e370096aa31018
2024-12-04 01:18:01 -05:00
Anusha GodavarthySurya b89977d518 SWDEV-469422 - Always schedule graph nodes
Change-Id: Icc636527fa19e7bf3eb111bc4b1bb9a5f9acff73
2024-12-03 23:44:23 -05:00
Chris Freehill f32e264933 rocr: Add gfx9-4-generic support
Change-Id: I4ebfbf0dcffa5b784d7fbfda7398d44dcc47aaef
2024-12-03 19:33:57 -05:00
Choudhary, Rahul 41a8bc4cc1 Update PSDB.yml - adding synchronize and removing edited type for action trigger
[ROCm/rocprofiler-sdk commit: d3aa966faa]
2024-12-03 14:25:08 -08:00
Choudhary, Rahul d3aa966faa Update PSDB.yml - adding synchronize and removing edited type for action trigger 2024-12-03 14:25:08 -08:00
Mallya, Ameya Keshava 52c3ba9e83 Update KWS to point to correct location of reusable action (#41)
[ROCm/rocprofiler-sdk commit: 78cd4c9526]
2024-12-03 12:23:37 -08:00
Mallya, Ameya Keshava 78cd4c9526 Update KWS to point to correct location of reusable action (#41) 2024-12-03 12:23:37 -08:00
Baraldi, Giovanni ba5500c356 Fix for tests. Fix for merge conflict in buffered_output. (#34)
* Fix for tests. Fix for merge conflict in buffered_output.

* Formatting

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: 4a80ecbfb8]
2024-12-03 14:00:36 -06:00
Baraldi, Giovanni 4a80ecbfb8 Fix for tests. Fix for merge conflict in buffered_output. (#34)
* Fix for tests. Fix for merge conflict in buffered_output.

* Formatting

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2024-12-03 14:00:36 -06:00
Vladana Stojiljkovic 9893726343 SWDEV-453145 - Enable _sync tests on nvidia
* _sync tests that use warp match functions (__match_any_sync and __match_all_sync) were disabled for nvidia because those functions are supported only on devices with compute capability 7.x or higher. In this solution, tests are always build (with specifying appropriate compile flag) and in in the runtime it is decided weather they should be skipped or not.

Change-Id: Ifa9e55f3b47aa3a00027cb986cd6ae46aed45ebd
2024-12-03 13:49:16 -05:00
Saleel Kudchadker 6611cc015d SWDEV-494149 - Improve hipGet/Set Device
Change-Id: If8975687a3ba9caadafc48a0066f19a4ebaab9e2
2024-12-03 13:36:38 -05:00
Satyanvesh Dittakavi 455ec9d367 SWDEV-499291 - Fix test failures due to nodiscard attibute
Change-Id: I7bd86f6506415a12940ed441556a35753fc0faa4
2024-12-03 12:33:12 -05:00
gobhardw fe55de6bef Disabling kernel names matching test
Change-Id: I70d74c421599a38207943a59c424ae7681b9fdcb
2024-12-03 15:59:24 +05:30