62cafd2bdc
Including remaining metric fixes from #251
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3ce140d04b
2024-03-01 15:50:42 -06:00
2ecc5a4246
Renaming global spec vars. Replacing L2Banks with total_l2_chan ( #251 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 86b6c8e848
2024-03-01 15:50:42 -06:00
5352eafde4
Reorganize the specs module to reduce duplicate code
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3b1b8d7b5b
2024-03-01 15:50:42 -06:00
f240822ea1
Fix off by one out of range kernel filtering ( #287 )
...
* Fi off by one out of range kernel filtering
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* reformat
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
---------
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
[ROCm/rocprofiler-compute commit: 4ad124a207
2024-02-29 12:38:37 -06:00
055bda677a
Supress warning: RuntimeWarning: Mean of empty slice ( #271 )
...
* Supress warning: RuntimeWarning: Mean of empty slice
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
* Move import to top
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
* Specify type of RuntimeWarning in catcher. Safer approach
Signed-off-by: colramos-amd <colramos@amd.com >
* Comply to formatting
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: Jose Santos <josantos@login1.hpcfund >
Signed-off-by: colramos-amd <colramos@amd.com >
Co-authored-by: Jose Santos <josantos@login1.hpcfund >
Co-authored-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f42aa6c7e0
2024-02-29 12:14:46 -06:00
e35c600d45
Fix for rocm-smi not getting mclk for MI100
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f2235b7f1d
2024-02-26 11:47:56 -06:00
6ac883e20e
more code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 76873dd0c4
2024-02-22 16:02:25 -06:00
e9f8f78f9f
more code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 5a27189c82
2024-02-22 16:02:25 -06:00
4bfcf9b8a8
code formatting updates
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 79b877d679
2024-02-22 16:02:25 -06:00
fba2e174fb
Fix clocks ( #246 )
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 852cc13f2a
2024-02-13 20:22:11 -06:00
0dcd6e35dd
Fix hbmBW calculation, ( #243 )
...
* Fix hbmBW calculation, currently we're reading the wrong value of the mclk out of rocm-smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* Fix for earlier smi
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: c60f031558
2024-02-13 20:19:56 -06:00
a5b1082836
Modify yaml configs to reflect new combined Top Stats
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b7d5d3b64b
2024-02-13 19:56:46 -06:00
96786667ad
Enable the revamped Top Stats section in standalone GUI
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: bd83f68412
2024-02-13 19:18:31 -06:00
85c4cec42e
Combine kernel and dispatch stats in the Top Stats section of analysis
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2526e14802
2024-02-13 19:17:41 -06:00
6bedf1ebf6
Fix logic for roofline field in sysinfo
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7bb211a465
2024-02-12 17:07:55 -06:00
8721490218
Revert sbios fix. Catch commas
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 33a2cd34ce
2024-02-08 12:52:07 -06:00
bce1fe532b
Escape sbios, can have commas on some systems ( #241 )
...
* escape sbios, can have commas on some systems
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
* Prefer to cast to str in original function
Signed-off-by: colramos-amd <colramos@amd.com >
---------
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: c8f4f74255
2024-02-08 12:40:52 -06:00
919cf88f8b
Add new l2 cache per channel headers to supported fields
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d7b78da250
2024-02-06 16:19:40 -06:00
1c85c5666e
Enable standalone GUI with new metric reordering
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 48911111be
2024-02-06 16:19:40 -06:00
149f7ca530
General spell check and typo fixing
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 66fcfd3def
2024-02-06 16:19:40 -06:00
bd22355b96
Add numPipes built-in-var for updated metrics
...
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d16f58b797
2024-02-06 16:19:40 -06:00
3b28104356
Fix SPGR merge warning and more descriptive CLI output
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b0cf695976
2024-02-06 16:12:14 -06:00
4a90ef122f
add an optional exit_on_error arg for the run utility and enable for a
...
subset of calls to rocm-smi
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: eece1f4688
2024-02-05 16:20:21 -06:00
875ab7257e
Fix reporting of --roof-only runs in sys_info
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 9b464503fe
2024-02-04 12:44:47 -06:00
c40ad2895e
Modify smi error detection to check for non-zero exit code
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 194e168414
2024-02-02 14:27:08 -06:00
c0e2d759dd
profile: fix parsing tcc per channel on mi300 ( #234 )
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f44ce21252
2024-01-31 09:34:50 -06:00
90fc9dced5
Remove old csv_converter module, add new kernel_name_shortener module
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: ad169fa1e8
2024-01-30 11:15:12 -06:00
d8608a07a2
Enable database mode
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e1867d34d3
2024-01-30 10:43:30 -06:00
edccad450c
Patch roofline debug logging
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: a1bfa83764
2024-01-29 10:22:37 -06:00
3f294b5dc0
Add missing input file to Mi300 flattening
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 911943acee
2024-01-26 10:32:13 -06:00
995429869a
Add missing rocm6 and ubuntu2204 elements to roofline binary
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: be606e6ccb
2024-01-25 12:55:32 -06:00
05b2113af4
update headers for 2024 calendar year
...
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: d7b6cf81e6
2024-01-24 17:50:31 -06:00
dcdd64b6bd
Patch specs enhancement for Mi300
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f49d7f7f0c
2024-01-24 16:30:04 -06:00
ee21c4d5ba
Responding to Karls review
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e5ac5ccf7d
2024-01-24 16:30:04 -06:00
f427785b26
Add license delimiter to new file
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: bd600bce49
2024-01-24 16:30:04 -06:00
0be51fc2fe
Catch ROCm-6.0.0 headers for replacement and standardization
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 88ef7b7550
2024-01-24 16:30:04 -06:00
e1f82cb8a5
Improved --list-metric pretty print
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7120f87963
2024-01-24 16:30:04 -06:00
bf27665e99
Fixing typo in KernelName header
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: c36578578b
2024-01-24 16:30:04 -06:00
0d72d942b4
Fix small typo
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 8ba3d8e45f
2024-01-24 16:30:04 -06:00
18e3b98535
Update headers based on latest rocprofv2 output. Overwrite old headers.
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: a171e776e4
2024-01-24 16:30:04 -06:00
249144eb7c
Add config files for Mi300_A1 and modify run_prof utility to use XCC modes
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 0432f77a7e
2024-01-24 16:30:04 -06:00
77ca223de8
Decode specs using utf-8 for backwards compatibility in rocprof
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d9a6832e30
2024-01-24 16:30:04 -06:00
7b9b4c90e6
Enable Standalone GUI. Note L2 per channel graphics haven't been ported to new format
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: df4f15ff47
2024-01-24 16:30:04 -06:00
6da5e58dd5
Enable specs correction, detection of cli_style property, and hbm stack num
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 92f429f8b2
2024-01-24 16:30:04 -06:00
924b421c3f
Add new submodule for mem chart
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e3f76599b3
2024-01-24 16:30:04 -06:00
c20a76f03d
Modify schema to reflect new l2 cache per channel
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 8fadbb070f
2024-01-24 16:30:04 -06:00
bdda466109
Implement specs correction function
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 8534cec3a6
2024-01-24 16:30:04 -06:00
035c6ec7a3
Fix bug in profiling for Mi100
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d4a649a926
2024-01-24 16:30:04 -06:00
3bc71d87e9
Optimizations to run_prof() utility
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: a1b5c252e2
2024-01-24 16:30:04 -06:00
84748197bf
Adding sbios, vbios, and partitioning info to specs. Also reorganizing fields.
...
Co-authored-by: fei.zheng <fei.zheng@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 987f612489
2024-01-24 16:30:04 -06:00
colramos-amd
JoseSantosAMD
Karl W Schulz
Nick Curtis