68387da116
Comply to formatting
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7046ea15bd
2024-06-03 13:47:45 -05:00
48c7833d07
Re-implementing HBM stack / XCD info for incoming product sku
...
Co-authored-by: Nicholas Curtis <nicholas.curtis@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 295b344646
2024-06-03 13:47:45 -05:00
782ea3099b
Wrap text displayed in 'Top Dispatch' table for neatness
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: c6cfa9cc26
2024-05-28 15:34:00 -05:00
8bd72673e8
Add fix for case where we pass a single 'nan' value to to_avg
...
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18
Manifests as e.g.:
```
ERROR [analysis] 'float' object has no attribute 'empty'
```
because of:
https://github.com/ROCm/omniperf/blob/f3a0360a5640e4539fac534f73876f51ddd268d0/src/utils/parser.py#L135
Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 047d7771f3
2024-05-28 15:34:00 -05:00
219914fa9e
Format CMake and Python
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 1f370c9fe7
2024-05-10 09:07:40 -06:00
e6b2b03f32
Add support for --quiet flag to roofline
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: dba868973b
2024-05-10 09:07:40 -06:00
5fd6022d9a
Update from https://github.com/ROCm/mibench/commit/b704bd3ec439f8cbece6713852fcafc855c5b07e
...
[ROCm/rocprofiler-compute commit: 519bcb9b3e
2024-05-10 09:07:40 -06:00
9a0d5f0663
Replace deprecated roofline warning with logging helper function
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7d34e80567
2024-04-25 18:43:20 +00:00
2653dc850b
additional mod needed to support roofline binaries potentially
...
executing from two different locations
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: b5011ff0ae
2024-04-22 09:00:18 -05:00
ab7db47eb6
update logic to detect roofline binaries in two alternate paths
...
depending on whether user is running within local clone or from form
install.
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 093a4511ee
2024-04-21 14:53:14 -05:00
c7d3c861be
update logic to detect VERSION file to accommodate rocm packaging;
...
check two locations to cover case where user is running within local
git clone directly or alternatively, from package install.
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 3c562588ff
2024-04-21 14:53:14 -05:00
a99b74810c
fix execution error when OMNIPERF_COLOR env is set; update coloring to
...
support four modes:
(0) - no coloring and no loglevel delimiters
(1) - colored loglevel delimiters
(2) - non-colored loglevel delimiters
(3) - fully colored messages for all levels besides INFO
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 65967658e9
2024-04-04 14:44:51 -05:00
55ebe7059c
Move dispatch id patch to proper util func in utils. Enable in rocprofv2 post-processing
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e0556f32ab
2024-04-01 14:30:21 -05:00
5d15f4d6fa
Restore OMNIPERF_COLOR global to disable default log coloring
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 6cc8f0154f
2024-04-01 14:30:21 -05:00
091e796643
Extending log coloring to message text. Enable by default.
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b1d0b3905c
2024-04-01 14:30:21 -05:00
e170da2c39
Throw more helpful warning on missing csv in analyze mode ( #313 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: f47b8d2547
2024-04-01 14:30:21 -05:00
e1470d7a38
Register TRACE loglevel ahead of parse_args to avoid error in --specs printout
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 706afa7f37
2024-04-01 14:30:21 -05:00
fa02efc962
Revert #333 deterministic ordering ( #337 )
...
* Revert "formatting"
This reverts commit e387561791898467371b6219921f10447d3486b3.
* Revert "Implement deterministic ordering of perfmon"
This reverts commit 2a24600a37c8002838145962a957cea447555b0c.
[ROCm/rocprofiler-compute commit: f7394bf272
2024-04-01 14:30:21 -05:00
ed86d5c64c
formatting
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: f6f6165379
2024-04-01 14:30:21 -05:00
e55b9b1d34
Adding redirect to help button in standalone GUI
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3928f36d5e
2024-04-01 14:30:21 -05:00
fad337db06
Removing unused modules
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 33e763178e
2024-04-01 14:30:21 -05:00
da0986846e
Implementing docs feedback with typos and minor enhancements
...
Co-authored-by: Jose Santos <josantos@amd.com >
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: cf36fb7fbf
2024-04-01 14:30:21 -05:00
c693890216
Fix for #300 ( #331 )
...
On some versions of numpy/pandas, applying a str map to an empty series doesn't change the type.
As a result, when adding a float to a string, sometimes numpy dies with a uadd error.
We fix this by explicitly casting to a str first
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
Co-authored-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: d72ef52208
2024-04-01 14:30:21 -05:00
8943f686f5
Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg'
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 62221383a7
2024-03-18 14:28:14 -05:00
fbb88baa20
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 4fc30eb5c4
2024-03-15 16:40:13 -05:00
19a9e0431c
apply formatter
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: f4070e3654
2024-03-15 14:04:49 -05:00
fa0cc81720
Update roofline distro_map for Ubuntu22.04 ( #319 )
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 2dcad38028
2024-03-15 12:47:30 -05:00
a8dcdec00f
tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the
...
loglevel name in output, but without color
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69de978d35
2024-03-15 09:31:22 -05:00
3a77ecadd3
bug fix for df tracing output - add more function demarcation
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: c29f28e25e
2024-03-15 09:31:22 -05:00
624606771f
enable more function demarcation for analyze tracing
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 76121f20a9
2024-03-15 09:31:22 -05:00
3dbe61f462
logger update: assign color for TRACE level
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 3438bc9d0f
2024-03-14 17:37:30 -05:00
8d6a8e3b06
update logging formatter handling for consistent behavior with error messsages
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 69af2ffc83
2024-03-14 17:37:30 -05:00
ff7751724b
Fix missing argv in console_warning()
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: e7cc326d5a
2024-03-12 16:44:02 -05:00
bd4bc51cd4
change stubbed values to hbm bw ( #302 )
...
* change stubbed values to hbm bw
Signed-off-by: Jose Santos <josantos@amd.com >
* Reformat
Signed-off-by: Jose Santos <josantos@amd.com >
* Update analysis_webui.py
remove print statements
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/omniperf_analyze/analysis_webui.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: efb8f131ec
2024-03-12 16:08:30 -05:00
513ba356ae
Kernel no overwrite ( #303 )
...
* Removing kernel name shortener from profile
- Kernel name shortener now in analyze
- db import uses pymongo to import
Signed-off-by: Jose Santos <josantos@amd.com >
* collections now added using pymongo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* kernel_name_shortener shortens dataframes and not a workload
- argparser: --kernel-verbose to connection group
- analysis_cli, profiler_rocprof_v2: remove kernel_name_shortener, so that it doesnt overwrite workload
- db_import: demangle kernel_name dfs
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix db name in pymongo command
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* reformat
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* fix typo
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* remove checker for verbose in profiler_base
Signed-off-by: Jose Santos <josantos@amd.com >
* kernel_name_shortener now called in create_df_kerenel_top_stats and
create_df_pmc
Signed-off-by: Jose Santos <josantos@amd.com >
* add kernel_verbose to analysis_webui, remove stubbed values
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
* Update src/utils/kernel_name_shortener.py
keep console_debug
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
* Update src/utils/kernel_name_shortener.py
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
---------
Signed-off-by: Jose Santos <josantos@amd.com >
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com >
Co-authored-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4424f320ad
2024-03-12 15:54:52 -05:00
4fb2f6e2b4
Update DB module for new sysinfo keys
...
Signed-off-by: colramos-amd <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 706d3bb9f0
2024-03-12 12:24:49 -05:00
28f027c7bf
move set_locale_encoding() to occur after logging is setup - allows
...
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083 )
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: e85037fdfb
2024-03-11 14:19:01 -05:00
6b0a36cb27
Update src/utils/utils.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 5e21dc35fd
2024-03-11 14:19:01 -05:00
d4015bd76b
Update src/utils/db_connector.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: ebc9108da0
2024-03-11 14:19:01 -05:00
ed8d923155
Update src/utils/db_connector.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 523639a7fd
2024-03-11 14:19:01 -05:00
f287aa0fc8
Update src/utils/utils.py
...
Co-authored-by: Cole Ramos <colramos@amd.com >
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com >
[ROCm/rocprofiler-compute commit: 8e45cc897f
2024-03-11 14:19:01 -05:00
35a983b85a
allow color formatter via env variable OMNIPERF_COLOR=1
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 34070394eb
2024-03-11 14:19:01 -05:00
9d7dde19b0
refactor setting of local encoding; remove from top-level omniperf
...
wrapper and push into base class via a companion utility function
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 27a57bdafb
2024-03-11 14:19:01 -05:00
2d84322ea1
update print_status() to use console logger; convert some info logs to debug logs
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 15c86ba424
2024-03-11 14:19:01 -05:00
fdbc5565f3
rework of logger.py setup to introduce another setup_file_handler() -
...
this function enables file-based logger output for use with profile
mode
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 505e263279
2024-03-11 14:19:01 -05:00
917b784ead
refactor logging initialization into two steps:
...
(1) setup_logging_handler -> called prior to arg parsing
(2) setup_logging_priority -> called after arg parsing
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: e24e6c35a5
2024-03-11 14:19:01 -05:00
975c2dad8b
add quietmode option to setup_logging function
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: abd3d20cb2
2024-03-11 14:19:01 -05:00
a9cda2ad33
add a exit keyword to console_error function; allows multiple error
...
lines prior to code exit
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 2b24375e8d
2024-03-11 14:19:01 -05:00
7756a5b00b
updates for run_prof() routine:
...
* add a profileMode keyword option, used to indent profiling output
* update logic if forked process is not successful, output is
displayed directly with INFO logging or lower; also dispaly output
in ERROR mode if the process fails
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 377c642ac2
2024-03-11 14:19:01 -05:00
ab3ce5ecb8
remove duplicate process output within run_prof()
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: dcdef37c34
2024-03-11 14:19:01 -05:00
coleramos425
Nicholas Curtis
coleramos425
Karl W Schulz
Nick Curtis
JoseSantosAMD
Karl W. Schulz