AI/rocm-systems
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
68,463 Commits 3 Branches 0 Tags
6540155c9d4f1c69db65adc0ef35fdff8a41b07b
Commit Graph
68463 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Gopesh Bhardwaj fabdab7aa4 [aqlprofile] Adding Strix Halo support (#1477) 
* Adding Strix Halo support

* copilot review feedback

* Addressing feedback
 2025-11-07 00:46:17 -06:00
Gopesh Bhardwaj 06bf110c84 Adding counters support for strix halo (#1358) 
* Adding counters support for strix halo

* Updated coutners list

* Added missing counter info

* Updated arch support
 2025-11-07 00:45:03 -06:00
Jason Bonnell 6e195ded9b Update rocprofiler_config_interfaces.cmake to use different elf naming (#1722) 
* Update rocprofiler_config_interfaces.cmake to use different elf naming

* try out conditional for libelf

* run cmake-format to fix formatting issue

* Remove libelf.patch file from therock-ci-windows.yml

* Remove libelf patch from therock-ci-linux.yml as well
 2025-11-06 23:50:02 -05:00
habajpai-amd 590c6c3b4f fix: null pointer after delete in get_stream_id (#1720) 2025-11-06 23:43:34 -05:00
David Galiffi 89cf46eb55 Removing jlumbroso/free-disk-space action from workflows (#1700) 2025-11-06 18:11:09 -05:00
Sourabh U Betigeri 90d5dc6b3a SWDEV-564408 - Reduces hip-tests runtime Pt 1 (#1695) 
* SWDEV-564408 - Reduces hip-tests runtime Pt 1

* Update cmd_options.hh
 2025-11-06 13:45:36 -08:00
Pratik BasyalandDavid Galiffi fdb557c88a [Systems-Profiler] Officially unsupported OS removed (#1740) 
* Fedora and CentOS removed

* David's feedback incorporated

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
 2025-11-06 16:06:28 -05:00
Kian Cossettini f4d0aeb8f3 Adjust host thread count for OpenMP-VV tests (#1742) 
Reducing test time
 2025-11-06 16:04:47 -05:00
MachineTom 3bb8c2ac50 SWDEV-564392 - Clean up image tests (#1694) 
Remove unnecessary checking.
Enable all disabled tests.
Move Mipmap test files into Windows section.
 2025-11-06 15:07:53 -05:00
Joseph Macaranas 524f62ae67 TheRock CI Workflow Updates 20251106 (#1743) 
- Update the pinned SHA for TheRock in CI workflows.
- Update the version for actions in those same workflows.
- Comment out the rm .patch line and provide details on its use.
 2025-11-06 12:06:44 -05:00
Poag, Charis d73726698b [SWDEV-562295] Fix Dmesg errors when using CLI (#822) 
* Changes:
  - Modified attempting to open files to check
    permissions -> check read access only.

Do not try to open all paths, may cause driver issues.
Read access is sufficient to check permissions.

Reason: GPUs which support partitioning (memory/compute),
logical devices will not be valid until configured.
See `sudo amd-smi set -h` or applicable APIs
to configure on supported hardware.

Example error dmesg output:
[965358.883112] amdgpu 0000:15:00.0: amdgpu: renderD153 partition 1 not valid!
[965358.883283] amdgpu 0000:15:00.0: amdgpu: renderD154 partition 2 not valid!
[965358.883438] amdgpu 0000:15:00.0: amdgpu: renderD155 partition 3 not valid!
[965358.883594] amdgpu 0000:15:00.0: amdgpu: renderD156 partition 4 not valid!
[965358.883749] amdgpu 0000:15:00.0: amdgpu: renderD157 partition 5 not valid!
[965358.883904] amdgpu 0000:15:00.0: amdgpu: renderD158 partition 6 not valid!
[965358.884060] amdgpu 0000:15:00.0: amdgpu: renderD159 partition 7 not valid!

---------

Signed-off-by: Charis Poag <Charis.Poag@amd.com>
 2025-11-06 10:24:14 -06:00
Poag, Charis ced0642b4b [SWDEV-562295] Fix Dmesg errors when using CLI (#822) 
* Changes:
  - Modified attempting to open files to check
    permissions -> check read access only.

Do not try to open all paths, may cause driver issues.
Read access is sufficient to check permissions.

Reason: GPUs which support partitioning (memory/compute),
logical devices will not be valid until configured.
See `sudo amd-smi set -h` or applicable APIs
to configure on supported hardware.

Example error dmesg output:
[965358.883112] amdgpu 0000:15:00.0: amdgpu: renderD153 partition 1 not valid!
[965358.883283] amdgpu 0000:15:00.0: amdgpu: renderD154 partition 2 not valid!
[965358.883438] amdgpu 0000:15:00.0: amdgpu: renderD155 partition 3 not valid!
[965358.883594] amdgpu 0000:15:00.0: amdgpu: renderD156 partition 4 not valid!
[965358.883749] amdgpu 0000:15:00.0: amdgpu: renderD157 partition 5 not valid!
[965358.883904] amdgpu 0000:15:00.0: amdgpu: renderD158 partition 6 not valid!
[965358.884060] amdgpu 0000:15:00.0: amdgpu: renderD159 partition 7 not valid!

---------

Signed-off-by: Charis Poag <Charis.Poag@amd.com>

[ROCm/amdsmi commit: d73726698b]
 2025-11-06 10:24:14 -06:00
jamessiddeley-amd 37bbb58a19 [rocprof-compute] fix unit regex 'ns' in analyze mode (#1689) 
* fix unit regex in analyze mode

* ruff format
 2025-11-06 11:13:10 -05:00
Galantsev, Dmitrii 8bdf951d32 Add numbers to .so because wheels dont allow symlinks (#820) 
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
 2025-11-06 03:57:31 -06:00
Galantsev, Dmitrii 181659ea1f Add numbers to .so because wheels dont allow symlinks (#820) 
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>

[ROCm/amdsmi commit: 8bdf951d32]
 2025-11-06 03:57:31 -06:00
marandje 0ad05ed515 SWDEV-556947 - Parse the HIP version from the Git tag (#1135) 2025-11-06 10:18:26 +01:00
Galantsev, Dmitrii aac09912ec Add downloaded gtest as fallback 
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
 2025-11-06 01:26:40 -06:00
Galantsev, Dmitrii 4e8d89306e Add downloaded gtest as fallback 
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: aac09912ec]
 2025-11-06 01:26:40 -06:00
Satyanvesh Dittakavi 478cee0f68 SWDEV-559525 - Add the HIP_POINTER_ATTRIBUTE_IS_LEGACY_HIP_IPC_CAPABLE attribute support (#1647) 
* SWDEV-559525 - Add the HIP_POINTER_ATTRIBUTE_IS_LEGACY_HIP_IPC_CAPABLE attribute implementation

* Update indentation in hip_memory.cpp
 2025-11-06 12:07:32 +05:30
systems-assistant[bot]andgithub-actions[bot] 27f85500f8 Update amdgpu-windows-interop with latest changes 20251105 (#1728) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2025-11-05 22:09:25 -05:00
habajpai-amdandDavid Galiffi ea31a0bf18 rocprofiler-sdk: fix per-record group_by_queue scoping (#1676) 
* rocprofiler-sdk: fix per-record group_by_queue scoping

* added under resolved issues to CHANGELOG.md

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
 2025-11-05 21:46:44 -05:00
Xie, AlexBin c877be2afe rocr: make sure the member variable is conctructed (#1387) 
Signed-off-by: Alex Xie <AlexBin.Xie@amd.com>
 2025-11-05 17:19:33 -05:00
alexxu-amd a330fb6b91 fix latest docs doesn't get synchronized issue (#1714) 2025-11-05 17:08:19 -05:00
Joseph Macaranas 865a8d4d59 Revert "Update amdgpu-windows-interop with latest changes (#1718)" (#1725) 
This reverts commit 321e497048.
 2025-11-05 15:38:23 -05:00
systems-assistant[bot]andgithub-actions[bot] 321e497048 Update amdgpu-windows-interop with latest changes (#1718) 
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
 2025-11-05 21:13:32 +01:00
lancesixandLaurent Morichetti 280cda3196 clr: SWDEV-547890 - Maintain an MQD for the emulated AQL queue (#1669) 
* clr: SWDEV-547890 - Maintain an MQD for the emulated AQL queue

To simplify the shader debugger implementation, maintain the relevant
parts of the emulated AQL queue's MQD (amd_queue_t): read_dispatch_id,
write_dispatch_id, compute_tmpring_size.

With this MQD, the shader debugger can handle the emulated AQL queue
the same way it does the real AQL queue, no specialization is required.

* clr: SWDEV-547890 - Conservatively update the MQD's read_dispatch_id

The read_dispatch_id cannot be smaller than the current aql_packet_id
- hsa_queue.size for the debugger to work correctly.

The read_dispatch_id really should be updated when the CmdBuf is marked
as complete. Left a FIXME to address it in a future commit.

---------

Co-authored-by: Laurent Morichetti <laurent.morichetti@amd.com>
 2025-11-05 17:39:33 +00:00
Rakesh Roy 8797bb0150 Revert "SWDEV-562996 - Build fix: Ubertrace callback calling convention mismatch on x86 (#1587)" (#1717) 
This reverts commit 8d31383dfe.

Reason for revert: It is breaking TheRock build on Windows
 2025-11-05 11:48:02 -05:00
Apurv Mishra eded1f3529 rocrtst: Add check for SVM support in Runtime (#1687) 
Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>
Approved-by: David Yat Sin <David.YatSin@amd.com>
 2025-11-05 11:36:38 -05:00
Galantsev, Dmitrii 982737a852 Fix missing iomanip and cstdio in tests 
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
 2025-11-05 10:14:19 -06:00
Galantsev, Dmitrii 87ace88e72 Fix missing iomanip and cstdio in tests 
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 982737a852]
 2025-11-05 10:14:19 -06:00
MachineTom 3b1c0c3464 SWDEV-558845 - Support image in rocr on Windows (#1582) 
Enable image build in Windows.
Remove some useless codes that fail building in Windows.
Some minor improvement.
Temporarily exclude mipmap test files.
Prevent negative tests affect some tests.
Move some catch info log codes into failed cases.
 2025-11-05 09:33:41 -05:00
systems-assistant[bot]andVladana Stojiljkovic 16334bc15d SWDEV-525244 - Additional graph validation test (#584) 
* SWDEV-525244 - Additional graph validation test

* SWDEV-525244 - Change capture mode to relaxed

* SWDEV-525244 - Additional comments

---------

Co-authored-by: Vladana Stojiljkovic <Vladana.Stojiljkovic@amd.com>
 2025-11-05 09:32:47 +01:00
vstojilj 18d4fc460b SWDEV-541362 - Fix error code mismatch in test (#1377) 2025-11-05 09:31:30 +01:00
vstojilj 7d078b9875 SWDEV-553920 - Fix Unit_hipStreamCreateWithPriority_ValidateWithEvents (#1622) 2025-11-05 09:31:01 +01:00
pcritchl-amdandRakesh Roy 8d31383dfe SWDEV-562996 - Build fix: Ubertrace callback calling convention mismatch on x86 (#1587) 
Co-authored-by: Rakesh Roy <137397847+rakesroy@users.noreply.github.com>
 2025-11-05 10:37:45 +05:30
Sourabh U Betigeri 78e9e47852 SWDEV-551244 - Fixes CUDA 13 compilation issues (#1237) 2025-11-04 16:56:49 -08:00
David Galiffi 1e501dd89a Free runner disk space (#1693) 
Motivation:
Basic runners are frequently running out of space

Technical Details:
Running autoclean after package installations.
Use the jlumbroso/free-disk-space action.
 2025-11-04 17:31:23 -05:00
Scott Todd fdbafd7757 Revert "SWDEV-554372 - Add 3 HIP_GET_PROC_ADDRESS_xxx flags (#1057)" (#1690) 
Reverts ROCm/rocm-systems#1057

Suspected of breaking the build, see https://github.com/ROCm/rocm-systems/pull/1057#issuecomment-3487715129

Logs: https://github.com/ROCm/rocm-systems/actions/runs/19062134668/job/54444052479#step:12:315
```
[rocprofiler-sdk] FAILED: source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o 
[rocprofiler-sdk] ccache /opt/rh/gcc-toolset-12/root/usr/bin/c++ -DAMD_INTERNAL_BUILD=1 -DGLOG_USE_GLOG_EXPORT -DROCPROFILER_DL=1 -DROCPROFILER_HAS_GHC_LIB_FILESYSTEM=1 -DROCPROFILER_SDK_USE_SYSTEM_RCCL=0 -DROCPROFILER_SDK_USE_SYSTEM_ROCDECODE=0 -DROCPROFILER_SDK_USE_SYSTEM_ROCJPEG=0 -DUSE_PROF_API=1 -DYAML_CPP_STATIC_DEFINE -D__HIP_PLATFORM_AMD__=1 -Drocprofiler_EXPORTS=1 -I/__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/source/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/yaml-cpp/include -I/__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/ptl/source -I/__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/external/ptl/source -isystem /__w/rocm-systems/rocm-systems/TheRock/build/core/clr/dist/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/core/ROCR-Runtime/dist/include -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/filesystem/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/profiler/rocprofiler-sdk/build/external/glog -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/glog/src -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/fmt/include -isystem /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/external/elfio -isystem /__w/rocm-systems/rocm-systems/TheRock/build/compiler/amd-comgr-stub/dist/include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/libdrm/build/stage/lib/rocm_sysdeps/lib/pkgconfig/../../include -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/libdrm/build/stage/lib/rocm_sysdeps/lib/pkgconfig/../../include/libdrm -isystem /__w/rocm-systems/rocm-systems/TheRock/build/third-party/sysdeps/linux/elfutils/build/dist/lib/rocm_sysdeps/include -O3 -DNDEBUG -std=c++17 -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -W -Wall -Wno-unknown-pragmas -faligned-new -rdynamic -fstack-protector-strong -Wstack-protector -MD -MT source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o -MF source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o.d -o source/lib/rocprofiler-sdk/CMakeFiles/rocprofiler-sdk-object-library.dir/hip/abi.cpp.o -c /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/abi.cpp
[rocprofiler-sdk] In file included from /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/rocprofiler-sdk/hip/abi.cpp:26:
[rocprofiler-sdk] /__w/rocm-systems/rocm-systems/projects/rocprofiler-sdk/source/lib/common/abi.hpp:62:27: error: static assertion failed: size of the API table struct has changed. Update the STEP_VERSION number (or in rare cases, the MAJOR_VERSION number)
[rocprofiler-sdk]    62 |             sizeof(TABLE) == ::rocprofiler::common::abi::compute_table_offset(NUM),                \
```
 2025-11-04 14:29:58 -08:00
marandje 811609c0e1 SWDEV-523137 - Fix and enable a few negative tests on NV (#1157) 2025-11-04 23:28:11 +01:00
David Galiffi 4b0fb2cdf5 Rename "corr_id" to "stack_id" in Perfetto annotations to match new n… (#1618) 
* Rename "corr_id" to "stack_id" in Perfetto annotations to match new naming in schema.

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

* correlation_id.ancestor was not added until ROCPROFILER_VERSION 1.0

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
 2025-11-04 14:20:11 -05:00
Joseph Macaranas b19cf0aadf Revert "Disable therock summary check, make it always positive (#1675)" (#1686) 
This reverts commit 0c32b90130.
 2025-11-04 14:17:37 -05:00
Pratik Basyal 6356c179ff [ROCm Systems Profiler] 7.1.0 Formatting updated for understanding rocpd output docs" (#1663) 
* Formatting udpated for ROCm Systems rocpd docs"

* Minor change

* Formatting in profiler script fixed"

* Sphinx warnings and formatting fixes

* Formatting fixed

* Formatting fixed

* Collapsible code block added

* Dixygne change reverted
 2025-11-04 12:48:02 -05:00
Pratik Basyal 9d84958527 JSON profiler option removed (#1649) 2025-11-04 17:49:22 +01:00
Sam Ruscica 757de39caa Updated amdFileRead/Write in rocdevice to support windows build (#1435) 
* Updated amdFileRead in rocdevice to support windows build

* Updated amdFileRead in rocdevice to support windows build
 2025-11-04 10:03:03 -05:00
Danylo Lytovchenko 0c32b90130 Disable therock summary check, make it always positive (#1675) 2025-11-04 12:58:53 +01:00
marantic-amd f4a65875d5 Added SQLite3 as a external submodule to rocprofiler-systems (#1348) 2025-11-04 11:33:25 +01:00
Todd tiantuo Li 7573fa168d SWDEV-554372 - Add 3 HIP_GET_PROC_ADDRESS_xxx flags (#1057) 2025-11-04 00:16:12 -08:00
MachineTomgeomin12Scott Todd
 		fb006546d0 SWDEV-1 - Fix a typo (#1615) 
* SWDEV-1 - Fix a typo

Fix a typo.
Remove unnecessary log.

* Removing patch

---------

Co-authored-by: geomin12 <geomin12@amd.com>
Co-authored-by: Scott Todd <scott.todd0@gmail.com>
 2025-11-03 12:59:00 -08:00
marandje d411d101fb SWDEV-557363 - Fix and enable Unit_hipWallClock64_Positive_Basic (#1223) 2025-11-03 21:08:33 +01:00
marandje 1ccc0ce2e4 SWDEV-555299 - Fix and enable Unit_Device_modf_modff_Negative_RTC (#1012) 2025-11-03 21:08:09 +01:00