Commit Graph

68463 Commits

Author SHA1 Message Date
Poag, Charis 88473b7fd0 [SWDEV-533305] Remove partition info from amd-smi static (-p/--partition still available) + CLI API call cleanup (#529)
Updates:
- Separate extra APIs calls from amd-smi CLI to target specific CLI commands that need them.
- Remove extra current_compute_partition SYSFS calls from amd-smi static.
- Remove the partition information from the default `amd-smi static` CLI command.
- Users must now use the `-p` argument to view partition information with `amd-smi static`.
- The help text for the `partition` argument has been updated to reflect this change.
- The partition information can still be accessed using the `amd-smi partition -c -m` or `sudo amd-smi partition -a` commands.

---------

Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-07-07 11:21:46 -05:00
Poag, Charis 92f926b43b [SWDEV-533305] Remove partition info from amd-smi static (-p/--partition still available) + CLI API call cleanup (#529)
Updates:
- Separate extra APIs calls from amd-smi CLI to target specific CLI commands that need them.
- Remove extra current_compute_partition SYSFS calls from amd-smi static.
- Remove the partition information from the default `amd-smi static` CLI command.
- Users must now use the `-p` argument to view partition information with `amd-smi static`.
- The help text for the `partition` argument has been updated to reflect this change.
- The partition information can still be accessed using the `amd-smi partition -c -m` or `sudo amd-smi partition -a` commands.

---------

Signed-off-by: Charis Poag <Charis.Poag@amd.com>

[ROCm/amdsmi commit: 88473b7fd0]
2025-07-07 11:21:46 -05:00
Park, Peter 8039ab9449 Fix links in docs (#532)
* fix links in amdsmi_cli/README.md
* fix xrefs to install docs
* rm rocm-smi examples and add cli tutorial
* rm disclaimer and add amd smi contributing guidelines to index

Signed-off-by: Peter Park <Peter.Park@amd.com>
2025-07-07 11:18:40 -05:00
Park, Peter aecda316c4 Fix links in docs (#532)
* fix links in amdsmi_cli/README.md
* fix xrefs to install docs
* rm rocm-smi examples and add cli tutorial
* rm disclaimer and add amd smi contributing guidelines to index

Signed-off-by: Peter Park <Peter.Park@amd.com>

[ROCm/amdsmi commit: 8039ab9449]
2025-07-07 11:18:40 -05:00
Narlo, Joseph 2cf6272b53 [SWDEV-541675] Remove Unnecessary API from amdsmi.h (#530)
Signed-off-by: josnarlo <Joseph.Narlo@amd.com>
2025-07-07 11:14:27 -05:00
Narlo, Joseph 540ecd41bd [SWDEV-541675] Remove Unnecessary API from amdsmi.h (#530)
Signed-off-by: josnarlo <Joseph.Narlo@amd.com>

[ROCm/amdsmi commit: 2cf6272b53]
2025-07-07 11:14:27 -05:00
Saeed, Oosman 5b95d227bc [SWDEV-538308] CPER CLI 20 limit bug (#499)
The bug was reproduced like this.

In terminal #1, run command:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

In terminal #2, inject errors:
while true; do sudo amdgpuras -b 7 -s 1 -m 6 -t 2; sleep 2; done

The terminal #1 starts dumping cper entry information that it captures. After 20 entries have been captured, open terminal #3 and run same command as terminal #1:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

From terminal #3, there will be no output, even when terminal #1 continues capturing and printing information.

The fix:

Since we already have more than 20 CPER entries available in the GPU buffer, when we run the command from terminal #3 to start capturing from the beginning and pass 20 buffers to copy entries to, the C++ API returns a code saying there is more data available.

The Python CLI should not treat this as an error, but should continue to print what the API returned.

---------

Signed-off-by: Oosman Saeed <oossaeed@amd.com>
2025-07-07 11:11:13 -05:00
Saeed, Oosman 1c60502d5f [SWDEV-538308] CPER CLI 20 limit bug (#499)
The bug was reproduced like this.

In terminal #1, run command:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

In terminal #2, inject errors:
while true; do sudo amdgpuras -b 7 -s 1 -m 6 -t 2; sleep 2; done

The terminal #1 starts dumping cper entry information that it captures. After 20 entries have been captured, open terminal #3 and run same command as terminal #1:
sudo amd-smi ras --cper --gpu 6 --severity all --folder /tmp/cper_dump --follow 

From terminal #3, there will be no output, even when terminal #1 continues capturing and printing information.

The fix:

Since we already have more than 20 CPER entries available in the GPU buffer, when we run the command from terminal #3 to start capturing from the beginning and pass 20 buffers to copy entries to, the C++ API returns a code saying there is more data available.

The Python CLI should not treat this as an error, but should continue to print what the API returned.

---------

Signed-off-by: Oosman Saeed <oossaeed@amd.com>

[ROCm/amdsmi commit: 5b95d227bc]
2025-07-07 11:11:13 -05:00
Bhardwaj, Gopesh 99a7fe5ff0 Ignoring aligned attribute warning (#70)
ignoring aligned attribute warning

[ROCm/roctracer commit: dd745ed9c7]
2025-07-07 09:34:39 -05:00
Bhardwaj, Gopesh dd745ed9c7 Ignoring aligned attribute warning (#70)
ignoring aligned attribute warning
2025-07-07 09:34:39 -05:00
Swargam, Rambabu eb2710785e SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure (#247)
* SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure

* SWDEV-532647 - Restricted to Linux, removed comment for mismatch error code

* SWDEV-532647 - Disabled tests for AMD due to hang issue

* SWDEV-532647 - Fixed clang format issues

[ROCm/hip-tests commit: 9741b347e5]
2025-07-07 17:49:00 +05:30
Swargam, Rambabu 9741b347e5 SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure (#247)
* SWDEV-532647 - [catch2][dtest] Test cases for hipGetLastError on Kernel Failure

* SWDEV-532647 - Restricted to Linux, removed comment for mismatch error code

* SWDEV-532647 - Disabled tests for AMD due to hang issue

* SWDEV-532647 - Fixed clang format issues
2025-07-07 17:49:00 +05:30
Venkatesh, Anavena 882d176c50 SWDEV-526521 : Inter GPU copy performance improvements (#240)
* SWDEV-532641 Inter GPU copy performance improvements

* SWDEV-532641 changed source data pointer type to vector type

[ROCm/hip-tests commit: feaa82ac46]
2025-07-07 17:45:20 +05:30
Venkatesh, Anavena feaa82ac46 SWDEV-526521 : Inter GPU copy performance improvements (#240)
* SWDEV-532641 Inter GPU copy performance improvements

* SWDEV-532641 changed source data pointer type to vector type
2025-07-07 17:45:20 +05:30
Swargam, Rambabu d9642dbbc2 SWDEV-532114 - [catch2][dtest] Test cases for hipMemGetHandleForAddessRange (#221)
[ROCm/hip-tests commit: c217bb601c]
2025-07-07 17:43:22 +05:30
Swargam, Rambabu c217bb601c SWDEV-532114 - [catch2][dtest] Test cases for hipMemGetHandleForAddessRange (#221) 2025-07-07 17:43:22 +05:30
Swargam, Rambabu b35d4e70ad SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's (#157)
* SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's

* Modified Cmake file

[ROCm/hip-tests commit: ea366c7aa5]
2025-07-07 17:42:45 +05:30
Swargam, Rambabu ea366c7aa5 SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's (#157)
* SWDEV-491288 - [catch2][dtest] Stream Capture tests for Occupancy API's

* Modified Cmake file
2025-07-07 17:42:45 +05:30
Apurv Mishra 3115384874 kfdtest: Temporarily blacklist KFDEvictTest suite
blacklist the KFDEvictTest suite until the defects
SWDEV 535386 and 537002, where these test cases fail
inconsistently, are fixed

Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>
2025-07-04 11:47:20 -04:00
Apurv Mishra 6c89d61cef kfdtest: Temporarily blacklist KFDEvictTest suite
blacklist the KFDEvictTest suite until the defects
SWDEV 535386 and 537002, where these test cases fail
inconsistently, are fixed

Signed-off-by: Apurv Mishra <Apurv.Mishra@amd.com>


[ROCm/ROCR-Runtime commit: 3115384874]
2025-07-04 11:47:20 -04:00
Roy, Rakesh 05b674651c Fix find_if build error for RHEL10 (#499)
overriding Jonathan's final approval ( as it is a long weekend in US/NA)
adding algorithm header to recognize stdlib's find_if looks fine

[ROCm/rocprofiler-sdk commit: 30e239d1b7]
2025-07-04 09:20:23 -04:00
Roy, Rakesh 30e239d1b7 Fix find_if build error for RHEL10 (#499)
overriding Jonathan's final approval ( as it is a long weekend in US/NA)
adding algorithm header to recognize stdlib's find_if looks fine
2025-07-04 09:20:23 -04:00
Manocha, Rahul 85d0210da4 SWDEV-536749 - Skip building hipSquareGenericTargetOnly for static libs (#291)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>

[ROCm/hip-tests commit: 0bf7c809d6]
2025-07-04 15:08:05 +05:30
Manocha, Rahul 0bf7c809d6 SWDEV-536749 - Skip building hipSquareGenericTargetOnly for static libs (#291)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-07-04 15:08:05 +05:30
Cheruvally, Aravindan f559075a81 [SWDEV-530465] Update share/doc/<pkgnm> License Folder (#516)
Update share/doc/ folder for license/docs to reflect correct package name.
Signed-off-by: Cheruvally, Aravindan <Aravindan.Cheruvally@amd.com>
2025-07-03 02:07:54 -05:00
Cheruvally, Aravindan d25c73783e [SWDEV-530465] Update share/doc/<pkgnm> License Folder (#516)
Update share/doc/ folder for license/docs to reflect correct package name.
Signed-off-by: Cheruvally, Aravindan <Aravindan.Cheruvally@amd.com>

[ROCm/amdsmi commit: f559075a81]
2025-07-03 02:07:54 -05:00
Castillo, Juan 8133e89e82 [SWDEV-539845] Add support for board voltage (#92)
* Add the API and CLI to show the board voltage.

---------

Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Signed-off-by: Juan Castillo <juan.castillo@amd.com>
Co-authored-by: Liu, Shuzhou (Bill) <Shuzhou.Liu@amd.com>

[ROCm/rocm_smi_lib commit: bab82d98b7]
2025-07-03 01:58:50 -05:00
Castillo, Juan bab82d98b7 [SWDEV-539845] Add support for board voltage (#92)
* Add the API and CLI to show the board voltage.

---------

Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
Signed-off-by: Juan Castillo <juan.castillo@amd.com>
Co-authored-by: Liu, Shuzhou (Bill) <Shuzhou.Liu@amd.com>
2025-07-03 01:58:50 -05:00
Cheruvally, Aravindan d1c281a87e SWDEV-530465 Update share/doc/<pkgnm> License folder (#86)
Update share/doc/ folder for license/docs to reflect correct package name.
Signed-off-by: Cheruvally, Aravindan <Aravindan.Cheruvally@amd.com>

[ROCm/rocm_smi_lib commit: 55ab9b2bda]
2025-07-03 01:56:50 -05:00
Cheruvally, Aravindan 55ab9b2bda SWDEV-530465 Update share/doc/<pkgnm> License folder (#86)
Update share/doc/ folder for license/docs to reflect correct package name.
Signed-off-by: Cheruvally, Aravindan <Aravindan.Cheruvally@amd.com>
2025-07-03 01:56:50 -05:00
gabrpham_amdeng a2885d6e70 [SWDEV-539451] Adjusted reset command to prevent reset on partitions
Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com>
2025-07-03 01:11:46 -05:00
gabrpham_amdeng e9f7fe2842 [SWDEV-539451] Adjusted reset command to prevent reset on partitions
Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com>


[ROCm/amdsmi commit: a2885d6e70]
2025-07-03 01:11:46 -05:00
cfallows-amd 30466f6bfa Adjust csv output list for test_block_SPI for MI350 (#785)
Adjusting expected output list for test_block_SPI for MI350 series products.
Run formatter.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 61a9381edf]
2025-07-03 01:58:11 -04:00
cfallows-amd 61a9381edf Adjust csv output list for test_block_SPI for MI350 (#785)
Adjusting expected output list for test_block_SPI for MI350 series products.
Run formatter.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-03 01:58:11 -04:00
Xie, Pengda 8e5921174f SWDEV-540576 - Abort if user request a core dump (#653)
* SWDEV-539414 - Return error status from runtime handler when HIP_SKIP_ABORT_ON_GPU_ERROR is false

* SWDEV-539414 - default handler when GPU core file is generated

* SWDEV-540576 - Abort if user request a core dump

Change-Id: I9e2c640acf559880bd13641de9103e660ef822a3

---------

Co-authored-by: Assiouras, Ioannis <Ioannis.Assiouras@amd.com>
Co-authored-by: agunashe <ajay.gunashekar@amd.com>

[ROCm/clr commit: 9c1bff0ae7]
2025-07-03 00:29:14 +05:30
Xie, Pengda 9c1bff0ae7 SWDEV-540576 - Abort if user request a core dump (#653)
* SWDEV-539414 - Return error status from runtime handler when HIP_SKIP_ABORT_ON_GPU_ERROR is false

* SWDEV-539414 - default handler when GPU core file is generated

* SWDEV-540576 - Abort if user request a core dump

Change-Id: I9e2c640acf559880bd13641de9103e660ef822a3

---------

Co-authored-by: Assiouras, Ioannis <Ioannis.Assiouras@amd.com>
Co-authored-by: agunashe <ajay.gunashekar@amd.com>
2025-07-03 00:29:14 +05:30
jamessiddeley-amd 94ea0fbf2f additional-code-coverage-compute (#763)
* added additional functions to test_utils.py

* added code coverage for db_connector.py

* Update test_profile_general.py

Added additional roofline test cases

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* updated coverage mi_gpu_spec.py 73% -> 94%

* added parser.py coverage

* removed redundant comments

* added test_utils and test_db_connector

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

[ROCm/rocprofiler-compute commit: a6463f5e98]
2025-07-02 13:29:10 -04:00
jamessiddeley-amd a6463f5e98 additional-code-coverage-compute (#763)
* added additional functions to test_utils.py

* added code coverage for db_connector.py

* Update test_profile_general.py

Added additional roofline test cases

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>

* updated coverage mi_gpu_spec.py 73% -> 94%

* added parser.py coverage

* removed redundant comments

* added test_utils and test_db_connector

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
2025-07-02 13:29:10 -04:00
Galantsev, Dmitrii d312e309c4 Exposed the energy count and current socket power metrics to profilers like PAPI (#225)
[ROCm/rocm_smi_lib commit: 6c32364d19]
2025-07-02 09:50:09 -05:00
Galantsev, Dmitrii 6c32364d19 Exposed the energy count and current socket power metrics to profilers like PAPI (#225) 2025-07-02 09:50:09 -05:00
Adam McDaniel b3caa4972c Exposed the energy count and current socket power metrics to profilers like PAPI
[ROCm/rocm_smi_lib commit: f688c9938d]
2025-07-02 09:47:17 -05:00
Adam McDaniel f688c9938d Exposed the energy count and current socket power metrics to profilers like PAPI 2025-07-02 09:47:17 -05:00
Galantsev, Dmitrii ff02dc85da Revert "rsmi_init: Do not complain loudly when no driver is found"
This reverts commit 42dc44f54d.


[ROCm/rocm_smi_lib commit: 731be3f743]
2025-07-02 09:45:41 -05:00
Galantsev, Dmitrii 731be3f743 Revert "rsmi_init: Do not complain loudly when no driver is found"
This reverts commit 8ca4207d5c.
2025-07-02 09:45:41 -05:00
cfallows-amd e085f3cc54 Fix method return for python version compatibility (#784)
Support for python3.8 and above means union defined in one of the methods was throwing errors for anything less than python3.10. Swapping out | operand for Optional[] resolves errors on systems using <3.10. No functional changes.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: a59b1ea6e6]
2025-07-02 10:36:37 -04:00
cfallows-amd a59b1ea6e6 Fix method return for python version compatibility (#784)
Support for python3.8 and above means union defined in one of the methods was throwing errors for anything less than python3.10. Swapping out | operand for Optional[] resolves errors on systems using <3.10. No functional changes.

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-07-02 10:36:37 -04:00
vedithal-amd 740fe492c2 Fix rocprofiler sdk list counters (#765)
[ROCm/rocprofiler-compute commit: 894046f283]
2025-07-02 09:41:51 -04:00
vedithal-amd 894046f283 Fix rocprofiler sdk list counters (#765) 2025-07-02 09:41:51 -04:00
Chris Freehill 12430fe25a rocr: Fix isa entries for gfx906/sramecc
Some of the entries for gfx906 in the ISA table in isa.cpp
had "any" for "sramecc-" instead of "disabled". This fixes
that.
2025-07-02 08:40:30 -05:00
Chris Freehill ad3985af1c rocr: Fix isa entries for gfx906/sramecc
Some of the entries for gfx906 in the ISA table in isa.cpp
had "any" for "sramecc-" instead of "disabled". This fixes
that.


[ROCm/ROCR-Runtime commit: 12430fe25a]
2025-07-02 08:40:30 -05:00