Commit Graph

1882 Commits

Author SHA1 Message Date
Saleel Kudchadker 40f41f4d0b SWDEV-422207 - Track commands for capture
- Track all captured commands under a new AccumulateCommand
- Add begin() and end() methods to capture commands
- Explicit TS object now passed to certain methods because
profilingBegin() and profilingEnd() now happen separately and thus can
run into threading issues

Change-Id: I171106bdcad72b057836cb2f3fc398db3533119f
2023-11-03 05:09:04 +00:00
Satyanvesh Dittakavi 6d6465cb96 SWDEV-430048 - hipMemcpy2D should return success for zero sized arrays
- This matches the CUDA behavior
- The pitch and width checks removed are already covered in ihipmemcpy2D

Change-Id: I03a6921a78b5d89723830d8dde5865fdc6db0379
2023-11-02 00:40:08 -04:00
sdashmiz 9b567e1799 SWDEV-417075 - add hipDrvAddMemCpyNode
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie631d7b1788f10171a29d463759a3cba3b2b2007

SWDEV-417075 - add hipDrvGraphAddMemcpyNode

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6bab3310919643e119cd0004276907e223641cfb
2023-10-31 09:55:42 -04:00
taosang2 9a24e1fb30 SWDEV-364236 - Fix device buffer to/from image issue
Fix offset of device buffer copied to/from image.

Change-Id: I149a8629769cd0d5848ffefb04f1752668a685b9
2023-10-30 12:17:14 -04:00
Anusha GodavarthySurya 5fb7536586 SWDEV-422207 - Remove L2 flush when kernelArgs are in device memory
Change-Id: I7b5625cb6d55e83689bff7bbb45be9c517ec4a8d
2023-10-26 19:14:58 +00:00
Anusha GodavarthySurya 38d2c56784 SWDEV-422207 - Handle nonkernel nodes for graph opt
- Support graph with different types of nodes with single
branch when DEBUG_CLR_GRAPH_PACKET_CAPTURE flag is enabled

Change-Id: I149a8629769cd0d5849ffefb04f1352668a685b6
2023-10-24 18:36:06 +00:00
Saleel Kudchadker 5662d4037c SWDEV-408180 - Address possible cornercases
- Address corner cases that can arise with the new
hipMemcpyDeviceToDeviceNoCU enum
- Better log

Change-Id: I6035b901f8d616741054b7a5ff4f67956329ac57
2023-10-23 16:54:08 -04:00
kjayapra-amd e226ae109b SWDEV-413997 - Fixing multiple access desc cases for hipMemSetAccess.
Change-Id: Iec7d1207ec0a7136e4e74ef2e390f3347e753d40
2023-10-23 09:44:04 -04:00
Jaydeep Patel ee00ebc42f SWDEV-425568 - Do cpu wait for device sync.
Change-Id: Ia05e09bd10ab623b36c74037e9988e132120dd9f
2023-10-21 01:16:06 -04:00
Saleel Kudchadker f316a30e5d SWDEV-408180 - Add a new hipMemcpyKind
Add hipMemcpyDeviceToDeviceNoCU to force a non blit copy path. This
helps in cases where an app may determine that CU may be busy and copies
with SDMA may be quicker.

Change-Id: I59b415dd8f6022c244e8d75f265464d5c635df1e
2023-10-20 13:18:10 -04:00
taosang2 5a0085e516 SWDEV-364236 - Fix layered Image issue
Fix wrong logic to get layer index;
Make layered image's layout match cuda spec;
Fix wrong comparision of element size.
Remove amd::BufferRect from ihipMemcpyAtoHCommand()
and ihipMemcpyHtoACommand().
Change-Id: Icc6a4233fbce2e9b2dc6feb79e6bfbd761684c7d
2023-10-19 16:06:20 -04:00
German 694fe4bedb SWDEV-427689 - Report LUID in Windows
Pass LUID infromation from PAL to HIP device properties.
NodeMask is calculated based on the order of devices in PAL

Change-Id: Ic53707b68b16f392e5284a0105bf1f3941b46653
2023-10-18 15:07:39 -04:00
Jatin Chaudhary 56f3b2563c SWDEV-306642 - Move the deprecated function/struct to hip_device_deprecated.cpp
Change-Id: Id1f8db09271c537a200bc090ba1feaacfb023b88
2023-10-16 21:42:18 +01:00
Satyanvesh Dittakavi 353dbe6e3b SWDEV-419480 - HIPRTC implementation of standard headers shouldn't be in std namespace
HIPRTC implementation of few type traits are defined in std
namespace which causes conflicts with the std C++ headers when
apps try to include those std headers. Instead, use the
specific implementation of these headers from __hip_internal
namespace to avoid this.

Change-Id: Ia358df159af8783d1eba9a19cd458e192bf7e9e6
2023-10-16 13:10:55 -04:00
kjayapra-amd 3ef829939a SWDEV-413997 - Initial VMM changes for ROCm path.
Change-Id: I4405fd7b53182eb4c4622835c811c0dc08461537
2023-10-16 11:29:16 -04:00
sdashmiz 2d83abaca6 SWDEV-389530 - [ABI Break]Match error with cuda
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id9de54b4fd1be7b6b887a4ebfcc6a3d9a70c7bc9
2023-10-16 07:31:34 -04:00
sdashmiz d78aef7f66 SWDEV-371332 - [ABI Break] Return success for unregistered ptr
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie58d16420578e7118997eb40a9fd6a6641b666f3
2023-10-15 14:32:24 -04:00
Jaydeep Patel 7150b2eaad SWDEV-425490 - Move ptrdiff_t & clock_t to hiprtc.cmake.
Change-Id: I7c8ce3c1b8cb11e0253b0f51ae10fca7f0a32017
2023-10-13 00:58:56 -04:00
sdashmiz c089ef4a2b SWDEV-332969 - [ABI Break]Substitute hipArray* with hipArray_t
- hipArray will be an internal struct from rocm6.0

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Icf97fe96b87be8532098cd7f9ceaad099f99c9b9
2023-10-12 12:09:19 -04:00
Jatin Chaudhary 2989840511 SWDEV-306642 - [ABI Break] Add texture/surface/device capabilities device struct entries
- alias hipGetDeviceProperties to hipGetDevicePropertiesR0600
- alias hipDeviceProp_t to hipDeviceProp_tR0600
- remove gcnArch from new device property struct
- add new requested struct members

Change-Id: If3f5dbef3d608487d9f6f419285f4bf577ea9bf0
2023-10-12 11:16:18 -04:00
jiabaxie 813907c29d SWDEV-418999 - python script to support profiler with hip versioning
Change-Id: I8f5ad81162581bf3792c2606ba8c6c3a8e0b4bf2
2023-10-11 13:46:45 -04:00
Rakesh Roy 52001adf43 SWDEV-421667 - Print shared library name which doesn't contain CO for current device
- ML Frameworks link many ROCm component libraries
- It becomes a tedious task to figure out which library HIP is complaining about
- To improve debuggability print out the shared library name

Change-Id: I53c4d66393670356b8cafd3e48075e430f0a45ce
2023-10-11 10:43:03 -04:00
Anusha GodavarthySurya c7e4e9c2f4 SWDEV-408701 - Avoid adding duplicates when no node is captured in cross stream
Change-Id: Iccbddaf9db73238aa938f8b3e8ec410f4a86d524
2023-10-09 13:15:47 -04:00
Sourabh Betigeri 01aa3557f4 SWDEV-369792 - Fix to use the roclr context already created when creating hip::Device rather than creating a new context in hip
Change-Id: I6dbccb1a17dee0e9a72ec52cb1a5bb096315fa0f
2023-10-07 14:32:32 -04:00
taosang2 6398f604b0 SWDEV-299127 - Support External Mipmap
Support hipExternalMemoryGetMappedMipmappedArray().
Add ImageExternalBuffer to differiate ImageBuffer.
Currently we only support tiling_optimal mode as
vulkan driver doesn't provide tiling information.

Change-Id: I7e3524cdde53e4df9f728894bcebf4bd3f58d4d9
2023-10-05 09:58:17 -04:00
Anusha GodavarthySurya e63c280d4d SWDEV-422207 - Capture AQL Packets for graph Kernel nodes during graph Inst. And enqueue AQL packet during launch
Change-Id: I1e5f7f9e2a70bd500d190193cb6ba0867f5a63e7
2023-10-05 00:34:29 -04:00
Ioannis Assiouras bf31109241 SWDEV-425129 - Revert "SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute"
This reverts commit c469f18e91.

Change-Id: I02d6e77f0874fc37f22de267435917edd4fdede3
2023-10-03 11:32:19 +01:00
Ioannis Assiouras c469f18e91 SWDEV-420822 - [ABI Break] Merge hipFunction_attribute into hipFuncAttribute
Change-Id: I9b9f7979e9b8dd422d9064c17c79a25bf7248d30
2023-10-01 06:52:12 -04:00
Ioannis Assiouras 31201b6e25 Revert "SWDEV-414194 - Make hip-lang available on nvidia platform"
This reverts commit 97403db468.

After changes in upstream cmake hip-lang-config.cmake will not be required on nvidia platform.

Change-Id: I711601dac1064ea17f58437da8ffbc50678eda08
2023-09-29 06:07:53 -04:00
kjayapra-amd c3a39ef32a SWDEV-424569 - Fixing a merge error, which removed amd::Program->release().
Change-Id: Ib43dfc528ce217cb23d5eb38a0f87c241ae274a6
2023-09-28 11:41:04 -04:00
Ajay 3337f6912d SWDEV-1 - fix build errors for file descriptor
Change-Id: I38b3962744f20ce758c32077f2c725013c666a35
2023-09-27 20:00:05 -04:00
Satyanvesh Dittakavi f5a9a36cf3 SWDEV-421415 - Pass the right hip major, minor versions to hiprtc builtins
Change-Id: I2ff5787039891d1d3390c996d37bf342e0a88705
2023-09-26 00:52:54 -04:00
Satyanvesh Dittakavi 2764b85ca5 SWDEV-402080 - Add options such as -Rpass=inline to exe_options in RTC if the user passes it
Change-Id: I12fcf200ed9d3112b014f3d426d5fe504eeca163
2023-09-25 04:03:44 -04:00
pghafari 9008a53c98 SWDEV-414833 - adding hipDeviceAttributeIsLargeBar
to hipDeviceGetAttribute

Change-Id: Icde0ab9326b1759c66f9a3acbadfb9a01cf6a5be
2023-09-25 00:31:30 -04:00
German Andryeyev fbea58ba11 SWDEV-423317 - Enable GPU wait for hip sync calls
hipStreamSynchronize and hipDeviceSynchronize won't longer wait
for CPU commands in DD mode

Change-Id: I079c8bbfc34ddc6d3e2d74c92a34665877e512a5
2023-09-22 13:04:27 -04:00
pghafari 96f41fad07 SWDEV-369567 - [ABI Break] updating gridY and Z max dimension check
Change-Id: If515fda4938d3c5f455a02b4a65adaad76dc0aed
2023-09-22 04:52:27 -04:00
sdashmiz 8705322f10 SWDEV-330665 - [ABI Break] check for attribute
- Add support for DevAttrHostRegisterSupported

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ica8d323eda97b65ef0088aa99c84dd36cfe4edf3
2023-09-22 04:51:24 -04:00
Ioannis Assiouras fe2d747bcc SWDEV-401489 - [ABI Break] Removed hipModuleLaunchKernelExt
Change-Id: I0b31d9db755f8a89ead203dbd238a93c18b76855
2023-09-21 23:50:16 -04:00
kjayapra-amd 369fdc4d87 SWDEV-422580 - Adding pcie.function to the PCI address string in hipGetDevicePCIBusId.
Change-Id: Iaa73b6028ac7b1d05cc310405d6fe622d764320f
2023-09-21 12:22:05 -04:00
Sourabh Betigeri 3f88fe850b SWDEV-326798 - [ABI Break] Fixes null stream sync behavior
Change-Id: I84ad21f61779145c198dc68bf0fe02a57d34bf64
2023-09-21 11:57:58 -04:00
Satyanvesh Dittakavi f16d336e32 SWDEV-375607 - Fix hipGraphExecUpdate behavior
Addresses the below scenarios like parameters mismatch
in memcopy node, difference in the count of nodes, difference
in the dependencies of the nodes.

Change-Id: I31c6516fb27cc1007809f1b50306fdb0c2356ccc
2023-09-21 11:17:49 -04:00
Satyanvesh Dittakavi d7d0f11318 SWDEV-395996 - Add HIPRTC support for missing hip headers
hip headers such as hip_math_constants.h, library_types.h,
hip_common.h, channel_descriptor.h, device_functions.h, hip_complex.h,
hip_texture_types.h, math_functions.h, surface_types.h
are added in HIPRTC

Change-Id: I4a4c198449ceb609c3ff55e00b43056c1f085431
2023-09-21 03:11:06 -04:00
Ajay 2bae1b1387 SWDEV-421102 - make clr compatible with c++20
Change-Id: Ia692817232caa3ee97dc0b2139645a0474b582e1
2023-09-18 11:28:29 -04:00
kjayapra-amd 85b645731c SWDEV-417244 - Create Unique File Desc Store and guarantee no duplicates fds are opened.
Change-Id: I7be7fee52b673f0b1b3facdfbd847b57f2a47cde
2023-09-13 17:03:18 -04:00
Jaydeep Patel a37c95d7ed SWDEV-418038 - Drop GPU_ENABLE_WAVE32_MODE from RTC.
Change-Id: Iac11f26714e8b3bae14cbf69933ef7c8c8be47da
2023-09-08 02:13:41 -04:00
Anusha GodavarthySurya 530dc6de2a SWDEV-301667 - Optimize performance when graph has single branch
Three for loops iterate over all graph nodes for UpdateStream, FillCommands and
EnqueueCommands has performance drop for large graphs.

Change-Id: I077accf3a4680d5d944b73200fd6498a7a48f25c
2023-09-07 23:35:36 -04:00
Ioannis Assiouras 315082e554 SWDEV-419996 - Allow both kernelParams and extra arguments to be set to null
When kernel function expects no parameters no error should be returned
if both kernelParams and extra arguments are set to null.

Change-Id: I5941bcc400b6fb380e623bdae0233ae3e4f73815
2023-09-07 12:57:46 -04:00
German 7be3a5e33e SWDEV-407533 - [ABI Break]Remove Wavelimiter
Change-Id: I6a2f6fb5a0c3acea93fa0200a69679783e76f5bd
2023-09-07 09:58:41 -04:00
Ioannis Assiouras 2bc6661737 SWDEV-420222 - Removed implementation of hipMemcpyArray functions
hipMemcpyArrayToArray, hipMemcpyFromArrayAsync, and hipMemcpyToArrayAsync
are deprecated in cuda and are missing the headers in hip_runtime_api.h.
Removed their implementation from hip_memory.cpp.

Change-Id: I9720aec6241515c56c66b7e90a37b2ed53347eb2
2023-09-04 13:35:08 +01:00
Rahul Garg c9cf3bdc16 SWDEV-418360 - Continue parsing modules even when some module don't have
right binaries built for current device

Change-Id: Icc6a4233fbcede9b2dc6feb78e6bfbd761684c7f
2023-08-31 14:54:59 -04:00