benrichard-amd
6605d5e217
Remove duplicate normal counters
...
Interleve TCC channel counters in putput file e.g. TCC_HIT[0] TCC_ATOMIC[0] ... TCC_HIT[1] TCC_ATOMIC[1]
Signed-off-by: benrichard-amd <ben.richard@amd.com >
[ROCm/rocprofiler-compute commit: 241a0949e1 ]
2024-08-09 09:46:42 -04:00
benrichard-amd
a2d03adce4
Interleve TCC channel counters
...
Signed-off-by: benrichard-amd <ben.richard@amd.com >
[ROCm/rocprofiler-compute commit: a4fdee488b ]
2024-08-09 09:46:42 -04:00
benrichard-amd
033922ecc0
Improve perfmon coalescing
...
Signed-off-by: benrichard-amd <ben.richard@amd.com >
[ROCm/rocprofiler-compute commit: c93fead779 ]
2024-08-09 09:46:42 -04:00
coleramos425
b3a7b477d0
Explicitly define Python path in CTest test declaration
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4532d7df74 ]
2024-08-09 09:46:42 -04:00
coleramos425
244ae98968
Comply to Python formatting
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 013bf218d0 ]
2024-08-09 09:46:42 -04:00
coleramos425
3f954de70d
Add detail to Omniperf logs
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 3d5493a3ff ]
2024-08-09 09:46:42 -04:00
coleramos425
7cc89dbeff
Split rocprofv2 cmd args prior to subprocess call ( #347 )
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 19a229a9f2 ]
2024-08-09 09:46:42 -04:00
coleramos425
7de6a2f997
Fix bug in abs diff calculation for analysis output
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: fa90752d0c ]
2024-08-09 09:46:42 -04:00
Ben Richard
21b23a08d6
Work around crash when profiling multi-process/multi-GPU application ( #376 )
...
* Fix crash in multi-GPU scenario
Exclude -o option when invoking rocprof so that each rocprof process
writes to a different .csv file. Concatenate into a single .csv file
when finished.
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Only combine csv files when using rocprofv2
rocprofv1 does not have separate csv files
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix indices in combined CSV file
Use ignore_index flag to ensure there are no duplicate indices.
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix Dispatch_ID column and remove unnamed column
-Pandas was inserting an unnamed column (index column)
-Overwrite the Dispatch_ID column so that every row is unique, starting at 0
-Remove fixup_rocprofv2_dispatch_ids as no longer needed
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix code formatting
Signed-off-by: benrichard-amd <ben.richard@amd.com >
* Fix code formatting (for real this time)
Signed-off-by: benrichard-amd <ben.richard@amd.com >
---------
Signed-off-by: benrichard-amd <ben.richard@amd.com >
[ROCm/rocprofiler-compute commit: 69e5c32d52 ]
2024-08-09 09:46:42 -04:00
David Galiffi
6029c74e5b
Fixing for packaging ( #386 )
...
Should have been checking environment variables for package name
overrides.
Disabled RPM Build's AUTOREQ and AUTOPROV
Signed-off-by: David Galiffi <David.Galiffi@amd.com >
[ROCm/rocprofiler-compute commit: 98e7d0cfb3 ]
2024-07-19 22:16:59 -04:00
coleramos425
ddd5fb9317
Upgrade docs package
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 6d24a074b4 ]
2024-06-04 00:33:18 +00:00
coleramos425
a3a0ca24bc
Update VERSION, CHANGELOG, and citation for next release
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: d100173739 ]
2024-06-04 00:03:43 +00:00
Karl W Schulz
eba7a19626
set CMAKE_HIP_ARCHITECTURES at configure time so that build matches
...
desired execution environment
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 18f96b6b23 ]
2024-06-03 17:41:19 -05:00
Karl W Schulz
f3a914adcc
include ENABLE_TESTS=ON for profile tests
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: c31ecf2a90 ]
2024-06-03 17:08:48 -05:00
Karl W Schulz
148439190b
wrap up test compilation with an ENABLE_TESTS option
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 90ff4bf575 ]
2024-06-03 16:20:14 -05:00
Karl W Schulz
0746f01845
update CI to build necessary vcopy binary via new additions to build
...
system (a la, just run make)
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 5077f9e24f ]
2024-06-03 16:20:14 -05:00
Karl W Schulz
c867a6c5fc
change project language to HIP; identify tests as cmake subdir
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: c54d3b34ea ]
2024-06-03 16:20:14 -05:00
Karl W Schulz
c38aa7f6b4
adding build-collateral for test subdir
...
Signed-off-by: Karl W Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 382a83f48b ]
2024-06-03 16:20:14 -05:00
coleramos425
68387da116
Comply to formatting
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7046ea15bd ]
2024-06-03 13:47:45 -05:00
coleramos425
67c4075950
Detection of MI308X and hardcode mclk to address bug in rocm-smi
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 1d19ae9483 ]
2024-06-03 13:47:45 -05:00
coleramos425
48c7833d07
Re-implementing HBM stack / XCD info for incoming product sku
...
Co-authored-by: Nicholas Curtis <nicholas.curtis@amd.com >
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 295b344646 ]
2024-06-03 13:47:45 -05:00
coleramos425
351d8d2141
Missing test case
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7c06b4d2ae ]
2024-05-31 22:02:18 +00:00
coleramos425
4ce7be32fb
Fixing some typos from debug
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 55a31ef880 ]
2024-05-31 21:46:18 +00:00
coleramos425
38ddf94211
Comply to Python formatting
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 9ff90edc10 ]
2024-05-31 16:09:58 -05:00
coleramos425
1dab1f6062
Remove outdated CTest case from CMakeLists
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: fef13818f9 ]
2024-05-31 16:09:58 -05:00
coleramos425
d02806639a
Update gpu-id on MI300 CI workloads and update test case
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 0315ed4458 ]
2024-05-31 16:09:58 -05:00
coleramos425
b046f69ce4
Remove old workloads
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 73f18d20f5 ]
2024-05-31 16:09:58 -05:00
JoseSantosAMD
ebad309264
Updated test_analyze_commands to include mi300 directories
...
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
[ROCm/rocprofiler-compute commit: 91f635e3e6 ]
2024-05-31 16:09:58 -05:00
coleramos425
2bc71cc0d8
Add vcopy workloads for MI300A and MI300X
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: c079f1330b ]
2024-05-31 16:09:58 -05:00
JoseSantosAMD
34b289e66d
updating expected exit codes for pytest
...
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
[ROCm/rocprofiler-compute commit: db7d77ca3f ]
2024-05-31 16:09:58 -05:00
JoseSantosAMD
ec09cf2cca
update test analyze scripts
...
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com >
[ROCm/rocprofiler-compute commit: 6d98a1eb5e ]
2024-05-31 16:09:58 -05:00
coleramos425
4c3c196c61
Remove debug print statements from profile_general
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 618c064571 ]
2024-05-31 16:09:58 -05:00
coleramos425
9be67d0cb4
Remove invalid test from workload generation script
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: cdccd93afa ]
2024-05-31 16:09:58 -05:00
coleramos425
89dc3f650f
Add CI workloads for MI300A_A1 and MI300X_A1
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: b8af814467 ]
2024-05-31 16:09:58 -05:00
coleramos425
9edb0fb72d
Remove redundant code in PyTest
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 7d79fcc276 ]
2024-05-31 16:09:58 -05:00
coleramos425
0158663680
Support MI300 in PyTest profile tests
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 09264591f3 ]
2024-05-31 16:09:58 -05:00
coleramos425
23cbe3f595
Create dedicated subdirectory in perfmon configs for archs supporting roofline
...
Separate subdirs allows us to target different roofline counters for different archs (i.e. MI300 vs MI200)
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 49371cacec ]
2024-05-31 16:09:58 -05:00
Karl W. Schulz
dd374ea0ef
remove use of distutils package entirely to avoid future deprecation
...
issues
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: 7a01f499d7 ]
2024-05-28 15:34:00 -05:00
Karl W. Schulz
7288bf34f4
updated approach for runtime dependency check that does use "pkg_resources"
...
which will reportedly be deprecated at some point in the future.
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com >
[ROCm/rocprofiler-compute commit: aca084f41c ]
2024-05-28 15:34:00 -05:00
coleramos425
782ea3099b
Wrap text displayed in 'Top Dispatch' table for neatness
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: c6cfa9cc26 ]
2024-05-28 15:34:00 -05:00
Nicholas Curtis
8bd72673e8
Add fix for case where we pass a single 'nan' value to to_avg
...
This is triggered by doing e.g., analyze -p <whatever> -k <kernel> -n per_kernel -b 17 18
Manifests as e.g.:
```
ERROR [analysis] 'float' object has no attribute 'empty'
```
because of:
https://github.com/ROCm/omniperf/blob/f3a0360a5640e4539fac534f73876f51ddd268d0/src/utils/parser.py#L135
Instead, we first check whether numpy thinks the whole array is nan's, and bail early if so
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 047d7771f3 ]
2024-05-28 15:34:00 -05:00
Nicholas Curtis
f7da503e6f
handle unspecified case
...
Signed-off-by: Nicholas Curtis <nicurtis@amd.com >
[ROCm/rocprofiler-compute commit: 1f584c1612 ]
2024-05-28 15:34:00 -05:00
Nick Curtis
562e36a5c3
fix formatting
...
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com >
[ROCm/rocprofiler-compute commit: 5579beeed5 ]
2024-05-28 15:34:00 -05:00
Nick Curtis
fbb384bd2f
Add ability to overide arch when name missing in rocminfo
...
Signed-off-by: Nick Curtis <nicholas.curtis@amd.com >
[ROCm/rocprofiler-compute commit: 989dd3b7ae ]
2024-05-28 15:34:00 -05:00
Cole Ramos
6ce7c00461
Update packaging.yml checkout library
...
Signed-off-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 57c4f2047e ]
2024-05-17 15:00:18 -05:00
Cole Ramos
28c2797792
Update AUTHORS
...
Signed-off-by: Cole Ramos <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 5f0978c278 ]
2024-05-17 13:42:36 -05:00
coleramos425
c2e549c883
Update CHANGES
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 4c70cb919d ]
2024-05-17 18:36:11 +00:00
coleramos425
219914fa9e
Format CMake and Python
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 1f370c9fe7 ]
2024-05-10 09:07:40 -06:00
coleramos425
e6b2b03f32
Add support for --quiet flag to roofline
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: dba868973b ]
2024-05-10 09:07:40 -06:00
coleramos425
d7d0e5bb70
Include Grafana assets in CMake build
...
Signed-off-by: coleramos425 <colramos@amd.com >
[ROCm/rocprofiler-compute commit: 1767c31db9 ]
2024-05-10 09:07:40 -06:00