Commit Graph

67 Commitit

Tekijä SHA1 Viesti Päivämäärä
David Galiffi 75a4b51d0d Check Python version on application launch (#393)
* Check that the minimum required Python (3.8) version is used.

Prints a descriptive error message, rather than a cryptic import
failure, if minimum Python version is not met.

Internal ticket SWDEV-477233.


* Disable the RPM mangling of shebangs.

The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`.
With this set, omniperf is always using the platform installed version
of python, which is python 3.6 on RHEL 8. Using virtual environments,
like conda, did not work.

* Fix pylint issues

---------

Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-09-25 17:21:39 +00:00
Karl W. Schulz 7a01f499d7 remove use of distutils package entirely to avoid future deprecation
issues

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-05-28 15:34:00 -05:00
Karl W. Schulz aca084f41c updated approach for runtime dependency check that does use "pkg_resources"
which will reportedly be deprecated at some point in the future.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-05-28 15:34:00 -05:00
Karl W. Schulz d1ee2ec870 Adding a top-level runtime python dependency checker. Goal is to
provide a kinder error message in the case where python dependencies
are not available locally. This is motivated for future execution by
users who are running from rocm-based binary packaging instead of using
normal cmake build system which would have verified the dependencies.

Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-05-03 15:26:27 -05:00
Karl W Schulz 27a57bdafb refactor setting of local encoding; remove from top-level omniperf
wrapper and push into base class via a companion utility function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2024-03-11 14:19:01 -05:00
colramos-amd 5ed9a5c902 Connect verbosity flag to loglevel
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-11 14:19:01 -05:00
colramos-amd 5bf38a4fed All logging should use call new functions
Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-11 14:19:01 -05:00
Cole Ramos f4511e7280 Force encoding before Omniperf execution (#299)
* Force encoding before Omniperf execution

Signed-off-by: colramos-amd <colramos@amd.com>

* Fix circular dependency in utils module

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
2024-03-06 17:01:07 -06:00
colramos-amd e1867d34d3 Enable database mode
Signed-off-by: colramos-amd <colramos@amd.com>
2024-01-30 10:43:30 -06:00
Karl W. Schulz d7b6cf81e6 update headers for 2024 calendar year
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2024-01-24 17:50:31 -06:00
Karl W Schulz 9b4b6aee8e restore formal call to sys.exit() in top-level main; this is needed
for companion testing collateral which expects SystemExit exceptions
to be raised.

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
2023-12-07 14:40:07 -06:00
colramos-amd 87388227ca Initial overhaul of Profile mode
Signed-off-by: colramos-amd <colramos@amd.com>
2023-10-31 15:11:17 -05:00
colramos-amd 95f886ef5a Consistent useage of -p/--path option in profile mode
Signed-off-by: colramos-amd <colramos@amd.com>
2023-10-04 09:50:30 -05:00
coleramos425 50fd968f51 Removing kernelVerbose from database mode
Signed-off-by: coleramos425 <colramos@amd.com>
2023-08-24 18:57:26 -05:00
coleramos425 7d457b5096 Replacing subprocess with shutil
Signed-off-by: coleramos425 <colramos@amd.com>
2023-08-24 15:54:00 -05:00
coleramos425 7187218ed9 Patch llvm-cxxfilt detection in atypical rocm installs
Signed-off-by: coleramos425 <colramos@amd.com>
2023-08-22 11:25:06 -05:00
coleramos425 064debf356 Documentation enhancements
Signed-off-by: coleramos425 <colramos@amd.com>
2023-08-17 09:50:38 -05:00
coleramos425 3ae0198f8e Renaming csv_converter to make more succinct
Signed-off-by: coleramos425 <colramos@amd.com>
2023-08-16 16:16:46 -05:00
coleramos425 5d74b142b6 Prevent users from ipblock filtering in standalone GUI
Signed-off-by: coleramos425 <colramos@amd.com>
2023-08-16 14:16:50 -05:00
coleramos425 4aa33848de Fixing several bugs on original PR
Signed-off-by: coleramos425 <colramos@amd.com>
2023-08-15 14:00:36 -05:00
josantos 59d77f9d81 Names shortened/demangled after join_prof
-  Added kernelVerbose flag in profile_group
-  Added KernelVerbose flag in analyze_group
-  Analyze replaces csv with shortened/demangled name
-  csv_converter uses llvm-cxxfilt

Signed-off-by: josantos <josantos@amd.com>
2023-08-10 11:13:27 -05:00
josantos 2948f73ae8 keep converter in csv_converter.py
Signed-off-by: josantos <josantos@amd.com>
2023-08-09 10:46:57 -05:00
JoseSantosAMD 76da2a9ed5 Merge branch 'dev' of https://github.com/AMDResearch/omniperf into kernel_name_mappings 2023-08-08 14:49:59 -05:00
JoseSantosAMD 4e51c122d1 removing calls to kernel_name_shortener in mongo
shortening now in profile

Signed-off-by: JoseSantosAMD <josantos@amd.com>
2023-08-08 12:06:39 -05:00
coleramos425 a89cb96b69 Extend filtering into timestamps.csv (#80)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-06-26 15:30:38 -05:00
coleramos425 514b91b210 Add LDSBanks for LDS bw calc (#107)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-19 16:08:23 -05:00
coleramos425 44edef4635 Enhance logging and warning reporting
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-16 15:39:45 -05:00
coleramos425 419e2fcac6 Add grid size option and cmd line option for --join-type
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-11 13:00:30 -05:00
coleramos425 f499408c7b Fix join_prof() call for --roof-only mode
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-08 11:55:45 -05:00
coleramos425 a9d82759ca Implement custom merge utility for rocprof
Signed-off-by: coleramos425 <colramos@amd.com>
2023-05-05 15:07:20 -05:00
coleramos425 77559a2f25 Roofline support for SLES15 SP3 and greater (#109)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-04-14 12:50:28 -05:00
coleramos425 6050cdd924 Add log.txt file to workload output (#106)
Signed-off-by: coleramos425 <colramos@amd.com>
2023-04-05 14:28:19 -05:00
coleramos425 27fa97aad9 Option for different markers per kernel name
Signed-off-by: coleramos425 <colramos@amd.com>
2023-02-27 16:18:42 -06:00
coleramos425 0705db024c Correct filtering in standalone roofline
Signed-off-by: coleramos425 <colramos@amd.com>
2023-02-22 14:37:20 -06:00
Cole Ramos acfba464ed Custom metrics for mi100
Signed-off-by: Cole Ramos <colramos@TheraC02.thera.amd.com>
2023-02-15 14:44:29 -06:00
Karl W. Schulz 574ebcf755 apply "make license" update
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2023-02-13 14:50:24 -06:00
Karl W. Schulz 3d7a7a6f32 updating copyright header for 2023 using newly-added "make license" target
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2023-02-13 14:15:27 -06:00
Karl W. Schulz c8fc8e8026 adding license delimiters to headers
Signed-off-by: Karl W. Schulz <karl.schulz@amd.com>
2023-02-13 10:36:29 -06:00
coleramos425 ad05c01966 Remove reference to deprecated --axis option
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-31 15:37:54 -06:00
coleramos425 88987f4c29 Add quotes to app cmd in sysinfo #76
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-27 11:12:53 -06:00
Cole Ramos 2e1de304f5 Add commenting
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-26 14:13:14 -06:00
coleramos425 b6d6c05e7b Re-enable standalone roof options. Everthing working.
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-26 14:07:10 -06:00
coleramos425 fb4b21380d Merge branch 'dev' of github.com:AMDResearch/omniperf into 69-merge-roofline-modules
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-25 15:39:16 -06:00
coleramos425 a8d64bf7e9 Modify parameters for calls to rocscope
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-25 15:30:04 -06:00
coleramos425 ee51ba994f Add execution privileges to omniperf bash
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-24 09:09:52 -06:00
Cole Ramos 6c930358fc Merge branch 'dev' into lucky 2023-01-23 15:32:44 -06:00
coleramos425 00c9ff9493 Merge branch 'dev' into lucky
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-23 15:28:35 -06:00
Keith Lowery 60eca50d02 Implemented the --use-rocscope command-line argument
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-23 15:12:15 -06:00
Keith Lowery 5d4de98d18 Supporting use of rocscope as alternative profiler
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-23 15:12:15 -06:00
Keith Lowery 9e12acf79c Got kernel summaries in rocscope integrated
Signed-off-by: coleramos425 <colramos@amd.com>
2023-01-23 15:12:15 -06:00