Граф коммитов

777 Коммитов

Автор SHA1 Сообщение Дата
Mythreya 6a4321c4e3 Add MI200/MI300 counters
Revision - Addition [Impact SoC: MI200, MI300]
    Note: this set of counters are important help understand the
          bottleneck.
    1.	TCC_TAG_STALL
        a.	Metric:  TCC_TAG_STALL/TCC_CYCLE: percentage of time TCC
            tag lookup pipeline is stalled
    2.	TCP_TCR_TCP_STALL_CYCLES
        a.	Metric: TCP_TCR_TCP_STALL_CYCLES/TCP_GATE_EN1: percentage
            of time TCP is stalled by TCR

Revision - Addition [Impact SoC: MI300]
    3.	TCC_BUBBLE:
        a.	Definition: Number of 128-byte read requests sent to EA
        b.	Revised Metric #1, TCC-EA Read BW:
        ReadBW =   128 * TCC_BUBBLE
                + 64 * (TCC_EA0_RDREQ - TCC_BUBBLE - TCC_EA0_RDREQ_32B)
                + 32 * TCC_EA0_RDREQ_32B
        c.	Revised Metric #2: TCC_EA Read Latency
        ReadLatency = TCC_EA0_RDREQ_LEVEL / (TCC_BUBBLE + TCC_EA0_RDREQ)

    /* [Fineprint] More detailed arithmetic:
    * ReadLatency = TCC_EA0_RDREQ_LEVEL / (#32B_req + #64B_req + #128B_req * 2)
    */

Change-Id: I0a2dfc1b64ca97023b1e8ba0f9830330b3034946


[ROCm/rocprofiler commit: 46e02a9866]
2023-10-30 15:38:46 -04:00
gobhardw 7aaf49a641 SWDEV-429377 : Fixing kernel name truncation for plugins
Change-Id: I5875048d1773959fdd73cbff5498854e61b92af8


[ROCm/rocprofiler commit: 49bd09b46c]
2023-10-30 10:52:31 -04:00
Ammar ELWazir 7f9ec63c49 Fixing Tool/Plugin Versioning and adding --version and adding proper documentation for those features
Change-Id: Icdb0d64e02943e638f183ab31759a37736d2dd61


[ROCm/rocprofiler commit: 32907ff14c]
2023-10-27 14:52:13 +00:00
Lancelot Six 929ea5d950 src/core/isa_capture/code_object_track.cpp: remove unused dbgapi import
The src/core/isa_capture/code_object_track.cpp file includes the
amd-dbgapi header but does not use the library (and is not configured to
use the library).

Remove the unused import.

Change-Id: Icc6c46a1f52355e9e5631395dfad1b44365bdca4


[ROCm/rocprofiler commit: 372fc3910b]
2023-10-27 00:09:21 -04:00
Ammar ELWazir ef2428fb96 Fixing V2 tests to accept HIP function versioning
Change-Id: Ic68116feb51b396b27e858dcaf8b389d4d11a49b


[ROCm/rocprofiler commit: cca295d951]
2023-10-26 22:04:53 +00:00
Mythreya 1471dc8a76 Remove non-functional counters for MI200 and MI300
Counters removed for MI300 (gfx940)
    TCP_TCC_WRITE_REQ_HOLE_LATENCY
    TCP_TCC_WRITE_REQ_LATENCY
    TCP_TCC_READ_REQ_LATENCY
    TCP_TCP_LATENCY

Counters removed for MI200 and MI300 (gfx90a and gfx940 respectively)
    TA_BUFFER_COALESCABLE_WAVEFRONT
    TA_FLAT_COALESCABLE_WAVEFRONT
    TCC_EA0_WRREQ_IO_CREDIT_STALL
    TCC_EA0_WRREQ_GMI_CREDIT_STALL
    TCC_EA0_WRREQ_DRAM_CREDIT_STALL
    TCC_EA0_RDREQ_IO_CREDIT_STALL
    TCC_EA0_RDREQ_GMI_CREDIT_STALL
    TCC_EA0_RDREQ_DRAM_CREDIT_STALL

Change-Id: Ic3d1e7bf35495f35b1239f03ca6420e949421386


[ROCm/rocprofiler commit: 1fae494b12]
2023-10-26 12:50:57 -04:00
gobhardw 8f5a295356 updating rocprof script for supported hw check
Change-Id: I41a8571682fd4c9ab227cc7d964f86d027d5c964


[ROCm/rocprofiler commit: 1bc98d806d]
2023-10-26 12:48:47 -04:00
Parag Bhandari 54208cd7d0 Add gfx1031 support for building
Change-Id: Ie88d76404a09de07d66a84083a7a8549bff3d050


[ROCm/rocprofiler commit: 8b9d8b966d]
2023-10-26 11:33:02 -04:00
Ammar ELWazir 37ca411965 Fixing Versioned HIP Call
Change-Id: Ib768f8a53ffc6cc3bb89e6c867918b6440ce1cab


[ROCm/rocprofiler commit: b5fd31fb9b]
2023-10-26 14:50:16 +00:00
Ranjith Ramakrishnan 57d8b98c56 SWDEV-427554 - Temporarily disable building of unittest in ASAN builds
Unittest is failing in ASAN builds. To unblock ASAN builds, disabling the same as a workaround
The test will run in non-asan builds

Change-Id: Ib3c8d7a2c77aa83e9c6260e9b47ccb0564f789e8


[ROCm/rocprofiler commit: 8babd28a50]
2023-10-25 17:45:54 -07:00
gobhardw a668f1b56e SWDEV-421283 : Fixing README for ATT
Change-Id: I4a85987b036dd27e344d0d2049ca8d22bf846dc2

Removed mention of deprecated SIMD_MASK
Removed duplicated ATT section

Change-Id: I4a85987b036dd27e344d0d2049ca8d22bf846dc2


[ROCm/rocprofiler commit: 623d614d77]
2023-10-25 06:42:37 -04:00
gobhardw c505fd6a2b SWDEV-427842: Fixing ATT csv mode
Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1

- Updated README for kernel name truncation.
- Updated CHANGELOG.
- By default enabled truncation for ATT because csv file names should be smaller

Change-Id: I7b8f37867d7aaf6da1301d91028990c343e555f1


[ROCm/rocprofiler commit: 296c935874]
2023-10-25 00:06:13 -04:00
Giovanni LB 976c0e6717 Initial commit for counter correctness tests.
Change-Id: I74caa4ab89bd765e59686cfbaaf1ce44ab10fe19

- adds counter correctness tests for GRBM, SQWAVES and SQ INSTRUCTIONs
- pandas dependency
- made it compatible with test infra.

Change-Id: I74caa4ab89bd765e59686cfbaaf1ce44ab10fe19


[ROCm/rocprofiler commit: 3f5ddfa0ab]
2023-10-23 03:51:42 -04:00
Sriraksha Nagaraj 45d34bb867 SWDEV-428099: Fixing hang with basenames option
Change-Id: I61c9ac03394bfde84c91d922e073690ef8655337


[ROCm/rocprofiler commit: c1884d70fc]
2023-10-23 00:38:16 -04:00
Ammar ELWazir c0bc40fd5d Fixing Usage of session after free
If hsa_shut_down() is not called from the application then we may still have async calls back
to the rocprofiler to use session parameters, thats why we need to leak the session up till
this is fixed in the ROCR-Runtime

Change-Id: Ia8fcdaa859815d88a272296770d702968132e3e6


[ROCm/rocprofiler commit: c9b5d73ca8]
2023-10-19 23:29:39 -04:00
Benjamin Welton 1e6d394c7a Migrate tracer performance fixes from roctracer
Change-Id: If9e1349537cce23b7be1d8530d795744a8cd07b1


[ROCm/rocprofiler commit: cb190b72f1]
2023-10-19 20:34:12 +00:00
Saurabh Verma 87654ec8b2 SWDEV-427921: Fixing rocprof v1 counter collection for PAPI on MI300
Change-Id: I8589fe78fca481ed326e584ea1d01c0f90de655e


[ROCm/rocprofiler commit: 1e1692e6c0]
2023-10-19 13:40:32 -04:00
gobhardw f16ad5d59d SWDEV-427969: Fixing kernel trace
Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1

When we did file plugin changes for omniperf in v2, we removed 2 fields from header:
SIG and OBJ. However from the values we missed removing OBJ. Fix is to remove the OBJ from values.

Change-Id: I050120ba0dd0df84a46f022c0f9b8117057202b1


[ROCm/rocprofiler commit: ab066543b1]
2023-10-19 05:56:55 -04:00
gobhardw ea5ecec246 SWDEV-427554 Fixing mainline ASAN build
Change-Id: I63cd047ceb75dea5f8ed6f84946e1ec209c7d812


[ROCm/rocprofiler commit: 5d390717b5]
2023-10-18 21:42:47 +05:30
Sriraksha Nagaraj facca4fd12 SWDEV-399631 : Fixing the regression issue
Change-Id: I9b2866e69ca2969405d06ac267eb17461b643eec


[ROCm/rocprofiler commit: ab288c8de8]
2023-10-16 15:27:07 -04:00
Ammar ELWazir 35ab6e9a72 SWDEV-391589: Addressing changes requested by Omniperf:
Adding Versioning to rocprof main script
Adding Versioning to file plugins to support legacy v1 output and new v2 output
Fixing headers for v2 output

Change-Id: I352e8c8ed03871466269a792d1bfa572da58bd8a


[ROCm/rocprofiler commit: 4f40fb8a40]
2023-10-16 15:19:20 -04:00
gobhardw 6978569d1f Solving timestamps and serialization merge
Change-Id: Icd14e49c06b19e4334adbdb98efed54af029b95b


[ROCm/rocprofiler commit: def7fa710a]
2023-10-16 14:54:50 -04:00
Ammar ELWazir 5e77e5008c SWDEV-302415: Fixing Kernel Dispatchs with trace-start off option
Change-Id: I225b88cb769d994f1007e7bc66f176e7fa40db05


[ROCm/rocprofiler commit: d816f133d1]
2023-10-16 09:39:42 -04:00
Giovanni LB 6852d2d6e8 SWDEV-427013: Fixing ATT parser for tensile kernels and network mode
Change-Id: I07cd34f5606c0aaf718d9e3ffabd5a407523a943


[ROCm/rocprofiler commit: 60197d0f20]
2023-10-13 20:41:46 -04:00
Sriraksha Nagaraj b5be707bcb Enabling -m and --basenames option
Change-Id: Ic19ac28ab6ec842daf2a93a311ed7690b61b1e2a


[ROCm/rocprofiler commit: a76341e30c]
2023-10-13 14:44:20 -04:00
Ranjith Ramakrishnan f4f9d5adf5 Missing library softlink added to ASAN package
The softlinks librocprofiler64.so and librocprofiler64v2.so was missing in ASAN package
Added the same

Change-Id: I8775b811f08377845dcce6bca88818c1741f3462


[ROCm/rocprofiler commit: a12d47fdb1]
2023-10-12 12:33:05 -04:00
Giovanni LB 769f6303d8 SWDEV-423947: Added ATT header option
Change-Id: I6e9ad213b578d752c865c9f9af4ee0b79d447e1b


[ROCm/rocprofiler commit: e0962d9d63]
2023-10-12 10:02:30 -04:00
Giovanni LB 5d443a4821 SWDEV-421283: ATT readme updates
Change-Id: I282a53ba6a6349b10c5976ab4232f451f51d82f6


[ROCm/rocprofiler commit: fdd4af4023]
2023-10-11 14:22:53 -04:00
Giovanni LB e52fb98671 SWDEV-416889: Changing rocminfo location from ROCM_PATH to CPACK_INSTALL_PATH
Change-Id: I7a488a05fc3903fcfcbeac6a76fe2d31f3a23bad


[ROCm/rocprofiler commit: 865d2782e8]
2023-10-11 14:18:31 -04:00
Giovanni LB 26f0300db7 SWDEV-423947: Moving to new aqllib
Change-Id: I2f99d88f9bda752fa0533f9c4416c805b68724d7


[ROCm/rocprofiler commit: 11a15ef9b0]
2023-10-11 10:59:30 -04:00
Giovanni LB 92ec86f2d4 Fixing GL2C counter instances
Change-Id: I37edbdaebe349149e369b21a9e48c302e170941e


[ROCm/rocprofiler commit: 9efd1865c0]
2023-10-10 12:09:49 -04:00
Giovanni LB 562c90fdb0 SWDEV-414768: Fixing multiqueue perfetto
Change-Id: Ie60cdc6bffe8e6748d443482a0dc3816d96b6604


[ROCm/rocprofiler commit: c22c7d64cc]
2023-10-10 11:55:42 -04:00
Sriraksha Nagaraj 168afe160e SWDEV-421208:Fixing the CMakelists for core unit test
Change-Id: I0949443e4204a69bb070532e4254d9baecd24dc3


[ROCm/rocprofiler commit: 04cec04c48]
2023-10-05 12:33:30 -04:00
gobhardw 31462313b6 Fixing missing limts header that causes build failure
Change-Id: I3d1ea3b6701a57a16af8742de446ce4bfea6ded6


[ROCm/rocprofiler commit: 417ceaa47f]
2023-10-05 10:58:10 -04:00
gobhardw 370a1ee4bd SWDEV-423972 fix kernel trace new line
Change-Id: I7932124cfd2ef519cad9bfde1c7d5f8ea35aace0


[ROCm/rocprofiler commit: b682ad8804]
2023-10-05 05:41:22 -04:00
Giovanni LB e17be9edb9 SWDEV-423366: Added workaround for comgr file offset. Fixed legacy mode for ATT.
Change-Id: Ib566f3573829b59ae6bd70a5479b9d7fb7fdc6ee


[ROCm/rocprofiler commit: d8951e2018]
2023-10-04 13:55:15 -04:00
Ammar ELWazir 93c3a5f278 SWDEV-421715: Fix for librocprofiler64.so Name link
Change-Id: I9c47570e58c764fb861c1b2ea139b14830e818c4


[ROCm/rocprofiler commit: f36568b35c]
2023-10-04 13:47:57 -04:00
Giovanni LB 2124bb6b38 SWDEV-423898: Fixing issues with parallel kernels
Change-Id: I6726f3003af6036ba041c2b4bc5227dd08691090


[ROCm/rocprofiler commit: 675e1b9d38]
2023-09-28 00:11:23 -03:00
Giovanni LB 3badb4ba81 SWDEV-423659: Disabling HIP_ACTIVITY when HSA_ACTIVITY is enabled.
Change-Id: If64fabdcd0d8a718dd0017c2bc821a94c999e87e


[ROCm/rocprofiler commit: 7418c52cc8]
2023-09-26 01:13:21 -04:00
Giovanni LB b92ddf8fd0 SWDEV-419972: Disable MP test
Change-Id: I646ee0206ef589e7c57107accfa00ccc801af40c


[ROCm/rocprofiler commit: 4ab6b8edcb]
2023-09-25 12:59:56 -03:00
vlaindic 581bf2cd87 SWDEV-418738: Listing counters of all GPU agents
Using `gfxip` when listing counters on the system with multi-GPUs
all belonging to the same family results in showing counters
of the first agent multiple times.
Instead, use the agent's `name` to observe counters of all agents.

Change-Id: I7b46c0670bc7c918e2ba0357fa659df9d23379d4


[ROCm/rocprofiler commit: 03a63791b0]
2023-09-22 17:22:28 +02:00
Ammar ELWazir a5006b00c4 Fixing Singleton test Issue
Change-Id: I21db27d5766232ee8307ce4579e8c6083a10538f


[ROCm/rocprofiler commit: c0c2af0e58]
2023-09-20 17:01:54 -04:00
gobhardw 593f54dc56 Fixing kernel-trace for file plugin
Change-Id: I9853e7e10da2f0812c69fe5242a9be34c78496f7


[ROCm/rocprofiler commit: 5d3f0a0e9e]
2023-09-19 23:40:54 +05:30
Giovanni LB d03a15bc22 SWDEV-419972: Disabling MT test because its broken. Moving MP test below plugin tests.
Change-Id: Ic6b69151f6ce96e56d7b9ae2bfd541faaca327f7


[ROCm/rocprofiler commit: 1b86e38776]
2023-09-15 14:13:50 -03:00
Sriraksha Nagaraj a157bb93b7 SWDEV-378008: Adding changes to serialize the kernels in rocprofV2
Change-Id: I82353ba94b3a15fdc5991e6129fe47f6765a9f74


[ROCm/rocprofiler commit: 54f6e2afb7]
2023-09-14 13:09:09 -04:00
Giovanni LB 00962f5862 SWDEV-421600: Fixing eval_metrics
Change-Id: I3a41fb6b27d80d84a34ee6461382e512dbecb61f


[ROCm/rocprofiler commit: adc1367c59]
2023-09-12 16:24:30 -04:00
gobhardw e10bff998f SWDEV-420435 solves wrong ordering of counter headers
Change-Id: Ifc2697e1f545d6329a7bbf024f106fd3244ae80a


[ROCm/rocprofiler commit: a40e05c425]
2023-09-12 11:20:10 +05:30
gobhardw 7f63d269b6 Fixing library path for roctx annotations
Change-Id: If3d65cf1808d011ef85e11e6804021c50ecce65c


[ROCm/rocprofiler commit: 5ec64f00a9]
2023-09-12 01:19:08 -04:00
gobhardw 2a0e835c4a Fixing Singleton test
Change-Id: I03daa4c741747b742179d18901a2e2e2d4a04ffb


[ROCm/rocprofiler commit: d4bb514493]
2023-09-11 15:00:39 -04:00
Giovanni LB 552814f227 SWDEV-419944: Added metrics for gfx1102
Change-Id: I5c69ff716f530d130710c0687f20e5bc990a60eb


[ROCm/rocprofiler commit: 43e259e5da]
2023-09-11 13:59:33 -04:00