Commit Graph

58 Commits

Author SHA1 Message Date
Jacob Lambert 2d9db8a102 SWDEV-371628 - Remove now-redundant Comgr devlib call from hipRTC
Because hipRTC is now using the newer
AMD_COMGR_COMPILE_SOURCE_WITH_DEVICE_LIBS_TO_BC, and now that this
action has been fixed for HIP compilations in Comgr, hipRTC no
longer needs separate Comgr call to link in the device libs.

Change-Id: Ibf9024cbaaab825584566e8d0b5fce60d7063dd8


[ROCm/clr commit: 283dd8352d]
2023-05-23 18:34:59 -04:00
Satyanvesh Dittakavi 82e044cb6a SWDEV-399851 - Add template overload for ToString in HIPRTC
HIPRTC_INIT_API can have nullptr in the arguments and ClPrint
can crash while printing

Change-Id: Iecade5c3867196509c8cc0647b9aa24be0960a02


[ROCm/clr commit: c98fad1edc]
2023-05-16 14:21:19 +00:00
Jatin Chaudhary 9e5b96d567 SWDEV-384013 - Print link options being passed to compiler with AMD_LOG_LEVEL
Change-Id: I556ed434587cff07a634796da51dcbb9ae78ef21


[ROCm/clr commit: 8753db5446]
2023-05-15 15:52:04 -04:00
Jacob Lambert c22413efba SWDEV-380857 - Fix bug when reading bitcode file into vector<char> buffer
The previous implementation using std::copy() resulted in
differences between the in-memory and on-disk representations.
With the updated implementation, we get the same contents.

Change-Id: Iadfae3cd7f7ba99538da2ac4f11f30f5a78260d8


[ROCm/clr commit: b17056cb93]
2023-05-08 16:25:01 -04:00
kjayapra-amd 23584feba4 SWDEV-393910 - Port gfx94x changes to mainline.
Change-Id: Ibf727223bbe5230b132b47c39e0fc1d87cbd3b9c


[ROCm/clr commit: f14e8a2dba]
2023-05-05 15:16:23 -04:00
Ioannis Assiouras 7adb0089c6 SWDEV-397356: Move HIP_API_PRINT after HIP_INIT so that the begin function call gets printed
Change-Id: I99b655596741c19bc483647794ae8b4f6e6f2843


[ROCm/clr commit: d88f0358b0]
2023-05-04 18:46:21 -04:00
Satyanvesh Dittakavi 53dcdf2b46 SWDEV-393060 - Address directed tests build failures with CLR
Change-Id: I76b93ee073d21ec5fae0db5a129ada89f750855d


[ROCm/clr commit: a3104c60e1]
2023-04-14 03:53:51 -04:00
Jaydeep Patel 235eb22491 SWDEV-390439 - SWDEV-387997 - Delete array.
Change-Id: Ica20b005f5db7f4ed65c5ebc51959392671fe320


[ROCm/clr commit: 0f975e6e93]
2023-04-05 16:37:39 +00:00
Jatin Chaudhary 421c4149e4 SWDEV-384013 - Add HIPRTC_JIT_IR_TO_ISA_OPT_EXT
Change-Id: Icfc06c19af32f41d603bf880ab1927bffb391097


[ROCm/clr commit: 300ba5b1f1]
2023-04-05 10:52:48 +00:00
Anusha GodavarthySurya f0dd8a6fe3 SWDEV-386102 - Handle code object v5
Change-Id: I47b840f484d90ca7815fb9c8af959ceaac62cf70


[ROCm/clr commit: 9b84e05427]
2023-03-09 00:19:25 -05:00
Satyanvesh Dittakavi 8947306ffd SWDEV-384714 - Add hipRTC support for amd_hip_fp16
Change-Id: Ib6e2b46908d740909dfc15253965590f496a7068


[ROCm/clr commit: a8c2375fe1]
2023-03-01 06:57:57 -05:00
Konstantin Zhuravlyov f789329113 SWDEV-1 - Add missing gpu cases in getProcName
Change-Id: I16103ab213cc70f388690df85e6a03e7a408384d


[ROCm/clr commit: caf7551dd7]
2023-02-17 15:55:09 -05:00
Satyanvesh Dittakavi 77e78dff33 SWDEV-370552 - Correct the HIPRTC behavior to optimize the ISA only once
Change-Id: Idaf0ea8294657db3666e9548deb6a9629e0ee718


[ROCm/clr commit: 99556449b6]
2023-02-09 11:55:41 -05:00
Satyanvesh Dittakavi d96114fd22 SWDEV-372396 - Address the errors in hiprtc headers with -Werror
Change-Id: Ied553216dfc2ff8b5c72de617cb47b6ca8f52063


[ROCm/clr commit: 0ccd41050b]
2023-01-23 17:25:42 +00:00
Satyanvesh Dittakavi f94a34e128 SWDEV-373231 - Support hip atomics header with HIPRTC
Change-Id: Ic500dfb66ed5ef0c4b672dfd0595409d0e8caaf5


[ROCm/clr commit: 842b9d0b56]
2023-01-17 00:31:07 -05:00
Jacob Lambert 507c87da5f SWDEV-356171 - Adding support for name lowering for bitcodes (-fgpu-rdc) via
Comgr mangled name fetching APIs

Change-Id: I10ce2b1288c459e3e61218d68a270aba2148376e


[ROCm/clr commit: 7dd54c746e]
2023-01-09 14:49:51 -05:00
Juan Manuel MARTINEZ CAAMAÑO f91da83d6a SWDEV-290384 - Missing hiprtcResult case in hiprtcGetErrorString
Change-Id: I11d18ff19f6f6f1b36febf87a586bc9ffb95af10


[ROCm/clr commit: 537df06c4f]
2023-01-06 03:38:44 -05:00
Satyanvesh Dittakavi 54c5fa36d8 SWDEV-375020 - Revert "SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr"
This reverts commit 96d28fd15d.

Reason: Adding "-Xclang" and "-disable-llvm-passes" in hiprtc
compilation seem to cause perf issues and memory fault in few apps.

Change-Id: I12ff46293c7b7afb24d570351736d884d2881b77


[ROCm/clr commit: 516acd4e60]
2023-01-06 00:09:06 -05:00
Satyanvesh Dittakavi 96d28fd15d SWDEV-370552 - Improve hiprtc performance by passing the right flags to comgr
Change-Id: I99674b033d1248d9b34ac598b4780bd84a38c279


[ROCm/clr commit: 627e689ad7]
2022-12-19 06:16:56 -05:00
kjayapra-amd 67cf4a5107 SWDEV-363865 - Use COMGR path to unbundle code object in HIPRTC.
Change-Id: Ifca29ea0c6ff319c3f584397e542a1658d220c4a


[ROCm/clr commit: 2f8847bfbd]
2022-12-15 07:16:55 -05:00
Jacob Lambert 50a845c43a SWDEV-322000 - Removing scoped locks in code regions with Comgr calls
Comgr now internally locks to avoid multi-threading issues with LLVM

Change-Id: I74b903d373af55c2efade17a9caf31fda3ca1795


[ROCm/clr commit: 2835ff1a63]
2022-12-14 12:40:45 -05:00
Satyanvesh Dittakavi a17cc5c6ba SWDEV-372032 - Support cooperative groups header with HIPRTC
Change-Id: Ia64652fd52b210a4eeee9d38fdfdfa6fdc7163ff


[ROCm/clr commit: 91291e48db]
2022-12-09 04:45:59 -05:00
Satyanvesh Dittakavi ea4ee7ed93 SWDEV-366306 - SWDEV-366314 - Add hip vector types and hip bfloat16 to HIPRTC cmake
Change-Id: If4213c3ca9446afe931c6b111c220033987e0204


[ROCm/clr commit: 88270b34f2]
2022-12-09 04:43:51 -05:00
Satyanvesh Dittakavi db752c6295 SWDEV-370841 - Correct the devicelibs library bitcode used by hiprtc
Change-Id: I1f2ab9ca4ab2947f42e101c37bb3e6a046e32d5b


[ROCm/clr commit: 450d0941ca]
2022-12-01 12:00:36 -05:00
Maneesh Gupta 3a7b8156a3 Revert "SWDEV-330775 - Update search path for LLVM"
This reverts commit f31b0874fd.

Reason for revert: SWDEV-368704

Change-Id: I8c38b4f40285f90f7d99145b970c2a14d051d5bb


[ROCm/clr commit: fab70a41ed]
2022-11-22 09:14:24 -05:00
Siu Chi Chan f31b0874fd SWDEV-330775 - Update search path for LLVM
ROCm's LLVM will be moved into /opt/rocm-<ver>/lib/, teach hipcc and
hipconfig about the new location.

Change-Id: Ie7f17146771aff94c684deb22148226cbb3a2895


[ROCm/clr commit: 3d15f9cbda]
2022-11-14 13:31:07 -05:00
kjayapra-amd acfea3b761 SWDEV-356947 - Create a new thread if current thread is nullptr.
Change-Id: Iebd69f22284041ed450d583471d24cb82fb0e47a


[ROCm/clr commit: cc9427e969]
2022-11-10 22:12:02 -05:00
Satyanvesh Dittakavi 300d7d98f9 SWDEV-364545 - Fix hiprtc cmake target on Windows
Change-Id: I360d0d1ee7f6a0c65a4d6cd07620bfa2a503c19f


[ROCm/clr commit: 1155dbda1e]
2022-11-10 01:23:42 -05:00
kjayapra-amd e380d85f27 SWDEV-355727 - Change in AMDGCN format in bitcode.
Change-Id: Ic32a3e7b866b35a321d8ececc2f6c63f9b23121d


[ROCm/clr commit: 1b902e1809]
2022-10-13 14:19:03 -04:00
Rakesh Roy f149b21399 SWDEV-351969 - TLS Optimization
- Aggregate all TLS(Thread Local Storage) variables into a single class
- This is to improve cache accesses per thread

Change-Id: Ic8361eaeae290fff00254684e309471958365eb9


[ROCm/clr commit: 8b391ef18c]
2022-10-09 22:08:14 -04:00
Satyanvesh Dittakavi a7f33f9237 SWDEV-357250 - hiprtc support with AMD_LOG_LEVEL when linked as separate library
Change-Id: Ieda83af85a9344b4e09d4fe85acc65386db79c39


[ROCm/clr commit: b425e27230]
2022-09-23 05:50:07 -04:00
kjayapra-amd b0825090e9 SWDEV-355727 - Added more rules to target ID comparison in hiprtc.
Change-Id: I56137375c3eb47dd604c7a02bb88f7e3dbe6c04d


[ROCm/clr commit: d870bdb9b1]
2022-09-21 12:18:13 -04:00
Maneesh Gupta 2e860b68a0 Revert "SWDEV-339488 - Address HIPRT tests failure with spaces in the include path"
This reverts commit 147c17cac4.

Change-Id: I10f91ec0205cd4276b141aade5728fdc20030195


[ROCm/clr commit: 8e10332ff1]
2022-09-13 23:06:23 -04:00
Satyanvesh Dittakavi 646e4dd5bd SWDEV-344342 - hiprtc-config-version.cmake should be generated in build directory
Change-Id: I7becaa64873c5e8ba95e814421c1f700a0997a8b


[ROCm/clr commit: b7716825c8]
2022-09-05 00:05:18 -04:00
Satyanvesh Dittakavi 147c17cac4 SWDEV-339488 - Address HIPRT tests failure with spaces in the include path
Change-Id: Ic9ed57e44fcfdf82a0d066483bc73e1d59c39e30


[ROCm/clr commit: 89355fb586]
2022-08-26 06:47:56 -04:00
Satyanvesh Dittakavi e960c639b7 SWDEV-344342 - Expose hiprtc target via cmake config interface
Change-Id: I1f19c4792665b078c2799c0c3c9e2d5b28c906de


[ROCm/clr commit: ab112eaf1d]
2022-08-25 00:29:23 -04:00
Ranjith Ramakrishnan a2b9eb12d4 SWDEV-353137 - Fix for incorrect library path for hiprtc
Hiprtc related libraries are duplicated when installed from build directory
This happens when cmake install libdir is set with lib64 as default and using hard code path "lib" for LIBRARY_DESTINATION
Replaced "lib" with cmake install libdir
Removed the default setting of libdir in source code and its should be controlled via build argument

Change-Id: Icac55eac9427a5088903d01942e6bfd5263a6fc0


[ROCm/clr commit: ba04f95771]
2022-08-23 12:19:06 -04:00
kjayapra-amd 7eecd3e27f SWDEV-351609 - Updating the right structure with file info.
Change-Id: Ia4e1195df0669450162b2df4de50197ff27cfcae


[ROCm/clr commit: f15016227b]
2022-08-22 21:54:35 -04:00
Satyanvesh Dittakavi feb23ab256 SWDEV-336448 - Load comgr versioned dll in hiprtc
Change-Id: I9c966ac6e3beae707d732e4bf84f88457d6265de


[ROCm/clr commit: 651f333140]
2022-08-19 00:38:08 -04:00
kjayapra-amd e8872579cf SWDEV-351508 - Change the data_kind to BC from FATBIN, since unbundling happens in runtime now.
Change-Id: Iaf6e85637edaa92171edc4edc650a0b4598bf625


[ROCm/clr commit: 9e9754be80]
2022-08-12 19:52:29 -04:00
Satyanvesh Dittakavi 9363dd8909 SWDEV-350479 - Add missing hiprtcVersion symbol on Windows
Change-Id: Ifcb737adddade80ebe91a50812c96c585d7d3217


[ROCm/clr commit: c33a6b4a03]
2022-08-09 03:15:12 -04:00
Satyanvesh Dittakavi b46875e588 SWDEV-336448 - hiprtc dll versioning on windows
Change-Id: I6ab6f975bcd7cd2fb27d59d0860a6dbe8434970e


[ROCm/clr commit: 9299d5febb]
2022-08-09 00:50:21 -04:00
kjayapra-amd 8aaf355b81 SWDEV-346018 - Support unbundling of code object in runtime for hiprtc.
Change-Id: Idda30def999b28500738c7b48560d36ca6a8e730


[ROCm/clr commit: 4bba4faa0c]
2022-08-03 17:57:29 -04:00
Satyanvesh Dittakavi 3b1e9dc52f SWDEV-2 - Fix hiprtcCompileProgram
- hiprtcCompileProgram should create isa with temp name when
  program name is not provided along with --save-temps option

Change-Id: I47974e2ac56336c851531622ff7d2a3ffb53455e


[ROCm/clr commit: 958b97b433]
2022-08-02 16:16:31 -04:00
Satyanvesh Dittakavi 0886b8ad06 SWDEV-340226 - SWDEV-340692 - Fix minor issues with hiprtc Link APIs
- hiprtcAddLinkData should accept 0 or null as input name
- hiprtcLinkCreate should accept 0 or null as options ptr
- hiprtcCompile should send -fgpu-rdc option to comgr if its present in the options

Change-Id: I84f6e36df5c99b719ee9c67dfc1b4dbcfd8e3172


[ROCm/clr commit: ee27685ac4]
2022-07-22 07:23:26 -04:00
Satyanvesh Dittakavi 8911a42f61 SWDEV-341360 - Handle named expressions with space in hipRTC
Change-Id: I1c26855d8a94e0a4d818664ca71094c6992221c9


[ROCm/clr commit: b263ab3248]
2022-06-22 14:19:16 +00:00
kjayapra-amd 8a049faccb SWDEV-339995 - Adding hiprtcGetBitcode and hiprtcBitcodeSize changes.
Change-Id: I378f1ac98de3b11fa3f74161abd036702c7b479b


[ROCm/clr commit: 2731d03f03]
2022-06-22 04:17:56 -04:00
Satyanvesh Dittakavi abcbb979db SWDEV-340226 - hiprtcLinkAddData should allow empty name
Change-Id: I2c9a53453223ee4899b0a5d05e1097bc7e0e428e


[ROCm/clr commit: a39ab85e04]
2022-06-22 04:15:32 -04:00
kjayapra-amd a223c541ca SWDEV-340226 - Fixing conversion to void* from size_t instead of size_t*.
Change-Id: Ib7e083395d4fbbe2a6f3012fce5b268e108ad62a


[ROCm/clr commit: 5d385fa0e2]
2022-06-21 06:28:06 -04:00
kjayapra-amd 86cc032d73 SWDEV-340226 - Fixing minor issues related to hiprtc Link API changes.
Change-Id: I18e7ca2a467ccf14d95ffb37b5516dda74f98cf7


[ROCm/clr commit: 5e61b9e762]
2022-06-16 06:06:38 -07:00