Commit Graph

68454 Commits

Author SHA1 Message Date
David Galiffi d6bdc53f1a Update rocprofiler-systems-continuous-integration.yml (#1271)
Disabling network test from CI while we investigate it's instability.
2025-10-07 18:55:30 -04:00
German Andryeyev 7ca2497378 rocr: Add AQL queue support under Windows (#1211)
Add 2 extra caps into the thunk interface to indicate
the queue object creation and PM4 emulation
2025-10-07 17:55:08 -04:00
ammallya 7cc026bf98 Adding release trigger (#1295)
* Adding release trigger
2025-10-07 10:43:31 -07:00
Rahul Manocha 27ec19116d SWDEV-557828 - fix hip-tests on cuda (#1152)
Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-10-07 08:28:56 -07:00
Maisam Arif 0a45a12e7a [SWDEV-558993] Fix amd-smi list to not check for groups for bdf
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I1ff9c0e00a9188435b0ee60e57c2678121dd8e72
2025-10-07 09:45:37 -05:00
Maisam Arif 1269ff4c0c [SWDEV-558993] Fix amd-smi list to not check for groups for bdf
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I1ff9c0e00a9188435b0ee60e57c2678121dd8e72


[ROCm/amdsmi commit: 0a45a12e7a]
2025-10-07 09:45:37 -05:00
Ben Richard f578f39f0a Fix web GUI displaying same section multiple times (#1267)
Some sections were being displayed multiple times in the web GUI.

Code to append the section was nested inside the subsection loop,
so each time a new subsction was appened to the section,
the entire section was appended.
2025-10-07 10:29:45 -04:00
Sam Ruscica 135c38b41c SWDEV-553436 Created wrapper functions for file read and file write (#935) 2025-10-07 09:42:22 -04:00
Gopesh Bhardwaj da457c9a43 [Documentation] rocprofv3 attach/detach (#1108)
* Fixing typo in script

* updating docs

* updating docs

* updating docs

* Update projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3-process-attachment.rst

Co-authored-by: Mark Meserve <mark.meserve@amd.com>

* Update projects/rocprofiler-sdk/source/docs/how-to/using-rocprofv3-process-attachment.rst

Co-authored-by: Mark Meserve <mark.meserve@amd.com>

---------

Co-authored-by: Mark Meserve <mark.meserve@amd.com>
2025-10-07 13:17:55 +05:30
Maisam Arif a0d59397b4 [SWDEV-558993] Fix bdf sourcing
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I0c50f490334f6de12a4c01abf1c2ed9e50d87295
2025-10-07 01:32:26 -05:00
Maisam Arif 0b16d22254 [SWDEV-558993] Fix bdf sourcing
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I0c50f490334f6de12a4c01abf1c2ed9e50d87295


[ROCm/amdsmi commit: a0d59397b4]
2025-10-07 01:32:26 -05:00
Kanangot Balakrishnan, Bindhiya 7ddd91653e [SWDEV-554046] xgmi cli redesign (#574)
Added `GPU LINK PORT STATUS` table to `amd-smi xgmi` command 
The `amd-smi xgmi -s` or `amd-smi xgmi --source-status` will show `GPU LINK PORT STATUS` table.  

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
2025-10-07 01:07:27 -05:00
Kanangot Balakrishnan, Bindhiya 693055ee50 [SWDEV-554046] xgmi cli redesign (#574)
Added `GPU LINK PORT STATUS` table to `amd-smi xgmi` command 
The `amd-smi xgmi -s` or `amd-smi xgmi --source-status` will show `GPU LINK PORT STATUS` table.  

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>

[ROCm/amdsmi commit: 7ddd91653e]
2025-10-07 01:07:27 -05:00
Pryor, Adam ce016f0dcb [SWDEV-558895] Fix rsmi_event_notification_get segfaulting (#738)
Signed-off-by: adapryor <Adam.pryor@amd.com>
2025-10-06 15:10:56 -05:00
Pryor, Adam d1679c7ade [SWDEV-558895] Fix rsmi_event_notification_get segfaulting (#738)
Signed-off-by: adapryor <Adam.pryor@amd.com>

[ROCm/amdsmi commit: ce016f0dcb]
2025-10-06 15:10:56 -05:00
Narlo, Joseph 7decbc67a1 [SWDEV-539078] Add missing API definitions to python interface (#525)
Added the following API's to amdsmi_interface.py.
	amdsmi_get_cpu_handle()
	amdsmi_get_esmi_err_msg()
	amdsmi_get_gpu_event_notification()
	amdsmi_get_processor_count_from_handles()
	amdsmi_get_processor_handles_by_type()
	amdsmi_gpu_validate_ras_eeprom()
	amdsmi_init_gpu_event_notification()
	amdsmi_set_gpu_event_notification_mask()
	amdsmi_stop_gpu_event_notification()
	amdsmi_get_gpu_busy_percent()

Added additional return value to API amdsmi_get_xgmi_plpd().
	The entry policies is added to the end of the dictionary to match API definition.
	The entry plpds is marked for deprecation as it has the same information as policies.

---------

Signed-off-by: josnarlo <Joseph.Narlo@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
2025-10-06 14:50:00 -05:00
Narlo, Joseph 6975b29c15 [SWDEV-539078] Add missing API definitions to python interface (#525)
Added the following API's to amdsmi_interface.py.
	amdsmi_get_cpu_handle()
	amdsmi_get_esmi_err_msg()
	amdsmi_get_gpu_event_notification()
	amdsmi_get_processor_count_from_handles()
	amdsmi_get_processor_handles_by_type()
	amdsmi_gpu_validate_ras_eeprom()
	amdsmi_init_gpu_event_notification()
	amdsmi_set_gpu_event_notification_mask()
	amdsmi_stop_gpu_event_notification()
	amdsmi_get_gpu_busy_percent()

Added additional return value to API amdsmi_get_xgmi_plpd().
	The entry policies is added to the end of the dictionary to match API definition.
	The entry plpds is marked for deprecation as it has the same information as policies.

---------

Signed-off-by: josnarlo <Joseph.Narlo@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>

[ROCm/amdsmi commit: 7decbc67a1]
2025-10-06 14:50:00 -05:00
Venkateshwar Reddy Kandula 952d1dabe2 [ROCProfiler-SDK][ROCR] HSA New API changes for HSA_AMD_EXT_API_TABLE_STEP_VERSION 8 (#1182)
* add new hsa ext api for version 8.

* use fmt instead of ostream.

* override rccl from therock

* Update rocprofiler-sdk-continuous_integration.yml

* Update rocprofiler-sdk-continuous_integration.yml

* Update rocprofiler-sdk-continuous_integration.yml

* enable rocr-build

* format

* disable att consecutive-kernels tests.

* Enable ROCR build in code coverage workflow

---------

Co-authored-by: Venkateshwar Reddy Kandula <venkateshwar.kandula1306@gmail.com>
2025-10-06 13:09:39 -05:00
Jason Bonnell ad78611674 rocprofiler-systems Nightly and CI on Ubuntu Jammy/Noble on MI355 and MI325 (#997)
* Initial steps added for rocprofiler-systems-continuous-integration.yml

* Add new line to end of rocprofiler-systems-continuous-integration.yml

* Fix matrix issue in rocprofiler-systems CI workflow

* Update runner to use mi355

* Remove sudo from ROCm download step

* Add Python venv

* Try to install python venv

* Add -y to pip venv install commands

* Add shell: bash to download ROCm step

* Fix issue in if statement

* Fix typo in mv command

* Fix mv command

* Update paths

* add directory in install step

* Use default runner for now while debugging setup

* Add set -e to steps

* debug build step

* Add amdgpu install step

* remove working-directory from amdgpu install step

* add path/ld lib path, add -S argument to run-ci.py

* Fix typo in DCMAKE_PREFIX_PATH

* Add DGPU_TARGETS to run-ci.py command

* add Docker options, remove GPU_TARGETS

* Install amd-smi-lib

* Add DCMAKE_BUILD_TYPE, update path

* Remove mkdir

* Add build dynist cmake arguments

* Update cmake arguments again

* Add missing \ to run-ci.py command

* add libdw dependency

* Add later install step

* Increase timeout of configure/build/test step

* use 16 jobs to try and speed up pipeline time

* Add GHCR image, remove TheRock tarball download step, minor changes for debugging

* Add credentials to container portion of step

* Add package read permissions to ubuntu step

* Update tarball name

* Increase jobs to 16, disable some tests for now due to timeouts

* Modify to only include gpu tests

* Fix configuration

* Enable MPI on run-ci.py run

* Add install MPI step, changed tests to be run

* Enable OMPI flags, enable network counter access

* Use new Docker image names, add privileged option to Docker

* Change cmake build type

* Add fail-fast false option for CI

* Update ROCM_VERSION variable to reflect docker changes

* Specify TARBALL_ROCM_VERSION as separate

* Add MI325 to debug pipeline errors

* Move location of env variables

* Only test on jammy for now, run all tests to assess other issues

* test with branch that contains fix for openmp

* Exclude "ompvv"

We will re-add one ticket is fixed.

* Test: Disable USE_MPI

* Replace TheRock ROCm install with rocm-dev for now

* Try out MI355 noble and MI325 for jammy/noble

* Update amdgpu step to support different ROCm versions

* Remove unused env variables

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-06 11:40:58 -04:00
ggottipa-amd c8ab57fe15 correcting typo. (#1222)
fixes SWDEV-557963.
2025-10-06 21:04:55 +05:30
systems-assistant[bot] 774cb67314 SWDEV-489106 - Hip Tests for Linker APIs (#578)
1) Test linking of SPIRV bundled and unbundled code object in runtime
2) Negative Param test for hipLinkAddData API

Change-Id: I7c8167f6d862f5b23f9532f69b6da4fc50e96dcd

Co-authored-by: Rahul Manocha <rmanocha@amd.com>
2025-10-06 08:34:33 -07:00
dependabot[bot] faf0024135 Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-10-06 09:17:33 -05:00
dependabot[bot] 8104a48f8e Bump rocm-docs-core[api_reference] from 1.25.0 to 1.26.0 in /docs/sphinx
Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.25.0 to 1.26.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/v1.26.0/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.25.0...v1.26.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core[api_reference]
  dependency-version: 1.26.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

[ROCm/amdsmi commit: faf0024135]
2025-10-06 09:17:33 -05:00
swargamrambabu e7e38d87f7 SWDEV-546350 - [catch2][dtest] Test cases for hipMemPrefetchAsync_v2 and hipMemAdvise_v2 (#664)
* SWDEV-546350 - [catch2][dtest] Test cases for hipMemPrefetchAsync_v2 and hipMemAdvice_v2

* SWDEV-546350 - Enable tests for NVIDIA, Guard failing tests

* SWDEV-546350 - Add checks for Managed Memory Support

* SWDEV-546350 - Gaurded Numa related things against windows

* SWDEV-546350 - Removed some scenarios which needs fixes, gaurded for NVIDIA

* SWDEV-546350 - Incorporated review comments

* SWDEV-546350 - Corrected File name

* SWDEV-546350 - Resetted to default device, modifed initial data filling ways

---------

Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-10-06 16:59:21 +05:30
Jaydeep 98d6d268a0 SWDEV-556588 - Handle graph node set params and disabled nodes for AQL packet batching. (#1099) 2025-10-06 13:26:12 +05:30
ajanicijamd 02883c3d8d Fixed openmp-vv tests (#1203)
* LD_LIBRARY_PATH was being overridden so tool's libraries could not be found.
2025-10-03 21:33:02 -04:00
Milan Radosavljevic 273919460c Find and include python libs in LD_LIBRARY_PATH for rocprof-sys-python (#1224) 2025-10-03 16:19:16 -04:00
Jason Bonnell f0fd2797b6 Add rocm-version 7.0 to rocprofiler-systems workflows (#1139)
* Adding rocm 7.0 to Ubuntu, Red Hat, and Debian workflows

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-03 13:16:21 -04:00
vedithal-amd 4870b2b881 Fix tests (#1213) 2025-10-03 09:52:38 -07:00
systems-assistant[bot] 3a9bf2e9f6 SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api (#525)
* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api

* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api

* SWDEV-546351 - Added test cases for hipGetDriverEntryPoint api

* SWDEV-546351 : Added test cases for hipGetDriverEntryPoint api

* addressed review comments Added non-zero check

---------

Co-authored-by: Anavena Venkatesh <Anavena.Venkatesh@amd.com>
Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-10-03 14:12:16 +05:30
Kian Cossettini edfda63701 Remove OMPT category and fix certain preprocessor checks (#1165)
* Part 1: Remove OMPT Category
* Part 2: Properly remove backend choices
* Part 3: Ensure preprocessor checks if user defined var to OFF
2025-10-02 21:08:18 -04:00
David Galiffi c0f8627e7f Update CI Docker files (#1202)
- Add `nlohmann-json-dev` (or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu.
- Add `gmock-dev` and `gtest-dev` (or equivalent) to CI Docker images for RHEL, SUSE, and Ubuntu.
- Add `--set solver classic` to conda config to resolve an issue setting up the conda environment
- Fix Perfetto package installation on ubuntu noble image.
- Add a check and log error if pip installation fail 

---------

Co-authored-by: jbonnell-amd <jason.bonnell@amd.com>
2025-10-02 21:06:01 -04:00
cfreeamd fb8ab442b6 rocr: Don't assert in hsa_shut_down when no agents (#1115)
* rocr: Don't assert in hsa_shut_down when no agents

Instead, print error message and return an error. Prior to
this patch, the assertion would occur when hsa_shut_down() is
called more than once.

* rocr: Reorder Unload  ASAN clean-up on shut down
2025-10-02 17:20:53 -07:00
cfreeamd 402aa7e253 rocr: Support batching in InterceptQueue store (#1194)
* rocr: Support batching in InterceptQueue store

* Fix comment, loop bounds
2025-10-02 10:37:40 -07:00
Pryor, Adam c967aead58 [SWDEV-525336] Use KFD to determine process start/stop (#723)
* Used KFD to determine linking between GPUs and PIDs rather than depend on fdinfo's per pid single gpu bdf info that we were getting.

Signed-off-by: adapryor <Adam.pryor@amd.com>

---------

Signed-off-by: adapryor <Adam.pryor@amd.com>
Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>
2025-10-02 10:57:08 -05:00
Pryor, Adam 8bc7216a65 [SWDEV-525336] Use KFD to determine process start/stop (#723)
* Used KFD to determine linking between GPUs and PIDs rather than depend on fdinfo's per pid single gpu bdf info that we were getting.

Signed-off-by: adapryor <Adam.pryor@amd.com>

---------

Signed-off-by: adapryor <Adam.pryor@amd.com>
Signed-off-by: Arif, Maisam <Maisam.Arif@amd.com>

[ROCm/amdsmi commit: c967aead58]
2025-10-02 10:57:08 -05:00
cfreeamd 55feeefcff Revert "rocr: Remove QueueProxy (#700)" (#1167)
This reverts commit c34c9826c3,
which was causing test failures.
2025-10-01 18:24:43 -07:00
Narlo, Joseph b1eeff9992 Add ASIC and Board information (#721)
Signed-off-by: josnarlo <Joseph.Narlo@amd.com>
2025-10-01 17:39:26 -05:00
Narlo, Joseph 098aa488aa Add ASIC and Board information (#721)
Signed-off-by: josnarlo <Joseph.Narlo@amd.com>

[ROCm/amdsmi commit: b1eeff9992]
2025-10-01 17:39:26 -05:00
Pryor, Adam 5ef0b3c34d [SWDEV-547088] Dynamic GPU Metrics Implementation (#692)
* Added ability to format gpu_metrics v1_9
* New gpu_metrics format from the driver should allow amd-smi to parse with future compatibility guaranteed

---------

Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
Signed-off-by: adapryor <Adam.pryor@amd.com>
Co-authored-by: Oliveira, Daniel <daniel.oliveira@amd.com>
2025-10-01 15:46:10 -05:00
Pryor, Adam 94e6ba68b4 [SWDEV-547088] Dynamic GPU Metrics Implementation (#692)
* Added ability to format gpu_metrics v1_9
* New gpu_metrics format from the driver should allow amd-smi to parse with future compatibility guaranteed

---------

Signed-off-by: Oliveira, Daniel <daniel.oliveira@amd.com>
Signed-off-by: adapryor <Adam.pryor@amd.com>
Co-authored-by: Oliveira, Daniel <daniel.oliveira@amd.com>

[ROCm/amdsmi commit: 5ef0b3c34d]
2025-10-01 15:46:10 -05:00
ammallya 8751d58616 Adding missed linux skip (#1197) 2025-10-01 10:37:47 -07:00
ammallya f7dba2eb5c Adding skip to docs paths (#1196) 2025-10-01 09:57:44 -07:00
habajpai-amd 74fc268a32 Add libomptarget discovery to prevent OpenMP/HIP segfaults (#1043)
This PR fixes a segmentation fault seen when running rocprof-sys-sample with multi-process OpenMP/HIP applications.
The crash was caused by missing libomptarget.so on the runtime loader path or incorrect LD_PRELOAD settings.

Fixes SWDEV-552804

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-10-01 09:51:26 -04:00
Justin Williams b727fe1f8b Adjust the amdsmitst.exclude file to blacklist the partition tests for non-MI300+ asics
Signed-off-by: Justin Williams <Justin.Williams@amd.com>
2025-10-01 08:36:42 -05:00
Justin Williams 33ff308c20 Adjust the amdsmitst.exclude file to blacklist the partition tests for non-MI300+ asics
Signed-off-by: Justin Williams <Justin.Williams@amd.com>


[ROCm/amdsmi commit: b727fe1f8b]
2025-10-01 08:36:42 -05:00
Geo Min 36a1fd87af Removing landed patch (#1184) 2025-09-30 16:51:41 -07:00
Geo Min b0a9a2386f [ci] Adding TheRock CI coverage for rocm-core (#868)
* TheRock CI points to rocm systems

* Fixing depth

* Fixing cache path

* Adding core components

* Adding more packages

* try this for windows building

* Add math libs

* Adding core only

* Attempt with no ccache

* adding patching

* Adding ls test

* adding this

* removing ls test

* changing dir name

* Adding cleanup for patch

* Adding ref

* adding correct no include

* Adding new temp branch for testing

* empty commit

* empty commit

* Adding commit hash bump

* Adding new hash for removed patches

* Adding TheRock submodule bump

* trying with compiler removed test

* Try dvc pull windows

* Update .github/workflows/therock-ci-linux.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

* Adding correct env

* revert to ../

* Adding path

* try new var

* Adding new branch

* Adding correct hash

* Update .github/workflows/therock-ci-linux.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

* Update .github/workflows/therock-ci-windows.yml

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>

---------

Co-authored-by: Marius Brehler <marius.brehler@gmail.com>
2025-09-30 16:08:50 -07:00
Marius Brehler 026a4e82a3 Rollup of build changes needed for compat with TheRock. (#1086)
* Rollup of build changes needed for compat with TheRock.
* When built for a non-default ROCM location, the HIP headers can't be found by a few targets.
* Uses pkg_check for DRM libraries like ROCR-Runtime does (which avoids accidental fallback to system versions).
* Robust fix for nolink targets
* nolink targets essentially exist for include directories
* all nolink targets are automatically added to rocprofiler-sdk-headers with a $<BUILD_INTERFACE:...> generator expression
* Re-add previously used mechanism to find drm libs

---------

Co-authored-by: Marius Brehler <marius.brehler@amd.com>
Co-authored-by: Stella Laurenzo <stellaraccident@gmail.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-09-30 18:39:10 -04:00
Jin Jung c6d44b47d4 Fix VulkanTest::CreateMappedStorage _WIN64 segfault (#1173)
* Fix VulkanTest::CreateMappedStorage _WIN64 segfault

* Fix Indentation
2025-09-30 14:52:05 -07:00