Commit Graph

68454 Commits

Author SHA1 Message Date
Madsen, Jonathan 91f7f42104 [SDK] Update finalization and correlation ID retirement (#281)
* Update finalization and correlation ID retirement

- directly invoke finalize if only one client
- correlation_id_finalize

* Address PR comments

* Improve logging for correlation_id_finalize

* Fix correlation ID handling in memory allocation service

* Fix clang-tidy issues in hsa-memory-allocation test exe

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-03-20 16:59:23 -05:00
Baraldi, Giovanni 5c782d91b9 Fix for ATT codeobj table initialization (#290)
* Fix for codeobj HSA table order

* Fix tests

* Format

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>

[ROCm/rocprofiler-sdk commit: b21452ec11]
2025-03-20 14:27:46 -07:00
Baraldi, Giovanni b21452ec11 Fix for ATT codeobj table initialization (#290)
* Fix for codeobj HSA table order

* Fix tests

* Format

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2025-03-20 14:27:46 -07:00
Srihari Uttanur b2c0f91aef Add perfetto support for counter collection
Fix endtimestamp for counter tracks

Add fix for rocprofv3 counter collection tests

Fix formats and refactors

Added docs and addressed review comments

Address more review comments.


[ROCm/rocprofiler-sdk commit: c9ca876b79]
2025-03-21 01:41:19 +05:30
Srihari Uttanur c9ca876b79 Add perfetto support for counter collection
Fix endtimestamp for counter tracks

Add fix for rocprofv3 counter collection tests

Fix formats and refactors

Added docs and addressed review comments

Address more review comments.
2025-03-21 01:41:19 +05:30
David Galiffi 05171e08d4 Add extra validation to the openmp target ctest (#141)
Update openmp-target ctest.

- Add a validation step to check the proto file for the offloaded kernel name

- Update the validation script to add an option to validate a substring of the perfetto label rather than an exact match.



[ROCm/rocprofiler-systems commit: 9b7d70fcc8]
2025-03-20 15:18:25 -04:00
David Galiffi 9b7d70fcc8 Add extra validation to the openmp target ctest (#141)
Update openmp-target ctest.

- Add a validation step to check the proto file for the offloaded kernel name

- Update the validation script to add an option to validate a substring of the perfetto label rather than an exact match.
2025-03-20 15:18:25 -04:00
Bhardwaj, Gopesh 705a2adbd3 [CI] Disable OpenMP test for sanitizers (#296)
* Disable openmp test for sanitizers

* fixing review feedback

[ROCm/rocprofiler-sdk commit: 4dcb239872]
2025-03-20 13:56:14 -05:00
Bhardwaj, Gopesh 4dcb239872 [CI] Disable OpenMP test for sanitizers (#296)
* Disable openmp test for sanitizers

* fixing review feedback
2025-03-20 13:56:14 -05:00
David Galiffi e8fae1399f Update CHANGELOG.md (#142)
* Update CHANGELOG.md


[ROCm/rocprofiler-systems commit: 9c6be7433a]
2025-03-20 12:33:48 -04:00
David Galiffi 9c6be7433a Update CHANGELOG.md (#142)
* Update CHANGELOG.md
2025-03-20 12:33:48 -04:00
Bhardwaj, Gopesh b3a603279b changing markdown to rst format (#259)
* changing markdown extension to rst extension

* updating callback services

* updating all services, ssamples and installtion

* Fix build

* More fixes

* more fixes

* minor fixes

* more fixes

* merging changes for SWDEV-510794 from pr 227

[ROCm/rocprofiler-sdk commit: 4735196fe4]
2025-03-20 11:09:53 -05:00
Bhardwaj, Gopesh 4735196fe4 changing markdown to rst format (#259)
* changing markdown extension to rst extension

* updating callback services

* updating all services, ssamples and installtion

* Fix build

* More fixes

* more fixes

* minor fixes

* more fixes

* merging changes for SWDEV-510794 from pr 227
2025-03-20 11:09:53 -05:00
Adel Johar d8d27d4fd6 Docs: Add more variables to env_variables.rst 2025-03-20 11:59:58 -04:00
Adel Johar 6195f65f9e Docs: Add more variables to env_variables.rst
[ROCm/ROCR-Runtime commit: d8d27d4fd6]
2025-03-20 11:59:58 -04:00
Madsen, Jonathan e744f11c2c [rocprofiler-sdk-att] Minor cmake update (#283)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>

[ROCm/rocprofiler-sdk commit: bcc15a28d0]
2025-03-20 10:57:35 -05:00
Madsen, Jonathan bcc15a28d0 [rocprofiler-sdk-att] Minor cmake update (#283)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-03-20 10:57:35 -05:00
Gupta, Maneesh 3217d8a78d Update CODEOWNERS (#3)
[ROCm/hipother commit: a00c8186c0]
2025-03-20 15:47:52 +05:30
Gupta, Maneesh a00c8186c0 Update CODEOWNERS (#3) 2025-03-20 15:47:52 +05:30
Gupta, Maneesh c9dd70dc06 Update CODEOWNERS (#34)
[ROCm/hip-tests commit: 2832b7431c]
2025-03-20 15:45:31 +05:30
Gupta, Maneesh 2832b7431c Update CODEOWNERS (#34) 2025-03-20 15:45:31 +05:30
Gupta, Maneesh 958e29a802 Update CODEOWNERS (#33)
[ROCm/hip commit: 1ef644f3d6]
2025-03-20 15:43:57 +05:30
Gupta, Maneesh 1ef644f3d6 Update CODEOWNERS (#33) 2025-03-20 15:43:57 +05:30
Gupta, Maneesh 781da97ff6 Update CODEOWNERS (#77)
[ROCm/clr commit: d9abcdd999]
2025-03-20 15:40:50 +05:30
Gupta, Maneesh d9abcdd999 Update CODEOWNERS (#77) 2025-03-20 15:40:50 +05:30
Lang Yu 89926f5b0b rocrtst: fix rocrtst.Test_Example
VerifyResult always returns true. That's not expected.

Signed-off-by: Lang Yu <lang.yu@amd.com>
2025-03-20 12:57:52 +08:00
Lang Yu cd239c7bcf rocrtst: fix rocrtst.Test_Example
VerifyResult always returns true. That's not expected.

Signed-off-by: Lang Yu <lang.yu@amd.com>


[ROCm/ROCR-Runtime commit: 89926f5b0b]
2025-03-20 12:57:52 +08:00
Galantsev, Dmitrii 4a3c70136f Make amdsmi_get_power_info backwards compatible
Change-Id: Ie5b4c35265827e78934caa94c142d31efce597e4
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-03-19 23:23:48 -05:00
Galantsev, Dmitrii 633d2a8890 Make amdsmi_get_power_info backwards compatible
Change-Id: Ie5b4c35265827e78934caa94c142d31efce597e4
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/amdsmi commit: 4a3c70136f]
2025-03-19 23:23:48 -05:00
Galantsev, Dmitrii 929041b556 Fix amdsmi_get_power_info API
This change creates a workaround for a broken C api in amdsmi.

amdsmi_get_power_info API is broken in rocm 6.4.0 (amdsmi 25.2) and is fixed
in rocm 6.4.1 (amdsmi 25.3).

Breaking AMDSMI change:
https://github.com/ROCm/amdsmi/commit/dc4a16da6fb45d581a6e23c78d340172989418a0

Change-Id: Ib45a2702aa722c7735f3ccd1081d8f62e4d34216
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-03-19 23:12:45 -05:00
Galantsev, Dmitrii 791fa376e9 Fix amdsmi_get_power_info API
This change creates a workaround for a broken C api in amdsmi.

amdsmi_get_power_info API is broken in rocm 6.4.0 (amdsmi 25.2) and is fixed
in rocm 6.4.1 (amdsmi 25.3).

Breaking AMDSMI change:
https://github.com/ROCm/amdsmi/commit/dc4a16da6fb45d581a6e23c78d340172989418a0

Change-Id: Ib45a2702aa722c7735f3ccd1081d8f62e4d34216
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>


[ROCm/rdc commit: 929041b556]
2025-03-19 23:12:45 -05:00
Kiss, Istvan e60263a55a SWDEV-514685 - Update documentation 2025-02-11 (#25)
Co-authored-by: Istvan Kiss <neon60@gmail.com>

[ROCm/hip commit: 69becfc7a8]
2025-03-19 22:04:47 +01:00
Kiss, Istvan 69becfc7a8 SWDEV-514685 - Update documentation 2025-02-11 (#25)
Co-authored-by: Istvan Kiss <neon60@gmail.com>
2025-03-19 22:04:47 +01:00
vedithal-amd 77ffa73e5b Update default PR reviewers (#617)
[ROCm/rocprofiler-compute commit: 40ad99eae1]
2025-03-19 16:00:28 -04:00
vedithal-amd 40ad99eae1 Update default PR reviewers (#617) 2025-03-19 16:00:28 -04:00
ajanicijamd df729548d0 Fix a RCCL initialization to avoid a deadlock (#136)
Also fixes: 

- crash while finalizing rocprof-sys-causal

[ROCm/rocprofiler-systems commit: 26bb604215]
2025-03-19 14:48:04 -04:00
ajanicijamd 26bb604215 Fix a RCCL initialization to avoid a deadlock (#136)
Also fixes: 

- crash while finalizing rocprof-sys-causal
2025-03-19 14:48:04 -04:00
Shweta Khatri 2ae70735e8 rocr: Fix PcSamplingCreateFromId to pass 32-bit dword count to DmaFill
In PcSamplingCreateFromId, convert number of bytes into number of
dwords because DmaFill expects a count of 32-bit words, not raw bytes.
This prevents OOB writes on large sampling buffers.
2025-03-19 14:42:41 -04:00
Shweta Khatri b570f22aca rocr: Fix PcSamplingCreateFromId to pass 32-bit dword count to DmaFill
In PcSamplingCreateFromId, convert number of bytes into number of
dwords because DmaFill expects a count of 32-bit words, not raw bytes.
This prevents OOB writes on large sampling buffers.


[ROCm/ROCR-Runtime commit: 2ae70735e8]
2025-03-19 14:42:41 -04:00
Lao, Darren cd4d236185 rocr: Change ISA grid dimensions
Signed-off-by: Lao, Darren <Darren.Lao@amd.com>
2025-03-19 13:44:17 -04:00
Lao, Darren c03e4cfe4d rocr: Change ISA grid dimensions
Signed-off-by: Lao, Darren <Darren.Lao@amd.com>

[ROCm/ROCR-Runtime commit: cd4d236185]
2025-03-19 13:44:17 -04:00
Arandjelovic, Marko cc5124241b Revert SWDEV-512344 - Unmap all subbuffers (#26)
This reverts commit 0b69120cfcb5b4689d9f2037b1a01e274d85c20f.

[ROCm/clr commit: e7ada4effe]
2025-03-19 21:17:36 +05:30
Arandjelovic, Marko e7ada4effe Revert SWDEV-512344 - Unmap all subbuffers (#26)
This reverts commit 0b69120cfcb5b4689d9f2037b1a01e274d85c20f.
2025-03-19 21:17:36 +05:30
Godavarthy Surya, Anusha 35a15ca3b2 Revert "SWDEV-492049 - Remove the handle of Phy Mem from Memobj" (#72)
This reverts commit dabe311bd8.

[ROCm/clr commit: 2259a8c01c]
2025-03-19 21:16:51 +05:30
Godavarthy Surya, Anusha 2259a8c01c Revert "SWDEV-492049 - Remove the handle of Phy Mem from Memobj" (#72)
This reverts commit 231b2410a0.
2025-03-19 21:16:51 +05:30
Castillo, Juan 7c882b2f69 SWDEV-518209: GPU Metrics 1.8 (#177)
- Updates:
    - Adding the following metrics to allow new calculations for violation status:
        - Per XCP metrics gfx_below_host_limit_ppt_acc
        - Per XCP metrics gfx_below_host_limit_thm_acc
        - Per XCP metrics gfx_low_utilization_acc
        - Per XCP metrics gfx_below_host_limit_total_acc
    - Increasing available JPEG engines to 40. Current ASICs may not support all 40. These will be indicated as UINT16_MAX or N/A in CLI.

Signed-off-by: Juan Castillo <juan.castillo@amd.com>
Co-authored-by: Charis Poag <Charis.Poag@amd.com>
2025-03-19 10:24:02 -05:00
Castillo, Juan fff2d21baf SWDEV-518209: GPU Metrics 1.8 (#177)
- Updates:
    - Adding the following metrics to allow new calculations for violation status:
        - Per XCP metrics gfx_below_host_limit_ppt_acc
        - Per XCP metrics gfx_below_host_limit_thm_acc
        - Per XCP metrics gfx_low_utilization_acc
        - Per XCP metrics gfx_below_host_limit_total_acc
    - Increasing available JPEG engines to 40. Current ASICs may not support all 40. These will be indicated as UINT16_MAX or N/A in CLI.

Signed-off-by: Juan Castillo <juan.castillo@amd.com>
Co-authored-by: Charis Poag <Charis.Poag@amd.com>

[ROCm/amdsmi commit: 7c882b2f69]
2025-03-19 10:24:02 -05:00
Andryeyev, German 5c7c86f66d SWDEV-517481 - Add dynamic queue management (#37)
Enabled by defaulty. DEBUG_HIP_DYNAMIC_QUEUES controls the feature

[ROCm/clr commit: 28967982b2]
2025-03-19 11:22:50 -04:00
Andryeyev, German 28967982b2 SWDEV-517481 - Add dynamic queue management (#37)
Enabled by defaulty. DEBUG_HIP_DYNAMIC_QUEUES controls the feature
2025-03-19 11:22:50 -04:00
Brzak, Branislav ee0e2af0e1 SWDEV-516564 - SWDEV-512817 - Remove mentions of gfx940 and gfx941 (#30)
[ROCm/hip-tests commit: 902988494e]
2025-03-19 15:42:18 +01:00