Commit gráf

975 Commit-ok

Szerző SHA1 Üzenet Dátum
Siu Chi Chan 1436897785 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back


[ROCm/clr commit: 3cf2d7d385]
2019-08-08 08:33:04 +00:00
Rahul Garg 6641c0dc94 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error


[ROCm/clr commit: 8b6317d041]
2019-08-08 08:27:41 +00:00
Alex Voicu a59924ae98 Fix hip_throw. (#1285)
* Fix hip_throw.

* Fix typo

* No, really fix typo


[ROCm/clr commit: e24df75cc1]
2019-08-05 09:52:22 +00:00
Jeff Daily 68f674205e consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor


[ROCm/clr commit: f337ae1edb]
2019-08-05 09:51:02 +00:00
Maneesh Gupta f36dced5d7 Merge pull request #1278 from gargrahul/fix_hipfuncGetAttribute_logstatus
Fix missing logstatus in hipFuncGetAttributes

[ROCm/clr commit: a489877153]
2019-08-02 10:00:38 +00:00
wkwchau 7b0f478767 Added CooperativeLaunch and CooperativeMultiDeviceLaunch flag and property for hipDeviceGetAttribute() and hipGetDeviceProperties() (#1247)
[ROCm/clr commit: ed04e96e2d]
2019-08-02 10:00:25 +00:00
Rahul Garg b064d7cab2 Fix missing logstatus in hipFuncGetAttributes
[ROCm/clr commit: 20e9aba94e]
2019-08-02 11:51:34 +05:30
wkwchau 75f1bb21b3 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases


[ROCm/clr commit: abe6776677]
2019-08-01 16:03:35 +00:00
Maneesh Gupta 60210d987c Merge pull request #1243 from jeffdaily/master-stream-lock-fix
remove stream locks where it is safe to do so

[ROCm/clr commit: 3de3f57468]
2019-08-01 08:59:13 +00:00
wkwchau a19b4fbd8b Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()


[ROCm/clr commit: 7b9801fe9a]
2019-08-01 08:58:48 +00:00
Maneesh Gupta b297398add Merge pull request #1269 from gargrahul/fix_ptr_attr_unkonwn_to_invalid
hipPointerGetAttributes- Change hipErrorUnknown to hipErrorInvalidValue

[ROCm/clr commit: e0397d3d1f]
2019-07-31 15:43:06 +00:00
Rahul Garg f9eaac9561 Add hip init in hipExtLaunchMultiKernelMultiDevice (#1263)
* Add hip init in hipExtLaunchMultiKernelMultiDevice

* Add more logstatus for multiple return paths

* Fix missing i in function name


[ROCm/clr commit: 8df47255c5]
2019-07-31 15:42:29 +00:00
Rahul Garg 3b5dac1d9d Add HIP init in hipFuncGetAttributes (#1262)
* Add HIP init in hipFuncGetAttributes

* [dtest]Remove explicit hip init call in hipFuncGetAttributes dtest


[ROCm/clr commit: c610159b85]
2019-07-31 15:42:08 +00:00
Rahul Garg 7a21d085ad Change hipErrorUnknown to hipErrorInvalidValue
[ROCm/clr commit: 1c49943ac3]
2019-07-31 00:28:30 +05:30
Jeff Daily df457ce2bd remove stream locks where it is safe to do so
[ROCm/clr commit: 734c4b92c3]
2019-07-22 17:38:51 +00:00
cdevadas 35f0fb2916 Increased the number of implicit-kernarg bytes to 56 (#1217)
[ROCm/clr commit: fc0aca2a7d]
2019-07-19 04:45:34 +00:00
wkwchau d20537e595 Fixed bug of determine max block size in hipOccupancyMaxPotentialBlockSize (#1235)
[ROCm/clr commit: 6ec476e50a]
2019-07-18 03:19:29 +00:00
ansurya 8b8946f78b Add Max Texture 1D,2D,3D device properties (#1226)
* Add Max Texture 1D,2D,3D device properties

* Corrected testcase to use enums defined in hipDeviceAttribute_t

* Added texture 1D,2D and 3D support for NVIDIA path


[ROCm/clr commit: 00aa42e05f]
2019-07-18 03:18:50 +00:00
Rahul Garg d92afe2277 Fix HIP_VISIBLE_DEVICES order (#1184)
* Fix HIP_VISIBLE_DEVICES order

* Fix device IDs mismatch

* Fix review comments- loop order and device range check

* Handle incomplete VISIBLE device env variable

* Revert "Handle incomplete VISIBLE device env variable"


[ROCm/clr commit: d2e8cdc8fb]
2019-07-18 03:18:04 +00:00
Aryan Salmanpour a4992850d8 [hip] fix a bug where we parse kernel's arguments layout for a given kernel multiple times (#1232)
[ROCm/clr commit: 8b90a5d274]
2019-07-17 07:29:07 +00:00
Evgeny Mankov 24af494e97 [HIP] Fix segfault on uninitialized struct members in hipArrayCreate and hipArray3DCreate
[ROCm/clr commit: 299fbd4842]
2019-07-12 16:38:26 +03:00
Evgeny Mankov b5f0cdaa7b [HIP][HIPIFY] Split HIP_ARRAY_DESCRIPTOR struct to HIP_ARRAY_DESCRIPTOR and HIP_ARRAY3D_DESCRIPTOR
[Reason] To be compatible with CUDA [#1133]

Update HIP code, hipify-clang, tests and docs

[TODO] Add support of the corresponding functions on nvcc fallback path


[ROCm/clr commit: f0832fd968]
2019-07-11 14:58:16 +03:00
Jatin Chaudhary 6e8edf8890 Adding bounds check before hipMemset (#1190)
* Adding bounds check in ihipMemset

* Adding ihipMemPtrGetInfo to hipMemPtrGetInfo


[ROCm/clr commit: fcb0a3d4e2]
2019-07-08 11:00:38 +00:00
Aryan Salmanpour 4b06a21504 [hip] Move _criticalData of ihipStream_t class to private section and use criticalData() to access it (#1177)
[ROCm/clr commit: 7e48231252]
2019-07-04 00:42:19 +00:00
Maneesh Gupta 154b861905 Added missing NULL checks and corrected API return values (#1188)
* Added missing NULL checks and corrected API return values as per validation

* Added missing NULL checks


[ROCm/clr commit: a220a8e8e9]
2019-07-03 08:51:39 +00:00
Anusha Godavarthy Surya 27722855b4 Added missing NULL checks
[ROCm/clr commit: 1a7c7e3b06]
2019-06-27 20:19:30 +05:30
Anusha Godavarthy Surya e643bae27d Added missing NULL checks and corrected API return values as per validation
[ROCm/clr commit: 4989452413]
2019-06-27 00:19:05 +05:30
wkwchau 7662c1a650 Fixed bug in hipOccupancyMaxPotentialBlockSize for the SGPRs limitation of gfx8 devices (#1176)
[ROCm/clr commit: 3742f24477]
2019-06-26 15:18:00 +05:30
Aaron Enye Shi 553caedb5c Fix dlpi_name info empty when using GCC on ub18 (#1181)
This fixes a bug where GCC++ on Ubuntu 18.04 creates failing executables compared to GCC++ on 16.04 and clang++. While creating function names on Ubuntu 18.04, dl_phdr_info seems to provide a non-zero value for dlpi_addr on initial iteration, and an empty string in dlpi_name. This is causing failure when linking with g++, since the empty string prevents the kernel function from being loaded. Clang++ and GCC on UB16 provide a zero value for dlpi_addr. To fix this, we need to verify both addr and name exists, so that /proc/self/exe can be properly loaded.

[ROCm/clr commit: f87b900f96]
2019-06-25 06:32:29 +05:30
Aryan Salmanpour 362445220a [hip] implement the hipExtLaunchMultiKernelMultiDevice API (#1165)
* [hip] implement the hipExtLaunchMultiKernelMultiDevice API

* add a guard to check the HCC version for acquire_locked_hsa_queue() API which was introdued in HCC for ROCm 2.5

* modified code based on the requested changes

* changes to lock all streams before launching kernels for each device and unlock them after the dispatches

* check each stream to be valid before starting to lock all the streams


[ROCm/clr commit: d6ad690cb6]
2019-06-20 05:59:05 +05:30
wkwchau 81b5ea1c4a Implement the hipOccupancyMaxPotentialBlockSize function (#1162)
* Implement the hipOccupancyMaxPotentialBlockSize function

* Replaced hipGetDeviceProperties() call by ihipGetDeviceProperties() in ihipOccupancyMaxPotentialBlockSize()

* Add test for hipOccupancyMaxPotentialBlockSize in Module API

* Added extern declaration for ihipGetDeviceProperties() to be accessed inside ihipOccupancyMaxPotentialBlockSize()

* fixed hipOccupancyMaxPotentialBlockSize test build issue

* Fix hipOccupancyMaxPotentialBlockSize dtest

* Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest

* Revert "Add BUILD_CMD in hipOccupancyMaxPotentialBlockSize dtest"

This reverts commit 0480ff56f1441fc515d2c26ce33783e303423938.

* Disable hipOccupancyMaxPotentialBlockSize dtest on NVCC

* move extern declaration of ihipGetDeviceProperties to hip_module.cpp

* Update the limiation of 32 wavefronts per CU and 800/512 SGPRs for VI/pre-VI chips to calculate the occupancy


[ROCm/clr commit: 28c34ead70]
2019-06-20 05:58:29 +05:30
Maneesh Gupta 0b3f5d4524 Merge pull request #1167 from eshcherb/hip_prof_refactoring_190611
prof layer includes refactoring

[ROCm/clr commit: 3b3118d459]
2019-06-19 13:36:33 +05:30
Rahul Garg effbc8b212 HACK for SWDEV-173477/SWDEV-190701
[ROCm/clr commit: 107734f7ad]
2019-06-13 18:15:31 -07:00
Evgeny 214c01e6bf prof layer includes refactoring
[ROCm/clr commit: c6600ba26b]
2019-06-11 20:13:29 -05:00
Maneesh Gupta b4fb2b0ab4 Merge pull request #1140 from scchan/program_state_stage_2-rebase-20190524
migrate more program_state logic from header into shared library (phase II)

[ROCm/clr commit: 1d5d923d36]
2019-06-05 16:09:01 +05:30
Maneesh Gupta 3d6944e0db Merge branch 'master' into implicit-kernarg
[ROCm/clr commit: d4fa74ff09]
2019-06-04 13:24:19 +05:30
Maneesh Gupta 1a9326b2dd Merge pull request #1155 from gargrahul/fix_kernel_lp_dim_trace
Fix wrong grid dim shown in trace

[ROCm/clr commit: 40a09318e4]
2019-06-04 13:21:39 +05:30
Maneesh Gupta 9f35c7bf43 Merge pull request #1130 from lmoriche/master
Add support for code object v3

[ROCm/clr commit: 4b3d59a93e]
2019-06-04 13:20:52 +05:30
cdevadas 8de283ef77 Runtime changes to append implicit kernel arguments.
Appended 48 empty bytes to the kernarg area at runtime. The implicit arguments are enabled primarily for the hostcall services
and it is completely abstracted from the user code. Enabled it for both hip-clang and hip-hcc.


[ROCm/clr commit: 214ec53da3]
2019-06-04 10:45:49 +05:30
Rahul Garg a8de3fafba Fix wrong grid dim shown in trace
[ROCm/clr commit: 7a2e3b6a1c]
2019-05-31 22:30:24 +05:30
Siu Chi Chan bafd29662c replace std::vector for kernarg
[ROCm/clr commit: 1fb9ab2d44]
2019-05-24 17:27:43 -04:00
Siu Chi Chan 304a1e2dbe move executable_cache into program_state.cpp
[ROCm/clr commit: 1a2d332e76]
2019-05-24 17:27:25 -04:00
Siu Chi Chan 305eb4239e remove executables() from program_state
[ROCm/clr commit: e2c0122892]
2019-05-24 17:27:01 -04:00
Siu Chi Chan 0cae3e06c1 moving agent_globals_impl into hip_module
[ROCm/clr commit: 6852be819f]
2019-05-24 16:43:38 -04:00
Laurent Morichetti 4c402ccfaf Add support for code object v3
Use the code object manager library to parse the code object metadata. Both
code object v2 and v3 formats are now supported for HCC generated binaries.


[ROCm/clr commit: de89102528]
2019-05-23 18:03:32 -07:00
Evgeny Mankov 204043c6e0 [HIP][HIPIFY] Make hipMemcpyParam2D coherent with cuMemcpy2D
+ Makes hip_Memcpy2D struct compatible with CUDA_MEMCPY2D struct
+ Add hipMemcpyParam2D support in nvcc fallback path
+ Update hipify-clang, tests and docs accordingly


[ROCm/clr commit: 9cb3e9aa5e]
2019-05-22 18:31:39 +03:00
Alex Voicu a4a3132c64 Add HIPRTC, glorious ersatz for NVRTC (#1097)
* Add ersatz for NVRTC.

* Fix extraneous paren and use correct namespace.

* Use lowerCamelCase (yuck, yuck) consistently.

* Link against FS when building hiprtc lib.

* Correctly mark Manipulators. Fix dual compile.

* Add unit tests. Extend HIT to accept linker options.

* Make sure the HIPRTC library is installed.

* Better logging. Try to auto-detect the target.

* Stop specifying the target explicitly.

* Add missing flavour of `hipModuleLaunchKernel`.

* Program was already destroyed.

* Don't use `--genco`. Fix mangled name trimming.

* Fix HIPRTC breakage due to upstream noise.

* [dtests] Replace RUN -> TEST in hiprtc tests

Change-Id: Ie499e92dfe4e5c94634b1c2b76cf52d241bcfea3

* [hit] Set HIP_PATH to HIP_ROOT_DIR for all tests

Change-Id: Ib0ad1f99bc71c03e363e055dd508a7a4a210680a


[ROCm/clr commit: a538eb705a]
2019-05-16 18:28:54 +05:30
Wenkai Du 3d75b10e0b Use NUMA distance for hop count calculation
[ROCm/clr commit: 56d2dc0022]
2019-05-15 21:50:35 +00:00
Maneesh Gupta e0e30536e6 Merge pull request #1083 from gargrahul/fix_hip_impl_visible_agents
Maintain HIP_VISIBLE_DEVICES for kernel launch

[ROCm/clr commit: c9fdb42b91]
2019-05-13 14:20:18 +05:30
Rahul Garg d44e800a17 Add fine grained host memory lock support (#1095)
* Add fine grained host memory lock support

* Fix default flag check


[ROCm/clr commit: e1f3dc0c80]
2019-05-13 11:48:26 +05:30