74adb64dfb
[BUILD] Fix UT packaging on Debian OS ( #1848 )
...
[ROCm/rccl commit: 5036d0e713
2025-08-11 09:43:26 -05:00
70a5f2f317
Fix rccl-UnitTests packaging on Debian systems ( #1846 )
...
Signed-off-by: ravaidya <ravaidya@amd.com >
[ROCm/rccl commit: cbbc713b03
2025-08-08 12:28:56 -05:00
c5b4e1bc78
Created coverage tests for rccl_wrap ( #1694 )
...
* Created coverage tests for rccl_wrap
RCCL_EXPOSE_STATIC off by default
Coverage tests for rccl_wrap.cc
* Remove RCCL_EXPOSE_STATIC dependency
* Removed Rcclwrap.RcclGetAlgoInfoTest
* Remove comments
* Corrected RCCL_EXPOSE_STATIC definition logic
---------
Co-authored-by: Welling <awelling@ctr2-alola-login-01.amd.com >
Co-authored-by: Atul Kulkarni <atul.kulkarni@amd.com >
[ROCm/rccl commit: 82bea39280
2025-08-06 14:48:00 -05:00
35283394ed
Add unit tests for graph/xml.cc & graph/xml.h ( #1833 )
...
* Added new binary for executing unit tests
Added new unit tests for argcheck.cc and alt_rsmi.cc files
Modified the method to execute unit tests to cover static methods
by using a bash script to convert static to non-static functions
and variables on the fly restricted to debug build type.
* Added new unit tests for src/transport/shm.cc
* Added new unit tests for graph/xml.cc
[ROCm/rccl commit: 0e7d7da55d
2025-08-01 14:20:27 -05:00
0d34963b35
Added tests for coll_reg ( #1700 )
...
Changes to coll_reg
Co-authored-by: Welling <awelling@ctr2-alola-login-01.amd.com >
[ROCm/rccl commit: 5ecc1b7ede
2025-07-31 13:49:23 -05:00
839fcb54b5
Added tests for transport.cc ( #1725 )
...
Co-authored-by: Welling <awelling@ctr2-alola-login-01.amd.com >
[ROCm/rccl commit: 7320752bf3
2025-07-31 11:04:28 -05:00
d65eb0b021
Fix RHEL10 packaging for rcclras and rccl-UnitTests ( #1831 )
...
Signed-off-by: ravaidya <ravaidya@amd.com >
[ROCm/rccl commit: 0adc5edc74
2025-07-31 11:00:49 -05:00
39c508b80d
Add collective latency profiler ( #1785 )
...
* [LatencyProfiler] Initial commit
* [LatencyProfiler] Add unit tests
* [LatencyProfiler] add more
* [LatencyProfiler] Pass unit tests
* [LatencyProfiler] Add hooks to integrate with meta internal tools
* [LatencyProfiler] Restore install.sh
* [LatencyProfiler] Resolved comments 1. add proper license 2. use proper namespace
* [LatencyProfiler] Add header
[ROCm/rccl commit: 874cd657ef
2025-07-30 14:59:28 -07:00
da2bb8a578
Added tests for Ipcsocket ( #1690 )
...
Co-authored-by: Welling <awelling@ctr2-alola-ctrl-01.amd.com >
[ROCm/rccl commit: 9843adaab2
2025-07-29 10:03:28 -05:00
88dcaaddc5
Code coverage improvements for alloc.h ( #1676 )
...
* Added tests for alloc.h
* Added tests for ZeroElementCopy and MemcpyNullSrcOrDstPointer
---------
Co-authored-by: Welling <awelling@ctr2-alola-ctrl-01.amd.com >
[ROCm/rccl commit: e118aadc14
2025-07-29 09:19:57 -05:00
5c02be7b51
Add Unit Test for bitops.h ( #1821 )
...
* Add Unit Test for bitops.h
* Change the style
* Fix the code review comments
* Add more test cases
[ROCm/rccl commit: fe182d6546
2025-07-28 11:25:15 -05:00
de0d446e03
Added new unit tests for src/transport/p2p.cc ( #1774 )
...
[ROCm/rccl commit: 81ec6bff4c
2025-07-25 12:57:57 -05:00
bd53bdf447
Added new unit tests for src/transport/shm.cc ( #1689 )
...
[ROCm/rccl commit: 1c3d1b3842
2025-07-25 05:54:42 -05:00
c94fb7c58e
Code coverage improvements ( #1665 )
...
* Increased max stack size to 640
* Added new binary for executing unit tests
Added new unit tests for argcheck.cc and alt_rsmi.cc files
Modified the method to execute unit tests to cover static methods
by using a bash script to convert static to non-static functions
and variables on the fly restricted to debug build type.
[ROCm/rccl commit: 275fdd43c1
2025-07-17 11:20:49 -05:00
41c985462c
[BUILD] Use fmt-header instead of libfmt ( #1791 )
...
[ROCm/rccl commit: 6b4ad0fd74
2025-07-10 17:19:53 -05:00
1623fcc7a1
Improving build time by removing the gfx11xx and host code from rccl_float8.h ( #1789 )
...
* removing extra build time by removing the gfx11xx arch from using hip_fp8
---------
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
[ROCm/rccl commit: 697bee4ee8
2025-07-09 14:03:47 -05:00
82a822b646
Fix chrono build error ( #1790 )
...
[ROCm/rccl commit: dd3b1d816c
2025-07-04 08:27:30 -05:00
d34a38ccfc
Add proxyTrace ( #1732 )
...
This feature tracks the proxy events and status of each send/recv op. ProxyTrace keeps a fixed number of active ops in host mem and dumps the status of each op when the program crashes or hangs.
[ROCm/rccl commit: 020dcf0a7c
2025-06-25 23:01:34 -05:00
c0c9312e38
Merge remote-tracking branch 'nccl/master' into develop
...
[ROCm/rccl commit: aaf023976a
2025-06-20 07:54:49 -05:00
7051f217a7
replayer update v0 ( #1733 )
...
* First version of new replayer, with comments on future TODOs
* plus minor fixes for UT
* Updated format of recorder, especially in binary department, according to replayer's need
[ROCm/rccl commit: ba97c9c18b
2025-06-13 15:05:34 -04:00
7f7f1cede3
Added missing copyright message. ( #1742 )
...
* Added missing copyright message.
* addressed comments.
[ROCm/rccl commit: 6c37ae9470
2025-06-12 09:58:01 -05:00
4cd71722f2
Added new ENABLE_CODE_COVERAGE option. ( #1664 )
...
Modified install.sh script to add this new option
[ROCm/rccl commit: 682ed36fe6
2025-06-10 12:12:36 -05:00
bbe7422279
SWDEV-536040 - Include <thread> header ( #1724 )
...
[ROCm/rccl commit: 2ac44cfe4e
2025-06-06 10:28:11 -06:00
59597ad8a7
Test: bump max stacksize once again to match current expectation.
...
[ROCm/rccl commit: c07445d5b4
2025-05-23 11:18:25 -05:00
2cb65ba466
Test: Change max stack size to 520 to accomodate new ROCm changes.
...
[ROCm/rccl commit: 523e0893e4
2025-05-21 20:21:27 -05:00
65d67dce7a
Switched to using the hip_fp8 header instead of rccl_float8, resolving compatibility issues. ( #1546 )
...
* Revert "Revert "replacing rccl_float8 with hip_fp8 and address compatibility …"
This reverts commit 30eecfdb25mberenjk@amd.com >
[ROCm/rccl commit: 170acf3bda
2025-05-14 15:33:03 -05:00
743cc971d3
Write JSON file to /tmp directory to avoid incorrect write access in recorderTest ( #1680 )
...
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
[ROCm/rccl commit: e70003736e
2025-05-07 13:58:27 -05:00
be0761502d
rccl-UnitTests - link to dl library ( #1673 )
...
[ROCm/rccl commit: 9525c5b2ef
2025-05-02 21:20:22 -05:00
5580cb7574
Added new tests for improving the code coverage ( #1656 )
...
Signed-off-by: Deeksha Goplani <deeksha.goplani@amd.com >
[ROCm/rccl commit: 2486838465
2025-04-30 18:01:11 -05:00
d045d0ca23
Merge remote-tracking branch 'nccl/master' into develop
...
[ROCm/rccl commit: a6bf9bfc9e
2025-04-23 20:47:43 -07:00
8023be9355
Adding UT_DEBUG_PAUSE to unit tests ( #1653 )
...
[ROCm/rccl commit: ee85a70bb4
2025-04-21 21:15:07 -06:00
58ee618194
RCCL Replayer update ( #1603 )
...
RCCL recorder w/ suggested change and UT
[ROCm/rccl commit: 9a55ff60a9
2025-04-19 00:21:27 -04:00
acf0bc1c6e
added copyright ( #1635 )
...
[ROCm/rccl commit: 7a84c5dbb0
2025-04-14 09:46:18 -05:00
8ed27fde74
Merge remote-tracking branch 'nccl/master' into develop
...
[ROCm/rccl commit: 0b2062c560
2025-03-27 12:53:04 -05:00
8cfbc0fbd1
[UT] Increase stack size for StandaloneTests to 480 ( #1616 )
...
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
[ROCm/rccl commit: d6b987a53f
2025-03-21 21:33:32 -05:00
4f67522420
Removing the experimental clique kernel files ( #1610 )
...
[ROCm/rccl commit: 626dc50ab5
2025-03-20 18:10:01 -06:00
12c1fe8fdf
Psuedo-randomly adding zero-byte sends in AllToAllv unit test ( #1597 )
...
[ROCm/rccl commit: 9a4e49ff1a
2025-03-20 17:00:48 -06:00
a3a598efb3
Skipping AllReduce test on more than 8 ranks for FP8 type on Hyabusa ( #1598 )
...
* Skipping AllReduce FP8 test on 9 to 16 ranks (gfx90a) as it's using Tree algorithm not RING
---------
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
[ROCm/rccl commit: 5f691aaf65
2025-03-17 10:22:49 -05:00
afd04a5117
Limit P2P channels per peer to not exceeding max channels ( #1594 )
...
* Limit P2P channels per peer to not exceeding max channels
* [UT] test single GPU cases for all collectives
* [UT] fix out of range root value
[ROCm/rccl commit: 4237caad69
2025-03-11 09:32:09 -07:00
14be1c9a7a
fix the size of the recv buffer in AllGather UBR test ( #1564 )
...
[ROCm/rccl commit: 59c55842f1
2025-03-05 11:42:15 -06:00
4ccbaabdc9
[UT] Include iomanip if not defined ( #1510 )
...
* [UT] Include iomanip if not defined
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
* Remove include guards
`iomanip.h` has pre-defined include guards. These are not needed.
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
---------
Signed-off-by: nileshnegi <Nilesh.Negi@amd.com >
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
[ROCm/rccl commit: 4e406acc43
2025-02-11 08:48:47 -07:00
a40d4eb960
non-hipGraph MSCCL++ tests for allReduce and allGather ( #1503 )
...
* working tests for a single message size
* move call_RCCL routine StandaloneUtils, create .cpp file for StandaloneUtils so that it can be included in several tests
* simplify test invocation
* remove unecessary logs and exit from ncclCommRegister
* set expected results for allGather
* skip test if nranks doesn't match number of gpus, call getAndDistributeNCCLid only from parent process
* fix improper size of expected-results vector
* Removing unused changes.
* Refactored to create a new file for the forked collectives call, as StandaloneUtils is for the Standalone tests. Renamed the functions to be slightly more accurate and follow existing naming conventions.
* Apply suggestions from code review
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
---------
Co-authored-by: isaki001 <isakioti@banff-pla-r27-38.pla.dcgpu >
Co-authored-by: corey-derochie-amd <161367113+corey-derochie-amd@users.noreply.github.com >
Co-authored-by: Corey Derochie <corey.derochie@amd.com >
[ROCm/rccl commit: 3398fa78fe
2025-02-04 09:11:32 -06:00
54c750456c
Only look for librccl .co files in StackSize test ( #1499 )
...
Co-authored-by: BertanDogancay <bertan.dogancay>
[ROCm/rccl commit: 5afe900efd
2025-01-22 16:48:10 -07:00
8e6bedeedc
Increased gfx90a stack size expectation to 320 to match latest compiler. ( #1487 )
...
[ROCm/rccl commit: c68b558ed5
2025-01-16 17:04:51 -07:00
300f954185
Initializing all ranks to the same value to avoid failure of UT AllR… ( #1459 )
...
* Initializing all ranks to the same value to avoid failure of UT AllReduce for FP8 type
Co-authored-by: Marzieh Berenjkoub <mberenjk@amd.com >
[ROCm/rccl commit: 39483c55f8
2025-01-02 11:39:02 -06:00
69d976532b
GPU allocation for CPX Unit Tests using PCI bus id ( #1403 )
...
* mapping devices wrt pci
* Gpu allocation by using pci mapping
* Passing gpuPriorityOrder in as an argument rather than making the functions non-static.
* Removing redundant testBed instance calling
[ROCm/rccl commit: 69b2b712ab
2024-11-04 10:51:00 -06:00
ad1384bea1
Hide or fix all build warnings ( #1331 )
...
* Changing C-strings to be const.
* Changed variable-length arrays to std::vector to avoid warnings. VLA is a compiler extension.
* Changed `#define` inside functions into `constexpr int` to preserve scoping and avoid macro redefinition warnings.
* Disabled warnings for modifying `CMAKE_CXX_FLAGS` caused by `check_symbol_exists`, which temporarily modifies the flag to do a compile check.
* Fixed VLA in rccl UT.
[ROCm/rccl commit: 1c45962273
2024-11-04 09:46:42 -07:00
251df02d42
Increase MAX_STACK_SIZE for UT ( #1398 )
...
[ROCm/rccl commit: 984f1e4343
2024-11-01 13:07:45 -04:00
e346e19065
Adjustment for UT Sendrecv ( #1400 )
...
Enabled UT sendrecv to same rank and refactor UBR call
[ROCm/rccl commit: fd9924cfe7
2024-10-30 15:13:53 -04:00
3eda60a031
static: Enable true rccl static library build ( #1379 )
...
* static: Enable true rccl static library build
Rccl uses `-fgpu-rdc` to compile, which requires a specialized link command in order to produce a true static library.
When "linking" with `amdclang++`, you need to use `--emit-static-lib` and `--hip-link` to get a static library with all gpu code generated. Subsequent links with binaries do not need any special flags to generate gpu code.`
Building a static library:
```
$ cmake -DROCM_PATH=$ROCM_PATH -DCMAKE_PREFIX_PATH=$ROCM_PATH -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=off -DCMAKE_POSITION_INDEPENDENT_CODE=on -DAMDGPU_TARGETS=gfx942 -DCMAKE_CXX_COMPILER=$ROCM_PATH/lib/llvm/bin/amdclang++ -DCMAKE_C_COMPILER=$ROCM_PATH/lib/llvm/bin/amdclang .. 2>&1 | tee -a /tmp/build.txt
-- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY) (Required is at least version "1.11")
-- Checking for ROCm support for GPU targets: gfx942
-- Compiling for gfx942
-- Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY) (Required is at least version "1.11")
-- ROCM_PATH found: /opt/rocm
-- Compiling with amdclang++
-- HIP compiler: clang
-- HIP runtime: rocclr
-- amdclang++ executable: /opt/rocm/llvm/bin/amdclang++
-- amdclang++ version: 18.0.0git
-- hipconfig executable: /opt/rocm/bin/hipconfig
-- amdclang++ HIP version: 6.2.41133
-- ROCm version: 6.2.0
...
$ make -j 32
[ 0%] Updating git_version.cpp if necessary
-- Updating git_version.cpp
[ 0%] Built target git_version_check
[ 0%] Hipifying src/transport/shm.cc -> /home/skarlage/local/rccl/build/hipify/src/transport/shm.cc
[ 0%] Hipifying src/bootstrap.cc -> /home/skarlage/local/rccl/build/hipify/src/bootstrap.cc
[ 0%] Hipifying src/channel.cc -> /home/skarlage/local/rccl/build/hipify/src/channel.cc
[ 1%] Hipifying src/device/all_reduce.h -> /home/skarlage/local/rccl/build/hipify/src/device/all_reduce.h
[ 1%] Hipifying src/device/broadcast.h -> /home/skarlage/local/rccl/build/hipify/src/device/broadcast.h
[ 1%] Hipifying src/device/all_gather.h -> /home/skarlage/local/rccl/build/hipify/src/device/all_gather.h
[ 1%] Hipifying src/device/common.cu -> /home/skarlage/local/rccl/build/hipify/src/device/common.cu.cpp
[ 1%] Hipifying src/debug.cc -> /home/skarlage/local/rccl/build/hipify/src/debug.cc
[ 1%] Hipifying src/device/alltoall_pivot.h -> /home/skarlage/local/rccl/build/hipify/src/device/alltoall_pivot.h
[ 1%] Hipifying src/device/network/unpack/unpack.h -> /home/skarlage/local/rccl/build/hipify/src/device/network/unpack/unpack.h
[ 4%] Hipifying src/collectives.cc -> /home/skarlage/local/rccl/build/hipify/src/collectives.cc
[ 4%] Hipifying src/device/msccl_kernel_impl.h -> /home/skarlage/local/rccl/build/hipify/src/device/msccl_kernel_impl.h
[ 4%] Hipifying src/device/network/unpack/unpack_defs.h -> /home/skarlage/local/rccl/build/hipify/src/device/network/unpack/unpack_defs.h
[ 4%] Hipifying src/device/op128.h -> /home/skarlage/local/rccl/build/hipify/src/device/op128.h
[ 4%] Hipifying src/device/onerank.cu -> /home/skarlage/local/rccl/build/hipify/src/device/onerank.cu.cpp
[ 4%] Hipifying src/device/common.h -> /home/skarlage/local/rccl/build/hipify/src/device/common.h
[ 6%] Hipifying src/device/prims_ll.h -> /home/skarlage/local/rccl/build/hipify/src/device/prims_ll.h
[ 6%] Hipifying src/device/primitives.h -> /home/skarlage/local/rccl/build/hipify/src/device/primitives.h
[ 6%] Hipifying src/device/prims_ll128.h -> /home/skarlage/local/rccl/build/hipify/src/device/prims_ll128.h
[ 6%] Hipifying src/device/reduce.h -> /home/skarlage/local/rccl/build/hipify/src/device/reduce.h
[ 7%] Hipifying src/device/common_kernel.h -> /home/skarlage/local/rccl/build/hipify/src/device/common_kernel.h
[ 7%] Hipifying src/device/reduce_scatter.h -> /home/skarlage/local/rccl/build/hipify/src/device/reduce_scatter.h
[ 7%] Hipifying src/device/sendrecv.h -> /home/skarlage/local/rccl/build/hipify/src/device/sendrecv.h
[ 7%] Hipifying src/device/prims_simple.h -> /home/skarlage/local/rccl/build/hipify/src/device/prims_simple.h
[ 7%] Hipifying src/enqueue.cc -> /home/skarlage/local/rccl/build/hipify/src/enqueue.cc
[ 7%] Hipifying src/device/reduce_kernel.h -> /home/skarlage/local/rccl/build/hipify/src/device/reduce_kernel.h
[ 7%] Hipifying src/graph/connect.cc -> /home/skarlage/local/rccl/build/hipify/src/graph/connect.cc
[ 7%] Hipifying src/graph/rings.h -> /home/skarlage/local/rccl/build/hipify/src/graph/rings.h
[ 8%] Hipifying src/graph/rings.cc -> /home/skarlage/local/rccl/build/hipify/src/graph/rings.cc
[ 8%] Hipifying src/graph/rome_models.cc -> /home/skarlage/local/rccl/build/hipify/src/graph/rome_models.cc
[ 8%] Hipifying src/graph/rome_models.h -> /home/skarlage/local/rccl/build/hipify/src/graph/rome_models.h
[ 8%] Hipifying src/graph/paths.cc -> /home/skarlage/local/rccl/build/hipify/src/graph/paths.cc
[ 9%] Hipifying src/graph/search.cc -> /home/skarlage/local/rccl/build/hipify/src/graph/search.cc
[ 9%] Hipifying src/graph/topo.cc -> /home/skarlage/local/rccl/build/hipify/src/graph/topo.cc
...
[100%] Linking CXX static library librccl.a
Elapsed time: 270 s. (time), 0.00046 s. (clock)
Elapsed time: 0 s. (time), 0.000342 s. (clock)
[100%] Built target rccl
```
Static rccl exists:
```
$ file librccl.a
librccl.a: current ar archive
```
* Fix up tests Cmake for static builds
We also need to fix up the tests CMakeLists.txt to:
* Remove the unused `BUILD_STATIC` option
* Use `SHARED_LIBS` as a definition of whether we're building static or
not.
[ROCm/rccl commit: bdf9544c81
2024-10-16 06:58:50 -07:00
Nilesh M Negi
Rahul Vaidya
awelling2801
Atul Kulkarni
ycui1984
peizhang56
mberenjk
Rakesh Roy
Dingming Wu
BertanDogancay
Tim
Arm Patinyasakdikul
Atul Kulkarni
vstojilj
corey-derochie-amd
Siu Chi Chan
deeksha-amd
gilbertlee-amd
AbandiGa
Wenkai Du
isaki001
Bertan Dogancay
saurabhAMD
Sean Karlage