AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
71,068 Commit 3 Branch 0 Tag
769d3dd67a35fb706dc1b8ebcc20612cbe4ad9cd
Commit Graph

7213 Commits

Author SHA1 Message Date
Alexandra Sidorova 38a359f5f3 [CLR] prevent compilation errors for non-HIP compilers in amd_hip_mx_common.h and amd_hip_ocp_types.h (#2448) 
Co-authored-by: Andrei Kochin <andrei.kochin@amd.com>
 2026-01-08 17:49:13 +04:00
Godavarthy Surya, Anusha 1ef6a86ee3 SWDEV-549711 - Improve graph DEBUG dot print for segments (#2205) 
Co-authored-by: Anusha GodavarthySurya<agodavar@amd.com>
 2026-01-07 14:07:49 +05:30
Gerardo Hernandez 50644f5aef SWDEV-508225 remove assertions when loading fat binary (#2013) 
* SWDEV-508225 - do not assert() after calling digestFatBinary() if it fails. Otherwise this causes assertions to trigger easily in systems that have an APU and a discrete GPU and the code was compiled for the discrete one

* SWDEV-508225 - fix that when using a non-existent ordinal in HIP_VISIBLE_DEVICES, getCurrentArch() would crash
 2026-01-06 21:53:32 +00:00
AidanBeltonS 39d8432893 SWDEV-566854 - Improve memory object handling (#1939) 
* Improve memory object handling for memcpy

* update

* Pass offsets and make hip_graph changes

* Update projects/clr/hipamd/src/hip_memory.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Remove unnecessary command overload

* Update based on feedback

* Fix failing hipGraphTests

* Fix graph bugs

* Fix failing memcpy tests

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2026-01-05 18:05:56 +00:00
Jimbo a59d46ffbf SWDEV-567545 - Implement block_rank in co-op grid groups (#2182) 
* SWDEV-567545 - Implement block_rank in co-op grid groups
 2025-12-29 11:39:23 -05:00
Sourabh U Betigeri fdc1660dfa SWDEV-565304 - Pass numa node to migrate pages correctly (#1729) 
* SWDEV-565304 - Pass cpuId of the the thread currently running

* SWDEV-565304 - Numa id to be returned

* SWDEV-565304 - Numa id to be returned
 2025-12-19 13:36:53 -08:00
Matt Arsenault 0c0d8dc974 SWDEV-548892 - Stop using __ockl_lane_id (#2186) 
__lane_id already exists and is identical.
 2025-12-19 20:34:55 +01:00
Sourabh U Betigeri 883fdfb820 Revert "clr: Minor fixes for error return" (#2399) 
- This reverts commit 8dd8436e43c7f0d062fd73252bf61c35615d181d.
- Resolve MIOpen test failures observed in TheRock
- TheRock Issue: ROCm/TheRock#2642
- room-systems issue: #2400
 2025-12-18 18:40:13 -05:00
Jatin Chaudhary fdf73116d5 Do not allocate code objects when we map a static code object (#2332) 2025-12-18 09:22:02 +00:00
Maneesh Gupta 4a9833e70e Revert "Add HasExpertSchedMode device prop (#2241)" (#2371) 
This reverts commit c0b4aef5ad.
 2025-12-17 21:26:44 -08:00
Shadi Dashmiz 96f6b6e251 SWDEV-571304 : Fix the constructor for __half (#2240) 
- comply with cuda

- Fix usecase for constexpr

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
 2025-12-17 11:15:20 -05:00
Filip Jankovic c0b4aef5ad Add HasExpertSchedMode device prop (#2241) 
* Add HasExpertSchedMode device prop

* Add unit tests for HasExpertSchedMode

* Add gfx12 check for HasExpertSchedMode prop

* Update gfx major version check and test for ExpertSchedMode

* Minor fix and ROCr version bump

* Update projects/rocr-runtime/runtime/hsa-runtime/inc/hsa_ext_amd.h

* Update projects/rocr-runtime/runtime/hsa-runtime/inc/hsa_ext_amd.h

* Apply suggestion from @dayatsin-amd

* Apply suggestion from @dayatsin-amd

---------

Co-authored-by: Stefan Sokolovic <stefan.sokolovic2@amd.com>
Co-authored-by: David Yat Sin <77975354+dayatsin-amd@users.noreply.github.com>
 2025-12-17 17:06:08 +01:00
systems-assistant[bot] b002c6a739 SWDEV-538607 - Add SIMDe as a build dependency, remove naked intrinsic use. (#500) 
Co-authored-by: Alex Voicu <alexandru.voicu@amd.com>
Co-authored-by: Ioannis Assiouras <Ioannis.Assiouras@amd.com>
 2025-12-15 17:40:51 +00:00
Matt Arsenault 49565f9d9f SWDEV-548892 - Always declare used ocml and ockl device libs functions (#2230) 
Ignore __CLANG_HIP_RUNTIME_WRAPPER_INCLUDED__. This should not be relying
on declarations from the clang builtin headers. There is no issue declaring
the same intrinsics multiple times. This will enable removal of declarations
from the clang builtin headers.
 2025-12-15 17:23:33 +01:00
Fábio Mestre 447beeb00b Replace usages of __ockl_gws_init with __builtin_amdgcn_ds_gws_init (#2235) 2025-12-15 16:56:14 +01:00
SaleelK 840301e12d clr: Minor fixes for error return (#2153) 2025-12-11 16:59:56 -08:00
Matt Arsenault a495d1137e SWDEV-548892 - Make declaration of __ockl_fdot2 always available (#2229) 2025-12-11 11:53:11 +01:00
German Andryeyev 3895aadba6 SWDEV-558849 - Make ROCR path in Windows more stable (#2181) 2025-12-10 12:37:10 -05:00
Jatin Chaudhary eea93d58a2 SWDEV-554626 - return correct error code (#1107) 
* SWDEV-554626 - return hipErrorInvalidDeviceFunction when we can not load module
Return correct error code when modules are empty

* Match the error codes

* Revert the error code
 2025-12-09 16:10:25 +01:00
Shadi Dashmiz 4812d8e78b SWDEV-566783 - clean up cmgr helper (#1864) 
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
 2025-12-08 10:37:03 -05:00
Ioannis Assiouras 3faf36fb25 Fix Unit_hipStreamBeginCaptureToGraph_CapturePartialInThreads (#2072) 
https://mlsejenkinsvm.amd.com/job/rocm-systems/job/hip/view/change-requests/job/PR-2072/6/
The last windowsCI has passed successfully
 2025-12-08 13:30:23 +01:00
Ajay GunaShekar d6f6435b88 SWDEV-526504 - Remove perl dependency in hip/clr build (#964) 
* SWDEV-1 - Remove perl dependency in hip/clr build
* SWDEV-1 - use python3 inplace of perl for formatting date,time
 2025-12-05 08:42:15 -08:00
Julia Jiang 272f06506f SWDEV-549696 - Fix HIP catch sub-test failure for MipmappedArray (#1198) 
Co-authored-by: JeniferC99 <150404595+JeniferC99@users.noreply.github.com>
 2025-12-05 11:00:06 -05:00
systems-assistant[bot] 06a3a5ca10 SWDEV-546110 - Fix encoding for certain types (#446) 2025-12-05 13:16:14 +00:00
Matt Arsenault d75d0bc1c9 SWDEV-548892 - Stop using ocml exp and exp2 functions (#2032) 2025-12-02 13:39:09 -05:00
SaleelK c105dcd05b clr: Use graph segment scheduling to process HIP Graphs (#1372) 
* clr: Use graph segment scheduling to process HIP Graphs

* Add a broader path to use capture packet capture for all topologies
* Refactor code
* Use DEBUG_HIP_GRAPH_SEGMENT_SCHEDULING to toggle new vs classic path,
  Enabled by default

* clr: Few fixes and improvements

* clr: Detect complex graphs to take classic path

* Use DEBUG_HIP_GRAPH_SEGMENT_SCHEDULING=2 to force segment scheduling
  path

* clr: Fix a cornercase stack corruption

* clr: Track commands of segments instead of snapshots

* clr: Fix Batch dispatch logic

* Track fence_dirty_ flag for command of other streams
* Dependency resolution markers can now accomodate dirty fence on cross
  streams

---------

Co-authored-by: Ioannis Assiouras <Ioannis.Assiouras@amd.com>
Co-authored-by: Godavarthy Surya, Anusha <agodavar@amd.com>
 2025-12-01 12:49:26 -08:00
vstojilj 77f58ceb9f SWDEV-558557 - Remove duplicate nodes when capturing hipMemcpyAsync (#1226) 2025-12-01 11:25:13 +01:00
vstojilj 1c09c87cc7 SWDEV-564927 - Allow sizeBytes to be 0 when hipMemsetAsync is captured (#1849) 2025-11-27 17:13:33 +01:00
Godavarthy Surya, Anusha 2e1c37a926 SWDEV-490861 - Remove recursion and extra loop in hipGraphLaunch (#1792) 2025-11-27 10:25:08 +00:00
Shadi Dashmiz 962b99f925 SWDEV-567514: Remove default stream wait (#1977) 
- when virtual map command is called

- can create deadlock

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
 2025-11-26 15:11:52 -05:00
AidanBeltonS d849b88aef SWDEV-558080 - Add recommended granularity (#1176) 
* Add recommended granularity

* Improve granularity testing

* Update based on feedback
 2025-11-26 16:10:58 +00:00
Matt Arsenault f089217e6a SWDEV-548892 - Stop using ockl steadyctr function (#1882) 
Directly use the builtin
 2025-11-26 09:29:06 -05:00
Matt Arsenault 9fbb062505 SWDEV-548892 - Stop using ocml isinf wrapper (#1854) 2025-11-25 22:21:37 -05:00
Karthik Jayaprakash 740a06d567 SWDEV-559267 - Use CLPrint to DevLogPrintf with Log Level - detail debug. (#1160) 2025-11-25 19:25:32 -05:00
German Andryeyev 93682f2f75 SWDEV-567852 - Clean-up hip::init() (#1948) 2025-11-25 19:05:41 -05:00
Pengda Xie 6c31785eaf SWDEV-562761 - Cleanup static fatbin on runtime teardown (#1873) 2025-11-24 21:57:46 -08:00
Marius Brehler 2dc32d645b Explicitly load versioned libamdhip64.so (#1872) 
* Explicitly load versioned libamdhip64.so

* Fix syntax errors

* Fix when patching happens in Windows workflow

---------

Co-authored-by: Joseph Macaranas <145489236+jayhawk-commits@users.noreply.github.com>
Co-authored-by: ammallya <ameyakeshava.mallya@amd.com>
 2025-11-24 10:05:05 -08:00
sluzynsk-amd 2cf9faa93f SWDEV-563777 - fix warnings related to inconsistent overrides (#1625) 
This patch adds missing override keywords. Fixes this class of warnings.

Signed-off-by: Sebastian Luzynski <Sebastian.Luzynski@amd.com>
 2025-11-24 18:50:07 +01:00
AidanBeltonS 0580e2053c SWDEV-533546, SWDEV-540027 - Add e8m0 conversions and testing (#987) 
* SWDEV-533546 - Add conversion functions for e8m0

* SWDEV-533546 - remove whitespace

* Add testing

* Update based on feedback

* Copilot suggestions

---------

Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
 2025-11-24 09:14:03 +00:00
Ioannis Assiouras 7313c3752a SWDEV-567475 - Fix failures in graph tests due to GraphExec destroy h… (#1917) 2025-11-22 23:01:47 +00:00
Matt Arsenault 4830979f0e SWDEV-548892 - Stop using ocml fma wrappers (#1702) 
Directly use elementwise builtin
 2025-11-13 16:20:27 -08:00
Matt Arsenault 42e91b8934 SWDEV-548892 - Stop using ocml sqrt wrappers (#1716) 2025-11-13 16:19:44 -08:00
Satyanvesh Dittakavi 07dd4c85e7 SWDEV-546308 - Implement hipKernelGetParamInfo API (#1783) 2025-11-12 14:09:26 +05:30
jofrn 8f9da259ac Fix memory leak in hip_fatbin.cpp UncompressAndPopulateCodeObject (#1692) 
Wrap amd_comgr_data_t item returned from action_data_get_data() in
ComgrDataUniqueHandle to ensure it gets released.
 2025-11-11 16:48:06 -05:00
systems-assistant[bot] a66ca8809b SWDEV-511239 - Remove and and use && for preprocessors (#506) 
This shows up as warning in msvc.

Co-authored-by: Jatin Chaudhary <JatinJaikishan.Chaudhary@amd.com>
 2025-11-11 09:43:57 -08:00
Todd tiantuo Li cf536a8c1a SWDEV-554372 - Add 3 HIP_GET_PROC_ADDRESS_xxx flags (#1771) 2025-11-10 23:29:40 -08:00
Rakesh Roy 9cac2e46e4 SWDEV-565668 - Bump minor version for ROCm 7.2 (#1762) 
Additionally remove cmake option HIP_OFFICIAL_BUILD
 2025-11-10 18:55:52 +05:30
Jin Jung 324a5519b9 SWDEV-563842 - Fix Memory Address Offset Bug (#1749) 
* SWDEV-563842 - Fix Memory Address Offset Bug

* Revert "SWDEV-563842 - Fix Memory Address Offset Bug"

This reverts commit 477958dc48300ee1fe0166aa6f0d3d8125b91f5e.

* SWDEV-563842 - Fix Memcpy Address Offset Bug

* SWDEV-563842 - Find Memcpy Device Address Offset

* Revert "SWDEV-563842 - Find Memcpy Device Address Offset"

This reverts commit 6c75a9e5b58b7dfabb9e3f91fa3dd892d42639cc.

* Revert "SWDEV-563842 - Fix Memcpy Address Offset Bug"

This reverts commit 0b89072a988074aa4da4e8fc7ba04c554f31ed44.

* SWDEV-563842 - MemObjMap_ Offset Support

This patch fixes the buffer offset handling bug.

* Revert "SWDEV-563842 - MemObjMap_ Offset Support"

This reverts commit 37fce3382465e3420721e5277377f943ec2b30a1.

* SWDEV-563842 - External Memory Buffer View
 2025-11-09 12:52:35 -08:00
Victor Zhang 7580052878 SWDEV-564318 - Add support for allocating uncached device memory (#1670) 2025-11-09 12:51:41 -05:00
marandje 0ad05ed515 SWDEV-556947 - Parse the HIP version from the Git tag (#1135) 2025-11-06 10:18:26 +01:00