AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
896 Commits 3 Branches 0 Tags
78c48eaed5da3359420d56f0e2e34ce0bbd5bf1d
Commit Graph

197 Commits

Author SHA1 Message Date
colramos-amd f47b8d2547 Throw more helpful warning on missing csv in analyze mode (#313) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-04-01 14:30:21 -05:00
coleramos425 706afa7f37 Register TRACE loglevel ahead of parse_args to avoid error in --specs printout 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-04-01 14:30:21 -05:00
Cole Ramos f7394bf272 Revert #333 deterministic ordering (#337) 
* Revert "formatting"

This reverts commit e387561791898467371b6219921f10447d3486b3.

* Revert "Implement deterministic ordering of perfmon"

This reverts commit 2a24600a37c8002838145962a957cea447555b0c.
 2024-04-01 14:30:21 -05:00
Nicholas Curtis f6f6165379 formatting 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-04-01 14:30:21 -05:00
colramos-amd 3928f36d5e Adding redirect to help button in standalone GUI 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-04-01 14:30:21 -05:00
colramos-amd 33e763178e Removing unused modules 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-04-01 14:30:21 -05:00
colramos-amd cf36fb7fbf Implementing docs feedback with typos and minor enhancements 
Co-authored-by: Jose Santos <josantos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-04-01 14:30:21 -05:00
Nick Curtis d72ef52208 Fix for #300 (#331) 
On some versions of numpy/pandas, applying a str map to an empty series doesn't change the type.
As a result, when adding a float to a string, sometimes numpy dies with a uadd error.
We fix this by explicitly casting to a str first

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
 2024-04-01 14:30:21 -05:00
colramos-amd 62221383a7 Fixing visualization for Compute Pipeline SOL. Need to consider 'Pct of Peak' rather than 'Avg' 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-18 14:28:14 -05:00
Karl W Schulz 4fc30eb5c4 apply formatter 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-15 16:40:13 -05:00
Karl W Schulz f4070e3654 apply formatter 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-15 14:04:49 -05:00
colramos-amd 2dcad38028 Update roofline distro_map for Ubuntu22.04 (#319) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-15 12:47:30 -05:00
Karl W Schulz 69de978d35 tweak logger formatter to suppor OMNIPERF_COLOR=2 which includes the 
loglevel name in output, but without color

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-15 09:31:22 -05:00
Karl W Schulz c29f28e25e bug fix for df tracing output - add more function demarcation 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-15 09:31:22 -05:00
Karl W Schulz 76121f20a9 enable more function demarcation for analyze tracing 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-15 09:31:22 -05:00
Karl W Schulz 3438bc9d0f logger update: assign color for TRACE level 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-14 17:37:30 -05:00
Karl W Schulz 69af2ffc83 update logging formatter handling for consistent behavior with error messsages 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-14 17:37:30 -05:00
colramos-amd e7cc326d5a Fix missing argv in console_warning() 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 16:44:02 -05:00
JoseSantosAMD efb8f131ec change stubbed values to hbm bw (#302) 
* change stubbed values to hbm bw

Signed-off-by: Jose Santos <josantos@amd.com>

* Reformat

Signed-off-by: Jose Santos <josantos@amd.com>

* Update analysis_webui.py

remove print statements

Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/omniperf_analyze/analysis_webui.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/omniperf_analyze/analysis_webui.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

---------

Signed-off-by: Jose Santos <josantos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
Co-authored-by: Cole Ramos <colramos@amd.com>
 2024-03-12 16:08:30 -05:00
JoseSantosAMD 4424f320ad Kernel no overwrite (#303) 
* Removing kernel name shortener from profile

-  Kernel name shortener now in analyze
-  db import uses pymongo to import

Signed-off-by: Jose Santos <josantos@amd.com>

* collections now added using pymongo

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* kernel_name_shortener shortens dataframes and not a workload

-  argparser: --kernel-verbose to connection group
-  analysis_cli, profiler_rocprof_v2: remove kernel_name_shortener, so that it doesnt overwrite workload
-  db_import: demangle kernel_name dfs

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* fix db name in pymongo command

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* reformat

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* fix typo

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* remove checker for verbose in profiler_base

Signed-off-by: Jose Santos <josantos@amd.com>

* kernel_name_shortener now called in create_df_kerenel_top_stats and
create_df_pmc

Signed-off-by: Jose Santos <josantos@amd.com>

* add kernel_verbose to analysis_webui, remove stubbed values

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* Update src/utils/kernel_name_shortener.py

keep console_debug

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

* Update src/utils/kernel_name_shortener.py

Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>

---------

Signed-off-by: Jose Santos <josantos@amd.com>
Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
Signed-off-by: JoseSantosAMD <87447437+JoseSantosAMD@users.noreply.github.com>
Co-authored-by: Cole Ramos <colramos@amd.com>
 2024-03-12 15:54:52 -05:00
colramos-amd 706d3bb9f0 Update DB module for new sysinfo keys 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-12 12:24:49 -05:00
Karl W Schulz e85037fdfb move set_locale_encoding() to occur after logging is setup - allows 
function to use console_error() directly (https://github.com/AMDResearch/omniperf/pull/308#discussion_r1519914083)

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 5e21dc35fd Update src/utils/utils.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz ebc9108da0 Update src/utils/db_connector.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 523639a7fd Update src/utils/db_connector.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W. Schulz 8e45cc897f Update src/utils/utils.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Karl W. Schulz <koomie@users.noreply.github.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 34070394eb allow color formatter via env variable OMNIPERF_COLOR=1 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 27a57bdafb refactor setting of local encoding; remove from top-level omniperf 
wrapper and push into base class via a companion utility function

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 15c86ba424 update print_status() to use console logger; convert some info logs to debug logs 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 505e263279 rework of logger.py setup to introduce another setup_file_handler() - 
this function enables file-based logger output for use with profile
mode

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz e24e6c35a5 refactor logging initialization into two steps: 
(1) setup_logging_handler -> called prior to arg parsing
(2) setup_logging_priority -> called after arg parsing

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz abd3d20cb2 add quietmode option to setup_logging function 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 2b24375e8d add a exit keyword to console_error function; allows multiple error 
lines prior to code exit

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 377c642ac2 updates for run_prof() routine: 
* add a profileMode keyword option, used to indent profiling output

* update logic if forked process is not successful, output is
  displayed directly with INFO logging or lower; also dispaly output
  in ERROR mode if the process fails

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz dcdef37c34 remove duplicate process output within run_prof() 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 61267ee262 include ERROR delimiter directly for console_error() messsages 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz cc7a725ae8 add a profileMode option to capture_subprocess_output() - includes 
indented output with profiler selection when enabled

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 6bb4210d94 minor refactor of print_status() 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz 63129e4247 add indent support to console_log() 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
Karl W Schulz bdfc536ade update setup_logging function to return loglevel; disable inclusion of 
loglevel delimiter in output

Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd 6c5a3623b6 Fix dangling merge conflict 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd f2aac37178 Fix python formatting 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd 771644f5f7 Replaced some straggling print statements with log functions 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd 5ed9a5c902 Connect verbosity flag to loglevel 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd 5bf38a4fed All logging should use call new functions 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd 233905071c Dedicated logging function for each log level 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd 0611ce4582 Remove outdated remove_workload.py module 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
colramos-amd 2e09f0be7e Standalone logging module for cleaner omniperf_base.py 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-11 14:19:01 -05:00
Cole Ramos f4511e7280 Force encoding before Omniperf execution (#299) 
* Force encoding before Omniperf execution

Signed-off-by: colramos-amd <colramos@amd.com>

* Fix circular dependency in utils module

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-06 17:01:07 -06:00
Jason Ray 994aea9f0e bump statman-stopwatch to 2.18 (#220) 
* Lock Pandas to version 1.4.3 for tutorial

Signed-off-by: colramos-amd <colramos@amd.com>

* Establish connection between kernel related flags in Analyze Mode (#187)

Signed-off-by: colramos-amd <colramos@amd.com>

* Fixing bug in kernel/dispatch filter pytest

Signed-off-by: colramos-amd <colramos@amd.com>

* More CI logic errors fixed

Signed-off-by: colramos-amd <colramos@amd.com>

* Update CHANGES

Signed-off-by: Cole Ramos <colramos@amd.com>

* Update CHANGES

Signed-off-by: Cole Ramos <colramos@amd.com>

* Update README.md

Signed-off-by: Cole Ramos <colramos@amd.com>

* bump statman-stopwatch to 2.18

Signed-off-by: Jason Ray <jayray.net@gmail.com>

* Fix merge mistakes

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: colramos-amd <colramos@amd.com>
Signed-off-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Jason Ray <jayray.net@gmail.com>
Co-authored-by: colramos-amd <colramos@amd.com>
 2024-03-05 11:16:23 -06:00