Commit Graph

4832 Commits

Author SHA1 Message Date
Mark Searles aa7ce2ef44 Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)
2018-08-31 11:10:58 -07:00
Saleel Kudchadker cd926a44b7 Merge branch 'master' of https://github.com/ROCm-Developer-Tools/HIP into skudchad-hip 2018-08-31 10:38:41 -07:00
Mark Searles f0183dfaac Add keyword 'explicit' to avoid ambiguity
Older gcc, e.g., 5.x, see an ambiguity in some calls. Example error
output as seen with gcc 5.5:

In file included from benchmark_wino.cpp:1:
In file included from ./miopen.hpp:13:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/regex:38:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/algorithm:62:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/stl_algo.h:66:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/random:51:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/bits/random.tcc:1324:27: error: call to 'abs' is ambiguous
                    const double __y = -std::abs(__n) * __param._M_sm - 1;
                                        ^~~~~~~~
/opt/rocm/hip/include/hip/hcc_detail/hip_complex.h:345:31: note: candidate function
__DEFINE_HIP_COMPLEX_REAL_FUN(abs, hipCabs)
2018-08-31 10:36:05 -07:00
foreman 0d2b874266 P4 to Git Change 1600056 by skudchad@skudchad_test2_win_opencl on 2018/08/30 12:04:10
SWDEV-145570 - [HIP] Fix elapsed time calc for hipEvent

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15717/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#6 edit
2018-08-30 12:17:57 -04:00
Maneesh Gupta 5ab1d757e4 Merge pull request #564 from phani544/hipClangClass8B
Adding class size>8bytes tests
2018-08-30 10:33:47 +05:30
Maneesh Gupta 2da880620d Merge pull request #647 from tdd11235813/fix-cmake-build-name
Fixes build-name bug due to reversed string() arguments in cmake.
2018-08-30 10:32:39 +05:30
Aaron Enye Shi e7352a1f4a __forceinline__ needs inline and always_inline
Related to SWDEV-163084
2018-08-29 18:33:35 +00:00
Aaron Enye Shi bbcb3fa0c0 Remove testing bitinsert/extract on nvcc path 2018-08-29 15:29:53 +00:00
Yaxun Sam Liu 1f74a66bea Add clock() and clock64() 2018-08-29 10:51:00 -04:00
fpadmin 0022f53a10 Adding class size>8bytes tests 2018-08-29 15:16:43 +05:30
Aaron Enye Shi 5893bbc1f4 Add tests for bitextract and bitinsert 2018-08-28 20:01:54 +00:00
Aaron Enye Shi ba9fc6f355 Add bitinsert64 to device functions 2018-08-28 20:01:14 +00:00
Aaron Enye Shi b939a3c6ed Clean up and add meaningful variables to bit funcs 2018-08-28 18:19:48 +00:00
Yaxun (Sam) Liu 8c0860df88 Fix documentation about hip-clang macros 2018-08-28 09:55:18 -04:00
Yaxun (Sam) Liu f991117288 Fix documentation about hip-clang macros 2018-08-28 09:48:38 -04:00
Yaxun (Sam) Liu d107b460b2 Documents hip-clang predefined macros 2018-08-28 09:43:38 -04:00
Maneesh Gupta 5358c83a1f Merge pull request #646 from mangupta/new_ci_flow
[ci] New CI flow
2018-08-28 13:14:57 +05:30
Maneesh Gupta e4c540d7dc [ci] New CI flow
- Removed hcc integration logic for now
- No longer publish docker images to artifactory or docker hub
- Switch to new docker images and new test node

Change-Id: Idb06bf0a52658d1869367cb38bb03ef4f1649103
2018-08-28 12:36:54 +05:30
foreman 938481928a P4 to Git Change 1598666 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/27 18:36:44
SWDEV-145570 - [HIP] - Multithreading issues
	Add a lock per function so kernel parameters don't get overwritten
	Make execStack_ thread local and remove global lock use for it:
	The compiler uses the same thread to set it up and launch the function

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#19 edit
2018-08-27 18:46:34 -04:00
Matthias Werner bbfda64813 Fixes build-name bug due to reversed string() arguments in cmake. 2018-08-27 17:51:12 +02:00
foreman e52fbca4a1 P4 to Git Change 1597160 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/22 18:31:15
SWDEV-145570 - [HIP] Implemented hipSurfaceCreate/Destroy APIs.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#4 edit
2018-08-22 18:42:22 -04:00
foreman 28ce8a8a89 P4 to Git Change 1596634 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/21 18:07:55
SWDEV-145570 - [HIP] Implmented hipSurfaceCreate/Destroy APIs

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#3 edit
2018-08-21 18:29:16 -04:00
foreman 095572b7d5 P4 to Git Change 1596023 by skudchad@skudchad_test2_win_opencl on 2018/08/20 18:40:38
SWDEV-145570 - [HIP] Fixes to HIP env var logic

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15653/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#16 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#18 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#225 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#311 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#105 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#96 edit
2018-08-20 18:48:00 -04:00
Aaron Enye Shi b445e45007 Add bitextract and bitinsert functions 2018-08-20 16:46:12 +00:00
Saleel Kudchadker 8e0e373f69 Check for hipEnvVar at the same level if directed_tests location fails 2018-08-17 12:14:42 -07:00
foreman 7f80b1c6bc P4 to Git Change 1595124 by skudchad@skudchad_test2_win_opencl on 2018/08/17 14:05:25
SWDEV-145570 - [HIP] Implement environment variables and subsequent changes for HIP. This gets hipEnvVar passing

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15641/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.cpp#224 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/device.hpp#310 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/pal/paldevice.cpp#104 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/rocm/rocdevice.cpp#95 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#297 edit
2018-08-17 14:28:54 -04:00
Yaxun Sam Liu 1299b65e15 Add HIP_DB=fatbin for debugging fat binary issues 2018-08-17 11:53:45 -04:00
Jenkins 265aef0fb4 Merge 'master' into 'amd-master'
Change-Id: I4c1fe6e6cc0d4eb1be5716dc013a4ecbdbbe2f8b
2018-08-16 04:09:43 -05:00
Maneesh Gupta e2a23add02 Merge pull request #629 from mangupta/fix_swdev-160956
[hipcc] Remove libhsakmt from linker flags
2018-08-16 06:10:49 +05:30
Aaron Enye Shi dbcede2ab8 Remove few hcc specific cmake for hip-clang 2018-08-15 21:53:20 +00:00
foreman c998b3c3e2 P4 to Git Change 1594075 by skudchad@skudchad-lnx on 2018/08/15 14:00:33
SWDEV-145570 - [HIP] Fix some test failures

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#14 edit
2018-08-15 14:13:08 -04:00
foreman 21559762b8 P4 to Git Change 1593706 by skudchad@skudchad_test2_win_opencl on 2018/08/14 18:44:29
SWDEV-145570 - [HIP] Implement hipError*

	ReviewBoardURL = http://ocltc.amd.com/reviews/r/15619/diff/

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#11 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_error.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#5 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#13 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#41 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_profile.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#12 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_surface.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#9 edit
2018-08-14 18:54:13 -04:00
Maneesh Gupta e658b68c14 [hipcc] Remove libhsakmt from linker flags
Change-Id: I6dc769d09d8c7546fbc594c1eb65f9edf0f0ff58
2018-08-14 15:31:04 +05:30
foreman a38de7d73d P4 to Git Change 1592348 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 17:00:39
SWDEV-145570 - [HIP] Do not multiply block and dims for Hcc/Ext kernel module launch

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#16 edit
2018-08-10 17:16:53 -04:00
foreman 327e62e31a P4 to Git Change 1592228 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:55:25
SWDEV-145570 - [HIP] Report maxGridSize as INT32_MAX, not UINT32_MAX

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#13 edit
2018-08-10 14:10:19 -04:00
foreman 903f8a551b P4 to Git Change 1592225 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:52:21
SWDEV-145570 - [HIP] Report memoryClockRate in kilohertz too.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#12 edit
2018-08-10 14:09:04 -04:00
foreman c4e3d90ba9 P4 to Git Change 1592223 by cpaquot@cpaquot-ocl-lc-lnx on 2018/08/10 13:50:47
SWDEV-145570 - [HIP] Report clockRate in kilohertz.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#11 edit
2018-08-10 14:04:43 -04:00
Yaxun Sam Liu a6c7aeed72 Add HIP directed test hipTestGlobalVariable.cpp 2018-08-10 08:15:36 -04:00
Jenkins de7e3ec932 Merge 'master' into 'amd-master'
Change-Id: Ie207caaa50ef3b2a01ad871a8cf9c7336b81b74a
2018-08-10 04:09:46 -05:00
Maneesh Gupta 4cf851f416 Merge pull request #621 from ROCm-Developer-Tools/disable_startup_loader
Disable startup loader by default and guard with env var
2018-08-10 10:18:25 +05:30
Maneesh Gupta d8d45a906c Merge pull request #623 from ROCm-Developer-Tools/tf18
Fix declaration conflict when hip/math_functions.h is included first
2018-08-10 09:36:27 +05:30
Maneesh Gupta 04dd1a8daf Merge pull request #616 from ROCm-Developer-Tools/hip-clang-static-lib
Let hipcc handle static library for hip-clang
2018-08-10 09:35:22 +05:30
Maneesh Gupta 04a34aa46a Merge pull request #615 from aaronenyeshi/enable-hip-compiler
Enable HIP_COMPILER to choose HIP-Clang lib links
2018-08-10 09:34:51 +05:30
Maneesh Gupta 11cccaa5d0 Merge pull request #613 from ROCm-Developer-Tools/hcc-compat
Add HCC compatibility mode for hip-clang
2018-08-10 09:32:31 +05:30
Maneesh Gupta b5f2ad0715 Merge pull request #617 from gargrahul/genco_remove_adipose_extn
Remove adipose extension from genco output
2018-08-10 09:31:44 +05:30
Maneesh Gupta d358ce75db Merge pull request #619 from ROCm-Developer-Tools/revert-pr457
Revert pr457
2018-08-10 09:25:57 +05:30
Evgeny Mankov 3ddfbfa94a Merge pull request #624 from emankov/cuComplex
[HIPIFY][Complex] Add cuComplex support
2018-08-09 20:01:51 +03:00
sunway513 17f38937e0 resolve a segfault bug when env var not set; remove startup_kernel_loader class 2018-08-09 16:40:26 +00:00
Jenkins b4c7ec1f94 Merge 'master' into 'amd-master'
Change-Id: I02f86242eebb6f3035681ed074eb024b8556420e
2018-08-09 04:09:46 -05:00
Rahul Garg 8f0d684988 Clean up module api samples 2018-08-08 22:28:13 +05:30