This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.
[ROCm/clr commit: 857052be1e]
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components
Fixed memcpy when memory is allocated with driver API's.
Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.
[ROCm/clr commit: 651c7a8e27]
SWDEV-203814 - Change the return type of the hiprtcGetTypeName to have compatibility across ABIs
ReviewBoardURL = http://ocltc.amd.com/reviews/r/18392/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_rtc.cpp#9 edit
[ROCm/clr commit: 4185d21347]
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES
Return an error instead of dereferencing a null pointer. This should address the issue described
in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#59 edit
[ROCm/clr commit: ba3da9b3ec]
SWDEV-216705 - [hipclang-vdi-rocm][FBA-80]Test crash when all GPUs are hidden by ROCR_VISIBLE_DEVICES
Return an error instead of dereferencing a null pointer. This should address the issue described
in the ticket, but more places need fixing in the runtime to avoid crashes for corner cases.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device_runtime.cpp#23 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#92 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#58 edit
[ROCm/clr commit: 8d32b426dd]
Step 1. Set the same values for RT error codes as for analogous Driver's
[Reason] RT's and Driver's error codes unification in CUDA 10.2
[ROCm/clr commit: 21b0f64f3a]
SWDEV-213031 - Check the functions_ map else interpret as a hip::Function for now. Function may not be a device function and may have been obtaiend via hipModuleGetFunction and thus not in the functions_ map
ReviewBoardURL = http://ocltc.amd.com/reviews/r/18388/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#57 edit
[ROCm/clr commit: 35e0c1b6c4]
SWDEV-145570 - [hip] special case const char* for logs in case it's a null pointer.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/trace_helper.h#3 edit
[ROCm/clr commit: e3448ce6c4]
SWDEV-213526 - [hip] OOM issue
Delay any access to device layers till HIP API is called by app.
This allows the app to fork the process first and then call HIP which is legal.
Doing hip calls then fork isn't legal nor supported by ROCm.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#25 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#49 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#55 edit
[ROCm/clr commit: f5921646e4]
* fix linking of vector types when linking hipcc objects with gcc
* use __atribute__((vector_size)) with both clang and gcc
and reinstate nonaligned n=3 vector type
* use implicit conversion to value and ext_vector_type when available
* Alternate formulation for GCC compatibility
* Built-in arrays don't mix well with placement new
* Fix typo
* Add conversions to enum
* Fix Scalar_accessor assignment.
* Update hip_vector_types.h
* stir up the underlying_type hideous mess
This fixes the HIP build issue "error: only enumeration types have underlying types".
[ROCm/clr commit: 280a8ebadf]
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
-Update hipTexRefSetArray
http://ocltc.amd.com/reviews/r/18356/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#29 edit
[ROCm/clr commit: 755f35e7d8]
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
[ROCm/clr commit: a369bd4418]
SWDEV-214490 - Update HIP RT for texture3D in HIP/PAL on Windows
-Update hipMemcpy3D function
http://ocltc.amd.com/reviews/r/18346/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#90 edit
[ROCm/clr commit: 1cd1b3eae2]
SWDEV-145570 - Adding back the lazy kernel changes because the OOM issue is because of KFD/RocR.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#53 edit
[ROCm/clr commit: 94e4e87b88]
Aryan Salmanpour
ansurya
foreman
Evgeny Mankov
Yaxun (Sam) Liu
saleelk
Alex Voicu
Maneesh Gupta
Sarbojit2019
mhbliao
Vladislav Sytchenko
jglaser
Rahul Garg