SWDEV-190565 - [HIP] Don't use clSetEventWaitList and just add the event to the list in HIP.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#10 edit
... //depot/stg/opencl/drivers/opencl/api/opencl/amdocl/cl_common.hpp#24 edit
[ROCm/hip commit: 78905ef7e9]
SWDEV-145570 - Support loading fat binary generated through --genco by hipModuleLoad.
hip-clang --genco generates fat binary instead of code object. To support that
we need to extract code object from fat binary in hipModuleLoadData. This is
needed for hipRTC since multiple GPU archs may be passed.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_module.cpp#27 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#31 edit
... //depot/stg/opencl/drivers/opencl/runtime/device/devprogram.cpp#42 edit
... //depot/stg/opencl/drivers/opencl/runtime/utils/flags.hpp#308 edit
[ROCm/hip commit: 37cbce4df7]
SWDEV-189488 - [HIP] Caffe2 TensorTest.TensorSerializationMultiDevices fails
1. Make sure to set attributes->device to current device for host malloc'd
2. Return hipSuccess for hipDeviceCanAccessPeer
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#56 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#4 edit
[ROCm/hip commit: 15d1df9255]
SWDEV-145570 - Fix device name mismatch for gfx906.
For now hip-clang can only emits gfx906 ISA with conservative configurations, i.e. with ecc on and xnack on, therefore it is always gfx906. It is still under discussion how to encode the target id for xnack off or ecc off.
Therefore, the reasonable solution for now is just allow code object marked as gfx906 to be loaded on any device name that starts with gfx906. We will have more detailed control once hip-clang is able to emit code object for gfx906 with ecc off or xnack off.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#30 edit
[ROCm/hip commit: 1d60371d01]
SWDEV-144570 - Fix build failure after switching to gcc-7
- Hex representation of float needs gnu++11. We'd better not relying on
that. Change the float in hex format into alternative representation.
RBT: http://ocltc.amd.com/reviews/r/17300/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#29 edit
[ROCm/hip commit: 09920e6024]
SWDEV-187020 - Basic "Hello World" Tensorflow program fails to execute on HIP/VDI/PAL/LINUX
Make sure that the size of `dest` is big enough to hoid `src` including trailing zero byte
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#19 edit
[ROCm/hip commit: 84679ca20e]
SWDEV-187020 - Basic "Hello World" Tensorflow program fails to execute on HIP/VDI/PAL/LINUX
the API hiDeviceGetName() should pass the length of device name as argument to strncpy() instead
of total (dest) memory size which is being passed to it by its caller. Also, bit of a code clean-up.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_device.cpp#18 edit
[ROCm/hip commit: 7a1d02c8a1]
SWDEV-145570 - Check host_context when matching GPU device.
- In CL#1766264, `host_context` is introduced for mGPU support. Need to
match that context specially when trying to match GPU device context.
The following tests passed:
$ python test_dataloader.py TestDictDataLoader.test_pin_memory
.
----------------------------------------------------------------------
Ran 1 test in 0.004s
OK
$ python test_dataloader.py TestDataLoader.test_sequential_pin_memory
.
----------------------------------------------------------------------
Ran 1 test in 0.063s
OK
$ python test_dataloader.py TestDataLoader.test_shuffle_pin_memory
.
----------------------------------------------------------------------
Ran 1 test in 0.174s
OK
$ python test_dataloader.py TestStringDataLoader.test_shuffle_pin_memory
.
----------------------------------------------------------------------
Ran 1 test in 0.104s
OK
$ python test_torch.py TestTorch.test_pin_memory
.
----------------------------------------------------------------------
Ran 1 test in 0.124s
OK
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#52 edit
[ROCm/hip commit: ac884527f4]
SWDEV-144570 - Fix pointer attribute query.
- For memory not registered with runtime, return
`hipErrorInvalidValue`. That's the behavior expected to check whether
a host buffer is pinned.
- Return `hipErrorInvalidDevice` in case a registered memory object
cannot find its matching device.
RB: http://ocltc.amd.com/reviews/r/17094/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#51 edit
[ROCm/hip commit: 0f67004f12]
SWDEV-145570 - [HIP] Use a context with all devices in system for host register
hipHostRegister and hipMemcpy 0x10 and 0x20 fail in mGPU systems because
we only register the memory on the current device. But in HIP, the registering
needs to happen on all devices.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#17 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_internal.hpp#26 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#50 edit
[ROCm/hip commit: 8753616c97]
SWDEV-145570 - Workaround for mismatch of device name and bundle id for gfx906.
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_platform.cpp#25 edit
[ROCm/hip commit: 292e93bf11]
SWDEV-145570 - Fix build failure due to type mismatch of amd::Event::CallBackFunction
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#16 edit
[ROCm/hip commit: 9501045322]
SWDEV-145570 - [HIP] Track last used event and use last enqueued command in a stream rather than creating a new event
ReviewBoardURL = http://ocltc.amd.com/reviews/r/15996/diff/
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_context.cpp#15 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_event.cpp#7 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_stream.cpp#14 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/command.cpp#90 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.cpp#28 edit
... //depot/stg/opencl/drivers/opencl/runtime/platform/commandqueue.hpp#20 edit
[ROCm/hip commit: 133447a412]
SWDEV-145570 - [HIP] - Map hipinfo sample from HIP mirror so that we have the same hipinfo
Affected files ...
... //depot/stg/opencl/drivers/opencl/api/hip/hip_peer.cpp#3 edit
... //depot/stg/opencl/drivers/opencl/tools/hipinfo/CMakeLists.txt#2 edit
... //depot/stg/opencl/drivers/opencl/tools/hipinfo/build/Makefile.hipinfo#2 edit
... //depot/stg/opencl/drivers/opencl/tools/hipinfo/hipinfo.cpp#2 delete
[ROCm/hip commit: 0a8d4ee78d]
foreman
foreman