Commit Graph

999 Commits

Author SHA1 Message Date
Rahul Garg 09bb83cf2c Fix PCI Domain ID query (#1424)
* Fix PCI Domain ID query

* Update BDF comment


[ROCm/clr commit: e2260d82a6]
2019-10-07 14:11:52 +05:30
mhbliao 85640091d5 [hip] Add the missing header <sstream>. (#1498)
[ROCm/clr commit: 5fbb09fb39]
2019-10-04 13:39:29 +05:30
Rahul Garg 8d500c1b59 Add texref get APIs support (#1471)
Added support for -
    hipTexRefGetArray
    hipTexRefGetAddressMode
    hipTexRefGetAddress



[ROCm/clr commit: d5a61736d8]
2019-10-04 13:38:45 +05:30
ansurya efc64a4f8a Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.


[ROCm/clr commit: 96890792b0]
2019-10-04 13:36:31 +05:30
Siu Chi Chan 1a7fc4e5c1 fix kernel descriptor bug with code object v3
Change-Id: I9306b2baf36d338e36c5ab1226f74373a61a5ae0


[ROCm/clr commit: d8e09c4b70]
2019-10-03 10:56:35 -04:00
satyanveshd 1c9dc1331e Reimplement hipMemGetInfo (#1447)
Addresses SWDEV-136570. hipMemGetInfo changed to compute free memory based on information from kfd instead of relying on hc::am_tracker.


[ROCm/clr commit: 1ae4cbed4d]
2019-10-01 12:40:36 +05:30
Jeff Daily 280212353c hipModuleUnload should remove global variables from memtracker (#1464)
[ROCm/clr commit: 2a53299f07]
2019-09-30 10:41:20 +05:30
Sarbojit2019 3ef2e123bb [HIP] Add tccDriver info in hipDeviceProp
Fixes #1433.

[ROCm/clr commit: db4c0c0811]
2019-09-26 13:53:33 +05:30
satyanveshd ca6b4bbc0d Fix checks in hipMemcpy[D/H]to[D/H]() (#1397)
* SWDEV-202043 hipMemcpyDtoD() issue


[ROCm/clr commit: 842e304a9c]
2019-09-16 08:32:38 +00:00
ansurya 4436a38e65 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported


[ROCm/clr commit: e2a934f377]
2019-09-16 08:31:30 +00:00
Aryan Salmanpour f68652cc5f [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API (#1368)
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API

* fix formatting


[ROCm/clr commit: 6c7da60e28]
2019-09-16 08:31:17 +00:00
Rahul Garg f79ffd587e Fix typo and colon in comment
[ROCm/clr commit: d9179cbe70]
2019-09-13 03:09:01 +05:30
Rahul Garg b7a06efb6c [HACK] Temporary fix for hipFree for hipManagedMalloc
[ROCm/clr commit: 2e9b8e9d0d]
2019-09-13 02:10:21 +05:30
Jeff Daily 42c49b6ba9 fix bug where HIP_DB=1 seg faults at startup (#1388)
[ROCm/clr commit: 3d7c146296]
2019-09-05 10:04:19 +00:00
Rahul Garg 33af62d66e Revert "Using HSA API for hipMemsetAsync (#1346)" (#1381)
This reverts commit 4313f00563.

[ROCm/clr commit: d433f6fb58]
2019-09-03 05:13:46 +00:00
Sarbojit2019 15b80a759d Updated hipErrorString and CUDAErrorTohipError (#1365)
[ROCm/clr commit: b5ff9e71ed]
2019-08-29 01:02:59 +00:00
Sarbojit2019 4d23e35532 [HIP] Reclaiming hipLaunchKernel API (#1353)
* [HIP] Reclaiming hipLaunchKernel API

* Reclaiming hipLaunchKernel : Incorporated review comments

* Incorporated review comments

* Removed hipLaunchKernel Macro from nvcc path


[ROCm/clr commit: 1ae43cbeba]
2019-08-29 01:02:41 +00:00
Aryan Salmanpour e8f69a8c36 [hip] add initial implementation for hipLaunchCooperativeKernel API (#1339)
* [hip] add initial implementation for hipLaunchCooperativeKernel API

* [hip] use total number of work groups to initialize the GWS resource

* [hip] use only one argument for init_gws kernel

* [hip] use the device associated with the stream for checking the device properties


[ROCm/clr commit: 32ce882d6e]
2019-08-23 09:19:35 +00:00
Rahul Garg 14a510ee74 Fix memcpy with IPC slowness (#1321)
* Fix memcpy with IPC slowness

* Make early erroneous returns

* Real Clean up

* Real Clean up++


[ROCm/clr commit: a786728939]
2019-08-23 09:19:18 +00:00
Jatin Chaudhary 4313f00563 Using HSA API for hipMemsetAsync (#1346)
[ROCm/clr commit: 9bbd09b04f]
2019-08-21 10:00:10 +00:00
Rahul Garg 147e516d1f Fix build issues seen with hip-clang path (#1331)
[ROCm/clr commit: a0cc627c42]
2019-08-16 02:13:45 +00:00
Rahul Garg 8966072920 Add hipMemcpy3DAsync (#1320)
* Add hipMemcpy3DAsync

* Fix CI build error

* Move back stream resolution to internal function

* Remove stream redefinition and check


[ROCm/clr commit: fbc9f7e20a]
2019-08-16 02:13:16 +00:00
Rahul Garg 1ca562e14c Fix undefined identifier issue for hipExtModuleLaunchKernel
[ROCm/clr commit: 7f9de881cb]
2019-08-14 16:46:32 -04:00
Rahul Garg 6630b0caa6 Add hipMemcpyParam2DAsync (#1296)
* Add hipMemcpyParam2DAsync

* Add NVCC path changes

* Clean up

* Fix build issue

* Fix else use in both sync and async apis


[ROCm/clr commit: 569f35a258]
2019-08-09 11:50:37 +00:00
Siu Chi Chan 1436897785 Compile HIP runtime with hidden visibility by default (#1303)
* add default visibility to most APIs in program_state

* remove unwanted C++ headers

* Add symbol visibility pragmas and compiler flags

* Add visibility attribute to APIs in channel_descriptor and hip_hcc

* remove unused headers

* simplify build flags with hcc

* add pragma visibility hidden to functional_grid_launch

* [CMake] add gfx908 back


[ROCm/clr commit: 3cf2d7d385]
2019-08-08 08:33:04 +00:00
Rahul Garg 6641c0dc94 Add support for hipFuncGetAttribute (#1279)
* Add support for hipFunGetAttribute

* Support NVCC path

* Test using sample module_api_global

* Try fixing CI build failure due to hip_prof_gen scan

* Fix for CI build issue

* Resolve conflict

* Rebase and resolve conflicts with master

* Fix build error

* Fix NVCC path build error


[ROCm/clr commit: 8b6317d041]
2019-08-08 08:27:41 +00:00
Alex Voicu a59924ae98 Fix hip_throw. (#1285)
* Fix hip_throw.

* Fix typo

* No, really fix typo


[ROCm/clr commit: e24df75cc1]
2019-08-05 09:52:22 +00:00
Jeff Daily 68f674205e consolidate thread local storage (#915)
* all thread local access now through single struct

* clean up old commented-out code, more use of GET_TLS()

* fewer calls to GET_TLS by passing tls as a funtion argument

* revert unnecessary change to printf

* fix failing tests due to TLS change

* fix merge conflicts in ihipOccupancyMaxActiveBlocksPerMultiprocessor


[ROCm/clr commit: f337ae1edb]
2019-08-05 09:51:02 +00:00
Maneesh Gupta f36dced5d7 Merge pull request #1278 from gargrahul/fix_hipfuncGetAttribute_logstatus
Fix missing logstatus in hipFuncGetAttributes

[ROCm/clr commit: a489877153]
2019-08-02 10:00:38 +00:00
wkwchau 7b0f478767 Added CooperativeLaunch and CooperativeMultiDeviceLaunch flag and property for hipDeviceGetAttribute() and hipGetDeviceProperties() (#1247)
[ROCm/clr commit: ed04e96e2d]
2019-08-02 10:00:25 +00:00
Rahul Garg b064d7cab2 Fix missing logstatus in hipFuncGetAttributes
[ROCm/clr commit: 20e9aba94e]
2019-08-02 11:51:34 +05:30
wkwchau 75f1bb21b3 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases


[ROCm/clr commit: abe6776677]
2019-08-01 16:03:35 +00:00
Maneesh Gupta 60210d987c Merge pull request #1243 from jeffdaily/master-stream-lock-fix
remove stream locks where it is safe to do so

[ROCm/clr commit: 3de3f57468]
2019-08-01 08:59:13 +00:00
wkwchau a19b4fbd8b Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()


[ROCm/clr commit: 7b9801fe9a]
2019-08-01 08:58:48 +00:00
Maneesh Gupta b297398add Merge pull request #1269 from gargrahul/fix_ptr_attr_unkonwn_to_invalid
hipPointerGetAttributes- Change hipErrorUnknown to hipErrorInvalidValue

[ROCm/clr commit: e0397d3d1f]
2019-07-31 15:43:06 +00:00
Rahul Garg f9eaac9561 Add hip init in hipExtLaunchMultiKernelMultiDevice (#1263)
* Add hip init in hipExtLaunchMultiKernelMultiDevice

* Add more logstatus for multiple return paths

* Fix missing i in function name


[ROCm/clr commit: 8df47255c5]
2019-07-31 15:42:29 +00:00
Rahul Garg 3b5dac1d9d Add HIP init in hipFuncGetAttributes (#1262)
* Add HIP init in hipFuncGetAttributes

* [dtest]Remove explicit hip init call in hipFuncGetAttributes dtest


[ROCm/clr commit: c610159b85]
2019-07-31 15:42:08 +00:00
Rahul Garg 7a21d085ad Change hipErrorUnknown to hipErrorInvalidValue
[ROCm/clr commit: 1c49943ac3]
2019-07-31 00:28:30 +05:30
Jeff Daily df457ce2bd remove stream locks where it is safe to do so
[ROCm/clr commit: 734c4b92c3]
2019-07-22 17:38:51 +00:00
cdevadas 35f0fb2916 Increased the number of implicit-kernarg bytes to 56 (#1217)
[ROCm/clr commit: fc0aca2a7d]
2019-07-19 04:45:34 +00:00
wkwchau d20537e595 Fixed bug of determine max block size in hipOccupancyMaxPotentialBlockSize (#1235)
[ROCm/clr commit: 6ec476e50a]
2019-07-18 03:19:29 +00:00
ansurya 8b8946f78b Add Max Texture 1D,2D,3D device properties (#1226)
* Add Max Texture 1D,2D,3D device properties

* Corrected testcase to use enums defined in hipDeviceAttribute_t

* Added texture 1D,2D and 3D support for NVIDIA path


[ROCm/clr commit: 00aa42e05f]
2019-07-18 03:18:50 +00:00
Rahul Garg d92afe2277 Fix HIP_VISIBLE_DEVICES order (#1184)
* Fix HIP_VISIBLE_DEVICES order

* Fix device IDs mismatch

* Fix review comments- loop order and device range check

* Handle incomplete VISIBLE device env variable

* Revert "Handle incomplete VISIBLE device env variable"


[ROCm/clr commit: d2e8cdc8fb]
2019-07-18 03:18:04 +00:00
Aryan Salmanpour a4992850d8 [hip] fix a bug where we parse kernel's arguments layout for a given kernel multiple times (#1232)
[ROCm/clr commit: 8b90a5d274]
2019-07-17 07:29:07 +00:00
Evgeny Mankov 24af494e97 [HIP] Fix segfault on uninitialized struct members in hipArrayCreate and hipArray3DCreate
[ROCm/clr commit: 299fbd4842]
2019-07-12 16:38:26 +03:00
Evgeny Mankov b5f0cdaa7b [HIP][HIPIFY] Split HIP_ARRAY_DESCRIPTOR struct to HIP_ARRAY_DESCRIPTOR and HIP_ARRAY3D_DESCRIPTOR
[Reason] To be compatible with CUDA [#1133]

Update HIP code, hipify-clang, tests and docs

[TODO] Add support of the corresponding functions on nvcc fallback path


[ROCm/clr commit: f0832fd968]
2019-07-11 14:58:16 +03:00
Jatin Chaudhary 6e8edf8890 Adding bounds check before hipMemset (#1190)
* Adding bounds check in ihipMemset

* Adding ihipMemPtrGetInfo to hipMemPtrGetInfo


[ROCm/clr commit: fcb0a3d4e2]
2019-07-08 11:00:38 +00:00
Aryan Salmanpour 4b06a21504 [hip] Move _criticalData of ihipStream_t class to private section and use criticalData() to access it (#1177)
[ROCm/clr commit: 7e48231252]
2019-07-04 00:42:19 +00:00
Maneesh Gupta 154b861905 Added missing NULL checks and corrected API return values (#1188)
* Added missing NULL checks and corrected API return values as per validation

* Added missing NULL checks


[ROCm/clr commit: a220a8e8e9]
2019-07-03 08:51:39 +00:00
Anusha Godavarthy Surya 27722855b4 Added missing NULL checks
[ROCm/clr commit: 1a7c7e3b06]
2019-06-27 20:19:30 +05:30