Commit Graph

1048 Commits

Author SHA1 Message Date
ansurya 7f788181ec Fix texture tests, always pass row pitch to HSA API for linear layout images (#1785)
=> New ROCr calculates pitch as per HSA specification and addrlib is used to check whether HW can support that configuration. Hence few texture tests are failing with HSA_EXT_STATUS_ERROR_IMAGE_PITCH_UNSUPPORTED.

=> Determine pitch for linear images and always pass rowpitch to HSA API's.

[ROCm/clr commit: 688b6e6af0]
2020-01-16 08:54:30 +05:30
Jatin Chaudhary 8550b344a2 Remove filesystem dependency in hipRTC (#1749)
Removing dependency on filesystem, so libstdc++fs is no longer required to link

[ROCm/clr commit: 0b211478dd]
2020-01-10 13:47:54 +05:30
Maneesh Gupta d814f1e292 Revert PRs that break ROCm builds (#1781)
Fixes SWDEV-218626 and SWDEV-218629

Changes:
- Revert "`static inline` in a header, just like excess sugar in a diet, causes bloat (#1692)"
   This reverts commit 47725baf8c.
- Revert "Fix rocFFT build failure (#1777)"
   This reverts commit f7bac3e057.

[ROCm/clr commit: c091635f5a]
2020-01-08 15:11:58 +05:30
Siu Chi Chan 94ddf110dd Detect when an explicit printf buffer flush is required (#1766)
* Detect when an explicit printf buffer flush is required
in a device/stream synchronization function.

* hip_module.cpp: add missing hc_am.hpp header


[ROCm/clr commit: 26b50e1e1b]
2020-01-07 09:06:38 -08:00
satyanveshd 72ce61218b hipMemcpy[To/From]Symbol(Async) fixes (#1774)
[ROCm/clr commit: 9b2f22f7aa]
2020-01-07 08:11:53 +05:30
Rahul Garg 83b9cc743c Fix nested designator warnings (#1768)
[ROCm/clr commit: 178d432b90]
2020-01-06 12:33:34 +05:30
Evgeny Mankov 8c58286a9b Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)

[ROCm/clr commit: ed43699a3a]
2019-12-30 19:21:09 +03:00
Aryan Salmanpour ed2609b880 [hip] refactoring cooperative kernel launch APIs (#1737)
This PR is a follow-up on PR# #1698 and it makes two more APIs (hipLaunchCooperativeKernel/hipLaunchCooperativeKernelMultiDevice) inline so that they can work correctly with lazy binding.

[ROCm/clr commit: 857052be1e]
2019-12-30 12:42:17 +05:30
ansurya 56d51a3dc7 Fix texture 3D & 2D layered with N components (#1746)
SWDEV-151670: Issue with 3D texture with 4 components
SWDEV-151671: Issue with 2D layered texture with 4 components

Fixed memcpy when memory is allocated with driver API's.

Github issues: #1755
Fixed 3D default case when array type is not set during memory allocation.

[ROCm/clr commit: 651c7a8e27]
2019-12-30 12:41:42 +05:30
Evgeny Mankov d191980c6a [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle


[ROCm/clr commit: 4aaa2336a8]
2019-12-23 17:01:35 +03:00
saleelk 60437b9d64 Fix the return type of demangle function so that its compatible across ABIs (#1744)
[ROCm/clr commit: 1ca75e5f6d]
2019-12-23 19:11:40 +05:30
Alex Voicu 1f762e3970 Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.


[ROCm/clr commit: 150e690a3a]
2019-12-23 19:11:24 +05:30
Alex Voicu 47725baf8c static inline in a header, just like excess sugar in a diet, causes bloat (#1692)
[ROCm/clr commit: cf526f5484]
2019-12-23 19:09:38 +05:30
Rahul Garg 48faf7423a Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.

[ROCm/clr commit: a369bd4418]
2019-12-06 09:51:53 +05:30
Rahul Garg 6c7a338471 Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.


[ROCm/clr commit: 261a04580f]
2019-12-04 11:56:23 +05:30
Aryan Salmanpour 2471c1950c [hip] refactoring hipExtLaunchMultiKernelMultiDevice API (#1698)
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.

To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.

[ROCm/clr commit: 8eaea4d114]
2019-12-04 11:50:51 +05:30
Jeff Daily 22c07e2331 fix hipMempcy precondition, test for zero size first (#1697)
[ROCm/clr commit: 6df73e1f12]
2019-11-25 19:03:03 -08:00
satyanveshd e2a0a547ff fixed directed tests fail when hcc bumped to 3.0 (#1678)
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.

[ROCm/clr commit: d4dde7a27d]
2019-11-20 21:37:52 +05:30
Alex Voicu 553a7c2ce3 General sync memcpy improvements. Add hipMemcpyWithStream (#1673)
* General sync memcpy improvements. Add `hipMemcpyWithStream`

* Update hip_memory.cpp


[ROCm/clr commit: 022ac3cb0a]
2019-11-20 21:36:37 +05:30
Rahul Garg 81dd3751a6 Update error codes for hipGetDevice for doxygen and move up null check (#1668)
* [docs] Update error codes for hipGetDevice

* Move up out ptr check


[ROCm/clr commit: 13c2a31d7e]
2019-11-20 21:35:27 +05:30
Sarbojit2019 2c00d66995 Revert [HIP] Fixed hipStreamAddCallback (#1674)
This reverts commit 4d0b7e65bb.
Addresses SWDEV#212675.

[ROCm/clr commit: 8a3c36a424]
2019-11-20 11:55:46 +05:30
Jeff Daily 58d1ae32ee hipStreamSynchronize can skip marker if stream is empty (#1667)
[ROCm/clr commit: dfaaf04611]
2019-11-19 09:42:43 -08:00
Sarbojit2019 7d5bc56ab7 Added null check in hipEventSynchronize (#1627)
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description


[ROCm/clr commit: 7985ad218f]
2019-11-18 12:18:55 +05:30
Jeff Daily bc5596cc74 General hipMemset improvements (#1495)
* hipMemset et al can use HSA API directly for synchronous cases

* lock and flush stream in hipMemset, hold lock until complete

* move hipMemset async check to front of conditional

* use hsa_amd_memory_fill for additional sync memset cases

code cleanup/review for all memset calls

* Fix inversion of execution mutating value.

* ihipMemsetSync fall back to kernel if HSA memset fails

* Never fallback, never surrender.

* Allow NULL stream.

* Optimise memset kernel. Remove deadwood.

* Update hip_memory.cpp

* Clean up stream logic in sync memset

* Revert "Clean up stream logic in sync memset"

This reverts commit 6117dedf673367f44cc704192573a117a3d92477.


[ROCm/clr commit: 854147e911]
2019-11-07 13:19:54 +05:30
Sarbojit2019 4d0b7e65bb [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425)
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior


[ROCm/clr commit: 97fca3439d]
2019-11-07 13:18:12 +05:30
ansurya f5a92e5cb6 Fixed texture 2D mapping for pitched arrays & 3D Texture read (#1415)
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313

SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components

[ROCm/clr commit: dc8f556460]
2019-11-07 13:17:46 +05:30
Rahul Garg cf648f7dbe Rename hip/hip_hcc.h to hip/hip_ext.h (#1341)
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h


[ROCm/clr commit: dfee3ae279]
2019-11-07 13:17:10 +05:30
Jeff Daily 39a98df790 hipEventRecord only needs one lock; remove locked_eventIsReady
[ROCm/clr commit: b2af1820f5]
2019-11-06 15:56:32 +00:00
Jeff Daily 539d0c2ae3 remove ihipEvent_t::refreshEventStatus(), new hipEventElapsedTime
This fixes possible races in hipEventElapsedTime.


[ROCm/clr commit: 444122dfb9]
2019-11-06 15:46:46 +00:00
Jeff Daily f7e255c3c4 fix race condition in hipEventRecord
[ROCm/clr commit: 6c3479a155]
2019-11-04 17:45:11 +00:00
Rahul Garg e61ff0408c Merge pull request #1598 from lmoriche/master
Fix a code object memory corruption

[ROCm/clr commit: 2199f8a6c6]
2019-10-31 17:12:24 -07:00
Rahul Garg 138b0327da Add stream
[ROCm/clr commit: f556e15361]
2019-10-31 12:15:56 -04:00
Rahul Garg 440a172f0e Fix HIP init calls in hipMemcpy2DFromArray
[ROCm/clr commit: 0718ba0f00]
2019-10-31 12:15:56 -04:00
Rahul Garg 04785f2d54 Merge pull request #1515 from ansurya/tex_unbind_issue_fix
Fix undefined ref to hipUnbindTexture for texture types

[ROCm/clr commit: aeb7cebbad]
2019-10-30 17:54:15 -07:00
Laurent Morichetti f1f649e57c Addressed review comments
Change comment "must exceed" to "must be no shorter than"
move the std::string instead of creating a copy


[ROCm/clr commit: 3243f06eef]
2019-10-30 13:14:41 -07:00
Rahul Garg 72c686ed67 Revert "Fix occupany APIs (#1560)"
This reverts commit ad1e409a24.


[ROCm/clr commit: 27221bc823]
2019-10-29 11:41:08 -07:00
Laurent Morichetti 0113961674 Fix a code object memory corruption
The lifetime of the buffer given to
hsa_code_object_reader_create_from_memory must exceed that of the
code object reader. We need to create a copy of the code object
binary memory (file) that is kept allocated until the code object
reader is destroyed.


[ROCm/clr commit: 66c91b42e6]
2019-10-29 08:23:57 -07:00
Anusha Godavarthy Surya dfa019bdf6 Merge branch 'master' into tex_unbind_issue_fix
[ROCm/clr commit: 9332a39838]
2019-10-25 15:54:25 +05:30
Anusha Godavarthy Surya 0140ea8e1a merge from master
[ROCm/clr commit: ae838f8cee]
2019-10-25 15:52:09 +05:30
Rahul Garg 7ea7a9c3b7 Add hipMemcpy2DfromArray (#1510)
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.

[ROCm/clr commit: 14b870d1ce]
2019-10-25 15:43:33 +05:30
Anusha Godavarthy Surya 2d538b702d Merge branch 'master' into tex_unbind_issue_fix
[ROCm/clr commit: c0fc5e718c]
2019-10-25 15:36:55 +05:30
satyanveshd ad1e409a24 Fix occupany APIs (#1560)
Addresses SWDEV-205006 

[ROCm/clr commit: 6c5fbf9b4a]
2019-10-24 17:44:47 +05:30
searlmc1 510be4b5dc Improve performance of v2 arg handling (#1539)
* Improve performance of v2 arg handling

* Missing change to `std::string`


[ROCm/clr commit: 15a699688e]
2019-10-24 17:44:05 +05:30
Aryan Salmanpour 9e0eaef846 [hip] add support for implicit kernel argument for multi-grid sync (#1456)
* [hip] add support for implicit kernel argument for multi-grid sync

* modified code for calculating the prev_sum

* change the impCoopArg type to size_t

* add memory clean up

* launch init_gws and main kernels into two separate loops


[ROCm/clr commit: 93c688a0c9]
2019-10-24 17:43:30 +05:30
Rahul Garg 685a4cd182 Merge pull request #1544 from vsytch/master
QoL changes to the hipMemset family

[ROCm/clr commit: a21fe1443b]
2019-10-16 18:54:20 -07:00
Nick Curtis a7d6c03e17 Guard against division by zero for no VGPR usage (e.g., in an empty kernel) (#1528)
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)

* fix bracket format

* clean up parenthesis


[ROCm/clr commit: d16963c9d5]
2019-10-16 10:49:56 +05:30
Vladislav Sytchenko e2c2025e3e Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description.
[ROCm/clr commit: 0200aa3a21]
2019-10-15 14:18:42 -04:00
Anusha Godavarthy Surya c5fc879606 Fix undefine ref to hipUbindTexture for texture types
[ROCm/clr commit: a5d9f56bef]
2019-10-09 16:26:06 +05:30
Evgeny 266d2fd9c8 tracing layer unifying with hcc: removing API_ID_ANY
[ROCm/clr commit: ed29c10394]
2019-10-08 19:09:43 -05:00
Rahul Garg 09bb83cf2c Fix PCI Domain ID query (#1424)
* Fix PCI Domain ID query

* Update BDF comment


[ROCm/clr commit: e2260d82a6]
2019-10-07 14:11:52 +05:30