Commit Graph

912 Commits

Author SHA1 Message Date
systems-assistant[bot] 83971da05e Merge commit 'ea2d79c3e260d5728ecbc843f5367a12e9c301c4' into develop 2025-08-12 12:09:54 +00:00
systems-assistant[bot] 576faeac43 Merge commit 'c60888b0cd135739477e62d400a61138333f1b08' into develop 2025-08-12 12:09:52 +00:00
systems-assistant[bot] d5d702a0cd Merge commit '0dde3ce5898815296008b8461a5396a5c3c25a07' into develop 2025-08-12 00:25:16 +00:00
systems-assistant[bot] 2dc8e2f2d4 Merge commit '0d9428135c73bd8d14432f1d8cd64076f5ebfea2' into develop 2025-08-12 00:25:14 +00:00
Joseph Macaranas 762c088758 Add 'projects/rocm-core/' from commit '942821090f1a81d7ad55f910dffdba93c2cdca8a'
git-subtree-dir: projects/rocm-core
git-subtree-mainline: 92e841646c
git-subtree-split: 942821090f
2025-08-11 18:27:37 -04:00
Joseph Macaranas 92e841646c Reset adding rocm-core to super-repo 2025-08-11 18:26:52 -04:00
xuchen-amd 0929e6ecc1 [rocprofiler-compute] Update amd smi lookup (#223) 2025-08-11 17:37:33 -04:00
cfallows-amd 3258c69b60 Fix cmake formatting (#222)
Fix formatting of CMakeLists.txt for cmake-format check

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-08-11 16:40:09 -04:00
Ammar ELWazir 11362bb5a6 Fixing CDash AQLProfile (#252) 2025-08-11 14:42:12 -05:00
Ammar ELWazir 22c07f02da ROCProfiler CI Clean up & Testing (#240)
* CI Clean up & Testing

* CI Clean up & Testing
2025-08-11 14:26:09 -05:00
Jason Bonnell 4eaf1fe346 [rocprofiler-systems] Add new secrets, update paths (#241)
* Add new secrets, update paths

* Remove old containers.yml workflow file

* Update .github/workflows/rocprofiler-systems-containers.yml

Co-authored-by: David Galiffi <David.Galiffi@amd.com>

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-08-11 14:31:17 -04:00
vedithal-amd 002b9607b6 [rocprofiler-compute] Fix profiling tests (#227)
* Add check for SQC_DCACHE csv in test script

* Fix the list of csv files when profiling in tests
2025-08-11 09:59:34 -04:00
systems-assistant[bot] 6150a119a4 Merge commit '926eedc23089f1963f56d7220764d45fe748c792' into develop 2025-08-11 13:13:50 +00:00
systems-assistant[bot] 7105a89a51 Add 'projects/hip-tests/' from commit '5ce508401e1934053b127de5bf756dcd56a326a2'
git-subtree-dir: projects/hip-tests
git-subtree-mainline: cc7a96c46f
git-subtree-split: 5ce508401e
2025-08-10 02:09:49 +00:00
systems-assistant[bot] cc7a96c46f Add 'projects/hipother/' from commit 'e9d2abe72168de35233ed77167f7920509c05a8a'
git-subtree-dir: projects/hipother
git-subtree-mainline: d76041b87b
git-subtree-split: e9d2abe721
2025-08-10 02:09:45 +00:00
systems-assistant[bot] d76041b87b Add 'projects/hip/' from commit 'e74b05a7bd9454b97dc04d7cc4b66d1fe6c534a7'
git-subtree-dir: projects/hip
git-subtree-mainline: 64df0940b8
git-subtree-split: e74b05a7bd
2025-08-10 02:09:42 +00:00
systems-assistant[bot] 64df0940b8 Add 'projects/clr/' from commit 'ed903e888949f3631f133847f834b06b817b63b8'
git-subtree-dir: projects/clr
git-subtree-mainline: 840ad49d28
git-subtree-split: ed903e8889
2025-08-10 02:09:38 +00:00
systems-assistant[bot] 1b1610fc2b Merge commit '53873e32f3e8f8f7f341e8743bea1e2bdd7e3979' into develop 2025-08-09 01:29:22 +00:00
systems-assistant[bot] 58d2a016ce Format source code to PEP8 using Ruff (#36)
* added ruff docs

* style: Run ruff and black before yapf pass

* yapf -r -i (23 fixes)

* fixed conf.py and ran ruff format .

* fixed conf.py 2

* formatted argparser.py

* formatted src/rocprof_compute_analyze

* formatted src/rocprof_compute_profile

* formatted soc_base.py

* formatted rocprof_compute_tui

* formatted gui_components

* formatted src/utils

* formatted tests/

* format extra files

* cleanup

* fix test_utils.py

* fixed typos

* Update pyproject.toml

* Update README.md

* Update test_utils.py

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
Co-authored-by: James Siddeley <James.Siddeley@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
2025-08-08 15:32:30 -04:00
systems-assistant[bot] d3f9ab25eb Use own counter definition (#91)
* Use own counter definition
  * Do not depend on rocprofiler-sdk counter definition

* Add missing counter definitions for MI100, MI200, MI300, MI350 series
  * Counters added based on register specification
  * This prevents some missing metrics

* Enable SQC_DCACHE_INFLIGHT_LEVEL counter and associated metrics

* Enable TCP_TCP_LATENCY counter and associated counter for all GPUs
  except MI300

* Update TCC_EA_* counters for MI100 to TCC_EA0_*
  * Update MI100 metrics which depend on TCC_EA0_* counters

* Enable accumulation counters for MI100

* Improve rocprof list avail usage to get a better idea of supported
  counters

* Update CHANGELOG

* Move accumulation counters to counter definition

---------

Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com>
2025-08-08 14:39:10 -04:00
vedithal-amd 97d9f35033 Fix ctest and docker to work with monorepo (#181)
* Remove .git folder and git command check in cmake

* Update docker container to work in monorepo
    * Update docker container to mount the top level folder in monorepo
2025-08-08 10:26:57 -04:00
Gopesh Bhardwaj 891b07aa5a README update (#120) 2025-08-08 13:27:08 +05:30
systems-assistant[bot] e56ff3716d Fix rocpd memory trace csv output (#166)
Co-authored-by: Srihari Uttanur <srihari.u@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
2025-08-08 13:22:40 +05:30
Ammar ELWazir 906030caf4 Changing CDash Project (#188)
* Changing CDash Project

* Fixing CI

* Fixing AQLProfile CDash

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI

* Fixing CI
2025-08-07 23:01:25 -05:00
Ameya Keshava Mallya 8aaf146284 Merge remote-tracking branch 'origin/develop' into preserved/rocprofiler-sdk 2025-08-07 20:10:13 +00:00
systems-assistant[bot] 4d21b819ec Merge commit 'def9a3c92d304b1debc20ba3ea0c40524a1b7420' into develop 2025-08-07 18:02:25 +00:00
systems-assistant[bot] 81e7540ddf Merge commit 'e3eb0f71b1542caa1b390d513e372ad76d521391' into develop 2025-08-07 18:02:23 +00:00
systems-assistant[bot] 84ed74e8db Merge commit '926ec4a56f9800637f652a8674c73ae6e3adfdac' into develop 2025-08-07 18:02:22 +00:00
cfallows-amd d8d739f57c Re-add rhel8 roofline binaries (#122)
RHEL8 now being supported until EOS, rebuilding rhel8 bins for rocm7 (previously built for rocm7 rhel9).

Remove roofline-rhel9-rocm7, replace with new roofline-rhel8-rocm7.
Update check for roof bin.
Update any doc mentions of rhel min support version back to rhel8.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-08-07 12:24:02 -04:00
vedithal-amd 2444c20172 Fix cmake to skip textual_fspicker check (#121) 2025-08-07 11:43:22 -04:00
vedithal-amd 448e5dfbcb Backport ROCm 7.0 changelog (#116)
* Backport changelog from ROCm 7.0 RC3 cherry-pick PR
    * https://github.com/ROCm/rocm-systems/pull/93
2025-08-07 00:13:04 -04:00
systems-assistant[bot] 7ca8a4dac2 Merge commit '48c3ba36ec02c694529b3af00588c76e75e2f509' into develop 2025-08-06 23:01:54 +00:00
systems-assistant[bot] 89c74ac3d3 Update Unit of Bandwidth metrics to Gbps (#96)
* Add Utilization to metric name for Bandwidth related metrics whose Unit
  is Percent

* Update Unit of Bandwidth metrics to Gbps
    * Update metric Formula to use total duration as denominator instead of normalization unit.
    * Update metric Description
    * Update metric Unit

* Update CHANGELOG
2025-08-06 18:39:50 -04:00
Ameya Keshava Mallya 90bb0d7f01 Align submodule 'papi' with subrepo at commit 3ce9001d 2025-08-06 21:50:53 +00:00
Vaddireddy, Sushma 223c86076d Fix TCC_EA0_RDREQ_DRAM event ID and enable TCC_BUBBLE counter (#567)
* Event ID fix for TCC_EA0_RDREQ_DRAM

* Adding TCC_BUBBLE

* Adding TCC_BUBBLE Counter

---------

Co-authored-by: Sushma Vaddireddy <svaddire@amd.com>

[ROCm/rocprofiler-sdk commit: 48c3ba36ec]
2025-08-06 14:27:24 -07:00
systems-assistant[bot] b989ce05f5 Merge commit '874b920edd15be9809f0d3d6468b5930d5213c94' into develop 2025-08-06 15:02:49 +00:00
systems-assistant[bot] 0406493ae0 Merge commit 'b5e1645a1476ea48ceeb601076ccb0714cc2948b' into develop 2025-08-06 01:30:06 +00:00
Welton, Benjamin ea4e6dc572 Fix hsa_code_object_app test deadlock with profiler serialization (#577)
Problem with original test:
- Created circular dependencies between queues:
  * Queue1: Kernel A → Barrier(waits for signal_2) → Kernel C
  * Queue2: Barrier(waits for signal_1) → Kernel B → sets signal_2
- With strict "one kernel at a time" serialization, this created deadlock:
  * Queue1 executed Kernel A, then blocked on barrier waiting for signal_2
  * Serializer switched to Queue2, but Queue2 was blocked waiting for signal_1
  * Neither queue could proceed: Queue1 needed Queue2's Kernel B to complete,
    but Queue2 couldn't start until Queue1 finished completely
- Test would hang indefinitely at hsa_signal_wait_relaxed() for signal_2

Solution implemented:
- Reordered packet submission to eliminate circular dependencies
- Ensured signal producers execute before consumers need them:
  * Kernel A produces signal_1 before Queue2's barrier needs it
  * Kernel B produces signal_2 before Queue1's continuation needs it
- Dependencies now flow forward without cycles, allowing serializer progress

Refactoring changes:
- Extract common functionality into helper functions:
  * create_completion_signal() for signal creation
  * create_queue() for queue creation
  * submit_kernel_packet() for kernel dispatch packets
  * submit_barrier_packet() for barrier packets
- Add comprehensive documentation explaining expected execution pattern
- Simplify main() function making the dependency flow more readable

Co-authored-by: Benjamin Welton <bewelton@amd.com>

[ROCm/rocprofiler-sdk commit: b5e1645a14]
2025-08-05 17:29:07 -07:00
systems-assistant[bot] cdacbdc758 Merge commit '6918af0dd60df64fa445256480dd27be33979c07' into develop 2025-08-05 23:01:31 +00:00
Kandula, Venkateshwar reddy 8974913bdd [CI] fix RHEL requirements issue (#563)
* use gcc/g++ from /opt/rh/ 



[ROCm/rocprofiler-sdk commit: 6918af0dd6]
2025-08-05 15:47:47 -05:00
systems-assistant[bot] aad122c939 Merge commit '5f422c1993e4d920b388cc4fc9c52983d507c763' into develop 2025-08-05 17:05:53 +00:00
Bhardwaj, Gopesh abc105f289 Fix missing include file in rocJPEG test app (#525)
- Fixes compilation error for rocJPEG test app
- SWDEV-544094

[ROCm/rocprofiler-sdk commit: 5f422c1993]
2025-08-05 11:50:01 -05:00
Baraldi, Giovanni 593d82433a Update readme for aqlprofile (#570)
* Update readme for aqlprofile

* Apply suggestions from code review

Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com>

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
Co-authored-by: Rawat, Swati <Swati.Rawat@amd.com>

[ROCm/rocprofiler-sdk commit: 54161f54fe]
2025-08-05 11:11:40 -05:00
U, Srihari e47033196d [SDK] Fix data race by syncing emplace and flush operations. (#529)
* Fix data race by syncing reader and writer

* Address review comments

[ROCm/rocprofiler-sdk commit: fc3eb4211d]
2025-08-05 11:07:00 -05:00
systems-assistant[bot] f2eb9e07cc Merge commit 'e3206c8a29d286c448b533d51b318c3f80b7158c' into develop 2025-08-05 16:06:35 +00:00
systems-assistant[bot] 1c3af22585 Merge commit 'a84c455a9de4569e589dc22d254ef3162a2de12a' into develop 2025-08-05 16:06:34 +00:00
Radosavljevic, Milan a5db496d63 Include installation sql header in rocpd library (#576)
Include installation of rocpd sql header

[ROCm/rocprofiler-sdk commit: e3206c8a29]
2025-08-05 11:04:09 -05:00
Rawat, Swati b2ad20d187 Update CHANGELOG.md (#557)
* Update CHANGELOG.md

* some more updates

---------

Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com>

[ROCm/rocprofiler-sdk commit: ca9905d6bb]
2025-08-05 10:29:42 -05:00
systems-assistant[bot] 3b008fae9c Merge commit 'e8675243442b2fb1044235af47affad11f2ca54c' into develop 2025-08-05 15:07:38 +00:00
systems-assistant[bot] 14b0b2a7d7 Merge commit 'fd6f96ffb54054b405a6f05f800c64394126672d' into develop 2025-08-04 22:06:08 +00:00