Commit Graph

1252 Commits

Author SHA1 Message Date
xuchen-amd 0929e6ecc1 [rocprofiler-compute] Update amd smi lookup (#223) 2025-08-11 17:37:33 -04:00
cfallows-amd 3258c69b60 Fix cmake formatting (#222)
Fix formatting of CMakeLists.txt for cmake-format check

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-08-11 16:40:09 -04:00
vedithal-amd 002b9607b6 [rocprofiler-compute] Fix profiling tests (#227)
* Add check for SQC_DCACHE csv in test script

* Fix the list of csv files when profiling in tests
2025-08-11 09:59:34 -04:00
systems-assistant[bot] 58d2a016ce Format source code to PEP8 using Ruff (#36)
* added ruff docs

* style: Run ruff and black before yapf pass

* yapf -r -i (23 fixes)

* fixed conf.py and ran ruff format .

* fixed conf.py 2

* formatted argparser.py

* formatted src/rocprof_compute_analyze

* formatted src/rocprof_compute_profile

* formatted soc_base.py

* formatted rocprof_compute_tui

* formatted gui_components

* formatted src/utils

* formatted tests/

* format extra files

* cleanup

* fix test_utils.py

* fixed typos

* Update pyproject.toml

* Update README.md

* Update test_utils.py

---------

Signed-off-by: jamessiddeley-amd <James.Siddeley@amd.com>
Co-authored-by: James Siddeley <James.Siddeley@amd.com>
Co-authored-by: systems-assistant[bot] <systems-assistant[bot]@users.noreply.github.com>
2025-08-08 15:32:30 -04:00
systems-assistant[bot] d3f9ab25eb Use own counter definition (#91)
* Use own counter definition
  * Do not depend on rocprofiler-sdk counter definition

* Add missing counter definitions for MI100, MI200, MI300, MI350 series
  * Counters added based on register specification
  * This prevents some missing metrics

* Enable SQC_DCACHE_INFLIGHT_LEVEL counter and associated metrics

* Enable TCP_TCP_LATENCY counter and associated counter for all GPUs
  except MI300

* Update TCC_EA_* counters for MI100 to TCC_EA0_*
  * Update MI100 metrics which depend on TCC_EA0_* counters

* Enable accumulation counters for MI100

* Improve rocprof list avail usage to get a better idea of supported
  counters

* Update CHANGELOG

* Move accumulation counters to counter definition

---------

Co-authored-by: Vignesh Edithal <Vignesh.Edithal@amd.com>
2025-08-08 14:39:10 -04:00
vedithal-amd 97d9f35033 Fix ctest and docker to work with monorepo (#181)
* Remove .git folder and git command check in cmake

* Update docker container to work in monorepo
    * Update docker container to mount the top level folder in monorepo
2025-08-08 10:26:57 -04:00
cfallows-amd d8d739f57c Re-add rhel8 roofline binaries (#122)
RHEL8 now being supported until EOS, rebuilding rhel8 bins for rocm7 (previously built for rocm7 rhel9).

Remove roofline-rhel9-rocm7, replace with new roofline-rhel8-rocm7.
Update check for roof bin.
Update any doc mentions of rhel min support version back to rhel8.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>
2025-08-07 12:24:02 -04:00
vedithal-amd 2444c20172 Fix cmake to skip textual_fspicker check (#121) 2025-08-07 11:43:22 -04:00
vedithal-amd 448e5dfbcb Backport ROCm 7.0 changelog (#116)
* Backport changelog from ROCm 7.0 RC3 cherry-pick PR
    * https://github.com/ROCm/rocm-systems/pull/93
2025-08-07 00:13:04 -04:00
systems-assistant[bot] 89c74ac3d3 Update Unit of Bandwidth metrics to Gbps (#96)
* Add Utilization to metric name for Bandwidth related metrics whose Unit
  is Percent

* Update Unit of Bandwidth metrics to Gbps
    * Update metric Formula to use total duration as denominator instead of normalization unit.
    * Update metric Description
    * Update metric Unit

* Update CHANGELOG
2025-08-06 18:39:50 -04:00
vedithal-amd 96f6abbc03 Remove marker for test autoconfig (#857)
[ROCm/rocprofiler-compute commit: 874b920edd]
2025-08-06 10:46:04 -04:00
xuchen-amd 34dd26fb07 Enable single pass counter collection (#833)
[ROCm/rocprofiler-compute commit: 6a77d241ed]
2025-08-06 10:35:05 -04:00
vedithal-amd 5084aad00b Fix autogen config test (#856)
* Only check file content hash consistency

* Do not check file modification timestamps since that can be updated by
  git commands

[ROCm/rocprofiler-compute commit: e867524344]
2025-08-05 10:50:32 -04:00
vedithal-amd 30c32c0bd1 Fix L2 cache bandwidth metrics for MI350 (#843)
* Fix L2 cache bandwidth metrics for MI350

* Address review comments

[ROCm/rocprofiler-compute commit: b349e406ed]
2025-08-01 14:00:46 -04:00
vedithal-amd 457b00ca12 Fix metrics description (#853)
* Fix ordering of metrics description

[ROCm/rocprofiler-compute commit: 6902b12e65]
2025-08-01 13:56:29 -04:00
vedithal-amd 2cd1df0db7 Remove duplicate metric descriptions from documentation (#852)
[ROCm/rocprofiler-compute commit: d84863b7af]
2025-08-01 13:33:58 -04:00
Fei Zheng 7a4d187f40 update license files (#849)
[ROCm/rocprofiler-compute commit: 0d6e172679]
2025-08-01 10:14:39 -06:00
xuchen-amd b6a7d72212 TUI: Kernel Selection (#769)
[ROCm/rocprofiler-compute commit: 9ddee8de2e]
2025-08-01 11:31:43 -04:00
Fei Zheng bf05f442b8 Fix pc sampling unit test (#847)
[ROCm/rocprofiler-compute commit: 81daaaecc7]
2025-08-01 09:28:43 -06:00
vedithal-amd 4edffecd3c Backport CHANGELOG changes from 7.0 release (#845)
* Backport CHANGELOG changes from 7.0 release

* Backport CHANGELOG changes from https://github.com/ROCm/rocprofiler-compute/pull/815

[ROCm/rocprofiler-compute commit: 70ebb4a299]
2025-07-31 19:02:50 -04:00
Fei Zheng 666f00a07f Format code (#842)
[ROCm/rocprofiler-compute commit: 6cbda3f1d8]
2025-07-31 08:20:49 -06:00
Fei Zheng 94ce792f39 quick fix how to call v3 with pc sampling
[ROCm/rocprofiler-compute commit: 3a40e4b58c]
2025-07-31 08:17:06 -06:00
dependabot[bot] deefddf2ff Bump rocm-docs-core from 1.21.1 to 1.22.0 in /docs/sphinx (#839)
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.21.1 to 1.22.0.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/ROCm/rocm-docs-core/compare/v1.21.1...v1.22.0)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-version: 1.22.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: vedithal-amd <Vignesh.Edithal@amd.com>

[ROCm/rocprofiler-compute commit: c7b5a0f43a]
2025-07-30 14:35:32 -04:00
vedithal-amd aa2f74c10f Fix rocprof avail usage (#840)
[ROCm/rocprofiler-compute commit: ea4769f604]
2025-07-30 13:52:55 -04:00
fxmarty-amd 49b5d410e4 bugfix to make amd-smi usage backward compatible (#836)
* Update soc_base.py

Fixes https://github.com/ROCm/rocprofiler-compute/issues/835

Signed-off-by: fxmarty-amd <felmarty@amd.com>

* address comments

---------

Signed-off-by: fxmarty-amd <felmarty@amd.com>

[ROCm/rocprofiler-compute commit: 56d040156e]
2025-07-30 09:40:04 -04:00
David Galiffi 85f6fb540a Update VERSION to 3.3.0 (#838)
Bumping version now that `release/rocm-rel-7.0` has been created

Signed-off-by: David Galiffi <David.Galiffi@amd.com>

[ROCm/rocprofiler-compute commit: 8ad2aa55f2]
2025-07-29 13:02:20 -04:00
vedithal-amd 2966867099 Fix test cases (#837)
* Fix formatting

[ROCm/rocprofiler-compute commit: 80ea339217]
2025-07-28 16:19:45 -04:00
vedithal-amd 17e5892614 Enable rocpd output format with rocprofiler sdk (#790)
* Add `rocpd` choice for `--format-rocprof-output` option
* Add rocpd_data.py which defines SQL queries to extract data from rocpd database
* Use sqlite3 package to read the database
* Add `--retain-rocpd-output` option in profile mode to retain raw
  rocpd database
* Add warning notice to say `--format-rocprof-output rocpd` will be
  default in future release

For rocpd output:
* Use only `pmc_perf.csv` instead of reading individual coll_level results csv files
* Post process csv files using pandas in analysis mode instead of profile mode
* Use ACCUM counters instead of SQ_ACCUM_PREV_HIRES

* Add test cases for rocpd output format
* Fix code formatting issues
* Update CHANGELOG

[ROCm/rocprofiler-compute commit: 03d27c0ba0]
2025-07-28 11:02:28 -04:00
vedithal-amd 97465e7448 add description for MI100 counters (#834)
[ROCm/rocprofiler-compute commit: 6885cb068d]
2025-07-26 15:33:23 -04:00
vedithal-amd 354fe5f52c Unified configuration for metrics (#726)
* Show description of metrics during analysis
    * Use --include-cols Description show the Description column in analyze mode (this is hidden by default)
    * Remove tips field from analysis config

* Align metric names in analysis config and documentation

* Add unified config utils/unified_config.yaml

* Add python script utils/split_config.py to auto generate analysis configuration and documentation metrics description
   * Add test case to ensure unified config is older than auto-generated config
   * Auto generate analysis config and documentation metrics description

* Update CONTRIBUTING.md to add instructions to build documentation assets
    * Add docker image and compose file to build documentation

* Update CHANGELOG and Documentation

* Use jinja template instead of hardcoding metric tables in documentation

[ROCm/rocprofiler-compute commit: bb44e90b2d]
2025-07-25 14:01:34 -04:00
xuchen-amd dcdadfd37d Improve --time-unit arg (#807)
[ROCm/rocprofiler-compute commit: 99a6e67bcc]
2025-07-24 12:15:52 -04:00
vedithal-amd 1cf98deedf Fix rocprofv3 supported counters not being detected (#832)
* Fix rocprofv3 supported counters not being detected

* Fix rocprof interface deprecation warning appearing twice

[ROCm/rocprofiler-compute commit: dbcaccb9de]
2025-07-24 11:50:07 -04:00
vedithal-amd 449a6d41a0 Improve baseline comparison (#817)
* Do not force unsupported metrics to be specified in older gpu
  architectures as None

* Remove metrics which are explicitly set to None

* Update CHANGELOG

* Fix analysis configuration to fix baseline comparisons across all gpu
  architectures
    * Add missing 1812 section for gfx908
    * Add missing 1812 section for gfx90a

* Baseline comparision will only show common metrics
   * First workload will be used to set Metric ID index column

[ROCm/rocprofiler-compute commit: d4c316a730]
2025-07-24 11:49:02 -04:00
Fei Zheng b4c626893f Fix L2 read/write/atomic bandwidths on MI350 (#831)
[ROCm/rocprofiler-compute commit: 137f35e700]
2025-07-23 15:46:19 -06:00
vedithal-amd d9da3feadf Improve block filtering to accept metric ids (#821)
* Fix tests
* Update CHANGELOG and documentation

[ROCm/rocprofiler-compute commit: a70ae40ddc]
2025-07-23 16:16:29 -04:00
cfallows-amd f6f3a6ed3e Update standalone roofline intro (#830)
[ROCm/rocprofiler-compute commit: 2a7bbc4cc2]
2025-07-23 15:17:00 -04:00
vedithal-amd 6c8b834f5c Fix tests and formatting (#826)
[ROCm/rocprofiler-compute commit: 068e5aaef4]
2025-07-22 17:49:16 -04:00
vedithal-amd a559d9e8d1 Standalone GUI bugfix (#825)
* Fix barchart elements table ids

* Add HBM bandwidth section to L2 cache report for gfx950

* bugfix for standlone GUI

Co-authored-by: Felix Marty <Felix.Marty@amd.com>

[ROCm/rocprofiler-compute commit: e132b047cd]
2025-07-22 15:31:54 -04:00
vedithal-amd e40141f2ba Fix memory clock detection with amd-smi (#824)
[ROCm/rocprofiler-compute commit: 0fdd186dd5]
2025-07-22 13:46:06 -04:00
vedithal-amd fc2037870f fix build (#823)
[ROCm/rocprofiler-compute commit: c4d129def5]
2025-07-22 13:02:14 -04:00
vedithal-amd 46ae3d36d9 Remove hardware IP block based filtering (#820)
* Analysis report block based filtering is the default now

* Update documentation

* Update CHANGELOG

* Fix tests
    * Replace hardware block based filtering tests with report block
      based filtering tests

[ROCm/rocprofiler-compute commit: 98bb0f4237]
2025-07-21 09:37:35 -04:00
vedithal-amd 2740d18028 Remove MI50/MI60 gfx906 support per documentation (#819)
[ROCm/rocprofiler-compute commit: 537a269e95]
2025-07-18 09:57:33 -04:00
vstojilj eec311b379 Add missing <cassert> include (#800)
Co-authored-by: Anusha GodavarthySurya <Anusha.GodavarthySurya@amd.com>

[ROCm/rocprofiler-compute commit: d2cec00116]
2025-07-16 13:54:39 -04:00
Pratik Basyal 7c228474ac Minor editorial changes data type selection feature (#816)
[ROCm/rocprofiler-compute commit: 24c27462d7]
2025-07-16 12:39:24 -04:00
Pratik Basyal ce3d76674a Architecture data support and diagrams added (#814)
* Architeture data support and diagrams added

* Architecture image added

* CDNA4 Image updated

* Review feedback incorporated

* CDNA 4 partition mode added

* Fei review feedback incorporated

[ROCm/rocprofiler-compute commit: 8099fd352e]
2025-07-16 10:40:11 -04:00
vedithal-amd 9a442748ea Fix docker testing instructions (#813)
[ROCm/rocprofiler-compute commit: ccb34e8a91]
2025-07-15 17:06:22 -04:00
cfallows-amd 10ead63735 Update workflows for building (#812)
* Update workflows for building testing in pipeline: rhel8 now tests rhel8 and 9, and for both rhel and ubuntu files we are using the same image as rocprofiler-systems which is consistently updated on docker hub.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 10c696521d]
2025-07-15 15:12:21 -04:00
cfallows-amd 930b32e2cb Fix roofline block print during CLI output (#811)
Fix roofline panel in CLI analyze stage when using --block option. Improve roofline CLI output checks and logs.

---------

Signed-off-by: Carrie Fallows <Carrie.Fallows@amd.com>

[ROCm/rocprofiler-compute commit: 1d834f4190]
2025-07-15 12:42:27 -04:00
xuchen-amd a91363744c Update TUI docs. (#796)
[ROCm/rocprofiler-compute commit: bfb2dc0795]
2025-07-15 11:13:24 -04:00
Fei Zheng 1050e0201c Update peak flops for MI350 (#810)
[ROCm/rocprofiler-compute commit: e1da9355c2]
2025-07-15 08:46:13 -06:00