a369bd4418
Revert - Changes related to hipMemcpyWithStream ( #1718 )
...
Reverting #1673 , #1697 and #1707 .
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
2019-12-06 09:51:53 +05:30
261a04580f
Fix hipMemcpyWithStream ( #1707 )
...
* Fix hipMemcpyWithStream
* Add a dtest for the same.
2019-12-04 11:56:23 +05:30
8eaea4d114
[hip] refactoring hipExtLaunchMultiKernelMultiDevice API ( #1698 )
...
[Background] it was found that if lazy linking used for a library that calls hipExtLaunchMultiKernelMultiDevice API then this API can get the wrong program_state object for looking up device kernels leading to a "No device code available" error in this API.
To fix this issue, the API was refactored to be inline and get and pass the correct program_state to an internal hip API to request a multi-device kernel launch.
2019-12-04 11:50:51 +05:30
6df73e1f12
fix hipMempcy precondition, test for zero size first ( #1697 )
2019-11-25 19:03:03 -08:00
d4dde7a27d
fixed directed tests fail when hcc bumped to 3.0 ( #1678 )
...
Handled the HCC version check appropriately as few of the directed tests (SWDEV-212161) were failing when hcc was bumped to 3.0.
2019-11-20 21:37:52 +05:30
022ac3cb0a
General sync memcpy improvements. Add hipMemcpyWithStream ( #1673 )
...
* General sync memcpy improvements. Add `hipMemcpyWithStream`
* Update hip_memory.cpp
2019-11-20 21:36:37 +05:30
13c2a31d7e
Update error codes for hipGetDevice for doxygen and move up null check ( #1668 )
...
* [docs] Update error codes for hipGetDevice
* Move up out ptr check
2019-11-20 21:35:27 +05:30
8a3c36a424
Revert [HIP] Fixed hipStreamAddCallback ( #1674 )
...
This reverts commit 97fca3439d
2019-11-20 11:55:46 +05:30
dfaaf04611
hipStreamSynchronize can skip marker if stream is empty ( #1667 )
2019-11-19 09:42:43 -08:00
7985ad218f
Added null check in hipEventSynchronize ( #1627 )
...
* Added missing null check in hipEventSynchronize
* Minor correction in the Event API description
2019-11-18 12:18:55 +05:30
854147e911
General hipMemset improvements ( #1495 )
...
* hipMemset et al can use HSA API directly for synchronous cases
* lock and flush stream in hipMemset, hold lock until complete
* move hipMemset async check to front of conditional
* use hsa_amd_memory_fill for additional sync memset cases
code cleanup/review for all memset calls
* Fix inversion of execution mutating value.
* ihipMemsetSync fall back to kernel if HSA memset fails
* Never fallback, never surrender.
* Allow NULL stream.
* Optimise memset kernel. Remove deadwood.
* Update hip_memory.cpp
* Clean up stream logic in sync memset
* Revert "Clean up stream logic in sync memset"
This reverts commit 6117dedf673367f44cc704192573a117a3d92477.
2019-11-07 13:19:54 +05:30
97fca3439d
[HIP] Fixed hipStreamAddCallback [SWDEV#165185] ( #1425 )
...
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior
2019-11-07 13:18:12 +05:30
dc8f556460
Fixed texture 2D mapping for pitched arrays & 3D Texture read ( #1415 )
...
Texture 2D image mapping for pitched arrays:
github issue: Texture Object's Buffer seems to be Misaligned #886
JIRA ticket: SWDEV-199313
SWDEV-151670 : Fixed issue with 3D texture with 4 components
SWDEV-151671 : Issue with 2D layered texture with 4 components
2019-11-07 13:17:46 +05:30
dfee3ae279
Rename hip/hip_hcc.h to hip/hip_ext.h ( #1341 )
...
* Rename hip/hip_hcc.h to hip/hip_ext.h
* Deprecate hip_hcc.h
2019-11-07 13:17:10 +05:30
b2af1820f5
hipEventRecord only needs one lock; remove locked_eventIsReady
2019-11-06 15:56:32 +00:00
444122dfb9
remove ihipEvent_t::refreshEventStatus(), new hipEventElapsedTime
...
This fixes possible races in hipEventElapsedTime.
2019-11-06 15:46:46 +00:00
6c3479a155
fix race condition in hipEventRecord
2019-11-04 17:45:11 +00:00
2199f8a6c6
Merge pull request #1598 from lmoriche/master
...
Fix a code object memory corruption
2019-10-31 17:12:24 -07:00
f556e15361
Add stream
2019-10-31 12:15:56 -04:00
0718ba0f00
Fix HIP init calls in hipMemcpy2DFromArray
2019-10-31 12:15:56 -04:00
aeb7cebbad
Merge pull request #1515 from ansurya/tex_unbind_issue_fix
...
Fix undefined ref to hipUnbindTexture for texture types
2019-10-30 17:54:15 -07:00
3243f06eef
Addressed review comments
...
Change comment "must exceed" to "must be no shorter than"
move the std::string instead of creating a copy
2019-10-30 13:14:41 -07:00
27221bc823
Revert "Fix occupany APIs ( #1560 )"
...
This reverts commit 6c5fbf9b4a
2019-10-29 11:41:08 -07:00
66c91b42e6
Fix a code object memory corruption
...
The lifetime of the buffer given to
hsa_code_object_reader_create_from_memory must exceed that of the
code object reader. We need to create a copy of the code object
binary memory (file) that is kept allocated until the code object
reader is destroyed.
2019-10-29 08:23:57 -07:00
9332a39838
Merge branch 'master' into tex_unbind_issue_fix
2019-10-25 15:54:25 +05:30
ae838f8cee
merge from master
2019-10-25 15:52:09 +05:30
14b870d1ce
Add hipMemcpy2DfromArray ( #1510 )
...
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.
2019-10-25 15:43:33 +05:30
c0fc5e718c
Merge branch 'master' into tex_unbind_issue_fix
2019-10-25 15:36:55 +05:30
6c5fbf9b4a
Fix occupany APIs ( #1560 )
...
Addresses SWDEV-205006
2019-10-24 17:44:47 +05:30
15a699688e
Improve performance of v2 arg handling ( #1539 )
...
* Improve performance of v2 arg handling
* Missing change to `std::string`
2019-10-24 17:44:05 +05:30
93c688a0c9
[hip] add support for implicit kernel argument for multi-grid sync ( #1456 )
...
* [hip] add support for implicit kernel argument for multi-grid sync
* modified code for calculating the prev_sum
* change the impCoopArg type to size_t
* add memory clean up
* launch init_gws and main kernels into two separate loops
2019-10-24 17:43:30 +05:30
a21fe1443b
Merge pull request #1544 from vsytch/master
...
QoL changes to the hipMemset family
2019-10-16 18:54:20 -07:00
d16963c9d5
Guard against division by zero for no VGPR usage (e.g., in an empty kernel) ( #1528 )
...
* guard against division by zero for no VGPR usage (e.g., in an empty kernel)
* fix bracket format
* clean up parenthesis
2019-10-16 10:49:56 +05:30
0200aa3a21
Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description.
2019-10-15 14:18:42 -04:00
a5d9f56bef
Fix undefine ref to hipUbindTexture for texture types
2019-10-09 16:26:06 +05:30
ed29c10394
tracing layer unifying with hcc: removing API_ID_ANY
2019-10-08 19:09:43 -05:00
e2260d82a6
Fix PCI Domain ID query ( #1424 )
...
* Fix PCI Domain ID query
* Update BDF comment
2019-10-07 14:11:52 +05:30
5fbb09fb39
[hip] Add the missing header <sstream>. ( #1498 )
2019-10-04 13:39:29 +05:30
d5a61736d8
Add texref get APIs support ( #1471 )
...
Added support for -
hipTexRefGetArray
hipTexRefGetAddressMode
hipTexRefGetAddress
2019-10-04 13:38:45 +05:30
96890792b0
Added new Memory API's ( #1399 )
...
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.
2019-10-04 13:36:31 +05:30
d8e09c4b70
fix kernel descriptor bug with code object v3
...
Change-Id: I9306b2baf36d338e36c5ab1226f74373a61a5ae0
2019-10-03 10:56:35 -04:00
1ae4cbed4d
Reimplement hipMemGetInfo ( #1447 )
...
Addresses SWDEV-136570. hipMemGetInfo changed to compute free memory based on information from kfd instead of relying on hc::am_tracker.
2019-10-01 12:40:36 +05:30
2a53299f07
hipModuleUnload should remove global variables from memtracker ( #1464 )
2019-09-30 10:41:20 +05:30
db4c0c0811
[HIP] Add tccDriver info in hipDeviceProp
...
Fixes #1433 .
2019-09-26 13:53:33 +05:30
842e304a9c
Fix checks in hipMemcpy[D/H]to[D/H]() ( #1397 )
...
* SWDEV-202043 hipMemcpyDtoD() issue
2019-09-16 08:32:38 +00:00
e2a934f377
Added new device attributes ( #1377 )
...
* Added new device attributes
* updated comment
* updated with new device attributes supported
2019-09-16 08:31:30 +00:00
6c7da60e28
[hip] add initial support for hipLaunchCooperativeKernelMultiDevice API ( #1368 )
...
* [hip] add initial support for hipLaunchCooperativeKernelMultiDevice API
* fix formatting
2019-09-16 08:31:17 +00:00
d9179cbe70
Fix typo and colon in comment
2019-09-13 03:09:01 +05:30
2e9b8e9d0d
[HACK] Temporary fix for hipFree for hipManagedMalloc
2019-09-13 02:10:21 +05:30
3d7c146296
fix bug where HIP_DB=1 seg faults at startup ( #1388 )
2019-09-05 10:04:19 +00:00
Rahul Garg
Aryan Salmanpour
Jeff Daily
satyanveshd
Alex Voicu
Sarbojit2019
ansurya
Rahul Garg
Laurent Morichetti
Anusha Godavarthy Surya
searlmc1
Nick Curtis
Vladislav Sytchenko
Evgeny
mhbliao
Siu Chi Chan