Commit Graph

187 Commits

Author SHA1 Message Date
Maneesh Gupta f8e1c01900 Revert "Match Occupancy APIs syntax with CUDA (#1625)" (#1857)
Reverting this for now till we figure out how to avoid the build
breakage.

This reverts commit fa98798b63.
2020-02-10 10:45:28 +05:30
lthakur 4d472b777f [dtest] Update hipLaunchCoopMultiKernel.cpp (#1844)
used reinterpret_cast<uint32_t*> for numBlocks, as expected by hipOccupancyMaxActiveBlocksPerMultiprocessor() api.
2020-02-04 19:37:38 +05:30
gandryey 48d1f766d5 [dtest] RCCL multi device launch test (#1731)
Simple test for hipLaunchCooperativeKernelMultiDevice API.
2020-02-04 08:53:43 +05:30
satyanveshd fa98798b63 Match Occupancy APIs syntax with CUDA (#1625)
* Match Occupancy APIs syntax with CUDA and fix tests using these APIs
2020-01-29 13:05:53 -08:00
Evgeny Mankov 0dadb23327 Merge pull request #1759 from emankov/master
[HIP] Unify hipError_t (Step 2)
2019-12-30 19:21:09 +03:00
Evgeny Mankov 4921678b6c [HIP] Clean-up deprecated HIP error codes
hipErrorMemoryAllocation -> hipErrorOutOfMemory
hipErrorInitializationError -> hipErrorNotInitialized
hipErrorMapBufferObjectFailed -> hipErrorMapFailed
hipErrorInvalidResourceHandle -> hipErrorInvalidHandle
2019-12-23 17:01:35 +03:00
Alex Voicu 75a11330aa Fix late-coming issues. (#1724)
Implementation for hipMemcpyWithStream.
2019-12-23 19:11:24 +05:30
Vladislav Sytchenko bf3df9d7c0 Add comments explaining choice on the cap for system memory on Windows. 2019-12-13 21:38:27 -05:00
Vladislav Sytchenko 12634879e2 Add explicit cast when computing the available amount of system memory. 2019-12-13 21:37:30 -05:00
Vladislav Sytchenko b12c53cceb Reduce the amount of free host memory to 40% of what is reported on Windows, otherwise we can run into OOM situations. 2019-12-11 20:21:12 -05:00
Rahul Garg e53fc316f1 Revert - Changes related to hipMemcpyWithStream (#1718)
Reverting #1673, #1697 and #1707.
Support for hipMemcpyWithStream and memcpy optimizations, will be brought in again once issues seen with these are resolved independently.
2019-12-06 09:51:53 +05:30
Rahul Garg 892d2a562e Fix hipMemcpyWithStream (#1707)
* Fix hipMemcpyWithStream
* Add a dtest for the same.
2019-12-04 11:56:23 +05:30
Sarbojit2019 153a959280 Revert [HIP] Fixed hipStreamAddCallback (#1674)
This reverts commit 45613311d7.
Addresses SWDEV#212675.
2019-11-20 11:55:46 +05:30
Rahul Garg 188752b2cb [dtest] Rename hipExtLaunchMultiKernelMultiDevice dtest (#1671) 2019-11-19 09:41:13 -08:00
Alex Voicu 69e74c3e96 Add support for extended launch syntax. (#1530)
* Add support for extended launch syntax.

* Add unit test.

* Fix typo

* hipExtLaunchKernelGGL lives in hip_ext.h

Change-Id: Ice32dab0d43475fda65c6a910c11416871a8f2ff

* [dtest] remove redundant include from hipModuleGetGlobal dtest
2019-11-16 22:24:07 -08:00
Sarbojit2019 45613311d7 [HIP] Fixed hipStreamAddCallback [SWDEV#165185] (#1425)
Fixed hipStreamAddCallback() as requested in SWDEV#165185
Added unit test to test the behavior
2019-11-07 13:18:12 +05:30
Rahul Garg 579a4f36fa Rename hip/hip_hcc.h to hip/hip_ext.h (#1341)
* Rename hip/hip_hcc.h to hip/hip_ext.h

* Deprecate hip_hcc.h
2019-11-07 13:17:10 +05:30
Aryan Salmanpour cf92fae9e6 [hip][tests] Add two more workgroup sizes for testing hipLaunchCooperativeKernel (#1613) 2019-11-05 12:32:46 +05:30
Rahul Garg 4739e68bbe Merge pull request #1582 from amd-lthakur/hipExtMLK
Adding a directed test case for hipExtModuleLaunchKernel() api.
2019-10-31 17:13:26 -07:00
Rahul Garg 55f2a38120 Formatting changes 2019-10-30 18:12:51 -07:00
Rahul Garg 4ab71216b4 Formatting changes ,variable name and check update 2019-10-30 18:09:21 -07:00
Rahul Garg e4a1e44162 Revert "Fix occupany APIs (#1560)"
This reverts commit af351d7e1b.
2019-10-29 11:41:08 -07:00
amd-lthakur 4239c94fe5 Excluded the test case for nvcc platform 2019-10-25 15:52:11 +05:30
Rahul Garg 12e1a86ec1 [dtest] Fix hipMemset2D test (#1579)
Reverts changes made in #1399. This is a RT api test. For testing hipMemAllocPitch , a new test should be written and that should use correct memset API.
2019-10-25 15:44:05 +05:30
amd-lthakur 564418c308 Refactored the file as suggested 2019-10-25 10:44:38 +05:30
amd-lthakur 318df5c36b Update matmul.cpp 2019-10-25 09:22:07 +05:30
amd-lthakur cd25149225 Update hipExtModuleLaunchKernel.cpp 2019-10-25 09:19:49 +05:30
satyanveshd af351d7e1b Fix occupany APIs (#1560)
Addresses SWDEV-205006
2019-10-24 17:44:47 +05:30
amd-lthakur 8b496e4715 Adding a directed test case for hipExtModuleLaunchKernel() api. 2019-10-24 15:06:28 +05:30
Vladislav Sytchenko 8f0a226660 _aligned_malloc() on Windows first takes size, then alignment, which is the opposite of how the similar function behaves on Linux. Memory allocated by it also has to be freed using _aligned_free(), unlike Linux where we can use regular free().
Edit aligned_alloc() macro and add a aligned_free() one to align with the above behaviour.
2019-10-17 18:58:32 -04:00
Vladislav Sytchenko c747b77ac1 hipMemset2D and hipMemset3D tests should be passing by default. 2019-10-16 11:02:38 -04:00
Vladislav Sytchenko f5af263aba In the hipMemset2D and hipMemset3D tests synchronize with the default stream after performing an async memset. 2019-10-15 17:15:49 -04:00
Vladislav Sytchenko 346bfa90d6 Update indentation in the hipMemset3D test. Replace all tabs with four spaces. 2019-10-15 15:29:14 -04:00
Vladislav Sytchenko 00425bdf3d Add async subtest to hipMemSet3D 2019-10-15 14:24:04 -04:00
Vladislav Sytchenko 3db2ecc52b hipMemset2D test should pass only if both async and sync subtests pass. 2019-10-15 14:20:14 -04:00
ansurya 87834500b9 Fix for directed tests failure (#1511)
directed_tests/runtimeApi/module/hipLaunchCooperativeKernel.tst - Disabling test temporarily until driver support is available.
directed_tests/runtimeApi/memory/hipArray.tst - Disabling test temporarily to reimplement it correctly.
2019-10-10 19:58:41 +05:30
ansurya ba9c6e13e4 Added new Memory API's (#1399)
Added new memory API's hipMemAllocPitch, hipMemAllocHost, hipMemsetD16, hipMemsetD16Async, hipMemsetD8Async
Modified to support all scenarios hipMemcpyParam2DAsync, hipMemcpyParam2D.
2019-10-04 13:36:31 +05:30
AlexBinXie b3e6ba50c3 [hip] Added gfx803,gfx1010,gfx1012 kernel binary hipModule test. (#1444)
This is to address hipModule test seg fault in GFX1010
2019-09-30 10:38:37 +05:30
AlexBinXie 5ed1f3e2c8 [hip]Skip test when hipHostMallocCoherent is not supported by implementation (#1380) 2019-09-16 08:31:43 +00:00
ansurya ceb734b917 Added new device attributes (#1377)
* Added new device attributes

* updated comment

* updated with new device attributes supported
2019-09-16 08:31:30 +00:00
Aryan Salmanpour 48880a017e [hip][tests] add a unit test for testing hipLaunchCooperativeKernel (#1361)
* [hip][tests] add a unit test for testing hipLaunchCooperativeKernel

* use __ockl_grid_sync function

* remove already defined __ockl_grid_sync function

* use sync function for grid synchronization
2019-09-16 08:31:09 +00:00
Rahul Garg 44422065a1 [dtests] refactor windows specific changes (#1313)
* [dtests] refactor windows specific changes

* Refactor hipMemoryAllocateCoherentDriver - PR- 1309

* Fix missing z in _putenv_s

* Revert "Fix missing z in _putenv_s"

This reverts commit 099a1b20a5c75c5f122d57c0ad2bca01745cdc9c.

* Refactor changes from PR 1299

* Update hipEnvVarDriver.cpp
2019-08-16 02:13:00 +00:00
amd-lthakur 9b31d26237 [dtests] Fix build issues with hipMemoryAllocateCoherentDriver.cpp on windows (#1309)
Compilation error being observed due to popen(), pclose() and setenv() linux calls on windows. Replaced with appropriate calls on windows.
2019-08-09 11:53:16 +00:00
amd-lthakur 9abae7114c [dtests] Fix build issue with hipMemcpy_simple.cpp on windows (#1306)
Compilation error being observed on windows due to aligned_alloc() call. Mapped the call to _aligned_malloc() for windows.
2019-08-09 11:52:46 +00:00
wkwchau aaec4f73a6 Added CooperativeLaunch and CooperativeMultiDeviceLaunch flag and property for hipDeviceGetAttribute() and hipGetDeviceProperties() (#1247) 2019-08-02 10:00:25 +00:00
wkwchau e7447d5809 Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttribu… (#1238)
* Added query of hipDeviceAttributeHdpMemFlushCntl and hipDeviceAttributeHdpRegFlushCntl

* Added NVCC blocker for the hip*FlushCntl test cases
2019-08-01 16:03:35 +00:00
wkwchau 4b18b321f7 Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOc… (#1240)
* Added support of hipOccupancyMaxActiveBlocksPerMultiprocessor & hipOccupancyMaxActiveBlocksPerMultiprocessorWithFlags APIs

* Taking into account of SGPR usage to determine the max active blocks in hipOccupancyMaxActiveBlocksPerMultiprocessor()
2019-08-01 08:58:48 +00:00
Rahul Garg 0517c30507 Add HIP init in hipFuncGetAttributes (#1262)
* Add HIP init in hipFuncGetAttributes

* [dtest]Remove explicit hip init call in hipFuncGetAttributes dtest
2019-07-31 15:42:08 +00:00
Aryan Salmanpour f3c4952f80 [hip][tests] add a unit test for using hipExtLaunchMultiKernelMultiDevice API (#1250) 2019-07-24 07:57:39 +00:00
Aaron Enye Shi 0de4caa085 Fix hipMemcpy-size test running out of Host Mem (#1224)
* Fix hipMemcpy-size test running out of Host Mem

The hipMemcpy-size uses a maxElem calculated from the total GPU mem /8. Then it will allocate 4 times that amount of host memory. This tests begins failing when there is not enough host memory, such as on systems with 32GB GPU mem, and 16GB RAM. This fixes the test if not enough host memory is available on the system.

* Add windows support to hipMemcpy-size fix

* avoid linking extra libs for windows

* HIPMemcpy-size Remove freeCPU including swap
2019-07-24 07:49:20 +00:00