- VA API tracing using Timemory gotcha wrappers.
- rocDecode API tracing integration using callback to ROCPROFILER_CALLBACK_TRACING_ROCDECODE_API
- Updated videodecode ctest to validate rocDecode APIs in perfetto trace.
* Adding pc sampling how to guide
* doc update
* Fixing indentation
* updating index
* udpating doc
* updating doc
* Added field information
* Fixing Formatting
* fix formatting error
* Added json format for pc sampling
* feedback resolved
* formatting for text
* PC Sampling API doc
* Reformatted
* Note for shared systems
* update docs
* correcting relative path for cross-referencing
---------
Co-authored-by: vlaindic_amdeng <vladimir.indic@amd.com>
* initial hack to fix for v3 stucking on mi100 becasue of -m parameter and missing counter csv file
* proper formating
* refactored profiler option function to take soc arch
* resolve missing step that casued error for profiler option
* fix typo of arch name
* change method of putting soc info into profiler option
* isort and black format
* add comment for the part that handles missing counter csv file
* remove unncecessary import
---------
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
[ROCm/rocprofiler-compute commit: 5ee37b3353]
* initial hack to fix for v3 stucking on mi100 becasue of -m parameter and missing counter csv file
* proper formating
* refactored profiler option function to take soc arch
* resolve missing step that casued error for profiler option
* fix typo of arch name
* change method of putting soc info into profiler option
* isort and black format
* add comment for the part that handles missing counter csv file
* remove unncecessary import
---------
Co-authored-by: YANG WANG <ywang@ywang-ubuntu.amd.com>
Environment variable HSA_HIGH_PRECISION_MODE can be used to control MFMA
precision
Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Ib78dd9dd8867025e090a3cca96ab6db4f65dea12
* Force HSA_AMD_MEMORY_POOL_EXECUTABLE_FLAG value to be used with HSA calls
Fix for CI
* More tweaks
* Increase reproducible-runtime kernel sleep granularity
* Fix data race in synchronous device counter collection sample
* Update device counting service
- add get_active_context function
---------
Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
* Add the missing commit from #453
* Remove unnecessary conditional and use 'is' operator
Co-authored-by: Richard Ben <ben.richard@amd.com>
[ROCm/rocprofiler-compute commit: bceddb0943]
For debian use cases, package conflict is required to remove the
deprecated package during package upgrade Also removed the duplicate
setting of package obseletes in RPM usecase.
- When waiting on non-interrupt signals, do not uSleep. This causes
regressions compared to interrupt signal usage.
- Cleanup code.
Change-Id: I706bda0b13e64ffec0b607c1915d8380a2ce0dea
* Add regex for undefined behavior to ROCPROFILER_DEFAULT_FAIL_REGEX
- add UBSAN_OPTIONS to setup-sanitizer-env.sh
* Improve ROCPROFILER_DEFAULT_FAIL_REGEX
* Use -fno-sanitize-recover=undefined flag
- this compiler flag causes all undefined behavior errors to exit
* Revert ROCPROFILER_DEFAULT_FAIL_REGEX
* fix for shift overflow
---------
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Manjunath-Jakaraddi <manjunath.jakaraddi@amd.com>
* Add example for synchronous reading of device counters
We already have test cases for this use case but this a sample
such that our collaborators can have a place to quickly pull
code from for use on their end (and to serve as a working example).
* Formatting fix
* Formatting fix
* Minor change for testing
---------
Co-authored-by: Benjamin Welton <ben@amd.com>
Set execute permission for HSA allocated memory
We need execute permission for HSA memory (req for IB buffers).
Enforcement is upcoming which will break counter collection (see ticket).
Change-Id: Id939bbdd8686915407bc60d0dfcd5110b0e91e90
Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
Set execute permission for HSA allocated memory
We need execute permission for HSA memory (req for IB buffers).
Enforcement is upcoming which will break counter collection (see ticket).
Change-Id: Id939bbdd8686915407bc60d0dfcd5110b0e91e90
Co-authored-by: Benjamin Welton <bewelton@amd.com>
Co-authored-by: Bhardwaj, Gopesh <Gopesh.Bhardwaj@amd.com>
[ROCm/rocprofiler commit: 6cc5501260]
1) When `clang` is used as system compiler, libraries were built without respecting LDFLAGS. For example, this affected LTO flags, if any (and it only affected clang, not gcc).
2) Linker flags are registered as CXX flags, which produces warnings during compilation:
```
clang++: warning: -Wl,-z,noexecstack: 'linker' input unused [-Wunused-command-line-argument]
clang++: warning: -Wl,-znoexecheap: 'linker' input unused [-Wunused-command-line-argument]
clang++: warning: -Wl,-z,relro: 'linker' input unused [-Wunused-command-line-argument]
clang++: warning: -Wl,-z,now: 'linker' input unused [-Wunused-command-line-argument]
```
3) Clang does not support `-Wtrampolines` flag:
```
warning: unknown warning option '-Wtrampolines' [-Wunknown-warning-option]
```
4) No linkers support `noexecheap` anymore. `noexecheap` linker flag was a part of PaX patches to GNU ld, (which were dropped in 2017)[https://www.gentoo.org/support/news-items/2017-08-19-hardened-sources-removal.html]. Now ld/ld.lld/ld.gold don't support it and protection of heap is managed by NX bit. Therefore every compiler produces this warning:
```
ld.lld: warning: unknown -z value: noexecheap
```
Closes#210.
Co-authored-by: Sv. Lockal <lockalsash@gmail.com>
* Adding New HIP APIs
* Format Fix
* Format Fix
* Removing changes from ostream and moving it to format
* Addressing Code Review Comments
* Versioning the new hip calls formatting
---------
Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
Sajina PK
cfallows-amd
Madsen, Jonathan
Arif, Maisam
Bhardwaj, Gopesh
Elwazir, Ammar
ywang103-amd
xuchen-amd
Harish Kasiviswanathan
Welton, Benjamin
Indic, Vladimir
Pryor, Adam
benrichard-amd
David Galiffi
vedithal-amd
Ranjith Ramakrishnan
Saleel Kudchadker
Luna Nova
U, Srihari
Nagaraj, Sriraksha
Jonathan Luu
Galantsev, Dmitrii
Jakaraddi, Manjunath
Choudhary, Rahul