8ac8384aea
Fix for HIP_VISIBLE_DEVICE [SWDEV-247751]
...
Change-Id: Iff0ca6646f9d97b1ffa378c3cdc44159b6bf8ad0
2020-09-02 02:08:56 -04:00
d2b9d267b2
SWDEV-248499 Fix a crash when printf is used with cooperative kernels
...
root cause - cooperative queue is not inserted into queuePool_ (HSA queues) of ROC device calss causing a crash when creating hostcall buffers for printf
Change-Id: I3f9aceb4e5fe6a7c7a2a549a4bb0a3511fe02799
2020-08-25 16:51:34 -04:00
6e69258b69
Enable prefetch async functionality
...
Fix a typo with the name define, when compilation wasn't enabled.
Force CPU prefetch if system was forced in runtime
Change-Id: Id4b578f9fa44a45426fdb5d8ecb1da803aa42313
2020-08-13 11:09:10 -04:00
7bb671fa55
Fix HSAIL build
...
Change-Id: I34209b3ae0ce0eefc30e464fd7f081a0b62449b0
2020-08-07 17:18:38 -04:00
f8f6bc16a1
SWDEV-246565 - Remove passing -msram-ecc to Comgr
...
Change-Id: I1604a0014186a5779561da3ec3eefec65aff5c37
2020-08-06 12:48:53 -04:00
2f3df8e691
Adding device memory channel information
...
Change-Id: I47dfa3daff97b1e3f42484dde5a4aa64244ac544
2020-08-06 06:54:35 -04:00
fdef6f722f
Apply constexpr on global constant varaibles
...
When HIP_ENABLE_DEFERRED_LOADING=0, many global variables will be
referenced but they are not initialized in that early time. The patch
will use constexpr to initialze global constant varables in compile
time.
Change-Id: I9d538b7abc6a0ce700ec3332b97fc144db5fc1ef
2020-07-22 22:14:13 -04:00
214827defa
Add numa lib detection in cmake
...
If numa lib is in building system, define ROCCLR_NUMA_SUPPORT to
support numa; otherwise, don't support numa.
Change-Id: I3848d7fdec5a3813ff1edad9b71ff04372dc0b9a
2020-07-21 14:58:56 -04:00
8b7e0f3cfe
SWDEV-232197 - Use HSA_ISA_INFO_NAME as the TargetID
...
TargetID will be passed to LC compiler.
Change-Id: I0385634922c11d53b57ebd596047698c47bda72b
2020-07-21 09:24:03 -04:00
5e0bb5bd39
SWDEV-244000 - Print freeMem_ for memory accounting
...
Change-Id: I5bbce213236a109e9aa69766d2d4d370b58d0d08
2020-07-15 13:44:05 -04:00
16e6b65b5c
SWDEV-240165 - Move all amd::MemObjMap_ reference to ROCclr and only allow base ptr to get ipc handle.
...
Change-Id: I9de10a0c4ba4dee3b3c8b972966840ab807001d8
2020-07-09 21:19:45 -04:00
cd1e364911
Replacing deprecated HSA API calls with newer ones
...
Change-Id: Iebe2c00e717ab0e47c61611752b717966c719994
2020-07-08 00:32:24 -04:00
4a901f3dd3
Always print error message with the returned error code before abort
...
Change-Id: I8479abc586937a50c90b2785c4ce7364e6e9732b
2020-07-07 16:28:30 -04:00
34b82eb998
remove unused argument from enableHostcalls/disableHostcalls functions
...
Change-Id: I351a6b4e23cd9f118310c5c79b1afcb4758fde1b
2020-06-26 16:33:30 -04:00
da94cd0de1
Support numa policy set by user
...
Add hostNumaAlloc() to support numa policy set by user
Change-Id: Ib6c3e838aa53e3d9b3db9735c585df46a1c98944
2020-06-23 18:57:03 -04:00
7a3b8c6dd2
SWDEV-240566 adds error message before abort
...
Change-Id: I4dbd089daa5e6fde5e8722dc2395225dd822561c
2020-06-22 10:12:49 -04:00
5b9af8f28d
Fix some -Wunused-but-set-variable warnings
...
Change-Id: I281583b5abdfc09d5dd8b7dfb20b8821581db193
2020-06-15 17:51:01 -04:00
afe825c506
Fix compile error in ATI make build
...
Change-Id: Id9d23b8f46bf1b97c0f02c8ae0edd94e6963b1b5
2020-06-15 10:31:57 -04:00
b14d9e0a36
Deduce hops from numa distance
...
Rocr won't return real hops so that we have to deduce hops from
numa distance as a workaround. This will be subject to change
as driver team will provide a long term solution in rocm3.7
Change-Id: Ifb939ed848db190c3d544bb7f30a5821161921e6
2020-06-13 17:04:17 -04:00
30e36a4925
Get gpu asicRevision_
...
Change-Id: I8afb53e027d912843655823eebaec29901c33d28
2020-06-12 14:51:52 -04:00
c5afd5d412
Initial HMM support
...
- Expose ROCclr interfaces for HIP usage
- ROCr interfaces aren't available in staging, thus control the
build with AMD_HMM_SUPPORT define
Change-Id: Iadc2bcc230e78d3b0dc22b235189c8cc80843446
2020-06-12 09:06:07 -04:00
2b771d2f5f
Add logging support for AQL packet
...
Use AMD_LOG_LEVEL=4 and AMD_LOG_MASK=8 to print AQL log
explicitly
Change-Id: I4209d91b460e64be44261d3ab773580067e47c29
2020-06-10 14:04:47 -07:00
5203c5271b
reuse available queue with the same priority if queue creation fails
...
Change-Id: I1522935ce1a73c4724135668d039e88a9097710b
2020-06-09 17:56:18 -04:00
1d938697a1
fix a build error on TeamCity due to order of initialization in rocm Device class
...
Change-Id: I2e45e71e53272b7a7813422d3b949e3835077ab0
2020-06-08 13:56:39 -04:00
b5552aa97f
Add support for setting queue priority for ROCm backend
...
Change-Id: I67ed5a6868af79538f7f4522d8d11c043cdf3c1e
2020-06-04 20:16:32 -04:00
2b6fea4348
Fix a potential mem leak
...
If a offset of the pointer is passed to free it may release
the mem object but may not release from MemObjMap. Erase the map
by getting the parent pointer.
Change-Id: I06b92548de2d49b4029efe6b511329225007cc55
2020-06-04 14:05:11 -04:00
fabfc42b68
Fix TC linux build issue due to previous Numa patch
...
Change-Id: I6068edaf38cac6fad187c8429707afdb727e8d41
2020-06-03 16:42:53 -04:00
aedb9590be
Support Numa-aware cpu selection
...
Select cpu in terms of the smallest Numa distance for a GPU device.
This will improve performance of hipMemcpy in the mode of
hipMemcpyHostToDevice or hipMemcpyDeviceToHost for small buffer.
`
Change-Id: I2860f1f83b79be0dff7bf5e64cf68ab4448db0a1
2020-06-01 21:01:24 -04:00
fec4adfd19
check for valid queue before accessing cuMask()
...
Change-Id: I8d4b0dbcd097c2ec5c31dea5a3d0060f0864a7e8
2020-05-20 16:23:09 -04:00
0af9c06968
Modified IpcDetach to return status instead of void.
...
Change-Id: I68ed94b93f0383babe25eb046b4047d249a0fdc1
2020-05-20 03:38:21 -04:00
cd2a713d63
Add major/minor/stepping to device layer
...
Change-Id: If82ea55a46b166b243a98089a6e9c40ccfdb479f
2020-05-17 12:57:34 -04:00
fed94b8604
Add support for setting CU mask on ROCclr for ROCm backend
...
Change-Id: I0dbe2eeb33467fc0f24b26929119c10e9b455da7
2020-05-15 14:23:43 -04:00
d10d691e76
Add env var to toggle large bar support in runtime
...
Use ROC_ENABLE_LARGE_BAR (0/1) to toggle. The support is
enabled by default.
Change-Id: I6cb93a46594cb6f5e90bf6057738330225efb553
2020-05-12 13:20:06 -04:00
b4f1239f34
device/rocm: split gfxVersion to major/minor/stepping
...
Change-Id: I1e437eaee30794147713d9516229211670f01d90
2020-05-12 12:17:13 -04:00
ae4aceb55e
Make sure the list of HSA agents is valid
...
If HIP_VISIBLE_DEVICES is active, then make sure the list of HSA
agents contains the valid agents
Change-Id: I584aad999a230ab7f88a0cfe20dcd0abe79c43a5
2020-05-11 15:49:30 -04:00
3ed185307e
Fix cooperative flag for hsa_queue creation in case they're not available
...
SWDEV-233766
Change-Id: If410ecfed61f2b3bb50b847cf2ededc573139494
2020-05-11 13:40:50 -04:00
503ef06555
Clear executable permission.
...
Change-Id: Ia0d363b1ba89d7947e5b5a55cb67edba86f0515e
2020-05-07 10:38:58 -04:00
bfbc8cd09b
SWDEV-234684 - hipmemcpy optimization does not work in tests
...
Change-Id: I899d172c5b2af88c796fe9a36f97d15ac45caf94
2020-05-05 15:58:03 -04:00
0fbc0a895b
Disable small copy optimization for now
...
Change-Id: Ib7a4aa676bb60940e067c985eb19070bd63b2fc2
2020-05-05 11:52:42 -04:00
6c5a42b33c
SWDEV-232894 Port hipMemcpy optimizations from HCC to VDI
...
Apply the optimization to change for OpenCL too.
Clean up some unnecessary checks.
Change-Id: I840261fe35baeeadeba7388e86779d482f509aad
2020-04-30 11:06:28 -04:00
b54c3f7db9
Couple of cleanups.
...
Remove queue limitation since we loop through HW queues now.
Add a DevLogError if we fail to create the hsa_queue. A ticket showed a regression there.
Change-Id: I4f58e405f88e75600a762f6d6352838c969cdb5e
2020-04-29 09:18:07 -07:00
f149fe0803
P2PStating buffer allocation when P2P is not enabled between all GPUs
...
SWDEV-232580 & SWDEV-232580
Allocate p2p statging buffer when full P2P access is not available between all devices.
p2p staging buffer will eventually be used when required.
Change-Id: If8490ba7b1c52c432c1e942ae95421b9d2ec7097
2020-04-28 07:10:57 -04:00
009d0b5f55
SWDEV-232894 Port hipMemcpy optimizations from HCC to VDI
...
Change-Id: I6bebe9ac503a9f80d067aeea8a848409ad210338
2020-04-27 14:53:58 -04:00
082cbfa1f5
Don't attempt to reuse the cooperative queue
...
Change-Id: I0e98e292a562715a7b395118f899af859f3e42bb
2020-04-27 09:18:05 -04:00
97f55b5c7f
[vdi] Add device assertion support.
...
- Once device assertion occurs, abort the host execution as well.
- TODO: This's the initial support. As we need to drain hostcall queue
to ensure device assertion message being flushed out, hostcall
listener needs an interface to explicitly drain its queue.
Change-Id: I8a04400aa7109bfd054ae5777c41a4abbf0db4a9
2020-04-22 10:03:55 -04:00
7458bf9964
SWDEV-229840 - Improve error messages on ROCCLR Layer.
...
Change-Id: Iab7d9156cdc206db86385aa05023a0095ed40f92
2020-04-19 20:01:49 -04:00
481d526859
SWDEV-184709 - support hipLaunchCooperativeKernel()
...
- Enable cooperative groups support, based on ROCr capability
Change-Id: I975bcea0af7865009eaed24454ce71d897ea8fc4
2020-04-01 12:13:33 -04:00
7ef8dfdfe7
SWDEV-184709 - support hipLaunchCooperativeKernel()
...
Add ROCr cooperative queue allocation
Change-Id: I1384482692f4080d31255b09e0f68a21ccad3da8
2020-03-30 16:09:09 -04:00
52046e41b2
SWDEV-224023
...
Correct typo.
Change-Id: I72131a6e0210e7b961e586cd0ae18608d21fc529
2020-03-15 16:37:25 -04:00
e76d867740
SWDEV-224023
...
Each WGP consists of 2 CU, so the number of available SIMD units is doubled.
Change-Id: I43978a8a9139c33f5f776b344a36bee927cc187d
2020-03-06 13:43:36 -05:00
Sarbojit Sarkar
Aryan Salmanpour
German Andryeyev
Jason Tang
Jatin Chaudhary
Tao Sang
kjayapra-amd
Dittakavi Satyanvesh
Vlad Sytchenko
Jason Tang
Saleel Kudchadker
Chauncey Hui
Christophe Paquot
Michael LIAO
Alex Xie
agodavar