Commit Graph

54 Commits

Author SHA1 Message Date
German Andryeyev eef47ca24a SWDEV-353281 - Initial support of memalloc in graph
Add memory allocation support in graph. Current implementation uses
cache from mempool  to hold the allocations which belong to the graph.
Also the resource tracking is disabled at this moment because mempool
operates with hip::Stream objects, but graph has execution with
amd::HostQueue objects.

Change-Id: I54fe3250126d24f5a26ada975f37d429bb4ef17b
2023-01-13 13:06:59 -05:00
Jiabao Xie 03200953e5 SWDEV-374375 - moving nullptr check into hipGraphNode::isValidNode
Change-Id: Ic9264521d6f0b36ffc948ca9feeaa70eb6e98eb6
2023-01-09 16:27:38 -05:00
Jaydeep Patel f2b0542442 SWDEV-374370 - Propogate element size to blit kernel.
Change-Id: I8a3355c62947265be34e6a2befd26f86b3dc6cd2
2023-01-01 23:54:09 -05:00
Anusha GodavarthySurya 0fcc5557bd SWDEV-325711 - Node can be enabled/disabled only for kernel, memcpy and memset nodes
Change-Id: Id9c19a14655732d61fccee9c3d1ffa0614123468
2022-12-13 05:08:38 +00:00
Anusha GodavarthySurya 5bcfb07c85 SWDEV-372521 - Fix copy of unused kernel attributes
Change-Id: Ib93f27d68cedac2182ba6dac0c234cc71c2c4229
2022-12-13 03:44:10 +00:00
pghafari 5acc2cdcc2 SWDEV-368166 - hipGraphAddMemcpyNode1D paramcheck
adding parameter check for hipGraphAddMemcpyNode1D

Change-Id: I94dc944bd55ea04b8e9288a27c8f58dd3720161b
2022-12-07 18:29:11 -05:00
Anusha GodavarthySurya 16b31b0c54 SWDEV-325711 - Correct formatting
Change-Id: Ie26159e0bb3315cf7c3de1eb682f23ef343df0f2
2022-11-30 05:15:01 +00:00
Anusha GodavarthySurya 3a9621574c SWDEV-325711 - Added implementation for graph API hipGraphKernelNodeCopyAttributes
Change-Id: I576d0e81c69097fe881556f6d022bb7c7ca3287b
2022-11-29 02:53:14 +00:00
Anusha GodavarthySurya 1ab46fe7ae SWDEV-325711 - Added implementation for graph APIs GetEnabled & SetEnabled
Change-Id: I15a165b3dc548d00b7f5458e1b322b192b8c0d76
2022-11-28 21:50:36 -05:00
Tao Sang 530ec02aae SWDEV-368280 - Fix crash in graph stream capture
Fix crash in graph stream capture for hipExtModuleLaunchKernel.

Change-Id: Ieaaed1d15b4d268193d8341d4b1609f83a9e4789
2022-11-28 09:33:39 -05:00
Anusha Godavarthy Surya 85296e280a SWDEV-240806 - Fix command release with new commands for every launch
Change-Id: Iecbf11a8f9e9b50f39858f2000a2d5266f0ef364
2022-11-25 09:30:45 +00:00
Anusha Godavarthy Surya 08c4619fab SWDEV-366653 - Added Implemention of DOT file generation for graph
Change-Id: I5ab6a58e49451b5e04f2e93bf594b985ac58cc8d
2022-11-24 11:02:21 -05:00
sdashmiz 5ec93c544e SWDEV-368695 - correct node type
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I23930be7d2f3415c14fc2ec3af4c526cb89d26f7
2022-11-24 10:35:34 -05:00
Tao Sang 0c4307f86e SWDEV-363038 - Fix hipGraphKernelNodeSetParams
Fix crash in hipGraphKernelNodeSetParams where paremeters
are taken from hipGraphKernelNodeGetParams.

Change-Id: I2216f72f4d4de6dd3766343b0d821cb3d35d7853
2022-11-01 15:02:39 -04:00
sdashmiz 4fc9df2a1a SWDEV-357917 - correct userobj for negative test cases
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6a2a74c763d2b938430ca53a14360f459af04665
2022-10-24 10:27:02 -04:00
Tao Sang f83ba8cd23 SWDEV-318349 - Fix hipGraphKernelNode and hipGraphMemcpyNode
For hipGraphKernelNode, remove func_;
and reorganize functions to naturely support mGPU;
For hipGraphMemcpyNode, make EnqueueCommands() support different
queues' sync
Change-Id: I22708923f454adf4456ff99d25559daffed8c20d
2022-10-07 09:07:56 -04:00
sdashmiz 39fc6605ec SWDEV-351274 - add proper checks for set attribute
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I9243e6180f3040341396b7159622f2b96e143ac2
2022-09-09 10:49:33 -04:00
sdashmiz ce5103ac97 SWDEV-352290 - remove the static list for user obj
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I8d7542ad5aacdda4e817c6aaed78c9cac4562efd
2022-08-24 12:01:41 -04:00
sdashmiz 2c010dec17 SWDEV-325711: Add userobject functions for graph
- add user obj APIs for creating release and retain of user onbjects

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0bf2999c77e44269565b27c31c7c1461f8a160a2
2022-08-17 14:31:43 -04:00
sdashmiz 66bde8f336 SWDEV-346456 - fix test for get/set attr
- test should allow first calling get function

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I365cd6210a01fd5ae3620711694bdc52e0f90b19
2022-07-25 15:17:27 -04:00
Sourabh Betigeri 5549c8cd1b SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3
2022-06-14 18:06:21 -04:00
sdashmiz 13c875eaf0 SWDEV-321698 - remove Memcpy1D type
- Memcpy1D node type is not complying with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If8113f5e699de0c62d98effc4580a2e0fee9a950
2022-06-13 08:31:02 -04:00
Ajay c06bfa6bef SWDEV-337331 - graph feature on Windows
Fixes for hipGraphInstantiate OutofMemory issue and
soft hang of hipStreamSynchronize.
Change-Id: Ic2bb97582c5978ef2e4eb3a1b124483aa412838e
2022-06-09 12:04:51 -04:00
sdashmiz efd2d55e9d SWDEV-318833 - Get and Set attribute for kernel nodes
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
2022-06-09 09:47:05 -04:00
pghafari 63f23ec2b0 SWDEV-327960, SWDEV-316901 - Adding Graph checks
hipGraphExecMemcpyNodeSetParamsToSymbol, fix for functional cases
failing as well

Change-Id: I9f263778f6b24e3ec35a78231a17e01c0d44f23a
2022-04-26 21:04:32 -04:00
pghafari 798a304dbd SWDEV-316292 - adding Graph checks
hipGraphExecMemcpyNodeSetParamsFromSymbol negative test cases

Change-Id: I7b6c496a8bca831dc90d1d427273a2a4fea96587
2022-04-05 13:26:46 -04:00
Payam 8618b1cd07 SWDEV-316819 - graph check ChildGraphNodeGetGraph
Change-Id: Id3a4fb64e6fb5ce37e97f1f3518e09c8bd9a2d0c
2022-04-05 01:24:36 -04:00
Payam Ghafari d888c0a9bf Revert "SWDEV-316819 - adding graph checks"
This reverts commit 5dd91d698b.

Reason for revert: Catch2 test fails

Change-Id: If0ea0eab16b50f27c9acbc471530266917773ff1
2022-03-23 15:23:00 -04:00
Payam 5dd91d698b SWDEV-316819 - adding graph checks
hipGraphChildGraphNodeGetGraph - Scenario 3: Pass Parent node instead of the child node

Change-Id: Ia55921bca1e2745c9c97f2b7eb36244ffb719eb4
2022-03-14 22:43:58 -04:00
Shadi Dashmiz 1965dd5795 Revert "SWDEV-321698 - hipGraphNodeTypeMemcpy1D NVDIA build failure"
This reverts commit 74beb4583c.

Reason for revert: hip changes not in yet

Change-Id: I89e35d171cf01fb82d361279998efcc90e54ef33
2022-03-08 15:08:31 -05:00
Sourabh Betigeri 0ae70a4c8d SWDEV-313503 - Returns appropriate error code when destroyed exec graphs are launched
Change-Id: I3ca025494fd27f9ed0cd4534c740f7e19e1c66b3
2022-03-08 11:54:04 -05:00
sdashmiz 74beb4583c SWDEV-321698 - hipGraphNodeTypeMemcpy1D NVDIA build failure
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I7aea11bf14adbeb7fea68eb862df74fcf6f13d75
2022-03-07 16:26:11 -05:00
Christophe Paquot 29851c0d34 SWDEV-325249 - hipGraphAddKernelNode incompatible with hipFunction_t
If params.func isn't a host function, assume it's a hipFunction_t.

Change-Id: I43361ec49a8dd579225f30e31722977ca9a82378
2022-03-07 13:33:17 -05:00
Ajay ef71f0ded1 SWDEV-313680 - hipGraphAddKernelNode invalid cases
Change-Id: I4c87c5dd80cd3f78f5c38b2d3447b03b91ffa656
2022-03-03 20:43:02 -05:00
Ajay 944c18c754 SWDEV-315443 - hipGraph and Node issues
Change-Id: I9fefd1a12d83bfa89d6704ee236c1409618ab02a
2022-03-02 00:40:05 +00:00
Sarbojit Sarkar a1562ec8f8 SWDEV-314667 - Fix for crash
Change-Id: I1cfeadde975649fb1791cf354f7ba3f70db9d162
2022-02-20 23:04:11 -05:00
Satyanvesh Dittakavi 6e562f4d83 SWDEV-306940 - Fix hipamd errors/warnings found by CppCheck
Change-Id: Ia93d4f5262ea4269d8031edbfd27033b887e5300
2022-02-05 08:42:47 -05:00
Ajay cb79dc7486 SWDEV-313082 - hipGraphMemsetNodeSetParams invalid params
Change-Id: Ibe57df8d7d583daf9ba9c7a86863eacca4868f3a
2022-01-28 19:27:32 -05:00
Ajay 0440d945e8 SWDEV-316467 - hipGraphMemcpyNodeSetParamsToSymbol negative scenarios
Change-Id: Ic2a6ce1572f35dabe754c9459690448c49bbd4a6
2022-01-27 21:25:20 +00:00
Sarbojit Sarkar e34fd8abe1 SWDEV-317925 - Fix for remove dependency issue
Change-Id: Ifbd3e9892f328d9c0d029c81d7bd08d9d444a318
2022-01-23 23:11:32 -05:00
Sarbojit Sarkar 7fe2a6e62f SWDEV-317974 - Fixed missing dependent node issue
Change-Id: Ia143c9ef93c465a5be67238d7f802c274da751bc
2022-01-23 23:10:58 -05:00
anusha GodavarthySurya cfb42c1408 SWDEV-240806 - Added graph API hipGraphExecUpdate & hipGraphExecChildGraphNodeSetParams
Change-Id: Ie9c85b746846374b73194b96c7ee73d15463b894
2021-11-19 20:42:54 -05:00
anusha GodavarthySurya ce58dae704 SWDEV-240806 - Added support for host graph node
Change-Id: I8b3088d34d0b4e8080b55b5da80d821c5f29d8a4
2021-11-17 01:10:18 -08:00
anusha GodavarthySurya 9c8b6b65e0 SWDEV-308983 - Fix hipGraphKernelNodeSetParams
Change-Id: I8a57a4e33048931955b7ba5ed567631703bd6c5d
2021-11-17 01:02:50 -08:00
anusha GodavarthySurya ec6b8d82b5 SWDEV-240806 - hipGraph performance create new graph commands for every launch
Change-Id: I7360b48055f67a91c23169ca532a19124d40e98b
2021-11-17 00:13:52 -08:00
anusha GodavarthySurya f6456c5e27 SWDEV-24806 - Added support for event wait and event record graph APIs
hip graph implementation for APIs AddEventRecordNode, AddEventWaitNode, EventRecordNodeGetEvent, EventWaitNodeGetEvent, EventRecordNodeSetEvent,EventWaitNodeSetEvent, ExecEventRecordNodeSetEvent, ExecEventWaitNodeSetEvent

Change-Id: Ifde51f4591067795d6cbf5595372cbdbd8a7bc26
2021-10-06 00:31:42 -07:00
anusha GodavarthySurya c4eda85835 SWDEV-24806 - Added support for memcpy related graph APIs
hipGraphMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams1D, hipGraphExecMemcpyNodeSetParams, hipGraphAddMemcpyNodeFromSymbol, hipGraphMemcpyNodeSetParamsFromSymbol, hipGraphExecMemcpyNodeSetParamsFromSymbol, hipGraphAddMemcpyNodeToSymbol, hipGraphMemcpyNodeSetParamsToSymbol, hipGraphExecMemcpyNodeSetParamsToSymbol

Change-Id: I6896144f340867d938aa1777880c78c46ca6f893
2021-10-05 22:43:49 -07:00
anusha GodavarthySurya 1c51d82dd5 SWDEV-240806 - Added few Graph API Implementation
hipGraph APIs clone, childGraph, RemoveDependencies, GetEdges,GetDependencies, GetDependentNodes, GetType and DestroyNode
hipStream APIs GetCaptureInfo, GetCaptureInfo_v2, UpdateCaptureDependencies.

Change-Id: Ib0f4cb8ea335698eecdd6d744ffab1e954153673
2021-10-05 07:44:54 -07:00
Anusha GodavarthySurya a71f54d9e9 SWDEV-240806 - Added API hipGraphAddMemcpyNode1D, hipGraphAddEmptyNode, hipGraphExecKernelNodeSetParams
Change-Id: I0d7ec8c0ea1abc3fc0f1e10fa7865f355d9cf2ad
2021-07-28 00:09:16 -04:00
Vladislav Sytchenko d3062d3bc2 SWDEV-240807 - Fix Windows build
These are defined as structs in HIP headers, not as classes.

Change-Id: Ie53424a026424c71fd45db3a60e5be906d472c5d
2021-07-21 20:40:16 -04:00