a2cff3c84d
[RDC] Fix GPU_COUNT metric to only count GPUs ( #1453 )
...
* [RDC] Fix GPU_COUNT metric to only count GPUs
* [RDC] Clean up float->double casts
---------
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
2025-10-30 12:50:47 -05:00
e0ec72ccdd
[rdc] Bump rocprofiler-sdk requirement to 1.1.0 ( #1610 )
...
Fixes RDC builds broken by #1563
2025-10-30 10:06:45 -04:00
8abe24d3b0
rdc: Add CPU support and CPU metrics infrastructure ( #770 )
2025-09-12 16:14:38 -05:00
a2d3f4a0e0
rdc: Profiler - improve metrics path detection ( #333 )
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com >
2025-08-13 12:33:17 -05:00
45e62ada3d
Profiler - Add metrics location
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 0a19a7ffc1
2025-07-30 16:59:44 -05:00
758adbc1a3
Profiler - Update counter definitions to match changed api
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 8f3a232613
2025-07-23 23:27:04 -05:00
8fc1d27ecd
Profiler - Remove UUID metric
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 059451d48f
2025-07-22 14:55:28 -05:00
07346922f5
Adam/bill cleanup ( #209 )
...
Co-authored-by: Bill(Shuzhou) Liu <shuzhou.liu@amd.com >
[ROCm/rdc commit: ca9d8c4bae
2025-07-07 15:41:22 -05:00
1d55c1d820
CMAKE - Format with gersemi
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 40545dcb49
2025-06-27 17:25:51 -05:00
bb0c4b7653
Python - Add entitycodec
...
Change-Id: I9dc7f5786e2c5ee5f9756cad7cb12387d05982ae
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: cae49cf4f7
2025-06-24 17:01:43 -05:00
5151fe9649
CMAKE - CONFIGURE -> CONFIG
...
Change-Id: I716f713363469091e944bdda5ecd6886a3a43aa1
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 502fcef7b3
2025-06-24 17:01:43 -05:00
ad14980e9a
Profiler - Add partition support
...
NOTE: GPU ordering used is not the same as in HSA/HIP.
GPUs are ordered via amdsmi and then GPU_ID fields are compared to map
GPU partitions to each other.
Change-Id: If379214f5281d7d5ee98515b3e5ba7affc2e2197
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 85b619b2f0
2025-06-03 19:34:00 -05:00
a14c15ea28
Profiler - Update to 1.0
...
Change-Id: Iee6d5e7a87a5eb8eed61adccf6729e4d6a144bf8
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 2adc8f82c6
2025-06-03 19:34:00 -05:00
0d352c515e
Profiler - Align SMI and Profiler indices
...
Change-Id: If2bb850ffd1c1b8b16a8f5963a0f6971f82d4863
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: eff955fdf7
2025-05-21 19:11:17 -05:00
0702a6a5a2
Profiler - Fix SIMD Utilization
...
Change-Id: I6775cce9901a714d20e80c8c17e7a563edeb48a4
[ROCm/rdc commit: 33924ea79e
2025-05-07 00:56:52 -05:00
1e8bc4dc96
CMAKE - Format with cmake-format
...
Change-Id: I08e71fc5060b1f6e0168225cc5fe66886c2044bd
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: fa8b89f4ae
2025-05-06 17:28:14 -05:00
b6488d150d
Profiler - Add SIMD_UTILIZATION ( #171 )
...
Change-Id: I19d5acd80dbed8c4fc4e1c85eec71ca89398d299
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 02c0786a2c
2025-05-06 13:20:03 -07:00
0a05e0db08
Profiler - Remove buffer to fix memory leaks
...
Change-Id: Ia3717ccfc147221557f5469965c2abb76b3f451c
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: dfae9cd37f
2025-04-11 17:27:27 -05:00
d87fe5bada
Profiler - Fix eval fields
...
The 'value' pointer was being written to a lot and then used for reading
within the same function. This likely caused issues all over RDC when
reading the metrics.
This commit changes it so *value is written to only once.
Change-Id: I83c158c1e46c6ce46ff87d8a2e769f26ffa8c0da
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 91be467cad
2025-04-09 20:06:21 -05:00
3273e2993b
Profiler - Remove bootstrap link
...
Change-Id: Ieea57515d77c2d521d95568c3bc2660cc829d829
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 58350a8bb8
2025-03-27 23:29:30 -05:00
bfee4ae9ee
Profiler - Add CPC and CPF metrics
...
Change-Id: I27fd725e9e1868c9afe7624d6e4aafad2a42d47e
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 51de344be7
2025-03-27 19:01:23 -05:00
0186fc2481
SWDEV-508477 Eval Flops Percent ( #85 )
...
SWDEV-508477 - Profiler add FP*_PERCENT
Change-Id: Idb6250fe6b7ba3df6fe7d30861e0fbbda7e9bdce
Signed-off-by: adapryor <Adam.pryor@amd.com >
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 6f358ddc9e
2025-01-24 10:07:32 -06:00
3218c2af5c
CMAKE - Rename SMI_*_DIR into AMD_SMI_*_DIR
...
Change-Id: I3b8b852e6b68f1448c8ed5d5e6ea4579c470ff53
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: e033fd4c55
2025-01-23 20:56:00 -06:00
8286a92fc1
Implementation for RDC_FI_PROF_OCCUPANCY_PER_ACTIVE_CU SWDEV-50895
...
Signed-off-by: adapryor <Adam.pryor@amd.com >
Change-Id: I8da7d9846edabe5629c75f50cd2bb4b23e019a17
Signed-off-by: adapryor <Adam.pryor@amd.com >
[ROCm/rdc commit: 290b90dc89
2025-01-21 21:49:19 -06:00
9f1f502d93
SWDEV-510089 Fix rocprof segfaulting on ctrl+c ( #94 )
...
Change-Id: Iaa0f3856bb8fed174cbc935b85739414ecd44758
Signed-off-by: adapryor <Adam.pryor@amd.com >
[ROCm/rdc commit: 0ae4404a09
2025-01-21 10:30:31 -06:00
725599b51c
Add RDC_FI_PROF_SM_ACTIVE metric.
...
Signed-off-by: Greg Scaffidi <salvatore.scaffidi@amd.com >
Change-Id: I63aaf5eb05d74ba696ace2b088e17c2cfb1bd74b
Signed-off-by: adapryor <Adam.pryor@amd.com >
[ROCm/rdc commit: f4de4b0529
2024-12-21 15:21:46 -06:00
755ae0ee5d
Profiler - Migrate from rocprofv1 to rocprofv3
...
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
Fixed RDC for Rocprofv3
Updates
Signed-off-by: adapryor <Adam.pryor@amd.com >
Change-Id: Ic9162bacf1322b265e6bbcdd9fbb9b1fdef414fd
last updates
Change-Id: I12e168501327c5e4cff8a9273b0512fb0e098fe7
comment
Change-Id: I61da61e66dcc017ec46f98ff4c90fb064c9679e8
[ROCm/rdc commit: 7c91a07a43
2024-12-20 15:39:02 -06:00
d9b13912c6
Profiler - Remove averaging
...
Averaging happens very slowly and only confuses people...
Change-Id: I60754d3b896b6ffeb6104bb1c2fcc54e9869b331
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 2c61dfe2ce
2024-12-11 11:58:50 -06:00
fc83179a9d
Profiler - Fix fp64 metric
...
Change-Id: Iab27e21740c2c51143a9e88d085b80716bf193e2
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 2605eda5f3
2024-12-11 11:27:41 -06:00
a8086b484d
rocprofiler: add valu utilization
...
SWDEV-475242
For the description of "FP32 Engine Activity" and "FP64 Engine Activity" in dcgm,
It seems that we do not have an equivalent to these pipe-utilizations on our hardware.
In rocprofiler, I think VALU Utilization is the closest to what we want.
Change-Id: Ibce8835ef4757084cdfd73258de6fc1606ca0158
Signed-off-by: Chen Gong <curry.gong@amd.com >
[ROCm/rdc commit: 251fcbe49d
2024-11-21 15:24:01 +08:00
b0035605ee
CMAKE - Find modules at build time
...
Change-Id: I9370ef1433579aff1a37f3636050f525638d8658
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: cdf1588974
2024-11-07 11:21:22 -06:00
39687e8d96
CMAKE - Fix RVS include
...
Change-Id: I65095cc3d04fc2a5daeee5c809f635cb1662822f
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
Revert "Disable RVS as the error scares people"
This reverts commit f3450f61bfdmitrii.galantsev@amd.com >
[ROCm/rdc commit: dd50027748
2024-11-07 11:18:41 -06:00
793b2de0cb
Profiler - Modify metrics
...
Remove occupancy metrics and replace with OccupancyPercent
Add OCCUPANCY_PERCENT which uses OccupancyPercent
Add GR_ENGINE_ACTIVE which uses GPU_UTIL/100
Add TENSOR_ACTIVE_PERCENT which uses MfmaUtil
Modify FLOPS_64 to use FP64_ACTIVE
Change-Id: I5f30d77a0c80f5ac78abd1a9e57f8a0a3c6cc00b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 28acbf0436
2024-10-15 19:00:30 -05:00
999cae5e2c
SWDEV-466829 - Disable ROCP when in GTest
...
Change-Id: I3b218fe256717c1dc9187d5f17476dfc990656c2
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: c40a6308c5
2024-09-26 17:00:05 -05:00
b50c64b868
Use correct rocprofiler metrics
...
Change-Id: I26603de7425abb6588f770ed68c22e14d6d20d56
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: d4bb33d100
2024-06-11 11:15:18 -05:00
73948f95e2
Rewrite rocprofiler plugin
...
Change-Id: Ic7dd967cc60cacd2b16a465180505ea2a342fccf
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 3514225b83
2024-06-11 03:11:15 -05:00
29b86095ed
Fix rocprofiler plugin
...
- Replace non-working fields with working ones
- remove CU_OCCUPANCY completely as it isn't well supported
- Fix rocprofiler initialization with shared_ptr and rdc_module_init
- Replace env var ROCPROFILER_METRICS_PATH with ROCP_METRICS
- ROCPROFILER_METRICS_PATH is only relevant for rocprofv2
- ROCP_METRICS is only relevant for rocprofv1 (which we are using)
Change-Id: I21e6fa3f0e1694c38f44ca0e5659d672559f7380
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 20ca2ce574
2024-06-06 01:51:39 -05:00
c2a75bbe4c
Finalize the rocprofiler fields
...
Change-Id: I4ed1c4309f21bdcc7281d911663036caf5947182
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 07c414af5e
2024-06-04 19:49:06 -05:00
f73e123900
Add GPU indexing and fix check for fields in rocprof
...
- Fix RUNPATH for tests
Change-Id: I79517592b49d27080a010a2e41e5878adf24a157
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: e11afbf60f
2024-06-04 12:56:22 -05:00
a80dfd4f00
Add memory bandwidth metrics
...
Change-Id: I310ca8af0536497be619d2bda1e540d1f11c2565
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 53033a5b77
2024-05-17 14:55:01 -05:00
cff2ac8490
Add rocprofiler_example.cc and fix logging
...
Change-Id: Ib3ed8754f314edc76ea56bfec9a645d720f8926d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: c7fcb1ad25
2024-05-17 14:55:01 -05:00
83cf97e280
Profiler - Add all required metrics
...
Change-Id: Iea3938df9407789c061c3a6ead9167a69069d6e6
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: c3a4c899d5
2024-05-09 23:24:02 -05:00
8b317a6490
Add rocprofiler plugin
...
Rename ROCR -> Runtime and ROCP -> Profiler
Change-Id: If90953da8fa5d695b681813dad4a3e7ec26a9c7e
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 234b2d835b
2024-05-07 04:39:39 -05:00
028355dff0
SWDEV-439576 - rocmsmi -> amdsmi
...
- Migrate to amdsmi library
- NOTE: raslib still uses rocmsmi
- Remove unused rocmsmi service
- Remove unused RDC client code
- Remove RSMI calls from protos/rdc.proto
Change-Id: Ifc34a264c506b0ec5792307ee56b34526268762d
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 9702d0f2d7
2024-04-09 20:19:28 -05:00
703d6c0d44
Use templates for module population
...
Also add stddef.h workaround for old GCC.
RHEL-8 still uses GCC 8.5 and templates are not well supported.
Change-Id: Ia4dae23892ec63682ea848c46ba81de85cf6d209
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: f9e80cc37a
2024-01-10 00:27:09 -06:00
ea624cbb7c
LINT: Add cpplint, clang-format and pre-commit support
...
Change-Id: I3cbb787ef27d90486b212dfb1a8c77c460acc2ac
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 434e40305d
2024-01-09 11:37:11 -06:00
c1a76d532a
SWDEV-380364 - Resolve dmon + rocmtools halt
...
* Move hsa_init out of rocmtools and into RDC
* Remove secondary hsa_shut_down from ROCR module
Change-Id: I57d84d41ddc51595b98e734265f10bc5129a7352
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
Depends-On: I2b389ee1a9ba3507b2df1fc2fe83598f67731aac
[ROCm/rdc commit: 24b3f138e9
2023-02-02 18:33:14 -06:00
eccb4e202c
Add rocmtools support
...
This commit adds integration with ROCmTools
Additional changes:
- Fix DEB and RPM installation issue when systemd is not present
- Fix typos in rdc.h
- Wrap negative values in parentheses in rdc.h
- CMAKE: Improve rocm_smi searching
- README: Improve formatting, add info about ROCmTools
Metrics added: 700-714
Metrics can be listed with `rdci dmon --list-all`
Majority of the metrics are only supported by Instict (MI) series GPUs
700 RDC_FI_PROF_ELAPSED_CYCLES should be available on most devices
See README for more information
Change-Id: I907d3eacdc92fc5588ca6c76c2fa1ce0ad900770
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com >
[ROCm/rdc commit: 861a843ed7
2022-12-16 12:19:59 -06:00
Dmitrii
Galantsev, Dmitrii
Pryor, Adam
Greg Scaffidi
Chen Gong