Commit Graph

73 Commits

Author SHA1 Message Date
Jaydeep Patel 90a00bc681 SWDEV-388926 - Original and new memory should be from same device for hipGraphExecMemsetNodeSetParams.
Change-Id: I32bd56db0b80d748e3ae0737a38ea975738bdab7


[ROCm/clr commit: ec227d560a]
2023-04-05 10:54:10 +00:00
sdashmiz ddf76371e6 SWDEV-386685 - return proper error
- if graph is already instantiated there cant be a second instance in
  case nodes are free or alloc

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I51e2ca8ade24799da96ed126a26c5ea3bad6f452


[ROCm/clr commit: f6c36be185]
2023-04-05 10:53:51 +00:00
sdashmiz 7528052a8f SWDEV-377862 - kind does not show on dotprint
- for to/from symbols nodes the correct kind is not showing

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Idf203976b71fcca67b2dd989de0daba4d0554b6d


[ROCm/clr commit: ae631aaa32]
2023-03-10 16:39:07 -05:00
Sourabh Betigeri 0e37a53fae SWDEV-385089 - Fixes hipGraphLaunch functionality accounting for the existence of MemFree node or already freed memory when the same graph is launched multiple times
Change-Id: I49beb49ad4e6db4a2dd5b8c8cc8ed11ff0e4e132


[ROCm/clr commit: ec8ab9b29c]
2023-03-09 21:10:13 -05:00
Ioannis Assiouras fc2406316f SWDEV-386926 - Added check for correct node type in hipGraphMem[Alloc/Free]NodeGetParams
Change-Id: Ic8446210a683d1329391288d0ed99d835c5aa140


[ROCm/clr commit: 58e05898d1]
2023-03-09 20:05:28 -05:00
Saleel Kudchadker 71a3807e6f SWDEV-345213 - Use the right accessor
- Use correct accessor to fetch memory objects. This checks the svm map
and arena maps

Change-Id: I84515330bb530cfe2b39abf30e1e659938f06806


[ROCm/clr commit: 8028d327e9]
2023-03-06 19:35:40 -05:00
sdashmiz bab487caa8 SWDEV-382838 - inetrmittent failure
- test fails intermittently because object is not cleared correctly

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I88daf3dc08bb83d6d3f047ff48a63c8f856fb0bf


[ROCm/clr commit: a69db9b426]
2023-02-27 16:23:04 -05:00
German Andryeyev 2e0fd95d74 SWDEV-353281 - Add support for MemPool in graphs
Implement hipDeviceGetGraphMemAttribute, hipDeviceSetGraphMemAttribute
and hipDeviceGraphMemTrim

Change-Id: I4f8fc1250ce1e8b7636d43d59ba7343158e45088


[ROCm/clr commit: 314bdba632]
2023-02-23 12:49:53 -05:00
Ioannis Assiouras 2633e62801 SWDEV-381402 - Derive hip::Stream from amd::HostQueue
Change-Id: I6c1aca5eb350c32d974ae4ffcc725705355956d8


[ROCm/clr commit: e3633dc8f4]
2023-02-21 18:12:03 -05:00
sdashmiz 8c69e2e52e SWDEV-377862 - wrong format for memcpy1d
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ide6d252083b1812b0ad9cd182b1435e3e59b3aa1


[ROCm/clr commit: e34be4fbee]
2023-02-14 09:47:04 -05:00
Sourabh Betigeri 3bc1a92b66 SWDEV-375194 - Fixes graph dot file descriptions to include labelId matching CUDA
Change-Id: Ia0e6b77e38678b13457f86755ed8f3b852c9b7a1


[ROCm/clr commit: 191b468d89]
2023-02-13 19:43:12 -05:00
Sourabh Betigeri 1544843291 SWDEV-375202 - Fixes print formatting for flags in hipGraphDebugPrint() to match CUDA
Change-Id: I2d85fc38d2c65bc12534109883fe00802e77e62d


[ROCm/clr commit: 4cbf9a4a16]
2023-02-09 13:07:57 -05:00
German Andryeyev 395d85ac2e SWDEV-353281 - Switch Graph to operate with stream
MemPool was designed to use hip::Stream, but graph implementation uses
amd::HostQueue. Hence switch graph to hip::Stream management.

Change-Id: Ia319389de45e4c3c6043d17473279a6f27a13140


[ROCm/clr commit: 0fe03b6494]
2023-02-06 10:11:55 -05:00
Jaydeep Patel c6da0aa014 SWDEV-377804 - Initial commit to support hipGraphInstantiateFlagAutoFreeOnLaunch
Change-Id: I7a35becb6c98a6ff70264e141317d98be7457a37


[ROCm/clr commit: f9e27bcdd4]
2023-02-01 11:51:39 -05:00
sdashmiz a081bdd157 SWDEV-361623 - correct remove edge behaviour
- remove node dependency before checking parents
- reduce edge level acording to new value of node

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Id4bff1684f7e0b42beeebc4d2e009bfdb507fb5f


[ROCm/clr commit: 34d087da93]
2023-01-31 12:48:59 -05:00
Jaydeep Patel 43565f0496 SWDEV-379125 - Check only if there is attr set for graph kernel node.
Change-Id: I8768b33ad27e75eb753d99d682edf60b31b240df


[ROCm/clr commit: 70bfc6145b]
2023-01-24 09:51:12 +00:00
Anusha GodavarthySurya f681854310 SWDEV-376407 - Track manual nodes added during capture
Change-Id: Ic44f842c303eed0eff08b6ee5922976d96a52c71


[ROCm/clr commit: d422ad0ec1]
2023-01-18 03:27:41 -05:00
sdashmiz 11f97823cd SWDEV-374374 - memset memory mapping should not change
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I4cc3b1ac5a59fe5c9ae060f4d5d189dc63ca450c


[ROCm/clr commit: 52bf09aac6]
2023-01-17 14:41:24 -05:00
Jaydeep Patel ffcff763d2 SWDEV-375366 - SWDEV-375351 - Handle HtoH case for graph mem cpy impl.
Change-Id: I5a8c3c3c22db045f714b0443b8d70a8c6b4a8cea


[ROCm/clr commit: fdecc1b351]
2023-01-16 11:37:57 -05:00
German Andryeyev 9c811dc241 SWDEV-353281 - Initial support of memalloc in graph
Add memory allocation support in graph. Current implementation uses
cache from mempool  to hold the allocations which belong to the graph.
Also the resource tracking is disabled at this moment because mempool
operates with hip::Stream objects, but graph has execution with
amd::HostQueue objects.

Change-Id: I54fe3250126d24f5a26ada975f37d429bb4ef17b


[ROCm/clr commit: eef47ca24a]
2023-01-13 13:06:59 -05:00
Jiabao Xie 3ab54974dc SWDEV-374375 - moving nullptr check into hipGraphNode::isValidNode
Change-Id: Ic9264521d6f0b36ffc948ca9feeaa70eb6e98eb6


[ROCm/clr commit: 03200953e5]
2023-01-09 16:27:38 -05:00
Jaydeep Patel 2d25a60c1a SWDEV-374370 - Propogate element size to blit kernel.
Change-Id: I8a3355c62947265be34e6a2befd26f86b3dc6cd2


[ROCm/clr commit: f2b0542442]
2023-01-01 23:54:09 -05:00
Anusha GodavarthySurya 09b894eeef SWDEV-325711 - Node can be enabled/disabled only for kernel, memcpy and memset nodes
Change-Id: Id9c19a14655732d61fccee9c3d1ffa0614123468


[ROCm/clr commit: 0fcc5557bd]
2022-12-13 05:08:38 +00:00
Anusha GodavarthySurya e1b559e386 SWDEV-372521 - Fix copy of unused kernel attributes
Change-Id: Ib93f27d68cedac2182ba6dac0c234cc71c2c4229


[ROCm/clr commit: 5bcfb07c85]
2022-12-13 03:44:10 +00:00
pghafari ed6108c2d6 SWDEV-368166 - hipGraphAddMemcpyNode1D paramcheck
adding parameter check for hipGraphAddMemcpyNode1D

Change-Id: I94dc944bd55ea04b8e9288a27c8f58dd3720161b


[ROCm/clr commit: 5acc2cdcc2]
2022-12-07 18:29:11 -05:00
Anusha GodavarthySurya e7fa085afe SWDEV-325711 - Correct formatting
Change-Id: Ie26159e0bb3315cf7c3de1eb682f23ef343df0f2


[ROCm/clr commit: 16b31b0c54]
2022-11-30 05:15:01 +00:00
Anusha GodavarthySurya f97723d118 SWDEV-325711 - Added implementation for graph API hipGraphKernelNodeCopyAttributes
Change-Id: I576d0e81c69097fe881556f6d022bb7c7ca3287b


[ROCm/clr commit: 3a9621574c]
2022-11-29 02:53:14 +00:00
Anusha GodavarthySurya 58201c1b92 SWDEV-325711 - Added implementation for graph APIs GetEnabled & SetEnabled
Change-Id: I15a165b3dc548d00b7f5458e1b322b192b8c0d76


[ROCm/clr commit: 1ab46fe7ae]
2022-11-28 21:50:36 -05:00
Tao Sang 9d1ce7a68f SWDEV-368280 - Fix crash in graph stream capture
Fix crash in graph stream capture for hipExtModuleLaunchKernel.

Change-Id: Ieaaed1d15b4d268193d8341d4b1609f83a9e4789


[ROCm/clr commit: 530ec02aae]
2022-11-28 09:33:39 -05:00
Anusha Godavarthy Surya b1fe9498c5 SWDEV-240806 - Fix command release with new commands for every launch
Change-Id: Iecbf11a8f9e9b50f39858f2000a2d5266f0ef364


[ROCm/clr commit: 85296e280a]
2022-11-25 09:30:45 +00:00
Anusha Godavarthy Surya a13afd3aca SWDEV-366653 - Added Implemention of DOT file generation for graph
Change-Id: I5ab6a58e49451b5e04f2e93bf594b985ac58cc8d


[ROCm/clr commit: 08c4619fab]
2022-11-24 11:02:21 -05:00
sdashmiz 29c1a7543b SWDEV-368695 - correct node type
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I23930be7d2f3415c14fc2ec3af4c526cb89d26f7


[ROCm/clr commit: 5ec93c544e]
2022-11-24 10:35:34 -05:00
Tao Sang 9091d2751f SWDEV-363038 - Fix hipGraphKernelNodeSetParams
Fix crash in hipGraphKernelNodeSetParams where paremeters
are taken from hipGraphKernelNodeGetParams.

Change-Id: I2216f72f4d4de6dd3766343b0d821cb3d35d7853


[ROCm/clr commit: 0c4307f86e]
2022-11-01 15:02:39 -04:00
sdashmiz a75852fb97 SWDEV-357917 - correct userobj for negative test cases
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I6a2a74c763d2b938430ca53a14360f459af04665


[ROCm/clr commit: 4fc9df2a1a]
2022-10-24 10:27:02 -04:00
Tao Sang 2be45a82ec SWDEV-318349 - Fix hipGraphKernelNode and hipGraphMemcpyNode
For hipGraphKernelNode, remove func_;
and reorganize functions to naturely support mGPU;
For hipGraphMemcpyNode, make EnqueueCommands() support different
queues' sync
Change-Id: I22708923f454adf4456ff99d25559daffed8c20d


[ROCm/clr commit: f83ba8cd23]
2022-10-07 09:07:56 -04:00
sdashmiz 44c74209ed SWDEV-351274 - add proper checks for set attribute
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I9243e6180f3040341396b7159622f2b96e143ac2


[ROCm/clr commit: 39fc6605ec]
2022-09-09 10:49:33 -04:00
sdashmiz 72703ab50f SWDEV-352290 - remove the static list for user obj
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I8d7542ad5aacdda4e817c6aaed78c9cac4562efd


[ROCm/clr commit: ce5103ac97]
2022-08-24 12:01:41 -04:00
sdashmiz 213aad7615 SWDEV-325711: Add userobject functions for graph
- add user obj APIs for creating release and retain of user onbjects

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I0bf2999c77e44269565b27c31c7c1461f8a160a2


[ROCm/clr commit: 2c010dec17]
2022-08-17 14:31:43 -04:00
sdashmiz ab694c23fb SWDEV-346456 - fix test for get/set attr
- test should allow first calling get function

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: I365cd6210a01fd5ae3620711694bdc52e0f90b19


[ROCm/clr commit: 66bde8f336]
2022-07-25 15:17:27 -04:00
Sourabh Betigeri 5d26e66ed7 SWDEV-318237 SWDEV-330173 - Fixes kernel parameter corruption when multiple nodes of the same kernelNode exist
Change-Id: I6437593be46b7b5afc3d77cdd887ad4139978ad3


[ROCm/clr commit: 5549c8cd1b]
2022-06-14 18:06:21 -04:00
sdashmiz 92f5d16599 SWDEV-321698 - remove Memcpy1D type
- Memcpy1D node type is not complying with cuda

Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: If8113f5e699de0c62d98effc4580a2e0fee9a950


[ROCm/clr commit: 13c875eaf0]
2022-06-13 08:31:02 -04:00
Ajay 65d3357dbc SWDEV-337331 - graph feature on Windows
Fixes for hipGraphInstantiate OutofMemory issue and
soft hang of hipStreamSynchronize.
Change-Id: Ic2bb97582c5978ef2e4eb3a1b124483aa412838e


[ROCm/clr commit: c06bfa6bef]
2022-06-09 12:04:51 -04:00
sdashmiz 3f588bf604 SWDEV-318833 - Get and Set attribute for kernel nodes
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>
Change-Id: Ie51aa4b56661cbb8c5b4eb1dbaad327377084ffb
Signed-off-by: sdashmiz <shadi.dashmiz@amd.com>


[ROCm/clr commit: efd2d55e9d]
2022-06-09 09:47:05 -04:00
pghafari 0ddbd07e0c SWDEV-327960, SWDEV-316901 - Adding Graph checks
hipGraphExecMemcpyNodeSetParamsToSymbol, fix for functional cases
failing as well

Change-Id: I9f263778f6b24e3ec35a78231a17e01c0d44f23a


[ROCm/clr commit: 63f23ec2b0]
2022-04-26 21:04:32 -04:00
pghafari 2442d41e31 SWDEV-316292 - adding Graph checks
hipGraphExecMemcpyNodeSetParamsFromSymbol negative test cases

Change-Id: I7b6c496a8bca831dc90d1d427273a2a4fea96587


[ROCm/clr commit: 798a304dbd]
2022-04-05 13:26:46 -04:00
Payam 8a6fd0bd65 SWDEV-316819 - graph check ChildGraphNodeGetGraph
Change-Id: Id3a4fb64e6fb5ce37e97f1f3518e09c8bd9a2d0c


[ROCm/clr commit: 8618b1cd07]
2022-04-05 01:24:36 -04:00
Payam Ghafari 37fa31aaa8 Revert "SWDEV-316819 - adding graph checks"
This reverts commit eff4583118.

Reason for revert: Catch2 test fails

Change-Id: If0ea0eab16b50f27c9acbc471530266917773ff1


[ROCm/clr commit: d888c0a9bf]
2022-03-23 15:23:00 -04:00
Payam eff4583118 SWDEV-316819 - adding graph checks
hipGraphChildGraphNodeGetGraph - Scenario 3: Pass Parent node instead of the child node

Change-Id: Ia55921bca1e2745c9c97f2b7eb36244ffb719eb4


[ROCm/clr commit: 5dd91d698b]
2022-03-14 22:43:58 -04:00
Shadi Dashmiz fc67e37d9a Revert "SWDEV-321698 - hipGraphNodeTypeMemcpy1D NVDIA build failure"
This reverts commit 42be9301d1.

Reason for revert: hip changes not in yet

Change-Id: I89e35d171cf01fb82d361279998efcc90e54ef33


[ROCm/clr commit: 1965dd5795]
2022-03-08 15:08:31 -05:00
Sourabh Betigeri fabd92b996 SWDEV-313503 - Returns appropriate error code when destroyed exec graphs are launched
Change-Id: I3ca025494fd27f9ed0cd4534c740f7e19e1c66b3


[ROCm/clr commit: 0ae70a4c8d]
2022-03-08 11:54:04 -05:00