Commit Graph

68600 Commits

Author SHA1 Message Date
Alysa Liu 2327cd35c8 rocr: Fix VMM cpu mapping clean up (#1831)
Remove CPU mapping before calling RemoveAccess().
2025-11-14 13:52:45 -05:00
German Andryeyev ff4782620e SWDEV-547108 - Fix PAL build with HSA backend (#1850)
When hip is built with HSA backend then the headers from ROCR will be used, but
scratch_backing_memory_byte_size is a part of amd_queue_v2_t structure
2025-11-14 12:28:03 -05:00
Joseph Macaranas 598ca70861 Revert "Update amdgpu-windows-interop with latest changes 20251105 (#1728)" (#1866)
- Reverts #1728
- Last PAL update broke applications on gfx12 Windows.
- Will need to reapply a patch to ubertrace when bumping submodule on TheRock.
2025-11-14 11:48:10 -05:00
marandje 5616a255e2 SWDEV-515530 - Re-enable passing tests (#1013) 2025-11-14 16:36:44 +01:00
Swati Rawat cb257ab9f7 [rdc] Replace readme link rdc -> rocm-systems/projects/rdc (#1758)
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-11-14 13:19:26 +01:00
amilanov-amd 738bf16008 [hip-tests] Tag multigpu tests with Catch2 tags (#1315) 2025-11-14 13:00:30 +01:00
venkatesh-amd f7249e092b SWDEV-533237 : Added test cases for hipOccupancyAvailableDynamicSMemPer… (#716)
* SWDEV-533237 Added test cases for hipOccupancyAvailableDynamicSMemPerBlock API

* SWDEV-533237 : Added test cases for hipOccupancyAvailableDynamicSMemPerBlock

* SWDEV-533237 : Addressed review comments for hipOccupancyAvailableDynamicSMemPerBlock aip test cases

---------

Co-authored-by: jainprad <92369414+jainprad@users.noreply.github.com>
2025-11-14 15:41:45 +05:30
Bindhiya Kanangot Balakrishnan 1b027d15bd [SWDEV-566930] Fix numa CSV output
Handled numa data - including cpu and socket list, bitmask,
and affinity for csv format.

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
2025-11-13 21:52:49 -06:00
Bindhiya Kanangot Balakrishnan 5e56281eb0 [SWDEV-566930] Fix numa CSV output
Handled numa data - including cpu and socket list, bitmask,
and affinity for csv format.

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>


[ROCm/amdsmi commit: 1b027d15bd]
2025-11-13 21:52:49 -06:00
Kanangot Balakrishnan, Bindhiya f8e4771363 [SWDEV-538483] Add NPM API's and CLI (#817)
* Added Python & C API's for new node devices. Currently these are functional for node 0 only.
 - amdsmi_get_node_handle
 - amdsmi_get_npm_info
* Added `amd-smi node` CLI for Node Power Management

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>
2025-11-13 21:51:31 -06:00
Kanangot Balakrishnan, Bindhiya 072daa28d5 [SWDEV-538483] Add NPM API's and CLI (#817)
* Added Python & C API's for new node devices. Currently these are functional for node 0 only.
 - amdsmi_get_node_handle
 - amdsmi_get_npm_info
* Added `amd-smi node` CLI for Node Power Management

---------

Signed-off-by: Bindhiya Kanangot Balakrishnan <Bindhiya.KanangotBalakrishnan@amd.com>
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Co-authored-by: Maisam Arif <Maisam.Arif@amd.com>

[ROCm/amdsmi commit: f8e4771363]
2025-11-13 21:51:31 -06:00
Milan Radosavljevic a77be32660 Prevent duplicated sdk events (#1826) 2025-11-13 22:36:36 -05:00
David Galiffi 540eda3865 [rocprof-sys] Forward ctest labels from the execution test to the validation test. (#1697)
* Forward ctest labels from the execution test to the validation test.

* Adjust test validation parameters for amid_smi samples

The actual number of samples will vary depending on the GPU. This test
is just to validate the presence of the samples
2025-11-13 21:49:07 -05:00
Milan Radosavljevic 833c250c27 Add clean up fixture for trace cache temporary files (#1836)
* Add clean up fixture for trace cache tmp files

* Switch to bash instead of cmake running command
2025-11-13 21:01:04 -05:00
Matt Arsenault 4830979f0e SWDEV-548892 - Stop using ocml fma wrappers (#1702)
Directly use elementwise builtin
2025-11-13 16:20:27 -08:00
Matt Arsenault 42e91b8934 SWDEV-548892 - Stop using ocml sqrt wrappers (#1716) 2025-11-13 16:19:44 -08:00
Charis Poag 00a893d299 Fix PPT - reset calls, unit format, and get_power_cap()
Changes:
  - Simplified reset calls
  - Updated static limit N/A values to all possible data
  (helps csv format be consistent)
  - Unit format was broken on static
  - get_power_cap() had min/max values swapped, and the return
    was missing two fields
  - Updated changelog to reflect all changes

Change-Id: I23713471b984f52085372486c6e6ff852e2f42f8
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2025-11-13 15:40:13 -06:00
Charis Poag e53645e871 Fix PPT - reset calls, unit format, and get_power_cap()
Changes:
  - Simplified reset calls
  - Updated static limit N/A values to all possible data
  (helps csv format be consistent)
  - Unit format was broken on static
  - get_power_cap() had min/max values swapped, and the return
    was missing two fields
  - Updated changelog to reflect all changes

Change-Id: I23713471b984f52085372486c6e6ff852e2f42f8
Signed-off-by: Charis Poag <Charis.Poag@amd.com>


[ROCm/amdsmi commit: 00a893d299]
2025-11-13 15:40:13 -06:00
Kian Cossettini 65b607b0bd [rocprofiler-systems] Add rocprof-sys-build to gitignore (#1829)
* Add rocprof-sys-build to gitignore

---------

Co-authored-by: David Galiffi <David.Galiffi@amd.com>
2025-11-13 16:22:19 -05:00
Julia Jiang 5599e8b1de SWDEV-561500 - Update change log and port 7.1.1 to develop branch (#1688)
* SWDEV-561500 - Porting changelog(up to 7.1.1) to develop branch

* Update CHANGELOG.md

* Update CHANGELOG.md

* Update CHANGELOG.md
2025-11-13 12:22:34 -08:00
gabrpham_amdeng 46e5f157f0 Fix PCIe Levels converting to csv
Change-Id: Id69b8bbc167887673a88e13eb497bdeac6dd0425
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
2025-11-13 13:08:12 -06:00
gabrpham_amdeng 3527ecf8dd Fix PCIe Levels converting to csv
Change-Id: Id69b8bbc167887673a88e13eb497bdeac6dd0425
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>


[ROCm/amdsmi commit: 46e5f157f0]
2025-11-13 13:08:12 -06:00
gabrpham_amdeng 18faddf6f3 Added support for configuring PPT1 power cap
- Updated python integration test to account for PPT1 support changes
  - Updated set/reset power-cap input format
  - Adjusted python API and updated C++ API test

Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com>
Change-Id: Ia9d02868b6e91c88c10a9772d9e2d9f37c3c352f
2025-11-13 13:08:12 -06:00
gabrpham_amdeng 351b6f96ae Added support for configuring PPT1 power cap
- Updated python integration test to account for PPT1 support changes
  - Updated set/reset power-cap input format
  - Adjusted python API and updated C++ API test

Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com>
Change-Id: Ia9d02868b6e91c88c10a9772d9e2d9f37c3c352f


[ROCm/amdsmi commit: 18faddf6f3]
2025-11-13 13:08:12 -06:00
darren-amd 4dfe74eb72 Set amdsmi_parser compute partition --help to list 2025-11-13 12:49:56 -06:00
darren-amd 360a4316b5 Set amdsmi_parser compute partition --help to list
[ROCm/amdsmi commit: 4dfe74eb72]
2025-11-13 12:49:56 -06:00
Saitarun Movva f6b1cb9024 Fix #132: Python parser not accepting compute partition arguments
The argparse 'choices' parameter was receiving a comma-separated string
instead of a list, causing it to treat individual characters as valid
choices rather than complete tokens like 'SPX', 'DPX', etc.

Fixed by removing the unnecessary join() operation in
get_accelerator_choices_types_indices() to return the list directly.
This matches the pattern used by get_memory_partition_types().

Now 'amd-smi set -C DPX' and other partition commands work correctly.
2025-11-13 12:49:56 -06:00
Saitarun Movva b8298bf5b6 Fix #132: Python parser not accepting compute partition arguments
The argparse 'choices' parameter was receiving a comma-separated string
instead of a list, causing it to treat individual characters as valid
choices rather than complete tokens like 'SPX', 'DPX', etc.

Fixed by removing the unnecessary join() operation in
get_accelerator_choices_types_indices() to return the list directly.
This matches the pattern used by get_memory_partition_types().

Now 'amd-smi set -C DPX' and other partition commands work correctly.


[ROCm/amdsmi commit: f6b1cb9024]
2025-11-13 12:49:56 -06:00
systems-assistant[bot] f55dda2082 SWDEV-543340 - Added Unit_hipEventIpc_shm_cleanup test (#548)
The test verifies that all shared memory objects for
IPC events used internally by HIP are properly cleaned
up after use and do not leave persistent files in /dev/shm.

Co-authored-by: Ioannis Assiouras <Ioannis.Assiouras@amd.com>
2025-11-13 18:21:12 +00:00
Istvan Kiss a0f53a5fdb Sync HIP documentation leftover (#1597)
* Sync HIP documentation leftover

* Update HIP docs environment.yaml and doxyfile
2025-11-13 09:19:33 -08:00
David Yat Sin 7e4b62290c rocr: Switch back to legacy IPC (#1744)
Switch back to legacy IPC Implementation while we fix some race
conditions.
2025-11-13 09:41:55 -05:00
Giovanni Lenzi Baraldi 5b5269f666 [aqlprofile] Enable nondetail shaderdata (#1805) 2025-11-13 13:47:21 +01:00
Giovanni Lenzi Baraldi cf164dd025 Fix for SQTT perfmon IDs (#1818)
* Fix for SQTT perfmon IDs

* Review comments
2025-11-13 13:46:57 +01:00
systems-assistant[bot] 720a5bcf9a SWDEV-547526 - Add missing free calls (#531)
Co-authored-by: Vladana Stojiljkovic <Vladana.Stojiljkovic@amd.com>
2025-11-13 11:16:41 +01:00
systems-assistant[bot] 7450910e53 SWDEV-548241 - Add missing destroy calls in graph tests (#520)
Co-authored-by: Vladana Stojiljkovic <Vladana.Stojiljkovic@amd.com>
2025-11-13 11:13:40 +01:00
Tim Huang e2d83014cf rocr/dtif: Add ring doorbell for sdma user queue (#1619)
Signed-off-by: Tim Huang <tim.huang@amd.com>
2025-11-13 15:08:08 +08:00
systems-assistant[bot] 061948a5ec [rocpd] Adding merge and package submodules for rocpd (#164)
* adding ROCpd database merge

* adding ROCpd database merge concatenating all tables

* update merge script

  - copy all tables from files

* fix merge format

* Add package submodule, initial POC.  Need to refine

* Minor fixes and clean up duplicated code in package.py

* Revamp metadata layout, add wildcard and .rpdb parsing

* Add auto merge & package when > 5 DBs, add examples, don't use auto_merge when using sub-commands merge & package

* - Extend package/yaml inputs to all rocpd modules
- Improve handling more corner cases for bad input files when parsing input parameters (bad yaml files, bad .rpdb folder, folders as input)
- Changed to use UUID in merged filename instead of the time, in auto-merge algorithm

* Minor text fixes for consistancy between modules

* Add more wildcard support and add package, merge tests

* Make changes based on review suggestions

* Move parsing packages into importer.py, simplified adding required params to a function

* fix package test by flattening input list before processing

* Integrate merge.py changes from Jonathan to add name-collision checks, recreating indexes, foreign key check (disabled for now, due to processing time)

* Rework rocpd.<submodule>.{add_args,process_args}

- add_args function returns a functor which accepts input and args
- time_window functor returned from add_args automatically applies time windowing of input

* change merge&package limit to 1, merge should create data views

* Move files by default instead of making copies

- copying can be enabled by passing "copy=True" or --copy cmdline argument

* refactor package to make the logic cleaner, set merge limit back to 5

* Allow automerge-limit param to override limit, change default back to 1.  Tests updated to use query, much quicker

* Update --help instructions for package

---------

Co-authored-by: acanadas <acanadas@amd.com>
Co-authored-by: a-canadasruiz <Araceli.CanadasRuiz@amd.com>
Co-authored-by: Young Hui <young.hui@amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-11-12 17:07:12 -05:00
Sourabh U Betigeri f58393108f SWDEV-564408 - Reduces hip-tests runtime Pt2 (#1724) 2025-11-12 13:37:00 -08:00
David Yat Sin 7b097599c4 rocr: Fix race condition in SetAsyncSignalHandler (#1642)
Fix race condition when SetAsyncSignalHandler for the first time because
async_events_thread_ could be null and launched twice.

Refactored async-events to use lazy_pointer.
2025-11-12 13:54:26 -05:00
pcritchl-amd 60cd210dac Reapply "SWDEV-562996 - Build fix: Ubertrace callback calling convention mismatch on x86 (#1587)" (#1717) (#1754) 2025-11-12 13:47:24 -05:00
Ioannis Assiouras 4f91b68988 SWDEV-559166 - Remove obsolete member execInfoOffset from KernelParameters (#1790) 2025-11-12 17:20:36 +00:00
David Galiffi f8694173f6 Round the sum of percentages before validating to account for floating point errors (#1824)
* Round the sum of percentages before validating to account for floating point errors
---------

Co-authored-by: Kian Cossettini <Kian.Cossettini@amd.com>
2025-11-12 09:26:25 -05:00
Aleksei Tumakaev 90ac6675c2 [rocpd] Fix negative timestamp delta in perfetto (#1568)
* Fix negative delta_ts in perfetto
2025-11-12 15:08:58 +01:00
Satyanvesh Dittakavi 07dd4c85e7 SWDEV-546308 - Implement hipKernelGetParamInfo API (#1783) 2025-11-12 14:09:26 +05:30
swargamrambabu e6b1ec25bd SWDEV-561337 Additional Tests for hipStreamCopyAttributes API (#1607)
* SWDEV-548797 Additional Tests for hipStreamCopyAttributes API

* SWDEV-548797 : Added sanity check section for negative test case
2025-11-12 14:05:54 +05:30
systems-assistant[bot] f99baf5481 SWDEV-519340 - Enable and fix hipModuleLoad test (#607) 2025-11-12 09:28:49 +01:00
David Galiffi 3ad7c20961 Change test condition from transpose-sampling to roctx-api-sampling (#1784) 2025-11-11 17:39:05 -05:00
jofrn 8f9da259ac Fix memory leak in hip_fatbin.cpp UncompressAndPopulateCodeObject (#1692)
Wrap amd_comgr_data_t item returned from action_data_get_data() in
ComgrDataUniqueHandle to ensure it gets released.
2025-11-11 16:48:06 -05:00
systems-assistant[bot] a66ca8809b SWDEV-511239 - Remove and and use && for preprocessors (#506)
This shows up as warning in msvc.

Co-authored-by: Jatin Chaudhary <JatinJaikishan.Chaudhary@amd.com>
2025-11-11 09:43:57 -08:00
Giovanni Lenzi Baraldi 07a563c475 AQLprofile SQTT double buffer support (#1787) 2025-11-11 13:01:22 +01:00