Commit Graph

8920 Commits

Author SHA1 Message Date
Trowbridge, Ian e307b89ca4 rocDecode API Tracing Support (#49)
* rocDecode API Tracing support

* Test bin file added to rocdecode. Need to add validate python methods

* Added option to not make rocDecode tests

* Added rocdecode and rocprofv3 tests

* Added csv test

* Address PR comments. Changed tests to use built-in rocstreambit decoder to remove ffmpeg dependancy. Changed cmake option to disbale tests rather than not build them. Tests work locally, but will fail until rocDecode is built with tracing enabled on CI

* Add option to avoid building rocdecode tests

* Added option to avoid building rocdecode bin file

* Merge conflict error

* CMake files changed in response to review comments. Attempting to implement callbacks.

* Turned off test building for rocdecode

* Minor fixes for review comments

* Review comments

* Updated formatting

* Document changes and format.hpp reversion. Need to remove iterate args support for now for later update.

* Remove iterate args support

* Remove iterate-args

* enforce abi versioning in macro if

* Fix doc error

* removed spaces to fix indentation error

---------

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
2025-01-17 14:42:25 -08:00
Baraldi, Giovanni 1f01526eed SWDEV-478762+FEAT-62196: Fix crash on AQL replay (#104)
* SWDEV-478762: Fix crash on replay

* Fix iteration range

* Format

* Refactor

* Addressing review comments

* Address review comments

* Formatting

* Format

* Refactor

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2025-01-17 12:23:48 -06:00
Mallya, Ameya Keshava aefc865bf4 Fixed Workflow for updated KWS structure 2025-01-17 08:26:52 -08:00
Mallya, Ameya Keshava 164eda5231 Fixed Workflow for updated KWS structure 2025-01-17 08:25:42 -08:00
Mallya, Ameya Keshava f8189fd60d Added KWS check 2025-01-17 08:23:51 -08:00
Mallya, Ameya Keshava 09936e6937 Added KWS check 2025-01-17 08:22:53 -08:00
Mallya, Ameya Keshava 0490b1c925 Fixed Workflow for updated KWS structure 2025-01-17 08:21:11 -08:00
Mallya, Ameya Keshava c5140c83a5 Fixed Workflow for updated KWS structure 2025-01-17 08:15:36 -08:00
Jakaraddi, Manjunath dfee6489b1 SWDEV-500520: Updated documentation for hang issue (#79)
* SWDEV-500520: Updated documentation for hang issue

* Avoid fatal error when invalid metric is found

* removing invalid metrics

* clang formatting
2025-01-16 02:14:22 -08:00
Welton, Benjamin 536fbba627 [SWDEV-509659] Skip rocprof device counting tests if lacking permissions (#125)
* [SWDEV-509659] Skip rocprof device counting tests if lacking permissions

Skips non-intercept test if proper permissions are not obtained
(SYS_PERFMON). This should be the only test that fails due to permission
issues (others do not require the IOCTL to pass).

Regex match sample: https://regexr.com/8b29s

* Update source/lib/rocprofiler-sdk/counters/tests/CMakeLists.txt

Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>

* fix

* Update source/lib/rocprofiler-sdk/counters/tests/CMakeLists.txt

---------

Co-authored-by: Benjamin Welton <ben@amd.com>
Co-authored-by: Madsen, Jonathan <Jonathan.Madsen@amd.com>
2025-01-16 01:51:06 -06:00
Welton, Benjamin 71dc203b0c Small debug print fix in ioctl.cpp (#120)
* Small debug print fix in ioctl.cpp

Fix debug print statement to print agent id.

* formatting

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-01-15 18:00:04 -08:00
Madsen, Jonathan fae4ad614c Fix host function logging (#63)
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-01-15 19:54:35 -06:00
Madsen, Jonathan 1b7ab08ded Split ABI checks for rocprofiler-sdk-roctx into separate file (#21)
* Split ABI checks for rocprofiler-sdk-roctx into separate file

* Update source/lib/rocprofiler-sdk-roctx/abi.cpp

Co-authored-by: Indic, Vladimir <Vladimir.Indic@amd.com>

* Update source/lib/rocprofiler-sdk-roctx/abi.cpp

Co-authored-by: Indic, Vladimir <Vladimir.Indic@amd.com>

* New line

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
Co-authored-by: Indic, Vladimir <Vladimir.Indic@amd.com>
2025-01-15 19:32:50 -06:00
Mallya, Ameya Keshava dcdaf7389e Add KWS Check (#9) 2025-01-15 12:05:09 -08:00
Mallya, Ameya Keshava 3bd980bff8 Added KWS check 2025-01-15 11:15:00 -08:00
Mallya, Ameya Keshava c6ce9a5aa0 Create kws-caller.yml 2025-01-15 11:12:25 -08:00
Mallya, Ameya Keshava cadbf69b45 Added KWS check (#88) 2025-01-15 11:11:01 -08:00
Mallya, Ameya Keshava 720763daac Changed branch to mainline 2025-01-15 11:08:20 -08:00
Bhardwaj, Gopesh bae2c449a2 Tool deprecation message for rocprofiler v1,v2 (#2) 2025-01-15 11:29:21 -06:00
Elwazir, Ammar 4d93253fa3 Merge pull request #2 from AMD-ROCm-Internal/gobhardw/v1-v2-depreaction-message
Tool deprecation message for rocprofiler v1,v2 and roctracer
2025-01-15 11:15:07 -06:00
gobhardw 0fdaf8aef2 Tool deprecation message for rocprofiler v1,v2 and roctracer 2025-01-15 11:21:59 +05:30
Galantsev, Dmitrii 55ee3cc442 [SWDEV-495169] Update ROCm SMI CLI and Error handling (#3)
Issues include:

Update ROCm SMI displaying None or Not Supported to N/A
Update ROCm SMI displaying err msg to instead log err

Signed-off-by: Juan Castillo juan.castillo@amd.com
Change-Id: I1a2ce6e4f329666b5666664a7d7b4475d6c1cbc7
2025-01-14 17:15:18 -06:00
James Xu 67a0de4279 [SWDEV-501108] Update Doxygen note on rsmi_dev_pci_id_get
- To address https://github.com/ROCm/rocm_smi_lib/issues/208
where use of fake BDFs for partitions can cause confusion. This note
is already in the comments of the function definition, but was not
updated in the function declaration.
- Fix broken formatting for the location table for PCIE coordinate fields
- Tracked in SWDEV-501108

Change-Id: Ic85439866cb836bb43acc52314a7f1d026c3215d
2025-01-14 15:49:55 -06:00
Elwazir, Ammar 94474de480 rocprofv3: fix collection period unit handling (#103)
* Fixing Collection Period

* Fixing default value for collection period unit

* Formatting

---------

Co-authored-by: Ammar ELWazir <aelwazir@amd.com>
2025-01-14 11:19:16 -06:00
Bhardwaj, Gopesh 81f600e3ba miscellaneous doc updates (#86)
* miscellaneous doc updates

* updated deprecartion message

* Updated memory allocation tracking documentation

* Update comparing-with-legacy-tools.rst

Co-authored-by: Elwazir, Ammar <Ammar.Elwazir@amd.com>

* Update comparing-with-legacy-tools.rst

Co-authored-by: Elwazir, Ammar <Ammar.Elwazir@amd.com>

* Update comparing-with-legacy-tools.rst

---------

Co-authored-by: Ian Trowbridge <ian.trowbridge@amd.com>
Co-authored-by: Elwazir, Ammar <Ammar.Elwazir@amd.com>
2025-01-14 11:17:45 -06:00
Mallya, Ameya Keshava 70bcd05fd4 Added necessary variable for commenting 2025-01-13 20:26:23 -08:00
Mallya, Ameya Keshava c7bf11e080 Potential fix for KWS 2025-01-13 19:37:58 -08:00
Mallya, Ameya Keshava 619836b4ea Update rocm-ci-caller.yml 2025-01-13 18:54:35 -08:00
Mallya, Ameya Keshava 074efe9f50 Update rocm-ci-caller.yml 2025-01-13 18:53:44 -08:00
limeng12 016a1d9d39 [SWDEV-230863] Improve the functionality of RdcSmiHealth module.
Memory check:get the threshold of retired page number
EEPROM check:read and verify the checksum
Power/Thermal check: power/thermal throttle status counter

Signed-off-by: Meng Li <li.meng@amd.com>
Change-Id: Id2c751416eb5bf007e6e1da8dc05966a6ba1324e
2025-01-14 08:14:36 +08:00
Mallya, Ameya Keshava b28af2f508 Merge pull request #1 from AMD-ROCm-Internal/amd-master
Test PR
2025-01-13 13:43:55 -08:00
Mallya, Ameya Keshava 7c278f090a Create rocm-ci-caller.yml 2025-01-13 13:43:22 -08:00
Mallya, Ameya Keshava f5267f7ab0 Merge pull request #1 from AMD-ROCm-Internal/amd-master
Test PR
2025-01-13 13:41:36 -08:00
Mallya, Ameya Keshava bce807a560 Create rocm-ci-caller.yml 2025-01-13 13:40:41 -08:00
Apurv Mishra ecf57310ca hsakmt: move 'counter_id' array to heap
local variable 'counter_id' exceeded the max single
use of stack, thus move to heap to prevent overflow

also, use of a contiguous memory block for 2D array
to reduce space complexity, add error messages for
NO_MEMORY exits and check MAX_COUNTER limit for IDs

Change-Id: Id0249ca767a336b31c759c693a82d3f5c950a2fa
Signed-off-by: Apurv Mishra <apurv.mishra@amd.com>
2025-01-13 16:29:16 -05:00
Harish Kasiviswanathan 1d71975fcc kfdtest: Fix KFDASMTest failure on older ASICs
HW_REG_HW_ID1 is only available from gfx12 onwards

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: Ibf4bd62e01ada3dee6dd88762ccb853bab63ff87
2025-01-13 15:22:20 -05:00
Harish Kasiviswanathan f8ae5c47ba kfdtest: Add gfx12 to TargetList for AssembleShaders
Add gfx12 so that it gets tested when KFDASMTest.AssembleShaders is run.
GWS support has been removed for gfx12. Modify shaders to take that into
account.

Signed-off-by: Harish Kasiviswanathan <Harish.Kasiviswanathan@amd.com>
Change-Id: I70e87febb6388852ea54d69cf9201339a7910581
2025-01-13 15:22:15 -05:00
Chris Freehill b1d6cacf79 rocr: Remove RuntimeCleanup and use of loaded()
The recent static initialization changes cause this clean up to
happen when it previously never did. The result of ~RuntimeCleanup()
being executed is that the static global "loaded_" is set to false,
which in turn prevents hsa_init() from executing again. Clean up
already happens when hsa_shut_down() occurs.

Change-Id: Ib5cefb80d82880c1945e04eb6ec246bc2c7d2324
2025-01-13 09:18:13 -05:00
Lang Yu fe5f12342d kfdtest: consolidate LoopIsa
1, Initialize the registers before using them is the best practice.
Though the use case here doesn't care whether the registers are
initialized or not, some emulators complain the "read_before_write"
behavior. Initialize the registers used to silence these complaints.

2, Update s_wait stuff for gfx12.

Change-Id: I462b2b0b5017dd2876a5954169d3b6b2f1c2a75b
Signed-off-by: Lang Yu <lang.yu@amd.com>
2025-01-10 21:27:23 -05:00
Baraldi, Giovanni a2fa188e14 Adding source snapshot and partial serialization (#99)
* Adding source snapshot

* Adding option to serialize only on target kernel

* Fix for tidy

* Formatting

* Testing the new flag

---------

Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2025-01-10 15:43:06 -08:00
Chris Freehill 7f417dc598 Support for generic ISAs in rocm_agent_enumerator
Change-Id: Ie6cf2f1930e27afd6564250e108af1f10864946e
2025-01-10 10:46:15 -06:00
Galantsev, Dmitrii 83f36f1673 Include assert.h during C compilation (#4)
Fix for https://github.com/ROCm/ROCm/issues/3997. When compiling a C program that includes rdc/rdc.h, multiple assertion errors are thrown without this header included.

Change-Id: Ie5b5c1a1a17c8207cf9b1be23b31193e260d5c1a

Co-authored-by: harkgill-amd <harkgill@amd.com>
2025-01-10 11:29:15 -05:00
Baraldi, Giovanni 27266eb242 SWDEV-508485: Adding MFMA F8 metric (#112)
Co-authored-by: Giovanni Baraldi <gbaraldi@amd.com>
2025-01-09 15:27:16 -06:00
srawat 0e53160bee Update LICENSE 2025-01-09 13:12:24 -06:00
Giovanni Baraldi f19bed4c8c SWDEV-508485: Adding MFMA F8 metric
Change-Id: I947d2645e8dc1544d198a4e0a02500feee10d89d
2025-01-09 12:18:02 -06:00
Kent Russell cc7ff73e7f kfdtest: Can't initialize variable-sized objects
Do a memset, since we can't initialize variable-sized objects

Change-Id: I57faf4a0581a29f9d30391aa387812c2b7bb5011
Signed-off-by: Kent Russell <kent.russell@amd.com>
2025-01-09 10:36:06 -05:00
Galantsev, Dmitrii 271f017251 OTF2 - Fix lib vs lib64 location on some systems (#68)
On my dev machine I use OpenSUSE Tumbleweed. For some reason OTF2 gets
installed into BUILD/external/otf2/lib64/, while cmake for the lib
searches BUILD/external/otf2/lib and cannot find it.

My fix sets the location to always match CMAKE_INSTALL_LIBDIR

Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-01-08 22:47:44 -06:00
Madsen, Jonathan 2c3bdeaed9 Download perfetto trace_processor_shell (#105)
* Download perfetto trace_processor_shell

* Upgrade to perfetto-trace-processor-shell v0.0.4

* Fix run-ci.py warning

- warning message:

CMake Warning (dev) at /.../build/CTestCustom.cmake:16:
  Syntax Warning in cmake code at column 77
  Argument not separated from preceding token by whitespace.

* Update tests/pytest-packages/pytest_utils/perfetto_reader.py

---------

Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2025-01-08 20:32:48 -06:00
Tim Huang 7bad0cb4a1 kfdtest: add blacklist for gfx1153
Change-Id: I1f132858cb79c6d0561477fe8ce69aafd93ad351
Signed-off-by: Tim Huang <tim.huang@amd.com>
2025-01-08 21:20:17 -05:00
Galantsev, Dmitrii 5861ec7663 RVS - Add IET and PEBB tests
Change-Id: Ia032901d74c882e5cbfa5a3164199cd4d571341f
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2025-01-08 18:23:13 -06:00