Commit gráf

8920 Commit-ok

Szerző SHA1 Üzenet Dátum
itrowbri 4ca1a68fd9 SWDEV-477849: Remove dependency of libatomic from roctracer
Change-Id: I2d94218936d33d832d1fddfe14454de5c1bc64f5
2024-10-16 13:49:52 -05:00
Benjamin Welton 28a6918b33 Clang Warning Fixes (#1131)
Builds prevented on clang-18
2024-10-15 22:20:38 -07:00
Ammar ELWazir d762694acb Fixing kokkosp tool library packaging (#1121)
* Fixing kokkosp tool library packaging

* Update source/lib/rocprofiler-sdk-tool/kokkosp/CMakeLists.txt

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update CMakeLists.txt

* Update CMakeLists.txt

* Component Requirement in CPack

* Adding package dependency

* Update CMakeLists.txt

* Update rocprofiler_config_packaging.cmake

* Fix rocprofiler-sdk-tool-kokkosp BUILD/INSTALL RPATH

- CMAKE_INSTALL_LIBDIR doesn't help

* Add BUILD/INSTALL RPATH to rocprofv3-trigger-list-metrics

- fixes packaging issues

* Update packaging

- core depends on rocprofiler-sdk-roctx
- add CPACK_DEBIAN_PACKAGE_SHLIBDEPS_PRIVATE_DIRS to resolve inter-package dependencies

* Fix package depends version format

* Improve tests/rocprofv3/summary/validate logging

* Update CI workflow

- prioritize roctx package in Install Packages step

* Remove setting <package-name>_VERSION in config.cmake.in

- this is automatically handled by existence of <package-name>-config-version.cmake

* Update rocprofiler-sdk-config.cmake

- relax find_package versioning requirements to same major and minor version

* Update rocprofiler-sdk-config.cmake

- relax find_package versioning requirements (remove EXACT, specify range)

* Tweak CI workflow

* Update perfetto_reader.py

- better handle failure to load trace processor

* Misc cleanup for config packaging

* Update config packaging

* Update config packaging

* Revert perfetto for core-rpm packages

* Revert perfetto for core-rpm packages

- perfetto < 0.9.0

* Tweak tests/rocprofv3/summary/validate.py

- reorder some checks

---------

Co-authored-by: Ammar Elwazir <aelwazir@useocpm2m-387-013.amd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-10-15 20:28:06 -05:00
Galantsev, Dmitrii 28acbf0436 Profiler - Modify metrics
Remove occupancy metrics and replace with OccupancyPercent

Add OCCUPANCY_PERCENT which uses OccupancyPercent
Add GR_ENGINE_ACTIVE which uses GPU_UTIL/100
Add TENSOR_ACTIVE_PERCENT which uses MfmaUtil
Modify FLOPS_64 to use FP64_ACTIVE

Change-Id: I5f30d77a0c80f5ac78abd1a9e57f8a0a3c6cc00b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2024-10-15 19:00:30 -05:00
Jonathan R. Madsen 309d53b20b Correct the package name of rocprofiler-sdk (#1126)
* Correct the package name of rocprofiler-sdk

ROCM VERSION(for ex: 60300) was missing in the package name.
Added the same

* Use cmake cache string while setting the variable for ROCm Version

* correct the cmake-format

---------

Co-authored-by: Ranjith Ramakrishnan <Ranjith.Ramakrishnan@amd.com>
2024-10-15 18:45:51 -05:00
Daniel Su c16f57801a External CI: enable CI triggers (#6) 2024-10-15 16:42:56 -04:00
David Yat Sin d58c9dea0a rocr: Add executable flag for memory allocations
Change-Id: I8307cd3562c3ab9c12fef8c457a59916e33b7923
2024-10-15 16:52:00 +00:00
David Galiffi d07bf508a9 Rename Omnitrace to ROCm Systems Profiler (#4)
The Omnitrace program is being renamed. 

Full name: "ROCm Systems Profiler"
Package name: "rocprofiler-systems"
Binary / Library names: "rocprof-sys-*"

---------
Co-authored-by: Xuan Chen <xuchen@amd.com>
Signed-off-by: David Galiffi <David.Galiffi@amd.com>
2024-10-15 11:20:40 -04:00
Manjunath-Jakaraddi f84ecfe99b SWDEV-481162: Updating MfmaUtil metric RDC
Change-Id: I60efa183edc14b6f870f7b6a82f223ea2c9789e5
2024-10-14 16:48:56 -05:00
Giovanni LB e5e2c6041d SWDEV-310289: Adding SPI pipe selection
Change-Id: I4856d284df3dccaa100a2341211ae09e11c63ecd
2024-10-12 01:14:49 -04:00
Benjamin Welton 6d80088c84 Added FP64_ACTIVE and ENGINE_ACTIVE
Should replicate DCGM_FI_PROF_EVAL_FLOPS_64 and
DCGM_FI_PROF_GR_ENGINE_ACTIVE respectively. See
https://ontrack-internal.amd.com/browse/SWDEV-490046
and
https://ontrack-internal.amd.com/browse/SWDEV-490031

Change-Id: Ia79f6a1601beac48a350493f2e83ce322c1d8d33
2024-10-11 15:51:09 -07:00
coleramos425 e633d17372 Update CODEOWNERS for product team
Signed-off-by: coleramos425 <colramos@amd.com>
2024-10-11 20:25:43 +00:00
David Yat Sin ead3aafcda rocrtst: Fix VirtMemory_Basic_Test permissions
Fix VirtMemory_Basic_Test permissions to adjust for previous change to
the hsa_amd_vmem_set_access behavior change that was done with this
patch:

rocr/vmm: Only modify permisions for specified agents

Change-Id: I97230600b9b9144459b08ca3da3a5bfbdbb98231
2024-10-11 10:41:11 -04:00
gobhardw d5bbc8aa77 SWDEV-479505 Updating ROCtracer spec for device ids
Change-Id: I9b65d91b36b77183d5fa55f23e4926510e0b5832
2024-10-11 09:26:42 -04:00
jokim 1d6ff45673 rocr: Workaround segfault on GFX9 devices older than GFX90a
Devices older than GFX90a hit a segfault on queue unmap when an
SDMA queue has been assigned a fixed engine.  Bypass fixing the
engine for these devices for now.

Change-Id: I7d2f882d2377f004a7bb65f3b397396db07ce6d3
2024-10-10 14:41:10 -04:00
Pramendra Kumar f3df78f746 Revert "Adding rocm-llvm-dev package as req."
This reverts commit b42028fcc0.

Reason for revert: <Imapcting driver install to QA due to timeout>

Change-Id: If5d98341e9ac3e803965064e3f5dc435b9310a0b
2024-10-10 06:59:50 -04:00
Gopesh Bhardwaj 8ab1ed78d8 Adding Node-id for debugging with log level trace (#1090) 2024-10-10 11:00:28 +05:30
adapryor e20bc58b1c Add XGMI read/write sum metrics
Change-Id: I898b779ea7f5336edf0d047fb1e5d3ec40085baa
2024-10-09 17:02:55 -05:00
Kent Russell ccd80d19ba kfdtest: Fix in-tree scriptless build
If you build thunk following the instructions in the thunk's README,
there is no /lib folder in the build folder. Adjust the include path,
and clean up the docs to reflect that. The header include is already
defined in the CMake file as ../../include, so we don't use
LIBHSAKMT_PATH for that linking, just the lib location

Change-Id: I73435d59adb9d01f527a28b1935086260e9d3d70
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-10-08 14:42:33 -04:00
Gopesh Bhardwaj 81e93a6ddb mem copy direction field update (#1124) 2024-10-08 15:15:48 +05:30
Benjamin Welton b46966e96b clang-18 build fix for RCCL (#1123)
Removes ambiguity on const usage, which clang-18 complains about
(preventing build with warn error).
2024-10-07 15:58:41 -07:00
Mythreya a3b41d04fc Fix PSDB change (#1120)
Reverts change to `source/include/rocprofiler-sdk/callback_tracing.h`
from commit 9b2ece76c3
2024-10-07 17:37:19 -05:00
Giovanni Lenzi Baraldi 9652a6e738 SWDEV-487621: Fixes for metric definitions (#1118)
* Fixes for metric definitions

* Removing gfx8

* Update changelog

* Fixing unit tests

* Small fixes

* Fix for write size
2024-10-08 02:44:31 +05:30
Giovanni Lenzi Baraldi a6be3f9660 SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests. (#1112)
* SWDEV-488948: PC Sampling - Correlation class to provide some thread safety. Adding multithread tests.

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/parser/correlation.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Adding backlog for codeobj changes

* Formatting

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

* Update source/lib/rocprofiler-sdk/pc_sampling/code_object.hpp

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>

---------

Co-authored-by: Vladimir Indic <139573562+vlaindic@users.noreply.github.com>
2024-10-07 20:00:59 +00:00
vstempen ba94cb8370 Documented Docker container OpenSSL abilities being affected by Host network proxy services (#440)
* Documented Docker container OpenSSL abilities being affected by host
network proxy services, causing network certificates verification
problem during Docker container build stage of Grafana server setup.

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>

* Update docs/install/grafana-setup.rst

Co-authored-by: Peter Park <peter.park@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>

---------

Signed-off-by: Vladimir Stempen <vladimir.stempen@amd.com>
Signed-off-by: vstempen <147086176+vstempen@users.noreply.github.com>
Co-authored-by: Peter Park <peter.park@amd.com>
2024-10-07 15:53:48 -04:00
Giovanni LB bddd5b51dd SWDEV-487621: Fixing BW measurement in MI300
Change-Id: Ib513009616214a1f3f3568571e58d79259692cfc
2024-10-07 16:29:09 -03:00
Shweta Khatri 8bc4efc8ca hsakmt: pmc_table.c: Fix Coverity reported warnings
Eliminate out-of-bounds access in get_block_properties

Change-Id: I3abee1e36fafdda053d4bc4a611698d676b01d5c
2024-10-07 14:15:26 -04:00
Shweta Khatri 52e7fd1480 hsakmt: debug.c: Fix Coverity reported warnings
Fix potential  memory leak reported by Coverity warnings

Change-Id: Iacbaa99be3f4fe7fae5fb6a10bd41dfc34b96059
2024-10-07 14:14:26 -04:00
Shweta Khatri c9454794b6 hsakmt: fmm.c: Fix Coverity reported warnings
Fixed multiple issues related to memory management, atomicity,
and error handling across various functions: handle null checks,
use-after-free, unchecked returns, and memory leaks.

Change-Id: Ia7c76320cc20e24001052fbba2dd0600bd412140
2024-10-07 13:54:03 -04:00
Giovanni LB dfa81b0cab Fix for s_delay_alu followed by s_waitcnt on gfx11
Change-Id: I3254ee80a0a5542467da5c61cf60f9e27aab9a36
2024-10-07 14:11:24 -03:00
Gopesh Bhardwaj 9b2ece76c3 Fixing installed pacakge tests in CI (#1119)
* Fixing installed pacakge tests in CI

* Formatted rocprofv3.py with black formatter
2024-10-07 20:55:35 +05:30
Gopesh Bhardwaj f2f267bcc0 updating rocprofv3 help options (#1113)
* updating rocprofv3 help options

* updating CHANGELOG
2024-10-05 12:40:27 +05:30
David Yat Sin dbae8da515 rocr: Fix memory leak on non-visible GPUs
Fix memory leak for memory regions objects when GPU is masked using
ROCR_VISIBLE_DEVICES.

Change-Id: I610842a18adbc3cdc854b12650844e271bc00592
2024-10-04 17:40:47 -04:00
Peter Park dc63370a1f Update documentation requirements (#402) (#5)
* Bump rocm-docs-core to 1.8.2

* Remove empty package-ecosystem in dependabot

Co-authored-by: Sam Wu <22262939+samjwu@users.noreply.github.com>
2024-10-04 15:27:02 -04:00
Jonathan Kim 0ae064fe2d rocr: Use new extended graphics handle registration call on IPC import
To correctly map to all GPUs after an import, use the new extended
registration call that can import a virtual address without having to
specify a target node.

Change-Id: Ifca8f6f6ee24fa99b2af357dcc3ea1de3ab234f7
2024-10-03 14:06:37 -04:00
Jonathan Kim 03463ed2c0 hsakmt: Enable graphics handle registration with a virtual address
Currently registering graphics memory without specifying a target
node will return a memory handle that's not a virtual address.

As a result, ROCr is forced to register with a target node for
IPC usage.

Mapping memory without specifying a target node afterwards will
result in mapping to the target node that was imported because the
previous import call flags this node targeting action to future mapping.

For ROCr IPC usage, ROCr wants to map to all GPU nodes if the target node
is not specified.

Allow the caller to register graphics handles that returns a virtual
address without having to specify the target node so that the caller
can make a subsequent map call to all GPUs.

Change-Id: I5a935092b885cc3568e4f3a5dd951c7ec6c84fca
2024-10-03 14:06:31 -04:00
Giovanni Lenzi Baraldi fa7fc7ec5d Fixing some accumulate metrics (#1089)
* Fixing some accumulate metrics

* Fixing some more accumulate metrics

---------

Co-authored-by: Benjamin Welton <bewelton@amd.com>
2024-10-03 09:44:31 -07:00
Giovanni Lenzi Baraldi 1d6a0b5c80 SWDEV-467350: Skipping tool counter iteration for unsupported hardware (#1083) 2024-10-03 09:04:42 -07:00
Ben Richard fb210abcd0 Skip output lines that have UTF8 decoding error (#441)
* Avoid crash if non-UTF8 character is encountered in output

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Ignore lines with non-UTF-8 characters. Do not print error.

Signed-off-by: benrichard-amd <ben.richard@amd.com>

* Remove trailing whitespace

Signed-off-by: benrichard-amd <ben.richard@amd.com>

---------

Signed-off-by: benrichard-amd <ben.richard@amd.com>
2024-10-03 11:27:55 -04:00
Benjamin Welton a159fb47c7 Update limit for max counter records in rocprof-tool (#1073)
A fixed sized std::array is used to store counter records in rocprofiler SDK. This limit was breached in SWDEV-484742. Upping the limit to 512 to be less likely to reach this limit again.
2024-10-02 16:56:42 -07:00
Benjamin Welton 4f05850efd [SWDEV-484495] Fix int truncation in CSV output (#1098)
CSV output truncates doubles to ints when it shouldn't. Derived metrics
are (mostly) doubles and lose precision (or become worthless) if treated
as an int. Converted these to double to match the format we return from
rocprof-sdk.

Co-authored-by: Benjamin Welton <ben@amd.com>
2024-10-02 16:55:00 -07:00
Ranjith Ramakrishnan f27ae44b8c cmake component grouping should not be ignored
In static build, the dev and binary components are grouped to generate static package
Removed the line that was ignoring the component grouping

Change-Id: Ie0ca9db109f2002891260985634f2e6b1ea7f236
2024-10-01 14:22:21 -07:00
Cole Ramos c8a1add54b Add smart name and notes to triggered releases (#438)
Signed-off-by: coleramos425 <colramos@amd.com>
2024-10-01 14:59:38 -05:00
Tim 725d289a2b Fix Issue [SWDEV-485618]: README Outdated: Include File
Changes to the README.md:
-Fixed the dead links in the examples.
-Updated the example to point to the ones in roctracer_spec.md instead of tests.

Changes to the roctracer_spec.md:
-Changed #include from #include <*.h> to #include <roctracer/*.h> to
reflect the latest code structure.

Change-Id: Iab44fc327821c1a01f0b949d3c9a3c20ca587599
2024-10-01 09:52:09 -04:00
Shweta Khatri 9f43c9fd51 hsakmt: spm.c: Fix Coverity reported warnings
Fix unused ret value and initialize gpu_id

Change-Id: Ib3acc7db4bbab519318d0970786a5dc641dcc9eb
2024-09-30 19:46:51 -04:00
David Yat Sin 73f6bfa747 rocr/vmm: Only modify permisions for specified agents
When hsa_amd_vmem_set_access is called, do not remove permissions for
unspecified agents. Also updating documentation in header to clarify
this.

Change-Id: I3bb4cf08ba399f85cc67b17fd13a4a40d862415f
2024-09-30 17:41:58 -04:00
coleramos425 faaf5bdcfe Update issue template
Signed-off-by: coleramos425 <colramos@amd.com>
2024-09-30 16:45:42 +00:00
Mukul Joshi b81e45f03c kfdtest: Update KFDPerformanceTest.P2PBandWidthTest for CPX mode
Currently, KFDPerformanceTest.P2PBandWidthTest cannot work if there are
more than 16 KFD nodes in the system. This limit was put in to match the
number of SDMA queues supported on a single node.
This patch updates the test to make it run on systems with more than
16 KFD nodes.

Signed-off-by: Mukul Joshi <mukul.joshi@amd.com>
Change-Id: I561d0cdef664cae84fb9c13a801052e2001256e5
2024-09-30 11:28:33 -04:00
Charis Poag 28c2cc3298 Merge amd-staging into amd-master 20240930
Change-Id: I814a16d5e1f9371e00dbbb3623dc975ab2359f44
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2024-09-30 10:56:18 -04:00
Jeffrey Novotny 78fe20320f Correct link to rocprofiler-sdk GitHub (#1097) 2024-09-27 21:03:49 -06:00