Commit Graph

8920 Commits

Author SHA1 Message Date
Ammar ELWazir eae890e335 Update rerun.yml 2024-04-04 12:21:32 -05:00
Ammar ELWazir ad22340a8c Update rerun.yml 2024-04-04 12:17:36 -05:00
Ammar ELWazir 48e4af1685 Fixing Re-Run (#740)
* Update rerun.yml

* Update rerun.yml

* Update rerun.yml

* Update rerun.yml
2024-04-04 11:27:24 -05:00
Ammar ELWazir 8c6017e7ff Fixing rerun comments (#738)
* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Rerun separated in different yml file

* Update rerun.yml

* Update rerun.yml

* Update rerun.yml
2024-04-04 11:02:14 -05:00
Ammar ELWazir 8c03c8a914 Adding PC Sampling CI (#739)
* Create ci_pc_sampling.yml

* Update continuous_integration.yml

* Update ci_pc_sampling.yml

* Update ci_pc_sampling.yml

* Update continuous_integration.yml
2024-04-04 10:03:08 -05:00
Ammar ELWazir 5bb087f072 Adding useful scripts for formating and building (#737)
* Addin useful scripts for formating and building

* Update build.sh

* Update build.sh

* Update continuous_integration.yml
2024-04-04 06:49:17 -05:00
gobhardw f0daa910d8 Disabling PC-sampling compilation
Change-Id: I56cc8a1c69ca32dc147cb945b18e708b3292beaf
2024-04-04 02:17:04 -04:00
Benjamin Welton e0caae9ebc Add debug printing for write interceptor injected packets (#674)
* Add debug printing for write interceptor injected packets

Adds debug printing for write interceptor injected
packets. All packets that pass through the write
intercepter while enabled will be printed.

Only executes/prints when the environment variable
GLOG_v is set to 2 or higher (otherwise it is a no-op
and the expression is not evaluated).

* source formatting (clang-format v11) (#675)

Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com>

* Changes on fmt location

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com>
2024-04-03 18:14:22 -07:00
Giovanni LB 563b1b023e Moving ATT Parser to v0.5
Change-Id: I0a348c183a9140de81d83e7ec0f337afe859bfd5
2024-04-03 12:06:20 -04:00
gobhardw 79096aff75 SWDEV-454917 Fix for multi-line input files in counter collection
Change-Id: Ibe63514cb6e14fe628f60a9f1952df24802d6d05
2024-04-03 15:09:57 +05:30
Benjamin Welton 41c0ddd72d Convert LOG() -> ROCP_X logging macros. (#695)
* Convert LOG() -> ROCP_X logging macros.

This patch converts the LOG() macro to the ROCP_X logging macros.
There are the following levels of logs.

Logs whos expressions are not evaluated unless the log level is enabled:

ROCP_TRACE - VLOG(2) (enabeled by env variable GLOG_v=2)
ROCP_INFO - VLOG(1) (enabeled by env variable GLOG_v=1)

Logs whos expressions are always evaluated:

ROCP_WARNING - LOG(WARNING)
ROCP_ERROR - LOG(ERROR)
ROCP_FATAL - LOG(FATAL)
ROCP_DFATAL - DLOG(FATAL) (only fatal in debug mode)

* source formatting (clang-format v11) (#696)

Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com>

* Minor fix

* Fixes for VLOG before main

* fix vmodule

* source formatting (clang-format v11) (#718)

Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com>

* memory leak fix

* Vlog change

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: bwelton <1683479+bwelton@users.noreply.github.com>
2024-04-02 17:15:30 -07:00
Gopesh Bhardwaj 5e4dd502d9 README update (#730)
* README update

* Addressing review comments
2024-04-02 14:11:05 -05:00
Ammar ELWazir 872aa1b1d2 Update formatting.yml 2024-04-02 11:28:44 -05:00
Shweta Khatri 244ad319ac Revert "Use HybridMutex for IPC locks"
This reverts commit 5c520f4544c654e5f18e05cabd1c63d64473cfab.

Reason for revert: This patch is introducing a synchronization related bug in Unit_hipGetSetDevice_MultiThreaded testcase.

Change-Id: I367e4d4f1d75b21658ac1127c58982894a97cedb
2024-04-02 12:27:55 -04:00
Benjamin Welton 1e612a5e52 Wait for all memory copies to complete before allowing destruction (#725)
* Wait for all mem copies to complete before destroying.

* Update source/lib/rocprofiler-sdk/hsa/async_copy.cpp

Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com>

* Update async_copy.cpp

---------

Co-authored-by: Ammar ELWazir <ammar.elwazir@amd.com>
2024-04-02 08:22:37 -05:00
Jonathan R. Madsen 939e23e9d1 Stop all client contexts prior to finalization (#721)
* Stop all client contexts prior to finalization

* Update lib/common/container/static_vector.hpp

- improve emplace_back for non-{move,copy}-assignable object

* Update samples/intercept_table/client.cpp

- improve robustness against static object destruction

* Update lib/rocprofiler-sdk/context/context.cpp

- change storage of registered context array
  - stable_vector of optional contexts
  - common::static_object wrapper around stable_vector

* Update samples/intercept_table/client.cpp

- use variable template for underlying function pointer
2024-04-02 03:05:11 -05:00
Gopesh Bhardwaj e3c7eed7c0 SWDEV-451569: bug in tracing options (#728) 2024-04-02 03:03:02 -05:00
dependabot[bot] 9d6809d0b6 Bump actions/configure-pages from 4 to 5 (#706)
Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 4 to 5.
- [Release notes](https://github.com/actions/configure-pages/releases)
- [Commits](https://github.com/actions/configure-pages/compare/v4...v5)

---
updated-dependencies:
- dependency-name: actions/configure-pages
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-04-02 02:34:32 -05:00
Ammar ELWazir ddbcf34da5 Formating Issue fix (#726)
* Update formatting.yml

* Update formatting.yml

* Update client.cpp

* Update formatting.yml

* Update samples/api_buffered_tracing/client.cpp

* Update client.cpp
2024-04-02 02:14:59 -05:00
Ammar ELWazir c45573f559 Update validate.py (#727) 2024-04-02 01:59:33 -05:00
Ammar ELWazir 2905fb5e95 Update run-ci.py (#641)
* Temp: Fixing node id

* source formatting (clang-format v11) (#709)

Co-authored-by: ammarwa <3832908+ammarwa@users.noreply.github.com>

* Using logical node id

* Update agent.cpp

* Update agent.cpp

* Python formatting

* Update run-ci.py

* Update run-ci.py

* Update continuous_integration.yml

* Update continuous_integration.yml

running directly using the prepared runner container

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update run-ci.py

* Clean up

* Fixing install paths

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Update continuous_integration.yml

* Fixing GPU Agents Test Validation

* python formatting (black) (#712)

Co-authored-by: ammarwa <3832908+ammarwa@users.noreply.github.com>

* Fixing the issue with rocclr detected kernels __amd_rocclr_.*

* python formatting (black) (#713)

Co-authored-by: ammarwa <3832908+ammarwa@users.noreply.github.com>

* Fixing the issue with rocclr detected kernels __amd_rocclr_.*

* Fixing static number of async copies and using hsa_api instead for validation

* python formatting (black) (#714)

Co-authored-by: ammarwa <3832908+ammarwa@users.noreply.github.com>

* Increasing the time limit for waiting on active signals

* Update continuous_integration.yml

* Update async_copy.cpp

* Update CMakeLists.txt

* changing node id to logical node id in rocprofv3

* Update tool.cpp

* testing async mem copy signal decrement

* Update logging.cpp

* Update validate.py

---------

Co-authored-by: Ammar ELWazir <aelwazir@rocprofiler1.amd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ammarwa <3832908+ammarwa@users.noreply.github.com>
Co-authored-by: Ammar ELWazir <aelwazir@rocprofiler2.amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-04-02 01:39:24 -05:00
Ammar ELWazir 62625d0aa1 Use logical_node_id for mapping rocprofiler agents to HSA agents (#708)
* Temp: Fixing node id

* source formatting (clang-format v11) (#709)

Co-authored-by: ammarwa <3832908+ammarwa@users.noreply.github.com>

* Using logical node id

* Update agent.cpp

* Update agent.cpp

* Python formatting

---------

Co-authored-by: Ammar ELWazir <aelwazir@rocprofiler1.amd.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: ammarwa <3832908+ammarwa@users.noreply.github.com>
Co-authored-by: Ammar ELWazir <aelwazir@rocprofiler2.amd.com>
Co-authored-by: Jonathan R. Madsen <jonathanrmadsen@gmail.com>
2024-04-02 01:38:18 -05:00
Benjamin Welton 4200faf813 Revert "Add additional debug info and do iteration on per-agent basis" (#723)
This reverts commit 6fc239f6eb.
2024-04-01 22:27:27 -07:00
Benjamin Welton 6fc239f6eb Add additional debug info and do iteration on per-agent basis 2024-04-01 18:45:04 -07:00
Jonathan R. Madsen 092c428b78 Update internal threading (#720)
- update lib/rocprofiler-sdk/internal_threading.*
- use PTL::TaskManager instead of PTL::TaskGroup
  - easier to handle for our needs
  - eliminate data race in rocprofiler_flush_buffer
  - combine memory management of TaskManager and ThreadPool
2024-04-01 20:31:54 -05:00
Charis Poag 6fada8c4a6 Merge amd-staging into amd-master 20240401
Change-Id: I52c8665735e86deed53645197c11889fc7ece8c5
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2024-04-01 17:48:06 -05:00
Stella Laurenzo a180fea5ad Properly nest build time headers to match arrangement at install time.
The build tree was missing a level of nesting, causing diversions based
on in-tree/out-of-tree use.
KR: Also fixed kfdtest paths

Change-Id: I8638b6d6227daabddd8eaa2aa387ba578b8dfab8
Signed-off-by: Stella Laurenzo <stellaraccident@gmail.com>
Signed-off-by: Kent Russell <kent.russell@amd.com>
2024-04-01 17:10:40 -04:00
Benjamin Welton 001f9baa04 Add debug printout for data in CC validate 2024-04-01 13:02:50 -07:00
coleramos425 aa5f4e7b95 Update documentation runner assets
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-01 14:35:57 -05:00
coleramos425 9403dce667 Define a README for /src subdir
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-01 14:30:21 -05:00
coleramos425 aac471c0fa Reorganizing docs runner and setting archive subdir for old docs
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-01 14:30:21 -05:00
coleramos425 9c93449cc7 Remove hardcoded URLs from docs in favor of relative links
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-01 14:30:21 -05:00
coleramos425 e0556f32ab Move dispatch id patch to proper util func in utils. Enable in rocprofv2 post-processing
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-01 14:30:21 -05:00
Nick Curtis a1017b68e9 implement rocprofv2 workaround for dispatch ids (#336)
* implement rocprofv2 workaround for dispatch ids

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

* formatting

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>

---------

Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
Co-authored-by: Nicholas Curtis <nicurtis@amd.com>
2024-04-01 14:30:21 -05:00
coleramos425 1a3bdad90a Adding documentation for global command line options
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 6cc8f0154f Restore OMNIPERF_COLOR global to disable default log coloring
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd b1d0b3905c Extending log coloring to message text. Enable by default.
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 78c48eaed5 Remove superfluous logging statement
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd f47b8d2547 Throw more helpful warning on missing csv in analyze mode (#313)
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
coleramos425 706afa7f37 Register TRACE loglevel ahead of parse_args to avoid error in --specs printout
Signed-off-by: coleramos425 <colramos@amd.com>
2024-04-01 14:30:21 -05:00
Cole Ramos f7394bf272 Revert #333 deterministic ordering (#337)
* Revert "formatting"

This reverts commit e387561791898467371b6219921f10447d3486b3.

* Revert "Implement deterministic ordering of perfmon"

This reverts commit 2a24600a37c8002838145962a957cea447555b0c.
2024-04-01 14:30:21 -05:00
Nicholas Curtis f6f6165379 formatting
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
2024-04-01 14:30:21 -05:00
Nicholas Curtis 97af96e435 Implement deterministic ordering of perfmon
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 3928f36d5e Adding redirect to help button in standalone GUI
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 33e763178e Removing unused modules
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 3d8b748924 Documentation enhancements and removing watermark
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 73ac6c9561 Adding comments to roofline and changing output file name for specificity
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 2cc297b9e1 Update version in anticipation of 2.0 release
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd cf36fb7fbf Implementing docs feedback with typos and minor enhancements
Co-authored-by: Jose Santos <josantos@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00
colramos-amd 6cfdca93b9 Correct typo in Mi100 metric defs for missing SQ_INSTS_VMEM
Signed-off-by: colramos-amd <colramos@amd.com>
2024-04-01 14:30:21 -05:00