AI/rocm-systems
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
8,920 Commits 3 Branches 0 Tags
93958aa8b9a8b0c19ea57ed15cddc668bef0ffa9
Commit Graph

8920 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
colramos-amd d6f45411eb Python formatting 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 817774be5e print version out of table 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nick Curtis 5b5d4c9a23 Update src/utils/specs.py 
Co-authored-by: Cole Ramos <colramos@amd.com>
Signed-off-by: Nick Curtis <6463881+skyreflectedinmirrors@users.noreply.github.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis de384467f5 push missing rabulate through get_table_string 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 200961ffd9 Re-implement machine-specs to contain documentation, units, etc. Print using tabulate 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
coleramos425 e86741ec6c Fix outdated function name to set arch 
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
coleramos425 5ebd2dbc74 Re-enable multi kernel filtering 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: coleramos425 <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis c10cc0ede2 fix for improper display of % of peak for instruction mix panel 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis cdeef4ebb3 minor touchup 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis a25da8d954 fix warning about unescaped control sequence 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 3197553ca6 Add version to specs/sysinfo output in order to throw warning for new fields 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 09f1455308 Added consistent 'Channel' headers to l2_per_chan, removed hardcoded 32 channels, and removed printed Nones (#276) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis e2ef041057 fix roofline install 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 0d516f05b4 Fix bug in GUI kernel filtering 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 20d93703fc correct small negatives in remote read/write traffic due to running in different passes 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 2c3c5fba35 fix dependency ordering in builtins 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis 18dfc35c14 typo 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
Nicholas Curtis c5e4a33c07 catch missing per-XCDs 
Signed-off-by: Nicholas Curtis <nicurtis@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd c17e39189f Enhance correct_sys_info() func and err checking 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 17a4d92c63 Remove mean for avg header in inst cache panel 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd a70dc4999d Hide L2Banks in sysinfo and update roofline module 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 3e59c928e0 Fixing misc Mi300 typos 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd d2c3d7faf9 Misc fix for kernel name shortener 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd bd794abb12 Fix Mi300 clk timings using GRBM_GUI_ACTIVE from #255 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 2001908fd8 Carry over fixed numSQCs calc from #247 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 3ce140d04b Including remaining metric fixes from #251 
Co-authored-by: Nick Curtis <nicholas.curtis@amd.com>
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 86b6c8e848 Renaming global spec vars. Replacing L2Banks with total_l2_chan (#251) 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
colramos-amd 3b1b8d7b5b Reorganize the specs module to reduce duplicate code 
Signed-off-by: colramos-amd <colramos@amd.com>
 2024-03-01 15:50:42 -06:00
arvindcheru 9b163aa567 Merge pull request #7 from arvindcheru/master-local-merge2 
Merging all the changes from internal development gerrit to github
 2024-03-01 14:50:17 -05:00
David Galiffi 90846043b9 SWDEV-437292 - Update CODEOWNERS file 
Add @nunnikri, @frepaul, @raramakr, @ashutom, and @amd-isparry
as CODEOWNERS.

Signed-off-by: David Galiffi
Change-Id: I1b4fa626bda8012cac569917d1d2a79afada7168
 2024-03-01 11:02:24 -08:00
AravindanC d338714f4d Adding Method to get ROCM Install Path 
Change-Id: Ib8ff920402e9f5d41c0ff8a0e4b76a18596e20e2
 2024-03-01 11:02:24 -08:00
Jonathan R. Madsen 1bb94add11 Fix rocprofiler_iterate_callback_tracing_kind_operation_args for HIP compiler callbacks (#532) 
* Fix HIP compiler iterate args

- `include/rocprofiler-sdk/hip/api_args.h`
  - replace struct fields named "f" with "func"
  - replace hip stream fields named "hStream" with "stream"
- `lib/rocprofiler-sdk/callback_tracing.cpp`
  - iterate_args for HIP compiler table
- `lib/rocprofiler-sdk/registration.cpp`
  - fix warning about roctx num_tables
- `lib/rocprofiler-sdk/hip/hip.def.cpp`
  - replace struct fields named "f" with "func"
  - replace hip stream fields named "hStream" with "stream"
- `lib/rocprofiler-sdk/{hip,hsa,marker}/utils.hpp`
  - improve `stringize_impl`
- `lib/rocprofiler-sdk/hsa/code_object.cpp`
  - remove stale commented out code
- `lib/rocprofiler-sdk/hsa/queue_controller.*`
  - destory_queue -> destroy_queue
- `tests/tools/json-tool.cpp`
  - improve parallelism in tool_tracing_callback
  - serialize the marker api args
  - only invoke rocprofiler_iterate_callback_tracing_kind_operation_args in exit phase
- `samples/counter_collection/CMakeLists.txt`
  - reduce timeout on tests to 120 seconds

* Update lib/rocprofiler-sdk/hsa/utils.hpp

- disable dereference of double pointer in stringize_impl

* Update lib/common

- indirection_level in mpl.hpp
- stringize_arg.hpp

* Rework rocprofiler_iterate_callback_tracing_kind_operation_args

- provide more information in rocprofiler_callback_tracing_operation_args_cb_t
- support specifying the dereference level to account for output paramters
 2024-03-01 01:46:07 -06:00
Jonathan R. Madsen a1267e1fd2 C compatibility for public headers (#566) 
* C compatibility for public headers

- add tests/tools/c-tool.c
  - builds a tool (which does nothing) with C language
  - ensures that tool can be compiled in C
- add tests/c-tool/CMakeLists.txt
  - ensures that tool library build from C is a valid tool
- rocprofiler_counter_info_v0_t is_derived is int instead of bool
  - C does not have bool unless <stdbool.h> is included
- add `include/rocprofiler-sdk/hsa/api_trace_version.h
  - handles providing HSA_*_TABLE_(MAJOR|STEP)_VERSION values if compiled from C
- cmake define in version.h.in for ROCPROFILER_HSA_*_TABLE_(MAJOR|STEP)_VERSION
  - HSA table versions compiled with
- use rocprofiler_(hsa|hip|marker)_api_no_args struct to handle incompatibility b/t empty structs in C vs. C++ (size of 0 vs. size of 1)
- extern "C" in include/rocprofiler-sdk/{hsa,hip,marker}/api_args.h
- fixed spelling error: derrived -> derived
- scope YY_NO_INPUT compile definition to lib/rocprofiler-sdk/counters/parser/*

* Revert CDash dashboard
 2024-02-29 23:49:54 -06:00
Giovanni LB c6575ab01c SWDEV-448279: Disabling CTF tests 
Change-Id: I63f915862fe28b51206ed58424d3358385103110
 2024-02-29 18:43:50 -03:00
JoseSantosAMD 4ad124a207 Fix off by one out of range kernel filtering (#287) 
* Fi off by one out of range kernel filtering

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

* reformat

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>

---------

Signed-off-by: JoseSantosAMD <Jose.Santos@amd.com>
 2024-02-29 12:38:37 -06:00
JoseSantosAMD f42aa6c7e0 Supress warning: RuntimeWarning: Mean of empty slice (#271) 
* Supress warning: RuntimeWarning: Mean of empty slice

Signed-off-by: Jose Santos <josantos@login1.hpcfund>

* Move import to top

Signed-off-by: Jose Santos <josantos@login1.hpcfund>

* Specify type of RuntimeWarning in catcher. Safer approach

Signed-off-by: colramos-amd <colramos@amd.com>

* Comply to formatting

Signed-off-by: colramos-amd <colramos@amd.com>

---------

Signed-off-by: Jose Santos <josantos@login1.hpcfund>
Signed-off-by: colramos-amd <colramos@amd.com>
Co-authored-by: Jose Santos <josantos@login1.hpcfund>
Co-authored-by: colramos-amd <colramos@amd.com>
 2024-02-29 12:14:46 -06:00
Karl W Schulz e63c24c618 Update CI configuration 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-29 10:58:38 -06:00
Giovanni LB 4bc8dbd029 SWDEV-448279: Workaround for UB24 compiler errors 
Change-Id: I01e880502edac8e8b941d199e08bc8f1eded0a89
 2024-02-28 23:56:14 -03:00
Gopesh Bhardwaj 31dcfabe23 counter collection multi-kernel test (#492) 
* counter collection multi-kernel test

* Adding counter collection in rocprofv3 script
 2024-02-28 17:08:28 -06:00
Karl W Schulz 3111b7ef99 remove coverage reporting for now 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 16:14:00 -06:00
Karl W Schulz 8c53982687 tweaking yaml syntax 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 16:12:39 -06:00
Karl W Schulz 91c268e064 trying another coverage tool 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 16:09:47 -06:00
Karl W Schulz f12794fadb restore all profiling test definitions 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 16:03:48 -06:00
Karl W Schulz 91ea609670 enable yet another reporter 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 15:55:49 -06:00
Karl W Schulz 8ae98403dc temporary disable profile-mode testing 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 15:46:46 -06:00
Karl W Schulz fe3b8e06d4 enforce run of coverage report 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 15:31:27 -06:00
Karl W Schulz 0486f2ffb2 fix yaml syntax 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 15:24:23 -06:00
Karl W Schulz 27967c72e5 trying alternate code coverage reporter 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 15:20:27 -06:00
Karl W Schulz bea6d2e125 fix path to coverage file 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 14:59:56 -06:00
Karl W Schulz a39661165e set required minimum coverage value 
Signed-off-by: Karl W Schulz <karl.schulz@amd.com>
 2024-02-28 14:46:02 -06:00