We don't need to keep track of specific blit engines in gang for
submission anymore as ganging early exits on pending bytes.
So tidy up the fluff.
Change-Id: I77e80bf1ad8f561a03fff77bce33aa09d02760c6
In ASAN builds, the compiler used is clang. The initialization of
variable sized array using assignment operator is causing compilation
failure in ASAN builds. Used memset to fix the same.
Change-Id: I02aef3b99a6cad0cce3a378210a48732e07a88fb
ROCm Packaging uses ROCM_PATCH_VERSION as a standard option to add the patch version which determines the rocm release for different libraries versions
Change-Id: If335f9095b069edd4ab6c29a4eb7349552fd47f3
ROCm Packaging uses ROCM_PATCH_VERSION as a standard option to add the patch version which determines the rocm release for different libraries versions
Change-Id: I1edce84d2963d495c55c83cc0697761d7f696c92
Add test to catch trap on wave start or end override event.
Signed-off-by: Jonathan Kim <jonathan.kim@amd.com>
Change-Id: Icb57af64475fbd2d8a6c0af9a2ee5db5d1a169c6
Address watch test will test read and write operations.
Test will also check if operation is precise if precise
address watch is available.
Signed-off-by: Jonathan Kim <jonathan.kim@amd.com>
Change-Id: I7ef835790e26bf6345682755d7dd26a35853bcd5
For GFX11 debugger testing, waves require to start in non-priv mode for
some test cases, so allow tester to set this.
Signed-off-by: Jonathan Kim <jonathan.kim@amd.com>
Change-Id: Iee93fda926bfd336d51c79c086f1f75bc35b70e5
* Added submodules for glog/fmt
Removes existing printing/formatting code.
* Update external/CMakeLists.txt
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
* Update external/CMakeLists.txt
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
* Update external/CMakeLists.txt
- checkout submodule if not already checked out or clone repo if no .gitmodules file
- find_package(... REQUIRED)
* Disable tests from external directory
* Update external/CMakeLists.txt
- fix type: BRANCH -> REPO_BRANCH
* Update cmake/rocprofiler_register_formatting.cmake
- Include external/CMakeLists.txt in format-cmake target
- include format-cmake in format target
* Fix cmake options
- ROCPROFILE_REGISTER_* -> ROCPROFILER_REGISTER_*
* Update rocprofiler_register_linting.cmake
- fix header filter to exclude external headers
- enable warning-as-errors except for misc-header-include-cycle because that originates in fmt headers
* Fix clang-tidy error in utility.cpp
- a bit out of place in this PR but caught due to --warning-as-errors addition
---------
Co-authored-by: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
When oversubscribing SDMA gangs, a circular deadlock can occur since
gang enqueue is staggered with respect to SDMA engine leader based
on source to destination.
As a result, an enqueued leader may be waiting on a gang item that is
waiting on another enqueued leader or gang item and so on.
To prevent this, first lock the submission to ensure dma status query
and submissions are atomic. Once this is in place, be more stringent
with ganging in that all SDMA engines must be available in order to gang.
Finally, re-enable SDMA ganging by default.
Change-Id: I4511e3487db9d26475b5aece4897f10168cc5322
xGMI for compute partitioning in non-SPX modes does not have
a reported bandwith.
Fix it to at most 2 since each partition is either bounded
by the number of xGMI links or the number of available
SDMA contexts.
Change-Id: I09094bd7548d9eee6f039b0efe849838e5de166e
SDMA ganging is causing some regressions with some applications hanging.
Temporarily disabling SDMA ganging by default until issue is fixed.
Change-Id: I65e172923a53a967df27b30d969ad5d215c4fa09
- Added arbitrary env-vars
- Fixed some UBs with atomic variables
- Fixed loading of file plugin
- ATT vs. kernel-trace off by one
Change-Id: I69c75f66f722e4085b5279f41afd05813628846d