Граф коммитов

8920 Коммитов

Автор SHA1 Сообщение Дата
Jonathan R. Madsen 3e2fa69a14 CI timeout + line-info in releases (#279)
* Update perfetto args.gn.in

- remove enable_perfetto_tools_trace_to_text (unused)

* core timeout implementation

- requires OMNITRACE_CI=ON
- requires OMNITRACE_CI_TIMEOUT=<sec>
- adds pthread_self and std::this_thread::get_id to thread info
- pthread_create_gotcha stores native handles (pthread_self)

* Testing updates

- improve detection of segfault/failures with PASS_REGEX exists
- add OMNITRACE_CI_TIMEOUT env variable to all tests

* Line-info in releases

- e.g. -g1 + more options to minimize size of debug info

* Fix typo in config exit action message

* OMNITRACE_UNLIKELY around debug/verbose messages

* format fixes

* Overflow tests + capability check

* transpose example update

- link to threads library

* roctracer/rocprofiler update

- in ROCm 5.5.0, cannot include rocprofiler.h and roctracer.h in same file due to conflicting enum defs
- Moved HSA tracing setup/shutdown to component::roctracer

* roctracer update

- fix definition of roctracer::setup when disabled

* Update fork example

- detach threads on main PID
- flush io outputs when printing info

* Update overflow tests

- pass regular expressions
- overflow on PERF_COUNT_SW_CPU_CLOCK event

* fork gotcha update

- use getpid() instead of getppid()

* update fork example

- wait on threads calling fork

* timeout update

- wait on timeout thread to launch before proceeding
2023-06-14 11:55:22 -05:00
Ruili Ji 9bf1cbe4ed kfdtest: Update COMPUTE_PGM_RSRC1 for software trap
If asics don't need software traps within GFX11 domain,
test with COMPUTE_PGM_RSRC1.PRIV = 1 will make system hang.

Change-Id: I00cf8eb6d6b07856885c77bd343ca3c41cc3cad5
Signed-off-by: Ruili Ji <ruiliji2@amd.com>
Signed-off-by: Aaron Liu <aaron.liu@amd.com>
2023-06-14 07:46:51 -04:00
Galantsev, Dmitrii 0478d53e23 SWDEV-340919 - Package rsmitst
Similar to I879b21428e6642f19fda67092b365d8b78b7ba7b.

Main CMake improvements:

* Add rsmitst with -DBUILD_TESTS=ON
* Package tests into rocm-smi-lib-tests.deb and .rpm
* Note - this breaks build_rsmitst.sh

Misc improvements:

* Add .editorconfig to normalize code formatting
* Export compile_commands.json
* Remove gtest source and pull from github instead

Change-Id: Ib87ed4a5acd9f78badae6d028e5ff3d4f56dafc2
Depends-On: I8b26795471ad1432c805e45d8b58d7bb34abfcfc
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-06-13 22:52:10 -05:00
Philip Yang 29b04c2534 kfdtest: Fix KFDSVMEvictTest.QueueTest OOM
Typo to calculate bufferSize from vramBufSizeInPages. The OOM shows up
only with HSA_XNACK=1 because HSA_XNACK=0 doesn't support VRAM
oversubscription. We changed to run SVM tests with both XNACK off and
on.

Change-Id: I3949959288fd92f4e7f4a87115a5f1547e225042
Signed-off-by: Philip Yang <Philip.Yang@amd.com>
2023-06-13 21:15:31 -04:00
gobhardw 7da40d2d7b Decoupling HIP code with runFeatureTest target
Change-Id: I8cac692289c7c9393b76789b0fa67eb239df2079
2023-06-14 01:48:17 +05:30
gobhardw bbc7bc1ada Fixing Logging for profiler v2
Change-Id: I7e52236c828f441e78631c5125692959eac7260b
2023-06-13 15:58:05 -04:00
Jonathan Kim bfb94b3b6e Soften trap handler loading failure when exception handling not supported
GFX11 and up including some GFX9 devices will not support
old trap handling without the new exception handling.

Instead of a hard assert failure that runs into a core dump,
let ROCr initialization continue instead.

Change-Id: I309becdc72ef4fb2fafd118c1faf0801407e658e
2023-06-13 13:05:47 -04:00
Ammar ELWazir 6c61aa5311 Fixes for Spack
Change-Id: Ib2ea41b8140589fbc74aa297379588cc720e0183
2023-06-13 12:02:58 -04:00
Galantsev, Dmitrii ac94bf5ed5 Temporarily ignore TestFrequencies
See SWDEV-391039 and SWDEV-391040 for details

Change-Id: I662ba43363d949465454ea4af4d4586b3d47a811
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-06-12 19:26:21 -05:00
Galantsev, Dmitrii 713f85721b --showtempgraph - Show N/A when no temp found
If temp in hwmon was missing - rocm-smi crashed.
e.g. /sys/class/drm/card1/device/hwmon/hwmon5/temp1_input

This change displays "N/A" for temp instead of crashing.

Change-Id: I02f84a466bd3acfbd9b65e7e4ca0f18e76606c3b
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-06-12 19:16:39 -05:00
James Zhu 4ba8f1fe77 kfdtest: Add test for event wait with event age tracking enable
Add 5 different test scenario to cover new event age tracking features.

Change-Id: Icab43240fd127208b18abbd7542d6444127ef0c7
Signed-off-by: James Zhu <James.Zhu@amd.com>
2023-06-10 11:41:50 -04:00
James Zhu a0cbf90b90 libhsakmt: add event age tracking
Keeping last signaled event age to avoid race conditions
for HSA_EVENTTYPE_SIGNAL when event age init value is non-zero.

Change-Id: Ifb9a11a6868e5762a9f92f579e45a0a2c8fa1017
Signed-off-by: James Zhu <James.Zhu@amd.com>
2023-06-10 11:41:50 -04:00
Ammar ELWazir 7ea04a63c5 Fixing Build Library Paths
Change-Id: If71f548dda3dd7cab3dc251b4a3e6389cfc9e4f9
2023-06-10 10:30:25 -04:00
Ammar ELWazir 8350f42329 Tests fix
Change-Id: I1fe7ab12c20e83f0bfc710bfc6db6a8d03802dd5
2023-06-10 10:26:33 -04:00
gobhardw 089fa278b3 SWDEV-388280 making ctf plugin usage similar to perfetto
Change-Id: Iccf17e8d8ff0f96701df8797cbb1ba58f9652575
2023-06-10 11:22:35 +05:30
colramos-amd 79eecb445e Comply to Python formatting
Signed-off-by: colramos-amd <colramos@amd.com>
2023-06-09 10:04:32 -05:00
colramos-amd 5f6c776170 Omniperf rocomni changes
Signed-off-by: colramos-amd <colramos@amd.com>
2023-06-09 10:01:37 -05:00
colramos-amd acb9729540 Fix VGPR issue (#139)
Signed-off-by: colramos-amd <colramos@amd.com>
2023-06-09 10:00:56 -05:00
Laurent Morichetti 6a82b0a038 Fix a race condition in the trap handler
status.priv may be read after returning from the trap handler, which
causes sq_interrupt_word_wave.priv to be 0 even though the s_sendmsg
instruction was initiated when status.priv was 1.

To work around this, added a s_waitcnt lgkmcnt(0) after s_sendmsg
to make sure the message is sent before continuing.

Signed-off-by: Jay Cornwall <Jay.Cornwall@amd.com>
Signed-off-by: Laurent Morichetti <Laurent.Morichetti@amd.com>
Change-Id: Ieb75005ca1559ef03d0efac80e966f521e41fcb7
2023-06-09 10:03:55 -04:00
Maisam Arif 00e170c2f5 SWDEV-404157 - Fixed printLog delimiter parsing
Signed-off-by: Maisam Arif <Maisam.Arif@amd.com>
Change-Id: I3d8e22d185790f4325aeacc18e4bfcfe8777d356
2023-06-08 20:02:51 -05:00
Ammar ELWazir 4560bcae9f Setting Priority for HSA Queue handling Device Profiling
Change-Id: I82072ffb73f56b6effd2878164513ce47014c33f
2023-06-08 18:11:59 -04:00
Giovanni LB 6e32c6d132 SWDEV-391586: Remove hsa handles and begin_ts from std::cout
Change-Id: I0d53849dd763d07094bd769d4bf1af908e39475f
2023-06-08 18:04:14 -04:00
Ammar ELWazir fc603d58d2 : Adding support to UMC & MMEA System Blocks
Change-Id: I92601f37757e0cff3f1fdc10f2e5e0db51c1ee2d
2023-06-08 21:22:19 +00:00
Ori Messinger 4675492852 kfdtest: Fix minor typo
The purpose of this patch is to fix a minor typo in KFDSVMRangeTest.
Before:
"Skipping test: no enough system memory."
After:
"Skipping test: Not enough system memory."

Signed-off-by: Ori Messinger <Ori.Messinger@amd.com>
Change-Id: I247cb558a177a1d25c393bf16c7386f4d79d0fba
2023-06-08 15:58:25 -04:00
Ammar ELWazir 19e3253049 Fixing ROCProfiler V1 Tests & V1 Tests Packaging
Change-Id: I741e29b8fbce9d4643c4f13afafd7d4fd648094b
2023-06-08 18:25:57 +00:00
Graham Sider d1a095123d kfdtest: Update GFX11 blacklist
KFDQMTest.MultipleCpQueuesStressDispatch is fixed as of MES SCHQ version
0x3c ().

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Change-Id: I437f3eb5f12dc159339a9b7c7cff2e2b8214ad7c
2023-06-08 14:11:30 -04:00
gobhardw 167326b6fc Rocprofiler V2 API doc improvements
Change-Id: I5fa751f6a4041fcd426eee4e496dcfd561f3a5e3
2023-06-08 12:28:10 -04:00
Ammar ELWazir 2a9595bc8f SWDEV-340925 & ROCMOPS-4997: Fixing Tests package for roctracer
Change-Id: I9913e1df86398ef79a5afcf4b89b5a132d61422c
2023-06-08 14:48:28 +00:00
Jonathan Kim 233413eb08 Remove Tab Indent on SDMA Status Fix
Use spaces not tabs.

Change-Id: Icaeb16158ebaddd8e5ac518103d285d55fe976f3
2023-06-07 16:47:04 -04:00
Ammar ELWazir 2e3d0ee110 SWDEV-296009: Disabling ROCP_MCOPY_DATA
Change-Id: I5bbc529831d60e254d510a176b432395daac280a
2023-06-07 12:10:53 -04:00
Giovanni LB 54cbefa9f3 Fixed scalebar for Navi
Change-Id: I5d644f43eac16c86535012286dff972e3afbcb3b
2023-06-07 11:40:56 -03:00
Hao Zhou 010678369f Merge amd-staging into amd-master 20230607
Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I1d26d320c15cb3bd813019140a4492f7f9e08362
2023-06-07 11:59:18 +08:00
Hao Zhou 255b4d122b Revert "Revert "Merge amd-staging into amd-master 20230602""
This reverts commit 5aa94c48d1.

Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: I38b7d0ca4535503bf0b9ba491de0eb747f3dd966
2023-06-07 11:56:43 +08:00
Hao Zhou 5cd963feb7 Revert "Revert^2 "Revert "Merge amd-staging into amd-master 20230524"""
This reverts commit be41c19d3c.

Signed-off-by: Hao Zhou <Hao.Zhou@amd.com>
Change-Id: Ibfe63f701719d4eee7c589bd44ab88f720d3105d
2023-06-07 11:56:16 +08:00
Giovanni LB e078d3704c SWDEV-391596: Moved counters output to the same line as dispatch info
Change-Id: I08076b4d4fd20cbb4632cf5cc18c4651caafe87c
2023-06-06 17:03:20 -04:00
Galantsev, Dmitrii f78f9a4082 Fix test temp blacklist, ignore TestVoltCurvRead
Change-Id: I86fa14fdc06e1b170a0bc0c0727fc08e4f4e2074
Signed-off-by: Galantsev, Dmitrii <dmitrii.galantsev@amd.com>
2023-06-06 17:02:14 -04:00
Xiaomeng Hou 389cd3564b Do not reserve scratch memory on asic with finite vram resource
Change-Id: I0a2207cb01f464ed3e73331637cfa9bd62f03d97
2023-06-06 22:01:31 +08:00
Ammar ELWazir 5c8cb39b08 Fixing Perfetto Plugin & Updating Perfetto SDK
Change-Id: Idad07448a70b0b17acee899c0265147455a9d87c
2023-06-06 09:02:17 -04:00
Sreekant Somasekharan 1428a7538e kfdtest: RoundToPowerOf2 function modified for compiler compliant bit shift values
Compiler behavior is undefined if the right operand is negative,
or greater than or equal to the width of the promoted left operand.
For release builds with address sanitizer enabled, this compiler
optimization behavior leads to unsupported queue size value since
current method shifts till 128 bits on a 64 bit value.

Signed-off-by: Sreekant Somasekharan <sreekant.somasekharan@amd.com>
Change-Id: Iafdc82d0dfb7f79e3012fb7bb70eda80e4b7a7a6
2023-06-05 18:14:58 -04:00
Charis Poag e2dec17284 [SWDEV-402336 + SWDEV-398070] Fix RPM install part2
Updates:
    [rocm-smi] RPM installation comment included a macro,
    now removed

Change-Id: Ifa7a8d2d1a713940c39e20df9d02635e0e623dd8
Signed-off-by: Charis Poag <Charis.Poag@amd.com>
2023-06-05 13:50:57 -05:00
David Yat Sin e4fffa140a Removing __linux__ definition in CMake
Removing this definition as this should already be defined by compiler.
This is causing compile errors on newer versions of llvm because the
macro is being redefined.

Change-Id: Ica6a06f46a14e16d3f52e83b9b5ee8cfd7359510
2023-06-05 12:23:56 -04:00
Graham Sider e2c3c3e510 Revert "Disable Queue_Validation_InvalidGroupMemory"
This reverts commit 7b74271d5e.

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Change-Id: I8424c96d5e5c3c9a9e7711ecff7c5372190b0d2d
2023-06-05 09:41:02 -04:00
Graham Sider dbe2a82e35 rocrtst: Remove extra clear_code_object() calls
A patch was made in gfx940 npi branch to move the kernel object file
loading to outside the rocrtstNeg.Queue_Validation_* main queue creation
and submission loops, and added a clear_code_object() after the loop.

Another patch was made to the non-npi branch which adds a
clear_code_object() inside the loop. When the npi branch patch was
merged, this was causing the code object to be cleared at the end of
the first loop. Remove these clear_code_object() calls.

Signed-off-by: Graham Sider <Graham.Sider@amd.com>
Change-Id: Id4188e78411e81c5071bf715c1f02491f571ab79
2023-06-05 09:41:02 -04:00
gobhardw 02412ff353 SWDEV-397576 Fixing typo in DISABLED keyword
Change-Id: Ia1e391e2503957a451d6f7051291d092a33b7e04
2023-06-04 00:45:36 -04:00
Giovanni LB f154067583 Added GFX11 compilation for tests
Change-Id: I4483a0439fba0921cd9304b4bf45447b9a94b065
2023-06-03 13:38:25 -03:00
Giovanni LB 58d82814e1 File plugin performance improvement (upto 40%) by not using endl.
Change-Id: Ic9be0fb144eb0fa95f8e72c2de46ee4187f071c3
2023-06-03 09:30:06 -04:00
Ammar ELWazir edf162163a Profiler and Tracer fix to use the same GPU ID
Change-Id: Ie42212d7717a3fd5e8fe1b5d1a2e893499ccedf7
2023-06-02 22:19:28 -04:00
Mark Searles c8db38ede2 Removing __linux__ definition in CMake
Removing this definition as this should already be defined by compiler.
This is causing compile errors on newer versions of llvm because the
macro is being redefined.

Change-Id: I3bf03617970d4b76dabce36ed980523673afadc5
2023-06-02 16:39:42 -07:00
Ammar ELWazir 3fd8de68aa Fixing ROCProf Tool V1 list basic/derived counters
Change-Id: I70534fd136301e54416d5f663e52b57788a7ec0a
2023-06-02 15:51:21 -05:00
Alex Sierra 728162c2c8 libhsakmt: include changes for upstream debugger API
Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Change-Id: Id296e13dff431c7a151c5aae0b93412b1e116467
2023-06-02 15:56:19 -04:00