Commit Graph

5052 Commits

Author SHA1 Message Date
Evgeny Mankov d75d979d31 [HIP][doc] AMD-hcc -> HIP-hcc
[ROCm/hip commit: 46b164c17a]
2019-10-28 21:41:12 +03:00
Evgeny Mankov 995348aecf [HIP][doc] Fix typo: AMD-clang -> HIP-clang
HIP-clang is already used below instead of AMD-clang


[ROCm/hip commit: 06d9e426e0]
2019-10-28 21:19:21 +03:00
Evgeny Mankov a2c162f85e [HIP][cmake] Move all *_INSTALL_DIR variables up before first add_subdirectory()
[REASON]
Those vars (may) used by cmake in subdirectories (#1571)


[ROCm/hip commit: b089d905c6]
2019-10-28 21:07:00 +03:00
Evgeny Mankov 17fd872099 [HIPIFY][tests] Rename the ambiguous call as well
[ROCm/hip commit: 70c5072302]
2019-10-25 16:07:31 +03:00
Evgeny Mankov 536376b341 [HIPIFY][tests] Fix ambiguous call to cusparseGetErrorString declared in cusparse.h
[ROCm/hip commit: 0410d5dcd2]
2019-10-25 16:04:20 +03:00
Anusha Godavarthy Surya 5c77b7d19a Merge branch 'master' into tex_unbind_issue_fix
[ROCm/hip commit: 03623cc3f1]
2019-10-25 15:54:25 +05:30
amd-lthakur 5e11495936 Excluded the test case for nvcc platform
[ROCm/hip commit: 4239c94fe5]
2019-10-25 15:52:11 +05:30
Anusha Godavarthy Surya 196bdea9c0 merge from master
[ROCm/hip commit: 5f47e99ffe]
2019-10-25 15:52:09 +05:30
Alex Voicu 8460793117 Add missing operators, fix GCC compilation. (#1589)
[ROCm/hip commit: dabd939048]
2019-10-25 15:44:24 +05:30
Alex Voicu 2e9868d597 Fix deadlock, remove old __sync_* use. (#1584)
This fixes a deadlock introduced by the switch to TTAS loops, and is therefore mildly urgent (to prevent the CI from hoovering in the broken code).

[ROCm/hip commit: a855a13c22]
2019-10-25 15:44:17 +05:30
Rahul Garg 849ae2bff0 [dtest] Fix hipMemset2D test (#1579)
Reverts changes made in #1399. This is a RT api test. For testing hipMemAllocPitch , a new test should be written and that should use correct memset API.

[ROCm/hip commit: 12e1a86ec1]
2019-10-25 15:44:05 +05:30
Rahul Garg c315da2028 Add hipMemcpy2DfromArray (#1510)
Adds hipMemcpy2DFromArray and hipMemcpy2DFromArrayAsync equivalent to cudaMemcpy2DFromArray and cudaMemcpy2DFromArrayAsync.

[ROCm/hip commit: 356765a223]
2019-10-25 15:43:33 +05:30
Anusha Godavarthy Surya 3007505d30 Merge branch 'master' into tex_unbind_issue_fix
[ROCm/hip commit: 259d8b4cdf]
2019-10-25 15:36:55 +05:30
Anusha Godavarthy Surya f51eeeb5de Fixed CI build failure
[ROCm/hip commit: ce04bdaa1a]
2019-10-25 12:21:41 +05:30
amd-lthakur 158cab3bb7 Refactored the file as suggested
[ROCm/hip commit: 564418c308]
2019-10-25 10:44:38 +05:30
amd-lthakur 629a933b63 Update matmul.cpp
[ROCm/hip commit: 318df5c36b]
2019-10-25 09:22:07 +05:30
amd-lthakur 4b771db194 Update hipExtModuleLaunchKernel.cpp
[ROCm/hip commit: cd25149225]
2019-10-25 09:19:49 +05:30
foreman 5d4af9ce22 P4 to Git Change 2018917 by gandryey@gera-win10 on 2019/10/24 14:33:36
SWDEV-197289 - VDI tracing API integration in rocTracer
	- Change the names of the functions according to the new interface

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_activity.cpp#2 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#34 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#32 edit


[ROCm/hip commit: 63a26884aa]
2019-10-24 14:40:22 -04:00
Rahul Garg 83bbf215c8 Update profiling doc (#1576)
[ROCm/hip commit: 70f2cd1317]
2019-10-24 17:51:55 +05:30
Jatin Chaudhary e0a382a781 Adding New Analyze Target Merging with cppcheck (#1583)
[ROCm/hip commit: 770d3412f8]
2019-10-24 17:46:06 +05:30
Rahul Garg 9e0f66daec Add HIP checks in texture driver sample (#1581)
[ROCm/hip commit: 04e10814d8]
2019-10-24 17:45:51 +05:30
gandryey 4a7884105f Hip vdi profiling header (#1577)
Add HIP-VDI profiling interface for GPU timing collection.

[ROCm/hip commit: 81952ce5a7]
2019-10-24 17:45:42 +05:30
Alex Voicu 8f020907c7 Make CAS loops use the TTAS idiom. (#1573)
* Make CAS loops use the TTAS idiom.

* More efficient re-formulation of TTAS.

* Fix typo.

* The typo was not quite a typo


[ROCm/hip commit: 9ba25b42c8]
2019-10-24 17:45:20 +05:30
satyanveshd 4f23f9cb18 Fix occupany APIs (#1560)
Addresses SWDEV-205006 

[ROCm/hip commit: af351d7e1b]
2019-10-24 17:44:47 +05:30
searlmc1 4d668d5a52 Improve performance of v2 arg handling (#1539)
* Improve performance of v2 arg handling

* Missing change to `std::string`


[ROCm/hip commit: c4a51f3679]
2019-10-24 17:44:05 +05:30
Alex Voicu 52a5380263 Improve scalar access into vector types. (#1531)
The improvement is based on the ideas here: https://t0rakka.silvrback.com/simd-scalar-accessor. It yields significantly better ISA when the base's .xyzw members are used.

[ROCm/hip commit: 4a635add45]
2019-10-24 17:43:49 +05:30
Aryan Salmanpour 9ab561dd66 [hip] add support for implicit kernel argument for multi-grid sync (#1456)
* [hip] add support for implicit kernel argument for multi-grid sync

* modified code for calculating the prev_sum

* change the impCoopArg type to size_t

* add memory clean up

* launch init_gws and main kernels into two separate loops


[ROCm/hip commit: 359dc79101]
2019-10-24 17:43:30 +05:30
amd-lthakur 297a20eac7 Adding a directed test case for hipExtModuleLaunchKernel() api.
[ROCm/hip commit: 8b496e4715]
2019-10-24 15:06:28 +05:30
Rahul Garg 66f0280f0b Merge pull request #1559 from vsytch/win10_aligned_alloc
Fixes for hipMemcpy_simple on Windows

[ROCm/hip commit: fe5f7d4245]
2019-10-23 13:10:59 -07:00
Evgeny Mankov 6a0ce151e5 [HIPIFY][cmake][#1571] Take into account building hipify-clang as a part of building HIP while installing
[Algorithm]
  [Release]
    If CMAKE_INSTALL_PREFIX is set by the user:
       If BIN_INSTALL_DIR is set by HIP, use it as CMAKE_INSTALL_PREFIX, otherwise CMAKE_INSTALL_PREFIX is used unchanged.
    If the user does not set CMAKE_INSTALL_PREFIX (CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT):
       If BIN_INSTALL_DIR is set by HIP, use it as CMAKE_INSTALL_PREFIX, otherwise use PROJECT_BINARY_DIR/bin for installation.
  [Debug]
    If CMAKE_INSTALL_PREFIX is set by the user:
       CMAKE_INSTALL_PREFIX is used unchanged.
    If the user does not set CMAKE_INSTALL_PREFIX (CMAKE_INSTALL_PREFIX_INITIALIZED_TO_DEFAULT):
       use CMAKE_CURRENT_SOURCE_DIR/bin for installation.

Standalone build left unchanged: CMAKE_INSTALL_PREFIX is used if set.


[ROCm/hip commit: 75d70a6714]
2019-10-23 18:54:45 +03:00
foreman 65728e91cf P4 to Git Change 2018213 by eshcherb@evgeny-hip on 2019/10/23 11:36:28
SWDEV-197287 - exporting interception functions

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#33 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#31 edit


[ROCm/hip commit: ff8a4e3b3b]
2019-10-23 11:45:28 -04:00
foreman ddcb175a67 P4 to Git Change 2017678 by jujiang@JJ-OCL-hip on 2019/10/22 17:01:21
SWDEV-208594 - Output mismatch with texture functions

	Revert CL#2014458 for now

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_texture.cpp#24 edit


[ROCm/hip commit: 04b0f820b0]
2019-10-22 17:06:07 -04:00
foreman a5aec98ec4 P4 to Git Change 2017443 by eshcherb@evgeny-hip on 2019/10/22 12:00:47
SWDEV-197287 - prof_protocol fix

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_prof_api.h#4 edit
... //depot/stg/opencl/drivers/opencl/api/hip/prof_protocol.h#2 delete
... //depot/stg/opencl/drivers/opencl/runtime/platform/prof_protocol.h#2 edit


[ROCm/hip commit: 06c37696fc]
2019-10-22 12:38:12 -04:00
Evgeny Mankov d39793f0f7 [HIPIFY] Disable delayed template parsing
By implicit unconditional passing -fno-delayed-template-parsing option (which appeared in LLVM 3.8.0, thus doesn't need compatibility wrapping) to hipify-clang.

[Reason] To parse uncalled template functions otherwise they are not parsed without calling, thus not hipified.

Affects cub_03.cu test, which has uncalled global template function.


[ROCm/hip commit: b6e6f12b54]
2019-10-22 19:07:37 +03:00
Evgeny Mankov 9822351686 [HIPIFY][#1569] Fix
[ROCm/hip commit: 6f88c81a78]
2019-10-22 11:08:37 +03:00
Evgeny Mankov a9b05f246b [HIPIFY][tests] Set max clang's CudaArch for corresponding CUDA major.minor version
[Reason] To support maximum CUDA features in offline tests

+ Add defined(__CUDA_ARCH__) && __CUDA_ARCH__ >= 600 restriction for atomicAdd on doubles in atomics.cu.
  So if LLVM < 7 and --cuda-gpu-arch doesn't work, __CUDA_ARCH__ is unset too (350 by default in clang);
  if LLVM >= 7 --cuda-gpu-arch is used and __CUDA_ARCH__ is set based on it.


[ROCm/hip commit: 39e7d213cf]
2019-10-21 17:50:00 +03:00
Evgeny Mankov f697f14117 [HIPIFY][perl] Support of 'using namespace cub'
[ROCm/hip commit: b08f29a6fa]
2019-10-21 17:15:05 +03:00
Evgeny Mankov f345ec8c58 [HIPIFY][tests] Set max clang's CudaArch for corresponding CUDA version
[Reason] To support maximum CUDA features in offline tests

+ Add CUDA_VERSION >= 800 restriction for atomics.cu

[TODO] Find a way to use or exclude atomicAdd for doubles if LLVM < 7, because
LLVM 6.0.1 and older do not use --cuda-gpu-arch in clang's Driver code at all (option is only declared)


[ROCm/hip commit: 14b4df126c]
2019-10-21 15:51:25 +03:00
Evgeny Mankov 57b2e130e0 [HIPIFY][tests] Set -I for CUDA path instead of --cuda-path for LLVM < 4
[ROCm/hip commit: 6cfea9b600]
2019-10-20 20:08:56 +03:00
Evgeny Mankov 9ec744aaae [HIPIFY][tests] Exclude all CUB tests if CUDA_CUB_ROOT_DIR is not set
[ROCm/hip commit: ccb075b1db]
2019-10-20 20:03:18 +03:00
Vladislav Sytchenko 05cf0313ce Remove extra #endif.
[ROCm/hip commit: 664b115c44]
2019-10-18 16:40:29 -04:00
foreman 4e6b80a5f1 P4 to Git Change 2016115 by cpaquot@cpaquot-ocl-lc-lnx on 2019/10/18 13:58:30
SWDEV-207366 - [HIP] 'hipErrorInvalidValue' (1011) with hipMemcpy3D
	We need to divide by sizeByte and not multiply the WidthInBytes to get pixel width

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#79 edit


[ROCm/hip commit: 4ec9d181e0]
2019-10-18 14:10:57 -04:00
Evgeny Mankov 376037abfc [HIPIFY][tests] Test clean-up
[ROCm/hip commit: 82adc93e69]
2019-10-18 18:55:52 +03:00
Evgeny Mankov 55e2ef4c7a [HIPIFY][CUB][#1460] Add "using namespace cub" translation support
+ Add cub_03.cu


[ROCm/hip commit: 98874c0e7f]
2019-10-18 18:51:40 +03:00
Evgeny Mankov 5c300e3320 Merge pull request #1558 from aaronenyeshi/fix-hipify-cmake-version
[HIPIFY][cmake] Make CMakeLists use default 3.5.1 for Ubuntu 16.04

[ROCm/hip commit: f0ed210b19]
2019-10-18 06:39:35 +03:00
Rahul Garg 80ee1cc5a5 Merge pull request #1550 from yxsamliu/new-launch
Add -fhip-new-launch-api to hipcc for HIP/VDI

[ROCm/hip commit: 1fd16d7601]
2019-10-17 19:07:32 -07:00
Vladislav Sytchenko fd17d3b737 _aligned_malloc() on Windows first takes size, then alignment, which is the opposite of how the similar function behaves on Linux. Memory allocated by it also has to be freed using _aligned_free(), unlike Linux where we can use regular free().
Edit aligned_alloc() macro and add a aligned_free() one to align with the above behaviour.


[ROCm/hip commit: 8f0a226660]
2019-10-17 18:58:32 -04:00
Aaron Enye Shi c3b3de7f95 [HIPIFY][cmake] Make CMakeLists use default 3.5.1 for Ubuntu 16.04
[ROCm/hip commit: 31e57f8b64]
2019-10-17 21:21:24 +00:00
Evgeny Mankov 222fb46a92 [HIPIFY][doc] Update README.md
+ Versions, testing


[ROCm/hip commit: 7ecbd71004]
2019-10-17 22:26:48 +03:00
foreman 198e044932 P4 to Git Change 2015320 by vsytchen@vsytchen-hip-win10 on 2019/10/17 14:00:39
SWDEV-207100 - [HIP CQE][HIPonPAL][WIN][QR] 5 hiptests failed in 19H1 Windows on all ASICs

	1. Reshuffle locations of the hipMemset functions to make them all next to each other.
	2. Update the declarations of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async. These functions are type aware and take in as their third argument the number of elements in the buffer, not the buffer size. Change the name of this argument from sizeBytes to count to align with the above description. Changes for the header are tracked here https://github.com/ROCm-Developer-Tools/HIP/pull/1544
	3. Add the actual implementation of hipMemsetD8, hipMemsetD8Async, hipMemsetD16, hipMemsetD16Async.
	4. Remove ihipMemset2D() as it is essentially a copy of ihipMemset(). Change hipMemset2D()/hipMemset2DAsync() to use ihipMemset().
	5. Implement hipMemset3DAsync().
	6. Update the test script to pick up the updated command line options for hipMemset and hipMemset3D.

Affected files ...

... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.def.in#32 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_hcc.map.in#30 edit
... //depot/stg/opencl/drivers/opencl/api/hip/hip_memory.cpp#78 edit
... //depot/stg/opencl/drivers/opencl/make/hip.git/tests/scripts/hip_runtimeapi_tests.txt#13 edit


[ROCm/hip commit: 238a71c4ca]
2019-10-17 14:09:46 -04:00