Граф коммитов

78 Коммитов

Автор SHA1 Сообщение Дата
Giovanni LB 97138f6625 SWDEV-411094: Fixing ROCTX & kernel_name data corruption in perfetto
Change-Id: Id106a310191eec08a52d675155f0bfd23826451f
2023-08-22 15:51:58 -03:00
Giovanni LB 0eb39775b9 SWDEV-418012: Fixed typo in perfetto
Change-Id: I1627c0a171403f2cc040ffa1b4d2e1525943973f
2023-08-22 12:54:33 -03:00
Ammar ELWazir a3dfe3d680 SWDEV-415259: Replacing HCC with AMD
Change-Id: I3de30d52d7e25ce5a6c727fba81af9a031f7eee3
2023-08-18 09:59:27 -04:00
Giovanni LB 157eacd2bb DCGPUBU-44: Added arbitrary envvars to file/dir names. Squashed some fixes.
- Added arbitrary env-vars
- Fixed some UBs with atomic variables
- Fixed loading of file plugin
- ATT vs. kernel-trace off by one

Change-Id: I69c75f66f722e4085b5279f41afd05813628846d
2023-08-15 17:53:57 -03:00
Giovanni LB 2f8edb0250 SWDEV-415057: Fixing warning messages for masked simds
Change-Id: I06eed3c986e5e7de68978ac995b36edb35183a8a
2023-08-02 17:05:45 -04:00
Giovanni LB 8c170e55a6 Fixing vscnt typo in stitch.py
Change-Id: I8a687b9df9173cef97078a23dabdc1f03a72445a
2023-07-15 17:25:17 -04:00
Ranjith Ramakrishnan 5e4ac01cb1 SWDEV-409575 - Append additional RPATH to libraries and binaries installed in /opt/rocm-ver/lib/rocprofiler
Append the rpath $ORIGIN/.. to component specific libraries
Binaries installed in /opt/rocm-ver/lib/rocprofiler had been appended with $ORIGIN/..
Binaries installed in /opt/rocm-ver/libexec/rocprofiler had been appended with $ORIGIN/../../lib
Used TARGET form for installation of rocprof-ctrl and librocprof-tool in runtime component

Change-Id: I53b7a283c6a8ddea97d4889db6010832389894bb
2023-07-14 12:21:28 -04:00
Giovanni LB 1c11700521 Added error handling to att iterate_data. Fix for genasm.
Change-Id: Ia86e629e74c6e00b98155355beabf69681a88875
2023-07-13 21:52:01 -04:00
Ammar ELWazir d4a33cf33a Pull from Github
Squashed commit of the following:

commit f029195705a15700380c6f832ba5d15d46fd6de7
Author: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Date:   Thu Jul 13 14:38:56 2023 -0500

    Formatting workflows for source (clang-format) and cmake (cmake-format) (#4)

    * Add .cmake-format.yaml file

    * Add formatting workflow

    * provide base input for creating PR

    * Update scheme for extracting branch name

    - disable running formatting on push to amd-staging branch

    * patch .cmake-format.yaml for find_package signature

    - apparently cmake-format doesn't format the full signature of find_package

    * run formatting (clang-format v11) (#7)

    Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>

    * run cmake formatting (cmake-format) (#6)

    Co-authored-by: jrmadsen <jrmadsen@users.noreply.github.com>

    ---------

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

commit bc4d135fdd8a1a9e51235f18a5d575fd2b3735e6
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Thu Jul 13 12:55:17 2023 -0500

    Removing Build cache for potential issues with auto-generated header files (#5)

    Change-Id: I9e2319f4335e2f88585ffa6fac2bd88a1c952e6e

commit ce86dea6a311d44d880fa684eb78f3329295e2a4
Author: Jonathan R. Madsen <jrmadsen@users.noreply.github.com>
Date:   Thu Jul 13 11:08:58 2023 -0500

    Fix decltype(<hsa-function>) function pointer usage (#3)

    - the following is done in several places:
        decltype(hsa_memory_allocate)* hsa_memory_allocate
    - above can cause compiler errors
    - replace decltype(<hsa-function>) with decltype(::<hsa-function>)
      - this ensures that the type within the decltype is recognized as the global scope HSA function, not the variable
    - in many places, the variable has a "_fn" suffix to prevent this issue but added '::' anyway for consistency

commit ac49fdd92a72e9c99394253a02da413a6c2e3b3a
Merge: a07946a 03a0855
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Wed Jul 12 11:36:24 2023 -0500

    Merge pull request #2 from ROCm-Developer-Tools/gerrit-amd-staging

    Pull from gerrit

commit 03a085588cffe863e8f466de67be1cfb205b675a
Merge: e88cad2 a07946a
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Wed Jul 12 10:57:30 2023 -0500

    Merge branch 'amd-staging' into gerrit-amd-staging

commit a07946a5cd4c670c83c27ad1a076a9d4567ce6d7
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 15:46:04 2023 +0000

    Enabling Cached Builds

commit 525e494a7f13941077a8fd4ad6840904db4d27d4
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 04:53:54 2023 +0000

    Updating missed GPU Targets

commit 42c75862f628c9bee7cfb7dc04dff2619430efbc
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 04:43:02 2023 +0000

    Adding V1 Testing

commit 9d72fd4aee85e4b0c12e717060d2730fa5b73be1
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 03:34:31 2023 +0000

    Fixing Artifacts directory path

commit f4000cc558b3b2e4676f7994f7ce8c8e6f94518e
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 03:27:26 2023 +0000

    Fixing CMake for test build job

commit 2ce8115d4c33948c3c8f957f545a95a04e1d6cd2
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 03:16:18 2023 +0000

    Fixing Ubuntu CMake for ubuntu test build

commit 6d0ed439191be900748d0c025157f9d689a73ec7
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 01:28:41 2023 +0000

    Removing Navi21

commit e349a7642e5ae5eb03ab9fcd0a0f74f09f78cab5
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 01:14:14 2023 +0000

    Removing Navi21

commit fefd02fe68d2a4bca7ec2e381960ad004ee9fc5b
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 00:42:48 2023 +0000

    Fixing CMake Job

commit 2ea46abf7bf92643efa8c549fa70346ffbd79d65
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 00:35:13 2023 +0000

    Fixing CMake Job

commit d99d681ed1999c5fcf291dc678b11a77205fb0f3
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Wed Jul 12 00:32:13 2023 +0000

    Fixing Pull Latest Dockers and CMake Jobs

commit dfc4498072d13b4a1df3a63047d34c682c3d9a29
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 23:54:21 2023 +0000

    Fixing CMake job

commit 919efe04de707f7c702031be15c3e2c5f8442cbb
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 23:52:13 2023 +0000

    Adding Pull Last dockers job

commit be1b1256e8b0e05308e8f7e7e69bee3acca55281
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 18:25:40 2023 -0500

    Update cmake.yml

commit 212299fa4355ae6ec18f9aaacbb79c51ea6c6f97
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 18:23:35 2023 -0500

    Update cmake.yml

commit 7c2c1327086a61466cc6cac39f70865c051a8bc7
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 18:18:53 2023 -0500

    Update cmake.yml

commit 191b5ce007e612e814c1d7a3afb4ad398f3852e1
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Tue Jul 11 16:03:22 2023 -0500

    Update cmake.yml

commit 8824113d95f3e13c7ce4d0af8e0d9d8f522a6c4a
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 16:28:09 2023 +0000

    Fixing Pull from Gerrit job name

    Change-Id: I9e7ed9a27a13ca49d62c93bdadb30f0057e4d385

commit cc3d5e4b02ffb439e8cc2b3efa53527c376f9982
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 16:21:43 2023 +0000

    Adding Staging sync job

    Change-Id: I0551f43878b0678ce4b3e74e27d62357cf95ad95

commit b9be2eee71380a2e6dd34d520e92d0c4209277a0
Author: Ammar ELWazir <Ammar.ELWazir@amd.com>
Date:   Tue Jul 11 15:57:11 2023 +0000

    Fixing build.sh

    Change-Id: Ia987b0244f0875370d5fe69907b3f5e9cea914de

commit 9eee33a95a1abd656a7ac5ca10a9f245e9825431
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 21:39:46 2023 -0500

    Update cmake.yml

commit 7093b85a78497140e8b52632ca2a002bdaeacd62
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 21:33:29 2023 -0500

    Update cmake.yml

commit f54697172c72a67740f9fdfa0c217b6ea6931576
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 21:01:26 2023 -0500

    Update cmake.yml

commit 1b6620e16f8940386b0f4f04e69e2410d21c0e26
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 20:21:02 2023 -0500

    Update cmake.yml

commit a94bec740c6b42c4b79c87bca20fa87b99bf060d
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:46:35 2023 -0500

    Update cmake.yml

commit 85d6b29d4375a69d575c18ece8542c50f2ddfcc3
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:34:39 2023 -0500

    Update cmake.yml

commit 8c004887cf1435f1a6214c3d2455299a8a27bd4c
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:31:17 2023 -0500

    Update cmake.yml

commit a14a9168e17d9348a53c6e9c9a47ba1edb4c4509
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:25:46 2023 -0500

    Update cmake.yml

commit 000f2f40b84e6a2f7d4becdbf5aed01436ca4c83
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:08:18 2023 -0500

    Update cmake.yml

commit a28a53d56731cad848fa9133d1c4dbaa8fc7afa7
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 19:03:39 2023 -0500

    Update cmake.yml

commit a6a2db01027f0b01fdfbb5997ddb772c7f51b649
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 18:21:53 2023 -0500

    Update cmake.yml

commit 118ef2a88b2d44e3207c31c343da3e5e5ec6f176
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 17:55:57 2023 -0500

    Update cmake.yml

commit 03c4c232396440cd0be6d2dd7baf4ceea1c2589d
Author: Ammar ELWazir <aelwazir@amd.com>
Date:   Mon Jul 10 17:48:49 2023 -0500

    Create cmake.yml

Change-Id: I77992f15694e77cbae49c56f9ff02f4f9079235d
2023-07-13 20:54:30 -04:00
Giovanni LB 019ddfe68e SWDEV-409195: Added instructions for ATT help.
Change-Id: Ie76518dd54c3de82abfbd64b5e8c44a43edc8a09
2023-07-13 16:47:05 -04:00
Giovanni LB 1166f3c121 SWDEV-403085: Added %rank to output path and metadata to CTF. Added tests for file/ctf/perfetto plugins.
Change-Id: I3b85e8a413cb99e44b7d8d5303dcb9e3520c0f04
2023-07-12 10:24:19 -04:00
Giovanni LB e935632769 SWDEV-408509: Added MPI awareness, dispatch ID and buffer size to ATT API. Fixed wrong dispatch ID on kernel.txt. Readme fixes.
Change-Id: Ib1e2d515d14419097d73dc28648e47ca752d95a6
2023-07-07 01:55:04 -04:00
gobhardw 90f6aa060f Fixing performance/mem leak for perfetto plugin
Change-Id: Id2873949042159941564b59f28466a60b16eca76
2023-07-05 13:06:50 +05:30
Ammar ELWazir 5180ca0d01 Fixing Performance Issues in the tool
Change-Id: I16ca6d57067861bec635a790105f0ee9cdb39969
2023-07-04 20:50:20 +00:00
Giovanni LB 02fbd5887b SWDEV-408607: Removed MPi message. Aded changelog and readme
Change-Id: I31efaf53ce4bf1b25c2bd94197a0b41bff84b0ff
2023-06-30 21:55:51 -03:00
Giovanni LB b9b17bfb34 SWDEV-408607: ATT parser rework
Change-Id: Ic180c3e7904bb6e46d9fd9fb4c9a97da503a5a3e
2023-06-30 18:01:39 -04:00
Ammar ELWazir 6dc1066d5d Changing build directory structure to match rocm
Change-Id: I22ed8ef777cfdbebe6caca65b68ff5e6bb12d35e
2023-06-30 14:11:46 -04:00
gobhardw 9ffb34f9d4 SWDEV-408750: Reoving Record_ID from HIP api trace
Change-Id: Iba9022246def090b1bbb90b68e67d54bab1bea31
2023-06-30 14:40:59 +05:30
Ammar ELWazir 3ac57e167e SWDEV-403068 & SWDEV-403069: Memory Leaks fix for tracer
Change-Id: I57ce10ae616dda9529d22d4cee15556864760d6c
2023-06-21 06:28:47 -04:00
Ammar ELWazir ad68526537 SWDEV-401678: Fixing Record IDs for File/CLI Plugin
Change-Id: Icf36f716b69d3b8ee3e84d73e276dbff4dbe70ae
2023-06-20 20:39:25 -04:00
Ammar ELWazir e924466ce9 SWDEV-405933: Perfetto to support PID for MEMCopies Tracks
Change-Id: Iec7bc8ed88d5d5c23f453a872154dff1d1c2e1c1
2023-06-20 10:17:46 -04:00
Ammar ELWazir d3c39dca88 SWDEV-391589: Fixing File plugin output text
Change-Id: I5e1d46431ca2b93661772b062996ed62574c36f9
2023-06-17 00:21:56 -04:00
Ammar ELWazir 6c61aa5311 Fixes for Spack
Change-Id: Ib2ea41b8140589fbc74aa297379588cc720e0183
2023-06-13 12:02:58 -04:00
Ammar ELWazir 8350f42329 Tests fix
Change-Id: I1fe7ab12c20e83f0bfc710bfc6db6a8d03802dd5
2023-06-10 10:26:33 -04:00
gobhardw 089fa278b3 SWDEV-388280 making ctf plugin usage similar to perfetto
Change-Id: Iccf17e8d8ff0f96701df8797cbb1ba58f9652575
2023-06-10 11:22:35 +05:30
Giovanni LB 6e32c6d132 SWDEV-391586: Remove hsa handles and begin_ts from std::cout
Change-Id: I0d53849dd763d07094bd769d4bf1af908e39475f
2023-06-08 18:04:14 -04:00
Giovanni LB 54cbefa9f3 Fixed scalebar for Navi
Change-Id: I5d644f43eac16c86535012286dff972e3afbcb3b
2023-06-07 11:40:56 -03:00
Giovanni LB e078d3704c SWDEV-391596: Moved counters output to the same line as dispatch info
Change-Id: I08076b4d4fd20cbb4632cf5cc18c4651caafe87c
2023-06-06 17:03:20 -04:00
Ammar ELWazir 5c8cb39b08 Fixing Perfetto Plugin & Updating Perfetto SDK
Change-Id: Idad07448a70b0b17acee899c0265147455a9d87c
2023-06-06 09:02:17 -04:00
Giovanni LB 58d82814e1 File plugin performance improvement (upto 40%) by not using endl.
Change-Id: Ic9be0fb144eb0fa95f8e72c2de46ee4187f071c3
2023-06-03 09:30:06 -04:00
Giovanni LB 59ee21f7d1 SWDEV-402866: Added browser file mode. Fixed caching. Changed ATT buffer size. Added MAX_ATT environment variable. Updated README/Changelog.
Change-Id: I36a6093bb85bf4ef179b59df676fc2e4cbdb5288
2023-06-02 12:41:20 -04:00
Giovanni LB 44e787957b Reduced ATT filesize. Fixed mov/scratch from gfx11 and false skip on gfx9.
Change-Id: Ibe80743bf02780f76d4a72dcb0626ca5077e34d9
2023-06-02 12:41:06 -04:00
Giovanni LB a6a61c5f51 Added support for Navi ATT
Change-Id: If65afd850b1a63fdda6382133c6269c8d17bfb4d
2023-06-02 12:40:48 -04:00
Ammar ELWazir 0859c3567d Adding Kernel Dispatch Tracing Correlation
Change-Id: I7f05fc1fa2fd3f13e0c120b2f48787454a6db7a6
2023-06-02 02:04:02 +00:00
Giovanni LB dd85b1d528 SWDEV-380521: Fixed perfetto data corruption for roctx and terminal. Added MPI rank to timeline.
Change-Id: I9d133c495b2809891f5df8b3e6504df13beb3d4e
2023-06-01 06:44:54 -04:00
Giovanni LB cd5456bf1c SWDEV-391594: Added macros for MPI env-vars
Change-Id: I373833a2ad997ba944a05f10ac8da6cfdf139fa3
2023-06-01 06:43:40 -04:00
Giovanni LB 1b5fed173c SWDEV-391583: Set default outputdir when filename is specified
Change-Id: I9765582cc0dc870906d0ec16aa9ca38e990e0ef8
2023-06-01 06:43:19 -04:00
Ammar ELWazir 2591d37add Fixing Perfetto & CTF plugins for ROCtx
Change-Id: I575dcfcac6ced4dd5973f037137f1386a684e08b
2023-06-01 08:41:25 +00:00
Ammar ELWazir 4bcef6b8de Removing ROCMTools naming from ROCProfiler project
Change-Id: Ibd6211e031157f68a1bc3dd8dd77385e695cb700
2023-05-30 22:14:50 -05:00
Ammar ELWazir 08fc21ac31 SWDEV-403050: Multiple fixes for Memory Leaks in profiler
Change-Id: Ib720a81105af13898ff745ce0cbc2a48c1f4a980
2023-05-30 21:41:54 -05:00
Giovanni LB 099a6b88b9 SWDEV-399505: Updated file.cpp from amd-staging
Change-Id: I8b43f98fc0fa3c7d928bcc58067fddb01018b607
2023-05-30 21:41:54 -05:00
Giovanni LB 140dc5bb1a Limited filenames size for ATT plugin
(cherry picked from commit e31b7466c3bf9d8e69311752a617097f81d51355)
Change-Id: I2efd25e23a7c836df7526f743d68288b696d23b1
2023-05-30 21:41:54 -05:00
Saurabh Verma 8f82ff6a46 MI300 counters support for rocprof and rocprofv2(Accumulation from all xccs)
1. Xml files updated for gfx940 counters
2. File plugin changes to allow rocprofv2 backward compatibility for results.csv
3. Changes in rocprofv2 script to use tblextr.py, to generate results.csv just like rocprof

Change-Id: I7798f4411ce01f6fbfffb126de654ed806ca7045
(cherry picked from commit 86cbaf38c436be876f0426fa27803b1e64d90378)
2023-05-30 21:41:54 -05:00
Ammar ELWazir 6b07b139c4 Fixing Timestamps for Tracing for the trace buffer results
Change-Id: I89b36daacb6531840ac334ba4629c73a7b8f1e79
2023-05-25 01:59:54 +00:00
Ammar ELWazir 1bba393b1b SWDEV-389161: Fixing CTF plugin to work with the TraceBuffer
Change-Id: I4bd9f21bb91d6bd7cee1417d88a81d9d3be6ea9b
2023-05-24 22:46:40 +00:00
Sriraksha Nagaraj cdc74d31db SWDEV-389161:Adding fix for tensorflow app hang with rocprofv2
Change-Id: I48ade2e853468940aa5e1fca58ba22f686d89f26
2023-05-24 22:46:40 +00:00
Ammar ELWazir cf14bfbef0 Adding a way to define the OPS operation in the file plugin
Change-Id: Id1810b9a34bd0af2f000c53aad328bb019768eb0
2023-05-23 04:38:17 +00:00
Ammar ELWazir 55feb12ed9 Fixing BARECTF Binary search path in CTF Plugin CMake
Change-Id: I05a965a844584422ea93a4dd4196b8d7b2cdb339
2023-05-23 04:38:16 +00:00
gobhardw c3107fc258 SWDEV-398161, SWDEV-398764 Fixed --hsa-api for v2
Change-Id: I1902ff463851a3485b48f7b9400f7116a073365a
2023-05-17 17:22:44 -04:00
Giovanni LB 55c6a2d4ad SWDEV-391616: Added network/file/off option for ATT analysis.
Change-Id: I77d0d6d6652f0bf1b3f46d919aec5c17e29f3da7
2023-05-10 18:39:48 -04:00