Alex Voicu
f27cd5ad33
Correct ill-formed merge in earlier commit and adjust for differences with the new CUDA natural indexing mechanism.
...
[ROCm/clr commit: 27bc487635 ]
2017-11-20 16:33:52 +00:00
Alex Voicu
9cf73ef515
Re-sync with upstream.
...
[ROCm/clr commit: 30d90dab38 ]
2017-11-20 15:34:50 +00:00
Alex Voicu
af0ae5421c
This implements the trivial change needed to move back from the hip{Something}_{x, y, z} macros to the natural CUDA syntax of Something.{x, y, z}. This is contained in lines 384-404 in hip_runtime.h. All of the other changes have to do with changing unit tests to use this syntax. The macros are retained for backwards compatibility.
...
[ROCm/clr commit: 0cc921f103 ]
2017-11-19 01:54:12 +00:00
Alex Voicu
142213a52b
Clean up trailing whitespace so as to reduce noise in #246 .
...
[ROCm/clr commit: 0ad1308efd ]
2017-11-08 00:08:55 +00:00
Alex Voicu
b738633bcb
This switches HIP from its currently convoluted macro + pfe based dispatch mechanism to a more natural one partially based on the existing module API. The basic idea is that HCC will always correctly emit __global__ functions: as empty-bodied stubs, on host, and as kernels, on device. It then becomes trivial to obtain the mangled name on host, at dispatch, from the function's address, and then to use the mangled name to retrieve the kernel. This should address all problems stemming from serialisation, dubious mismatches due to the manufactured functor, macro-isms et al. It also immediately enables support for generalised globals as a consequence of that being available in the module API. Finally, it will make debug much easier, since the actual names of the __global__ functions will automatically be used in traces etc. One detail is that due to how dispatch works now (hipLaunchKernel and hipLaunchKernelGGL are themselves variadic function templates which deduce the function type of the callee), in certain cases it may be necesssary to insert explicit casts to ensure that the variadic argument list selects a viable overload - this can be observed in some unit tests. Eventually we may be able to remove this limitation, but for now it does not appear terribly onerous. The code is not extremely HIPpie, nor is it fully optimised, but rather is intended as a starting point for the HIP team to make its own.
...
[ROCm/clr commit: 28f87f7d2e ]
2017-11-01 15:09:59 +00:00
Ben Sander
fd5b9cb650
Merge pull request #222 from bensander/fix_device_prop
...
Fix device prop
[ROCm/clr commit: 7e8b39fc96 ]
2017-10-30 17:58:48 +01:00
Siu Chi Chan
bec0ff43e0
Merge remote-tracking branch 'origin/master' into HEAD
...
[ROCm/clr commit: cf98d0e37d ]
2017-10-27 01:18:28 -04:00
Siu Chi Chan
1e4a2a7dd0
add a printf device function
...
[ROCm/clr commit: 36c2795dd4 ]
2017-10-23 18:30:08 -04:00
Ben Sander
2774542487
Update device properties.
...
- clear properties to defined initial state.
- enable some property flags which are now supported.
[ROCm/clr commit: ed85b15c3e ]
2017-10-20 15:52:13 +00:00
Chris Kitching
c3f743a763
Add [[nodiscard]] attribute to hipError_t in C++17 mode
...
This will yield a compiler warning any time you discard an error
return value from an API call.
[ROCm/clr commit: 939fa02ade ]
2017-10-19 13:34:02 +01:00
Maneesh Gupta
e80a4ee235
Merge pull request #194 from bensander/fix_genco_math_path
...
Fix math ordering for --genco mode.
[ROCm/clr commit: 132316fecf ]
2017-10-03 16:17:34 +05:30
Ben Sander
e5bb8f73d0
Fix math ordering for --genco mode.
...
[ROCm/clr commit: 2e9b78c274 ]
2017-10-02 21:52:16 +00:00
Rahul Garg
bc675b15b8
Fixed review comment
...
[ROCm/clr commit: 71a5a0cb42 ]
2017-10-02 17:29:08 +05:30
Rahul Garg
f32bb0e089
Fixed review comments
...
[ROCm/clr commit: 79a943e654 ]
2017-10-02 10:57:25 +05:30
Rahul Garg
59fce18f03
Fixed build issue
...
[ROCm/clr commit: d92cfa44d2 ]
2017-10-02 10:40:01 +05:30
Rahul Garg
c1cb518025
Fix texture support on HIP/NVCC path
...
[ROCm/clr commit: e6725e2b7a ]
2017-10-02 10:40:01 +05:30
Siu Chi Chan
063dae2c46
ensure the condition is evaluated before applying the negation operator
...
[ROCm/clr commit: bf6a3f4294 ]
2017-09-20 01:38:28 -04:00
Maneesh Gupta
e3aa4edf79
Merge pull request #155 from wsttiger/master
...
Modify hip headers such that they are more compatible with strict C compiler
[ROCm/clr commit: 01163d327b ]
2017-09-15 10:49:55 +05:30
Maneesh Gupta
c443f3814f
Fix typo in nvcc_detail/hip_runtime_api.h
...
[ROCm/clr commit: 846b0555b9 ]
2017-09-14 16:19:57 +05:30
Maneesh Gupta
bb818d9c74
Merge pull request #175 from gargrahul/assert_support
...
Device side assert support
[ROCm/clr commit: 096caca840 ]
2017-09-14 16:08:00 +05:30
sriharikarnam
f65fb4755e
Add hipDevice[Get/Set]SharedMemConfig API on nvcc details
...
[ROCm/clr commit: f6fda276ce ]
2017-09-14 16:03:19 +05:30
Rahul Garg
2725242ba4
Device side assert support
...
[ROCm/clr commit: 9dcf2ad751 ]
2017-09-07 20:45:27 +05:30
Ben Sander
dcd8961a9d
Update docs.
...
- Review unsupported comments and refresh.
- Review experimental tag in API.
[ROCm/clr commit: a6d1778fff ]
2017-08-28 15:44:38 -05:00
wsttiger
ef8c6a67fc
Modify header such that it's compatible with strict C compiler
...
[ROCm/clr commit: 8302138d57 ]
2017-08-15 13:23:09 -05:00
wsttiger
5ba2f6ea57
Add missing CUDA tags
...
[ROCm/clr commit: 7933b3292d ]
2017-08-15 13:22:20 -05:00
Siu Chi Chan
6598eabd24
implement __threadfence_system
...
[ROCm/clr commit: b6e22b5c93 ]
2017-08-02 08:50:18 +00:00
Ben Sander
a5b3f825c2
Merge pull request #100 from weixingzhang/texture
...
HIP Texture Support
[ROCm/clr commit: 702651fc85 ]
2017-07-26 19:28:15 -05:00
Maneesh Gupta
f29245a846
Renable frexp(f) device math function
...
Change-Id: I53c022b8ddf38cd17ddb42eba457b9020db66395
[ROCm/clr commit: 1bd1c6bea8 ]
2017-07-20 14:41:30 +05:30
Weixing Zhang
d9abb032f7
HIP Texture Support
...
[ROCm/clr commit: ccbd3b13fc ]
2017-07-17 15:16:12 -04:00
Wen-Heng (Jack) Chung
4ce97c30e9
Remove explicit address spaces declarations
...
[ROCm/clr commit: 0237aeab06 ]
2017-07-07 12:46:29 -05:00
Ben Sander
57733404c1
Add hipdbPrintMem - wrapper for hcc memory tracker.
...
[ROCm/clr commit: 18660be8ce ]
2017-07-03 15:05:30 -05:00
Rahul Garg
ce0833f3bb
Fixed build error in hipDeviceGetByPCIBusId
...
Change-Id: I33be362910c4c5dca7435fb9c41f427b54f0e9a7
[ROCm/clr commit: cbc98cc098 ]
2017-07-01 07:56:30 +05:30
Ben Sander
35f05c0a3a
Refactor hip_hcc.
...
Don't require setting __HIP_PLATFORM_HCC__ ; Instead check if compiler is HCC.
The functions here use HCC-specific functionality so only work with HCC.
ANd they work regardless of the __HIP_PLATFORM_HCC__ setting so don't
require that.
Also remove the "hcc_detail" extra hierarchy level for hip_hcc.h as
it is not necessary. Remove hcc_detail/hip_hcc.h.
[ROCm/clr commit: 5e5b017b0d ]
2017-06-30 08:26:15 -05:00
Rahul Garg
1be7dc7cc2
Fixed hipDeviceGetByPCIBusId
...
Change-Id: Ia36bb9425671ef7659541c9aeedae4098456a31b
[ROCm/clr commit: 467a2ba014 ]
2017-06-30 10:11:41 +05:30
Rahul Garg
8c9545ad7c
Fixed hipDeviceGetPCIBusId for HIP/NVCC
...
Change-Id: I662efa148257a710f09002850b41d57bef00dff3
[ROCm/clr commit: 38d48b5cf0 ]
2017-06-29 00:13:02 +05:30
Rahul Garg
1ff995a92a
Fixed hipDeviceGetPCIBusId for HIP/HCC
...
Change-Id: I3688fa2476e1baada2d3c5fc3735cec3f15a1e21
[ROCm/clr commit: a7c727f352 ]
2017-06-28 23:48:27 +05:30
Sun, Peng
8a45f03573
Remove some warning debug info and add weak attribute back to GGL __global__ define
...
Change-Id: I2021b107dda697b1262d44fa1506465e94a3916b
[ROCm/clr commit: 3d2a729580 ]
2017-06-27 14:15:16 -05:00
Aditya Atluri
ede75a84ab
fixed default args for symbol memcpy apis
...
Change-Id: Ie0b63f8b9c5535eb3946bd6af3f30fe71a015244
[ROCm/clr commit: 3043766899 ]
2017-06-23 19:05:44 -05:00
Ben Sander
f1bed37a34
Clean up old USE_* and RELEASE.md notes.
...
[ROCm/clr commit: 42882ddf9c ]
2017-06-23 18:05:30 -05:00
Rahul Garg
3e29f81050
Added device side abort function in HIP/NVCC
...
Change-Id: I6ae35a72a8b9c34852619f02da1a046c8d3b2ed3
[ROCm/clr commit: 0fd6b59e22 ]
2017-06-20 09:38:56 +05:30
Rahul Garg
20dd968547
Abort device function in HIP/HCC, need new HCC
...
Change-Id: I4195ab75e9b7b48c8b8128d6925ddc0fa5e9e009
[ROCm/clr commit: d9935cd089 ]
2017-06-18 12:31:31 +05:30
Aditya Atluri
cd12c963b0
removed bad copy constructor
...
Change-Id: I661991d9d43941a61848b0b8e9879c0bfa811b40
[ROCm/clr commit: 34e14bb02d ]
2017-06-16 09:02:26 -05:00
Sun, Peng
a1a23c69d3
Additional GGL make_kernel_functor_* macros, contributed by Alex
...
Change-Id: I01aabb7d2b5418fcefb1bbf78eb5d1888dbc5c96
[ROCm/clr commit: 9bce2af76f ]
2017-06-14 11:10:52 -05:00
Sun, Peng
14e51d052e
Fix error related to undefined reference of __get_dynamicgroupbaseptr().
...
Change-Id: I14951e1725e35dd5f5e53805f81cdb58661f59f2
[ROCm/clr commit: 682dda4418 ]
2017-06-08 19:24:32 -05:00
Sun, Peng
65ead764d3
Add clang version guard so the hip_fp16.h header won't be picked up by gcc
...
Change-Id: Ia21335a455bc93210901b44bc8c76a7f4a385b55
[ROCm/clr commit: 5450021f93 ]
2017-06-08 19:24:32 -05:00
Sun, Peng
450a26e5d4
Improve HIP kernel names, attributes and codegen, contributed by Alex Voicu
...
Change-Id: I2cafbdc5a98e26c7f4fad84739c915e7dc09993c
[ROCm/clr commit: 3b6a863eef ]
2017-06-05 11:39:00 -05:00
Ben Sander
7237ed04f3
Fix HIP_SYNC_NULL_STREAM=0 mode.
...
- Fix null-stream sync
- hipStreamDestroy of null stream returns hipErrorInvalidResourceHandle
- Update documentation.
- Add tests for null stream sync, hipEventElapsedTime.
- Rename internal enum hipEventStatusRecorded to hipEventStatusComplete
- refactor hipStreamWaitEvent to streamline control-flow
[ROCm/clr commit: 823281dcba ]
2017-06-05 08:50:22 -05:00
Aditya Atluri
97fa7aeef6
added half data type and vector destructors
...
1. Added half data types to hip_fp16.h
2. Added destructor to vector data types
Change-Id: Id5ae76a663bb90a4bde2839ec79c58fbaee5072f
[ROCm/clr commit: fdcc223842 ]
2017-06-02 11:19:33 -05:00
Evgeny Mankov
afbf55a9dc
[HIP] [HIPIFY] CUDA Driver API 8.0.44 JIT options support.
...
[ROCm/clr commit: 463c026976 ]
2017-05-31 18:55:29 +03:00
Ben Sander
0ca3262f0a
Add event controls for release fences.
...
Env var : HIP_EVENT_SYS_RELEASE
Event allocation flags : hipEventReleaseToDevice, hipEventReleaseToSystem
(remove hipEventDisableSystemRelease)
Update test for new functionality.
[ROCm/clr commit: 942ec0eff8 ]
2017-05-27 16:02:34 -05:00