- DPB buffer size was set to NUM_REF_FRAMES(8) which can not handle streams with 8 reference frames. We increase DPB size from 8 to 10 (same strategy as AV1) to be able to handle these streams.
- Fixed a condition check in loop filter frame init process.
- Removed the redundant conversion in interpolation filter assignment in VAAPI. The conversion has been done already when we parse the interpolation filter syntax.
* * rocDecode/VP9: Inter decode is up and running.
- Added reference list setup for VA-API.
- Added update reference frame process (8.10).
- Added set up past independence function.
- Added DPB and decode pool management.
- Added display management.
- Added super frame detection and parsing.
- Added VA-API parameter logging functions for debugging purposes.
* * rocDecode/VP9: Minor change: removed an extra newline.
* * rocDecode/VP9: Removed todo comments. No functional changes.
* * rocDecode/VP9: Minor changes based on review comments.
* * rocDecode/VP9: Minor changes based on review comment.
* * rocDecode/VP9: Initial code for VP9.
- Added structures for VA-API.
- Added defines for uncompressed header and parsing functions.
* * rocDecode/VP9: Added decode frame call to VA-API.
* * rocDecode/VP9: Added new sequence notification function.
* * rocDecode/VP9: Intra decode started to work.
* * rocDecode/VP9: Minor changes based on review comments.
---------
Co-authored-by: Kiriti Gowda <kiritigowda@gmail.com>
* fix for while loop hang
* fix for while loop hang
* add more data validation code in parser
* minor change
* addressed review comments
* fix conformance failures with new code
* added more checks
* added new API to release video frame for decoder and parser
* removed ReleseFrame() from low level parser classes
* Removed rocDecReleaseFrame() from decoder and added in parser
* address review comments
* revert un-necessary files
* minor fix
* remove unused function
* minor formatting fix
* * rocDecode: Added real decode speed report.
- The current decode speed report is actually output/display speed report.
- Due to AV1's extensive use of alternate reference frames that are not display, AV1 decoded frame count and output/displayed frame count can be quite different, making the current speed report not an accurate decode speed measurement.
- We now added the actual decode speed report, besides the existing speed report, now called output/display FPS.
* * rocDecode: Added real decode speed report.
- The current decode speed report is actually output/display speed report.
- Due to AV1's extensive use of alternate reference frames that are not display, AV1 decoded frame count and output/displayed frame count can be quite different, making the current speed report not an accurate decode speed measurement.
- We now added the actual decode speed report, besides the existing speed report, now called output/display FPS.
* * rocDecode/Sample script: Added missing changes for sample_mode 0 case.
* * rocDecode/AV1: Fixed an issue with multiple tile group OBUs per picture cases.
- We now use the single base pointer for all tiles in all tile group OBUs and submit them once per picture.
* * rocDecode/AV1: Fixed a typo.
* * rocDecode: Added the missing pts to decode return info for decoded pictures.
* * rocDecode: Added the missing pts to decode return info for decoded pictures.
* * rocDecode/AV1: Enabled AV1 decode by default.
* * rocDecode/AV1: Added changes suggested in code review.
- Bumped up rocDecode version to 0.7.0.
- Added AV1 support statement in readme file.
- Added film grain parameter saving and loading procedures.
- Added buffer management for film grain synthesis output.
- Fixed the corruption issue with 10-bit film grain streams. We need to see surface attibutes based on pixel format when creating VAAPI surfaces.
- Added missing global motion, loop filter and segmentation parameter loading in load reference frame procedure.
- Fixed an issue with one tile streams.
- Fixed an issue with un-initialized frame header structure after frame decode.
- Fixed a bug with decode buffer status update.
* * rocDecode/AV1: Added a few changes to enable general testing (non-film-grain).
- Added show existing frame support.
- Added load_previous() function.
- Added more operations to reference frame update process.
- Added reference frame loading process.
- Added decode frame wrapup process.
- Added DPB recycling.
- Added DPB content logging funcion for debugging purposes.
* * rocDecode/AV1: Removed a line which was added accidentally in the previous commit.
- Added initial support for DPB and decode/display buffer management.
- Added initial display support.
- Added reference frame set up.
- Fixed an issue with cdef_y_sec_strength/cdef_uv_sec_strength parsing. We should leave the conditional increment to VA-API driver or below due to VA-API formatting.
* * rocDecode/AV1: Added new sequence callback and submit decode calls.
* * rocDecode/AV1: Intra decode started to work.
* * rocDecode/AV1: Do not build PrintVaapiParams() in normal (non-debug) mode.
* * rocDecode/AV1: Added OBU parsing at picture level.
* * rocDecode/AV1: Added a few todos and fixed a few issues in frame header parsing.
* * rocDecode/AV1: Minor changes based on code review.
* * rocDecode/AV1: Removed more empty lines.
* * rocDecode: Initial check in for decode buffer pool.
* * rocDecode: All 135 streams pass.
* * rocDecode: Fixed a build error in debug mode.
* * rocDecode/HEVC: Removed two workaround in HEVC DPB management, after decode buffer pool implementa
tion.
- WR 1: Conditional bumping (when max_num_reorder_pics > 0) to avoid synchronous job submission in
C.5.2.3.
- WR 2: Add two more buffers in DPB to avoid buffer over-writing.
* * rocDecode/HEVC: Added display delay feature.
* * rocDecode/HEVC: Fixed the -z option issue within the context of the new decode buffer pool implementation.
* * rocDecode/HEVC: Removed redundent code.
* * rocDecode/AVC: Added decode buffer pool implementation for AVC.
* * rocDecode: Added a few changes.
- Added display delay feature to AVC.
- Removed a workaround for AVC: AVC_MAX_DPB_FRAMES was increased to 18. Now it is back to 16.
- Removed a workaround for AVC: increased DPB buffer size by 2. Now it is back to normal.
- Code format changes for HEVC.
* * rocDecode/AVC: Fixed the -z option issue within the context of the new decode buffer pool implementation.
* * rocDecode: Merged OutputDecodedPictures() method to upper class RocVideoParser.
* * rocDecode: Code cleanup. No functional changes.
* * rocDecode: Made decode buffer pool size adaptive.
- Removed the hard coded decode buffer pool size set in the decoder.
- Exposed the display delay parameter from RocVideoDecoder class to the user.
- Now the decoder buffer pool size is determined from the DPB buffer size and display delay parameter.
* * rocDecode: Several changes based on code review.
- Merged decode and display use status into one parameter.
- Removed the surface index from DecodeFrameBuffer, which is now implicitly referred by the array index.
- Changed a function name for better clarity.
* * rocDecode: Added a comment.
* * rocDecode: Added error handling of missing headers in cases where they are not parsed but referred in the frame decode process. One example is when frame seek is performed and the target picture is not a random access point.
* * rocDecode/HEVC: Added some missing error handlings.
---------
Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
* * rocDecode/AVC: Added initial field picture decode support.
- 7 conformance streams pass.
* * rocDecode/AVC: Minor change based on review comment.
* * rocDecode/AVC: Fixed an issue with getting the decoded frame buffer index for the second field.
- 10 more field conformance streams now pass.
* * rocDecode/AVC: Added support for picture adaptive frame-field feature.
- 10 more field conformance streams now pass.
* * rocDecode/AVC: Added a missing change during last merge.
* * rocDecode/AVC: Added initial field picture decode support.
- 7 conformance streams pass.
* * rocDecode/AVC: Minor change based on review comment.
* * rocDecode/AVC: Fixed an issue with getting the decoded frame buffer index for the second field.
- 10 more field conformance streams now pass.
* * rocDecode/AVC: Changed from C type cast to C++ type cast.
* * rocDecode/AVC: Fixed the decode failure of conformance stream MR2_TANDBERG_E.264.
- Fixed a bug in memory management control operation 4 process.
* * rocDecode/AVC: Added the missing assignment of top/bottom POC of ref_pic_list_1 in VAAPI slice parameter struct. This change did not make any effective functional changes.
* * rocDecode/AV1: Added frame header OBU parsing.
* * rocDecode/AV1: Added a missing function description.
* * rocDecode/AV1: Added tile group OBU parsing.
* added frame rate calculation to AVC parser
* fixed typo in avc_parser.h and removed cout debug statements from avc_parser.cpp
* made all changes discussed with Jeff
---------
Co-authored-by: jeffqjiangNew <142832361+jeffqjiangNew@users.noreply.github.com>
* * rocDecode/AVC: Added two decode error handlings.
- Exit with error when the stream is coded field pictures.
- Exit with error when the stream has multiple slice groups. VCN HW does not support it.
* * rocDecode/AVC: Added a missing error return from the last commit.
---------
Co-authored-by: Aryan Salmanpour <aryan.salmanpour@amd.com>
- At the end of some streams, the demuxer sends a picture payload of NAL units that do not contain slice data. In such cases, we return gracefully without causing a decoder error.
* * rocDecode/AVC: Added adaptive memory control decoded reference picture marking process. Other changes include:
- Replaced part of reference list modification implementation with a cleaner and more correct logic. It was found that the steps suggested
in the spec resulted errors on some streams.
- Fixed an issue in reference picture list construction. We still need to do picture number calculation (8.2.4.1) for I pictures.
- Fixed a bug in VAAPI slice parameter setup for ref list 1 for B pictures.
* * rocDecode/AVC: Fixed the scaling list setup for VAAPI.
- Put the scaling list in zig-zag scan order.
* * rocDecode/AVC: Added adaptive memory control decoded reference picture marking process. Other changes include:
- Replaced part of reference list modification implementation with a cleaner and more correct logic. It was found that the steps suggested
in the spec resulted errors on some streams.
- Fixed an issue in reference picture list construction. We still need to do picture number calculation (8.2.4.1) for I pictures.
- Fixed a bug in VAAPI slice parameter setup for ref list 1 for B pictures.
* * rocDecode/AVC: Fixed the scaling list setup for VAAPI.
- Put the scaling list in zig-zag scan order.
* * rocDecode/AVC: Replaced Todo comments with error messages, based on code review.
jeffqjiangNew
Aryan Salmanpour
Rajy Rawther
Pavel Tcherniaev
Lakshmi Kumar